Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16386
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73030/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16386
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16386
**[Test build #73030 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73030/testReport)**
for PR 16386 at commit
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16968#discussion_r101683048
--- Diff: docs/ml-classification-regression.md ---
@@ -363,6 +363,51 @@ Refer to the [R API docs](api/R/spark.mlp.html) for
more details.
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16968#discussion_r101683098
--- Diff: docs/ml-classification-regression.md ---
@@ -363,6 +363,51 @@ Refer to the [R API docs](api/R/spark.mlp.html) for
more details.
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16969#discussion_r101683604
--- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd ---
@@ -564,6 +566,26 @@ model <- spark.logit(df, Species ~ ., regParam = 0.056)
summary(model)
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16969#discussion_r101683480
--- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd ---
@@ -564,6 +566,26 @@ model <- spark.logit(df, Species ~ ., regParam = 0.056)
summary(model)
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16969#discussion_r101683657
--- Diff: examples/src/main/r/ml/svmLinear.R ---
@@ -0,0 +1,41 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16969#discussion_r101683410
--- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd ---
@@ -564,6 +566,26 @@ model <- spark.logit(df, Species ~ ., regParam = 0.056)
summary(model)
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16969#discussion_r101683369
--- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd ---
@@ -471,6 +471,8 @@ SparkR supports the following machine learning models
and algorithms.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16386
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73029/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16386
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16386
**[Test build #73029 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73029/testReport)**
for PR 16386 at commit
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/16969
are we merging this after #16968?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user uncleGen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16972#discussion_r101682505
--- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala ---
@@ -73,17 +81,52 @@ private[spark] class DiskStore(conf: SparkConf,
Github user uncleGen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16972#discussion_r101682451
--- Diff: core/src/test/scala/org/apache/spark/storage/DiskStoreSuite.scala
---
@@ -39,27 +40,27 @@ class DiskStoreSuite extends SparkFunSuite {
Github user uncleGen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16972#discussion_r101682663
--- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala ---
@@ -21,17 +21,25 @@ import java.io.{FileOutputStream, IOException,
Github user uncleGen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16972#discussion_r101682730
--- Diff:
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
@@ -344,7 +370,7 @@ private[spark] class MemoryStore(
val
Github user uncleGen commented on the issue:
https://github.com/apache/spark/pull/16972
@vanzin I will add some unit test in future. But could you please review
this first? I think I may be missing something.
---
If your project is set up for it, you can reply to this email and have
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16972
**[Test build #73036 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73036/testReport)**
for PR 16972 at commit
GitHub user uncleGen opened a pull request:
https://github.com/apache/spark/pull/16972
[SPARK-19556][CORE][WIP] Broadcast data is not encrypted when I/O
encryption is on
## What changes were proposed in this pull request?
`TorrentBroadcast` uses a couple of "back doors"
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/16499#discussion_r101682138
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -1018,7 +1025,9 @@ private[spark] class BlockManager(
try {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/16499#discussion_r101680844
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -813,7 +813,14 @@ private[spark] class BlockManager(
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/16923#discussion_r101680633
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -106,21 +106,33 @@ private[hive] class HiveClientImpl(
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/16923#discussion_r101680479
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -106,21 +106,33 @@ private[hive] class HiveClientImpl(
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16785
**[Test build #73035 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73035/testReport)**
for PR 16785 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16970
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73028/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16970
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16970
**[Test build #73028 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73028/testReport)**
for PR 16970 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16971
**[Test build #73033 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73033/testReport)**
for PR 16971 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16785
**[Test build #73034 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73034/testReport)**
for PR 16785 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/16785
> this looks like a very big hammer to solve this problem. Can't we try a
different approach?
I think we should try to avoid optimizing already optimized code snippets,
you might be able to do
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/16851
gentle ping @srowen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
GitHub user zhengruifeng opened a pull request:
https://github.com/apache/spark/pull/16971
[SPARK-19573][SQL] Make NaN/null handling consistent in approxQuantile
## What changes were proposed in this pull request?
update `StatFunctions.multipleApproxQuantiles` to handle NaN/null
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16923#discussion_r101678941
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -106,21 +106,33 @@ private[hive] class HiveClientImpl(
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16951#discussion_r101676637
--- Diff: R/pkg/R/stats.R ---
@@ -149,15 +149,18 @@ setMethod("freqItems", signature(x =
"SparkDataFrame", cols = "character"),
#' This method
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16951#discussion_r101676617
--- Diff: R/pkg/R/stats.R ---
@@ -149,15 +149,18 @@ setMethod("freqItems", signature(x =
"SparkDataFrame", cols = "character"),
#' This method
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/16949
Sure, this PR is fine, I'd just prefer some minor API adjustments to bring
it closer to the code I linked above.
---
If your project is set up for it, you can reply to this email and have your
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16951
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16951
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73031/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16951
**[Test build #73031 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73031/testReport)**
for PR 16951 at commit
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/16499#discussion_r101675669
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -1018,7 +1025,9 @@ private[spark] class BlockManager(
try {
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/16499#discussion_r101675576
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -813,7 +813,14 @@ private[spark] class BlockManager(
Github user zzcclp commented on the issue:
https://github.com/apache/spark/pull/16964
@srowen after update to master, in Eclipse IDE, there is an error in
JavaConsumerStrategySuite.java line 52:
`final Map offsets = new HashMap<>();
Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/16499#discussion_r101664624
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -813,7 +813,14 @@ private[spark] class BlockManager(
Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/16499#discussion_r101674560
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -1018,7 +1025,9 @@ private[spark] class BlockManager(
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16826
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16826
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73027/
Test FAILed.
---
Github user jinxing64 commented on the issue:
https://github.com/apache/spark/pull/16790
https://github.com/apache/spark/pull/16690#discussion_r101616883 causes the
build to produce lots of deprecation warnings.
@srowen @vanzin How do you think about this ?
---
If your project
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16826
**[Test build #73027 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73027/testReport)**
for PR 16826 at commit
Github user jinxing64 commented on the issue:
https://github.com/apache/spark/pull/16690
@srowen
How do you think about https://github.com/apache/spark/pull/16790?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user gczsjdy commented on a diff in the pull request:
https://github.com/apache/spark/pull/16476#discussion_r101673768
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala
---
@@ -340,3 +341,91 @@ object CaseKeyWhen {
Github user uncleGen commented on the issue:
https://github.com/apache/spark/pull/16949
@vanzin I opened a jira (https://issues.apache.org/jira/browse/SPARK-19642)
to research and address the potential security flaws. Do you mind if I continue
this pr?
---
If your project is set up
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16951
**[Test build #73031 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73031/testReport)**
for PR 16951 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16386
**[Test build #73032 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73032/testReport)**
for PR 16386 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16826
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16826
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73022/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16826
**[Test build #73022 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73022/testReport)**
for PR 16826 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16386
**[Test build #73030 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73030/testReport)**
for PR 16386 at commit
Github user hhbyyh commented on the issue:
https://github.com/apache/spark/pull/16968
I see. I will drop the R example here, whichever PR goes in later can
finish the document update.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16386
**[Test build #73029 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73029/testReport)**
for PR 16386 at commit
Github user NathanHowell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r101671453
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -1764,4 +1769,117 @@ class JsonSuite extends
Github user NathanHowell commented on the issue:
https://github.com/apache/spark/pull/16386
@cloud-fan When implementing tests for the other modes I've uncovered an
existing bug in schema inference in `DROPMALFORMED` mode:
https://issues.apache.org/jira/browse/SPARK-19641. Since it
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16962
**[Test build #73023 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73023/testReport)**
for PR 16962 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16962
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16962
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73023/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16970
**[Test build #73028 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73028/testReport)**
for PR 16970 at commit
GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/16970
[SPARK-19497][SS]Implement streaming deduplication
## What changes were proposed in this pull request?
This PR adds a special streaming deduplication operator to support
`dropDuplicates`
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16938
One more case:
5. `CREATE TABLE` or `CTAS` without the location spec: if the default path
exists, should we succeed or fail?
After we finishing the TABLE-level DDLs, we also need to
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/15125
LGTM. @felixcheung are we good to merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15125
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73019/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15125
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15125
**[Test build #73019 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73019/testReport)**
for PR 15125 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16826
**[Test build #73027 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73027/testReport)**
for PR 16826 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16962
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16962#discussion_r101666288
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/SaveIntoDataSourceCommand.scala
---
@@ -0,0 +1,52 @@
+/*
+ *
Github user thunterdb commented on a diff in the pull request:
https://github.com/apache/spark/pull/15770#discussion_r101666251
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/clustering/PowerIterationClusteringSuite.scala
---
@@ -0,0 +1,153 @@
+/*
+ * Licensed to the
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16611
Sure, I will rebase and update.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user thunterdb commented on a diff in the pull request:
https://github.com/apache/spark/pull/15770#discussion_r101665899
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/clustering/PowerIterationClustering.scala
---
@@ -0,0 +1,182 @@
+/*
+ * Licensed to the
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/16923
@vanzin , would you mind helping to review this PR, thanks a lot.
IIUC the issue was introduced in #11510 .
---
If your project is set up for it, you can reply to this email and have
Github user thunterdb commented on a diff in the pull request:
https://github.com/apache/spark/pull/15770#discussion_r101664268
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/clustering/PowerIterationClustering.scala
---
@@ -0,0 +1,182 @@
+/*
+ * Licensed to the
Github user thunterdb commented on a diff in the pull request:
https://github.com/apache/spark/pull/15770#discussion_r101663790
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/clustering/PowerIterationClustering.scala
---
@@ -0,0 +1,182 @@
+/*
+ * Licensed to the
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16969
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16969
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73025/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16969
**[Test build #73025 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73025/testReport)**
for PR 16969 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16826
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16826
**[Test build #73026 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73026/testReport)**
for PR 16826 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16826
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73026/
Test FAILed.
---
Github user thunterdb commented on a diff in the pull request:
https://github.com/apache/spark/pull/15770#discussion_r101662332
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/clustering/PowerIterationClustering.scala
---
@@ -0,0 +1,182 @@
+/*
+ * Licensed to the
Github user thunterdb commented on a diff in the pull request:
https://github.com/apache/spark/pull/15770#discussion_r101662298
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/clustering/PowerIterationClustering.scala
---
@@ -0,0 +1,182 @@
+/*
+ * Licensed to the
Github user thunterdb commented on a diff in the pull request:
https://github.com/apache/spark/pull/15770#discussion_r101662273
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/clustering/PowerIterationClustering.scala
---
@@ -0,0 +1,182 @@
+/*
+ * Licensed to the
Github user thunterdb commented on a diff in the pull request:
https://github.com/apache/spark/pull/15770#discussion_r101662038
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/clustering/PowerIterationClustering.scala
---
@@ -0,0 +1,182 @@
+/*
+ * Licensed to the
Github user thunterdb commented on a diff in the pull request:
https://github.com/apache/spark/pull/15770#discussion_r101662018
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/clustering/PowerIterationClustering.scala
---
@@ -0,0 +1,182 @@
+/*
+ * Licensed to the
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16826
**[Test build #73026 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73026/testReport)**
for PR 16826 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16395#discussion_r101660601
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/FilterEstimation.scala
---
@@ -0,0 +1,569 @@
+/*
Github user rolando commented on the issue:
https://github.com/apache/spark/pull/16967
I've (rip)grep'ed over all `.py` and `.md` files in the repository
searching for ` topi? ` (case insensitive regex) and haven't seen other case of
this typo (writing `top` instead of `topic`).
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16938
ok let's discuss it case by case:
1. `CREATE TABLE ... LOCATION path` works if path exists, it's expected
2. `CREATE TABLE ... LOCATION path` fails if path doesn't exist, is it
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/16395#discussion_r101659663
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/FilterEstimation.scala
---
@@ -0,0 +1,569 @@
+/*
+
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16969
**[Test build #73025 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73025/testReport)**
for PR 16969 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/16967
Sure, it's worth a search for similar instances because sometimes typos
spread via copy and paste. Could you make a pass over related code?
---
If your project is set up for it, you can reply to
101 - 200 of 547 matches
Mail list logo