[GitHub] spark pull request #17060: [SQL] Duplicate test exception in SQLQueryTestSui...

2017-02-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17060 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #17060: [SQL] Duplicate test exception in SQLQueryTestSuite due ...

2017-02-25 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17060 Thanks! Merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #17056: [SPARK-17495] [SQL] Support Decimal type in Hive-...

2017-02-25 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17056#discussion_r103097875 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/HashExpressionsSuite.scala --- @@ -371,6 +370,48 @@ class

[GitHub] spark pull request #17056: [SPARK-17495] [SQL] Support Decimal type in Hive-...

2017-02-25 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17056#discussion_r103097851 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/HashExpressionsSuite.scala --- @@ -371,6 +370,48 @@ class

[GitHub] spark pull request #16991: [SPARK-19594][Structured Streaming] StreamingQuer...

2017-02-25 Thread eyalzit
Github user eyalzit commented on a diff in the pull request: https://github.com/apache/spark/pull/16991#discussion_r103097765 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingQueryListenerSuite.scala --- @@ -133,6 +133,93 @@ class

[GitHub] spark issue #17071: [SPARK-15615][SQL][BUILD][FOLLOW-UP] Replace deprecated ...

2017-02-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17071 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17071: [SPARK-15615][SQL][BUILD][FOLLOW-UP] Replace deprecated ...

2017-02-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17071 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73478/ Test FAILed. ---

[GitHub] spark issue #17071: [SPARK-15615][SQL][BUILD][FOLLOW-UP] Replace deprecated ...

2017-02-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17071 **[Test build #73478 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73478/testReport)** for PR 17071 at commit

[GitHub] spark issue #17072: [WIP][MINOR][BUILD] Fix lint-java breaks in Java

2017-02-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17072 **[Test build #73481 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73481/testReport)** for PR 17072 at commit

[GitHub] spark pull request #17071: [SPARK-15615][SQL][BUILD][FOLLOW-UP] Replace depr...

2017-02-25 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17071#discussion_r103097204 --- Diff: sql/hive/src/test/java/org/apache/spark/sql/hive/JavaMetastoreDataSourcesSuite.java --- @@ -26,22 +26,17 @@ import

[GitHub] spark pull request #17071: [SPARK-15615][SQL][BUILD][FOLLOW-UP] Replace depr...

2017-02-25 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17071#discussion_r103097195 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala --- @@ -828,7 +828,7 @@ class JsonSuite extends

[GitHub] spark pull request #17071: [SPARK-15615][SQL][BUILD][FOLLOW-UP] Replace depr...

2017-02-25 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17071#discussion_r103097192 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala --- @@ -590,7 +590,7 @@ class JsonSuite extends

[GitHub] spark pull request #17071: [SPARK-15615][SQL][BUILD][FOLLOW-UP] Replace depr...

2017-02-25 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17071#discussion_r103097154 --- Diff: examples/src/main/scala/org/apache/spark/examples/sql/SQLDataSourceExample.scala --- @@ -135,10 +138,10 @@ object SQLDataSourceExample {

[GitHub] spark issue #17072: [MINOR][BUILD] Fix lint-java breaks in Java

2017-02-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17072 **[Test build #73480 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73480/testReport)** for PR 17072 at commit

[GitHub] spark issue #17072: [MINOR][BUILD] Fix lint-java breaks in Java

2017-02-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17072 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17072: [MINOR][BUILD] Fix lint-java breaks in Java

2017-02-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17072 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73480/ Test FAILed. ---

[GitHub] spark pull request #17065: [SPARK-17075][SQL][followup] fix some minor issue...

2017-02-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17065 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #17065: [SPARK-17075][SQL][followup] fix some minor issues and c...

2017-02-25 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17065 @ron8hu can you fix https://github.com/apache/spark/pull/17065#discussion_r103087483 and https://github.com/apache/spark/pull/17065#discussion_r103073122 if you have time? thanks! --- If your

[GitHub] spark issue #17065: [SPARK-17075][SQL][followup] fix some minor issues and c...

2017-02-25 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17065 thanks for the review, merging to master! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #17065: [SPARK-17075][SQL][followup] fix some minor issue...

2017-02-25 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17065#discussion_r103097107 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/FilterEstimation.scala --- @@ -95,15 +84,16 @@ case

[GitHub] spark issue #17072: [MINOR][BUILD] Fix lint-java breaks in Java

2017-02-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17072 **[Test build #73480 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73480/testReport)** for PR 17072 at commit

[GitHub] spark issue #17072: [MINOR][BUILD] Fix lint-java breaks in Java

2017-02-25 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17072 I haven't checked the tests. Maybe, let me wait for the test results before cc'ing someone. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request #17072: [MINOR][BUILD] Fix lint-java breaks in Java

2017-02-25 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17072#discussion_r103097032 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -153,7 +153,7 @@ public void writeTo(ByteBuffer buffer) {

[GitHub] spark pull request #17072: [MINOR][BUILD] Fix lint-java breaks in Java

2017-02-25 Thread HyukjinKwon
GitHub user HyukjinKwon opened a pull request: https://github.com/apache/spark/pull/17072 [MINOR][BUILD] Fix lint-java breaks in Java ## What changes were proposed in this pull request? This PR proposes to fix the lint-breaks as below: ``` [ERROR]

[GitHub] spark issue #17067: [SPARK-19602][SQL][TESTS] Add tests for qualified column...

2017-02-25 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17067 Thank you for working on this! I like the coverage of qualified column names. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark issue #17067: [SPARK-19602][SQL][TESTS] Add tests for qualified column...

2017-02-25 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17067 Uh. Forgot one more point. Could you move these test cases to our new end-to-end SQL query suite into `SQLQueryTestSuite` ? --- If your project is set up for it, you can reply to this

[GitHub] spark issue #17067: [SPARK-19602][SQL][TESTS] Add tests for qualified column...

2017-02-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17067 **[Test build #73479 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73479/testReport)** for PR 17067 at commit

[GitHub] spark issue #17067: [SPARK-19602][SQL][TESTS] Add tests for qualified column...

2017-02-25 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17067 Some test cases are negative; some test cases are expected to be supported. Could you split them from the positive test cases? Now some test cases are pretty large. --- If your project is set

[GitHub] spark issue #17067: [SPARK-19602][SQL][TESTS] Add tests for qualified column...

2017-02-25 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17067 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark pull request #17069: [MINOR][ML][DOC] Document default value for Gener...

2017-02-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17069 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #17069: [MINOR][ML][DOC] Document default value for GeneralizedL...

2017-02-25 Thread yanboliang
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/17069 LGTM, merged into master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #17056: [SPARK-17495] [SQL] Support Decimal type in Hive-...

2017-02-25 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17056#discussion_r103096516 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/HashExpressionsSuite.scala --- @@ -371,6 +370,48 @@ class

[GitHub] spark issue #16929: [SPARK-19595][SQL] Support json array in from_json

2017-02-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16929 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73477/ Test PASSed. ---

[GitHub] spark issue #16929: [SPARK-19595][SQL] Support json array in from_json

2017-02-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16929 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16929: [SPARK-19595][SQL] Support json array in from_json

2017-02-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16929 **[Test build #73477 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73477/testReport)** for PR 16929 at commit

[GitHub] spark issue #17039: [SPARK-19710][SQL][TESTS] Fix ordering of rows in query ...

2017-02-25 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17039 @hvanhovell I made a try and just realized it might be hard to automatically detect whether it is a complete sort and respect the predefined sort order. The order by clauses could be complex

[GitHub] spark issue #17071: [SPARK-15615][SQL][BUILD][FOLLOW-UP] Replace deprecated ...

2017-02-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17071 **[Test build #73478 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73478/testReport)** for PR 17071 at commit

[GitHub] spark issue #17071: [SPARK-15615][SQL][BUILD][FOLLOW-UP] Remove deprecated u...

2017-02-25 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17071 Let me please cc both @cloud-fan and @srowen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #17071: [SPARK-15615][SQL][BUILD][FOLLOW-UP] Remove depre...

2017-02-25 Thread HyukjinKwon
GitHub user HyukjinKwon opened a pull request: https://github.com/apache/spark/pull/17071 [SPARK-15615][SQL][BUILD][FOLLOW-UP] Remove deprecated usage of json(RDD[String]) API ## What changes were proposed in this pull request? This PR proposes to replace the deprecated

[GitHub] spark issue #16929: [SPARK-19595][SQL] Support json array in from_json

2017-02-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16929 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73475/ Test PASSed. ---

[GitHub] spark issue #16929: [SPARK-19595][SQL] Support json array in from_json

2017-02-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16929 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16929: [SPARK-19595][SQL] Support json array in from_json

2017-02-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16929 **[Test build #73475 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73475/testReport)** for PR 16929 at commit

[GitHub] spark issue #17070: [WIP][SS] Good error message for version mismatch in log...

2017-02-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17070 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73476/ Test PASSed. ---

[GitHub] spark issue #17070: [WIP][SS] Good error message for version mismatch in log...

2017-02-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17070 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17070: [WIP][SS] Good error message for version mismatch in log...

2017-02-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17070 **[Test build #73476 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73476/testReport)** for PR 17070 at commit

[GitHub] spark issue #16929: [SPARK-19595][SQL] Support json array in from_json

2017-02-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16929 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16929: [SPARK-19595][SQL] Support json array in from_json

2017-02-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16929 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73474/ Test PASSed. ---

[GitHub] spark issue #16929: [SPARK-19595][SQL] Support json array in from_json

2017-02-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16929 **[Test build #73474 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73474/testReport)** for PR 16929 at commit

[GitHub] spark issue #16980: [SPARK-19617][SS]fix structured streaming restart bug

2017-02-25 Thread gf53520
Github user gf53520 commented on the issue: https://github.com/apache/spark/pull/16980 @uncleGen The JIRA ID is 19617. But JIRA 19677 is same problem with this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #16929: [SPARK-19595][SQL] Support json array in from_json

2017-02-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16929 **[Test build #73477 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73477/testReport)** for PR 16929 at commit

[GitHub] spark issue #17061: [SPARK-13446] [SQL] Support reading data from Hive 2.0.1...

2017-02-25 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17061 cc @cloud-fan @yhuai @sameeragarwal --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16929: [SPARK-19595][SQL] Support json array in from_json

2017-02-25 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/16929 Hi @marmbrus, @brkyvz and @hvanhovell, I think it is ready for a review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #17048: [SPARK-14772][PYTHON][ML] Fixed Params.copy method to ma...

2017-02-25 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/17048 LGTM Merging with branch-2.1 Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #17070: [WIP][SS] Good error message for version mismatch in log...

2017-02-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17070 **[Test build #73476 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73476/testReport)** for PR 17070 at commit

[GitHub] spark pull request #17070: [WIP][SS] Good error message for version mismatch...

2017-02-25 Thread lw-lin
GitHub user lw-lin opened a pull request: https://github.com/apache/spark/pull/17070 [WIP][SS] Good error message for version mismatch in log files ## What changes were proposed in this pull request? (Please fill in changes proposed in this fix) ## How was this

[GitHub] spark issue #16929: [SPARK-19595][SQL] Support json array in from_json

2017-02-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16929 **[Test build #73475 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73475/testReport)** for PR 16929 at commit

[GitHub] spark issue #16929: [WIP][SPARK-19595][SQL] Support json array in from_json

2017-02-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16929 **[Test build #73474 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73474/testReport)** for PR 16929 at commit

[GitHub] spark issue #17069: [MINOR][ML][DOC] Document default value for GeneralizedL...

2017-02-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17069 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73473/ Test PASSed. ---

[GitHub] spark issue #17069: [MINOR][ML][DOC] Document default value for GeneralizedL...

2017-02-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17069 **[Test build #73473 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73473/testReport)** for PR 17069 at commit

[GitHub] spark issue #17069: [MINOR][ML][DOC] Document default value for GeneralizedL...

2017-02-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17069 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15770: [SPARK-15784][ML]:Add Power Iteration Clustering to spar...

2017-02-25 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/15770 Sorry for my absence from recent conversation! I agree there is no clear answer for handling input and output schema. Some options: * Option 1: same as RDD/GraphX-based API *

[GitHub] spark issue #17062: [SPARK-17495] [SQL] Support date, timestamp and interval...

2017-02-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17062 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73472/ Test PASSed. ---

[GitHub] spark issue #17062: [SPARK-17495] [SQL] Support date, timestamp and interval...

2017-02-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17062 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17062: [SPARK-17495] [SQL] Support date, timestamp and interval...

2017-02-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17062 **[Test build #73472 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73472/testReport)** for PR 17062 at commit

[GitHub] spark pull request #16938: [SPARK-19583][SQL]CTAS for data source table with...

2017-02-25 Thread windpiger
Github user windpiger commented on a diff in the pull request: https://github.com/apache/spark/pull/16938#discussion_r103093504 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InsertIntoHadoopFsRelationCommand.scala --- @@ -97,61 +98,46 @@ case class

[GitHub] spark pull request #16938: [SPARK-19583][SQL]CTAS for data source table with...

2017-02-25 Thread windpiger
Github user windpiger commented on a diff in the pull request: https://github.com/apache/spark/pull/16938#discussion_r103093397 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala --- @@ -140,8 +140,8 @@ case class

[GitHub] spark issue #17069: [MINOR][ML][DOC] Document default value for GeneralizedL...

2017-02-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17069 **[Test build #73473 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73473/testReport)** for PR 17069 at commit

[GitHub] spark issue #17069: [MINOR][ML][DOC] Document default value for GeneralizedL...

2017-02-25 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/17069 CC @actuaryzhang @yanboliang Just noticed that the default is missing in the Scaladoc. (Thanks btw for adding Tweedie support!) --- If your project is set up for it, you can reply to this

[GitHub] spark pull request #17069: [MINOR][ML][DOC] Document default value for Gener...

2017-02-25 Thread jkbradley
GitHub user jkbradley opened a pull request: https://github.com/apache/spark/pull/17069 [MINOR][ML][DOC] Document default value for GeneralizedLinearRegression.linkPower Add Scaladoc for GeneralizedLinearRegression.linkPower default value Follow-up to

[GitHub] spark issue #17055: [SPARK-19723][SQL]create datasource table with an non-ex...

2017-02-25 Thread windpiger
Github user windpiger commented on the issue: https://github.com/apache/spark/pull/17055 cc @gatorsmile @cloud-fan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #17062: [SPARK-17495] [SQL] Support date, timestamp and interval...

2017-02-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17062 **[Test build #73472 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73472/testReport)** for PR 17062 at commit

[GitHub] spark issue #17068: [SPARK-19709][SQL] Read empty file with CSV data source

2017-02-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17068 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #17062: [SPARK-17495] [SQL] Support date, timestamp and interval...

2017-02-25 Thread tejasapatil
Github user tejasapatil commented on the issue: https://github.com/apache/spark/pull/17062 Jenkins retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #17056: [SPARK-17495] [SQL] Support Decimal type in Hive-hash

2017-02-25 Thread tejasapatil
Github user tejasapatil commented on the issue: https://github.com/apache/spark/pull/17056 @cloud-fan @gatorsmile : can you please review this PR ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request #17068: [SPARK-19709][SQL] Read empty file with CSV data ...

2017-02-25 Thread wojtek-szymanski
GitHub user wojtek-szymanski opened a pull request: https://github.com/apache/spark/pull/17068 [SPARK-19709][SQL] Read empty file with CSV data source ## What changes were proposed in this pull request? Bugfix for reading empty file with CSV data source. Instead of throwing

[GitHub] spark issue #17067: [SPARK-19602][SQL][TESTS] Add tests for qualified column...

2017-02-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17067 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #16793: [SPARK-19454][PYTHON][SQL] DataFrame.replace improvement...

2017-02-25 Thread zero323
Github user zero323 commented on the issue: https://github.com/apache/spark/pull/16793 > I think (and I could be wrong) that @nchammas was suggesting it might make sense to have some more tests with dict, not that the other additional new tests are bad. I am like Python -

[GitHub] spark pull request #17067: [SPARK-19602][SQL][TESTS] Add tests for qualified...

2017-02-25 Thread skambha
GitHub user skambha opened a pull request: https://github.com/apache/spark/pull/17067 [SPARK-19602][SQL][TESTS] Add tests for qualified column names ## What changes were proposed in this pull request? - Add tests covering different scenarios with qualified column names without

[GitHub] spark issue #17024: [SPARK-19525][CORE] Compressing checkpoints.

2017-02-25 Thread aramesh117
Github user aramesh117 commented on the issue: https://github.com/apache/spark/pull/17024 @mridulm I've added a new commit. Thank you for the review! :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request #17065: [SPARK-17075][SQL][followup] fix some minor issue...

2017-02-25 Thread ron8hu
Github user ron8hu commented on a diff in the pull request: https://github.com/apache/spark/pull/17065#discussion_r103090517 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/FilterEstimation.scala --- @@ -361,57 +343,52 @@ case

[GitHub] spark pull request #16793: [SPARK-19454][PYTHON][SQL] DataFrame.replace impr...

2017-02-25 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/16793#discussion_r103089544 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1307,43 +1307,66 @@ def replace(self, to_replace, value, subset=None): |null| null|null|

[GitHub] spark pull request #16793: [SPARK-19454][PYTHON][SQL] DataFrame.replace impr...

2017-02-25 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/16793#discussion_r103089653 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1307,43 +1307,66 @@ def replace(self, to_replace, value, subset=None): |null| null|null|

[GitHub] spark pull request #16793: [SPARK-19454][PYTHON][SQL] DataFrame.replace impr...

2017-02-25 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/16793#discussion_r103089704 --- Diff: python/pyspark/sql/tests.py --- @@ -1591,6 +1591,67 @@ def test_replace(self): self.assertEqual(row.age, 10)

[GitHub] spark pull request #13072: [SPARK-15288] [Mesos] Mesos dispatcher should han...

2017-02-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13072 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #13072: [SPARK-15288] [Mesos] Mesos dispatcher should handle gra...

2017-02-25 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/13072 Merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark pull request #17010: [SPARK-19673][SQL] "ThriftServer default app name...

2017-02-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17010 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #17010: [SPARK-19673][SQL] "ThriftServer default app name is cha...

2017-02-25 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/17010 Merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #17065: [SPARK-17075][SQL][followup] fix some minor issues and c...

2017-02-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17065 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73471/ Test PASSed. ---

[GitHub] spark issue #17065: [SPARK-17075][SQL][followup] fix some minor issues and c...

2017-02-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17065 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17065: [SPARK-17075][SQL][followup] fix some minor issues and c...

2017-02-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17065 **[Test build #73471 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73471/testReport)** for PR 17065 at commit

[GitHub] spark issue #14601: [SPARK-13979][Core] Killed executor is re spawned withou...

2017-02-25 Thread steveloughran
Github user steveloughran commented on the issue: https://github.com/apache/spark/pull/14601 1. It's good to have some tests 2. I note that `appendS3AndSparkHadoopConfigurations()` has a weakness in how it propagates env vars: no propagation of the session environment

[GitHub] spark issue #16990: [SPARK-19660][CORE][SQL] Replace the configuration prope...

2017-02-25 Thread steveloughran
Github user steveloughran commented on the issue: https://github.com/apache/spark/pull/16990 LGTM, though you'd have to go do the full coverage to verify that there's not a typo in any of the strings. This is why although Spark has adopted the more readable inline strings, I'm more

[GitHub] spark issue #17061: [SPARK-13446] [SQL] Support reading data from Hive 2.0.1...

2017-02-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17061 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17061: [SPARK-13446] [SQL] Support reading data from Hive 2.0.1...

2017-02-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17061 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73470/ Test PASSed. ---

[GitHub] spark pull request #17065: [SPARK-17075][SQL][followup] fix some minor issue...

2017-02-25 Thread ron8hu
Github user ron8hu commented on a diff in the pull request: https://github.com/apache/spark/pull/17065#discussion_r103087483 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/FilterEstimation.scala --- @@ -95,15 +84,16 @@ case class

[GitHub] spark issue #17061: [SPARK-13446] [SQL] Support reading data from Hive 2.0.1...

2017-02-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17061 **[Test build #73470 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73470/testReport)** for PR 17061 at commit

[GitHub] spark pull request #17065: [SPARK-17075][SQL][followup] fix some minor issue...

2017-02-25 Thread ron8hu
Github user ron8hu commented on a diff in the pull request: https://github.com/apache/spark/pull/17065#discussion_r103087345 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/FilterEstimation.scala --- @@ -297,6 +278,8 @@ case class

[GitHub] spark issue #15505: [SPARK-18890][CORE] Move task serialization from the Tas...

2017-02-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15505 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15505: [SPARK-18890][CORE] Move task serialization from the Tas...

2017-02-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15505 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73468/ Test PASSed. ---

[GitHub] spark issue #15505: [SPARK-18890][CORE] Move task serialization from the Tas...

2017-02-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15505 **[Test build #73468 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73468/testReport)** for PR 15505 at commit

  1   2   >