[GitHub] spark issue #17083: [SPARK-19750][UI][branch-2.1] Fix redirect issue from ht...

Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/17083 Ping @vanzin , do you have any further comments? Thanks a lot. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #17128: [SPARK-18352][DOCS] wholeFile JSON update doc and progra...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17128 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17128: [SPARK-18352][DOCS] wholeFile JSON update doc and progra...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17128 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73729/ Test PASSed. ---

[GitHub] spark issue #17128: [SPARK-18352][DOCS] wholeFile JSON update doc and progra...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17128 **[Test build #73729 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73729/testReport)** for PR 17128 at commit

[GitHub] spark issue #17122: [SPARK-19786][SQL] Facilitate loop optimizations in a JI...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17122 **[Test build #73737 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73737/testReport)** for PR 17122 at commit

[GitHub] spark issue #17034: [SPARK-19704][ML] AFTSurvivalRegression should support n...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17034 **[Test build #73738 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73738/testReport)** for PR 17034 at commit

[GitHub] spark issue #16971: [SPARK-19573][SQL] Make NaN/null handling consistent in ...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16971 **[Test build #73739 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73739/testReport)** for PR 16971 at commit

[GitHub] spark pull request #17001: [SPARK-19667][SQL]create table with hiveenabled i...

Github user windpiger commented on a diff in the pull request: https://github.com/apache/spark/pull/17001#discussion_r103865522 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala --- @@ -30,7 +33,7 @@ import

[GitHub] spark pull request #17124: [SPARK-19779][SS]Delete needless tmp file after r...

Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/17124#discussion_r103864707 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala --- @@ -282,8 +282,12 @@

[GitHub] spark pull request #17124: [SPARK-19779][SS]Delete needless tmp file after r...

Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/17124#discussion_r103865389 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreSuite.scala --- @@ -295,6 +295,28 @@ class StateStoreSuite

[GitHub] spark pull request #17125: [SPARK-19211][SQL] Explicitly prevent Insert into...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17125#discussion_r103865408 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala --- @@ -128,6 +129,15 @@ case class CreateViewCommand(

[GitHub] spark pull request #17001: [SPARK-19667][SQL]create table with hiveenabled i...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17001#discussion_r103865312 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala --- @@ -30,7 +33,7 @@ import

[GitHub] spark pull request #17122: [SPARK-19786][SQL] Facilitate loop optimizations ...

Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/17122#discussion_r103865206 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala --- @@ -206,6 +206,16 @@ trait CodegenSupport extends SparkPlan

[GitHub] spark pull request #17122: [SPARK-19786][SQL] Facilitate loop optimizations ...

Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/17122#discussion_r103865202 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala --- @@ -206,6 +206,16 @@ trait CodegenSupport extends SparkPlan

[GitHub] spark issue #17097: [SPARK-19765][SQL] UNCACHE TABLE should re-cache all cac...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17097 **[Test build #73736 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73736/testReport)** for PR 17097 at commit

[GitHub] spark pull request #17075: [SPARK-19727][SQL] Fix for round function that mo...

Github user wojtek-szymanski commented on a diff in the pull request: https://github.com/apache/spark/pull/17075#discussion_r103864843 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/types/DecimalSuite.scala --- @@ -193,7 +193,7 @@ class DecimalSuite extends

[GitHub] spark pull request #17075: [SPARK-19727][SQL] Fix for round function that mo...

Github user wojtek-szymanski commented on a diff in the pull request: https://github.com/apache/spark/pull/17075#discussion_r103864772 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala --- @@ -362,17 +374,13 @@ final class Decimal extends

[GitHub] spark pull request #17075: [SPARK-19727][SQL] Fix for round function that mo...

Github user wojtek-szymanski commented on a diff in the pull request: https://github.com/apache/spark/pull/17075#discussion_r103864736 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala --- @@ -362,17 +374,13 @@ final class Decimal extends

[GitHub] spark pull request #16910: [SPARK-19575][SQL]Reading from or writing to a hi...

Github user windpiger commented on a diff in the pull request: https://github.com/apache/spark/pull/16910#discussion_r103864544 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala --- @@ -1588,6 +1590,153 @@ class HiveDDLSuite }

[GitHub] spark issue #17132: [SPARK-19792][webui]In the Master Page,the column named ...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17132 **[Test build #3591 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3591/testReport)** for PR 17132 at commit

[GitHub] spark pull request #17075: [SPARK-19727][SQL] Fix for round function that mo...

Github user wojtek-szymanski commented on a diff in the pull request: https://github.com/apache/spark/pull/17075#discussion_r103864520 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/MathFunctionsSuite.scala --- @@ -233,6 +233,18 @@ class MathFunctionsSuite extends

[GitHub] spark issue #17076: [SPARK-19745][ML] SVCAggregator captures coefficients in...

Github user MLnick commented on the issue: https://github.com/apache/spark/pull/17076 @yanboliang yeah I agree we can do it in this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #17076: [SPARK-19745][ML] SVCAggregator captures coefficients in...

Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/17076 +1 @MLnick Three lines change, updated here? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #17075: [SPARK-19727][SQL] Fix for round function that mo...

Github user wojtek-szymanski commented on a diff in the pull request: https://github.com/apache/spark/pull/17075#discussion_r103864255 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala --- @@ -362,17 +374,13 @@ final class Decimal extends

[GitHub] spark pull request #17081: [SPARK-18726][SQL][FOLLOW-UP]resolveRelation for ...

Github user windpiger commented on a diff in the pull request: https://github.com/apache/spark/pull/17081#discussion_r103864206 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -364,7 +364,12 @@ case class DataSource(

[GitHub] spark pull request #17034: [SPARK-19704][ML] AFTSurvivalRegression should su...

Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/17034#discussion_r103864147 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/AFTSurvivalRegressionSuite.scala --- @@ -27,6 +27,9 @@ import

[GitHub] spark pull request #17001: [SPARK-19667][SQL]create table with hiveenabled i...

Github user windpiger commented on a diff in the pull request: https://github.com/apache/spark/pull/17001#discussion_r103863975 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala --- @@ -30,7 +33,7 @@ import

[GitHub] spark issue #17076: [SPARK-19745][ML] SVCAggregator captures coefficients in...

Github user MLnick commented on the issue: https://github.com/apache/spark/pull/17076 @imatiach-msft `LinearRegression`, `LogisticRegression` and `AFTSurvivalRegression` do not have the `lazy` - they only do `private val gradientSumArray ...` so would need to be updated. --- If

[GitHub] spark pull request #17125: [SPARK-19211][SQL] Explicitly prevent Insert into...

Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/17125#discussion_r103863856 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala --- @@ -128,6 +129,15 @@ case class CreateViewCommand(

[GitHub] spark issue #17034: [SPARK-19704][ML] AFTSurvivalRegression should support n...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17034 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73731/ Test PASSed. ---

[GitHub] spark issue #17034: [SPARK-19704][ML] AFTSurvivalRegression should support n...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17034 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #17075: [SPARK-19727][SQL] Fix for round function that mo...

Github user wojtek-szymanski commented on a diff in the pull request: https://github.com/apache/spark/pull/17075#discussion_r103863771 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala --- @@ -223,12 +223,24 @@ final class Decimal extends

[GitHub] spark issue #17034: [SPARK-19704][ML] AFTSurvivalRegression should support n...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17034 **[Test build #73731 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73731/testReport)** for PR 17034 at commit

[GitHub] spark pull request #17075: [SPARK-19727][SQL] Fix for round function that mo...

Github user wojtek-szymanski commented on a diff in the pull request: https://github.com/apache/spark/pull/17075#discussion_r103863738 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala --- @@ -339,36 +339,34 @@ case class Cast(child:

[GitHub] spark pull request #17095: [SPARK-19763][SQL]qualified external datasource t...

Github user windpiger commented on a diff in the pull request: https://github.com/apache/spark/pull/17095#discussion_r103863691 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -254,7 +254,18 @@ class SessionCatalog(

[GitHub] spark issue #17132: [SPARK-19792][webui]In the Master Page,the column named ...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17132 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #17122: [SPARK-19786][SQL] Facilitate loop optimizations ...

Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17122#discussion_r103863428 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala --- @@ -206,6 +206,16 @@ trait CodegenSupport extends

[GitHub] spark pull request #17132: [SPARK-19792][webui]In the Master Page,the column...

GitHub user 10110346 opened a pull request: https://github.com/apache/spark/pull/17132 [SPARK-19792][webui]In the Master Page,the column named “Memory per Node” ,I think it is not all right all right Signed-off-by: liuxian ## What

[GitHub] spark pull request #17076: [SPARK-19745][ML] SVCAggregator captures coeffici...

Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/17076#discussion_r103863345 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LinearSVC.scala --- @@ -463,6 +458,8 @@ private class LinearSVCAggregator( */

[GitHub] spark pull request #17122: [SPARK-19786][SQL] Facilitate loop optimizations ...

Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17122#discussion_r103863351 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala --- @@ -206,6 +206,16 @@ trait CodegenSupport extends

[GitHub] spark pull request #17075: [SPARK-19727][SQL] Fix for round function that mo...

Github user wojtek-szymanski commented on a diff in the pull request: https://github.com/apache/spark/pull/17075#discussion_r103863388 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala --- @@ -339,36 +339,34 @@ case class Cast(child:

[GitHub] spark pull request #17125: [SPARK-19211][SQL] Explicitly prevent Insert into...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17125#discussion_r103863369 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala --- @@ -128,6 +129,15 @@ case class CreateViewCommand(

[GitHub] spark pull request #17095: [SPARK-19763][SQL]qualified external datasource t...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17095#discussion_r103863244 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -254,7 +254,18 @@ class SessionCatalog(

[GitHub] spark pull request #17001: [SPARK-19667][SQL]create table with hiveenabled i...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17001#discussion_r103863070 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala --- @@ -30,7 +33,7 @@ import

[GitHub] spark pull request #16910: [SPARK-19575][SQL]Reading from or writing to a hi...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16910#discussion_r103862924 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala --- @@ -1588,6 +1590,153 @@ class HiveDDLSuite }

[GitHub] spark pull request #17001: [SPARK-19667][SQL]create table with hiveenabled i...

Github user windpiger commented on a diff in the pull request: https://github.com/apache/spark/pull/17001#discussion_r103862862 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala --- @@ -30,7 +33,7 @@ import

[GitHub] spark pull request #17122: [SPARK-19786][SQL] Facilitate loop optimizations ...

Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17122#discussion_r103862946 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala --- @@ -206,6 +206,16 @@ trait CodegenSupport extends

[GitHub] spark pull request #17122: [SPARK-19786][SQL] Facilitate loop optimizations ...

Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/17122#discussion_r103862749 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala --- @@ -206,6 +206,16 @@ trait CodegenSupport extends SparkPlan

[GitHub] spark issue #16910: [SPARK-19575][SQL]Reading from or writing to a hive serd...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16910 **[Test build #73735 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73735/testReport)** for PR 16910 at commit

[GitHub] spark issue #17122: [SPARK-19786][SQL] Facilitate loop optimizations in a JI...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17122 **[Test build #73734 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73734/testReport)** for PR 17122 at commit

[GitHub] spark pull request #17081: [SPARK-18726][SQL][FOLLOW-UP]resolveRelation for ...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17081#discussion_r103862631 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -364,7 +364,12 @@ case class DataSource(

[GitHub] spark pull request #17122: [SPARK-19786][SQL] Facilitate loop optimizations ...

Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17122#discussion_r103862423 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala --- @@ -206,6 +206,16 @@ trait CodegenSupport extends

[GitHub] spark pull request #17081: [SPARK-18726][SQL][FOLLOW-UP]resolveRelation for ...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17081#discussion_r103862351 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -86,7 +86,7 @@ case class DataSource( lazy

[GitHub] spark pull request #17122: [SPARK-19786][SQL] Facilitate loop optimizations ...

Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/17122#discussion_r103862311 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala --- @@ -434,6 +434,17 @@ case class RangeExec(range:

[GitHub] spark pull request #17122: [SPARK-19786][SQL] Facilitate loop optimizations ...

Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/17122#discussion_r103862282 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala --- @@ -206,6 +207,13 @@ trait CodegenSupport extends SparkPlan

[GitHub] spark pull request #17095: [SPARK-19763][SQL]qualified external datasource t...

Github user windpiger commented on a diff in the pull request: https://github.com/apache/spark/pull/17095#discussion_r103862289 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -254,7 +254,18 @@ class SessionCatalog(

[GitHub] spark pull request #17122: [SPARK-19786][SQL] Facilitate loop optimizations ...

Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/17122#discussion_r103862257 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala --- @@ -77,6 +77,7 @@ trait CodegenSupport extends SparkPlan {

[GitHub] spark pull request #17122: [SPARK-19786][SQL] Facilitate loop optimizations ...

Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/17122#discussion_r103862272 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala --- @@ -206,6 +207,13 @@ trait CodegenSupport extends SparkPlan

[GitHub] spark pull request #17095: [SPARK-19763][SQL]qualified external datasource t...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17095#discussion_r103862062 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -254,7 +254,18 @@ class SessionCatalog(

[GitHub] spark pull request #17127: [SPARK-19734][PYTHON][ML] Correct OneHotEncoder d...

Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17127 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #17081: [SPARK-18726][SQL][FOLLOW-UP]resolveRelation for ...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17081#discussion_r103861992 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -122,7 +122,7 @@ case class DataSource(

[GitHub] spark issue #17127: [SPARK-19734][PYTHON][ML] Correct OneHotEncoder doc stri...

Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/17127 Merged into master, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #17104: [MINOR][ML] Fix comments in LSH Examples and Pyth...

Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17104 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #17104: [MINOR][ML] Fix comments in LSH Examples and Python API

Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/17104 LGTM, merged into master. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16910: [SPARK-19575][SQL]Reading from or writing to a hive serd...

Github user windpiger commented on the issue: https://github.com/apache/spark/pull/16910 ok, do it now ~ yesterday is ok... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #17001: [SPARK-19667][SQL]create table with hiveenabled i...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17001#discussion_r103861521 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala --- @@ -30,7 +33,7 @@ import

[GitHub] spark pull request #17081: [SPARK-18726][SQL][FOLLOW-UP]resolveRelation for ...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17081#discussion_r103861424 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -364,7 +364,12 @@ case class DataSource(

[GitHub] spark pull request #17001: [SPARK-19667][SQL]create table with hiveenabled i...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17001#discussion_r103861355 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala --- @@ -74,7 +77,19 @@ abstract class ExternalCatalog

[GitHub] spark pull request #17122: [SPARK-19786][SQL] Facilitate loop optimizations ...

Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17122#discussion_r103861360 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala --- @@ -434,6 +434,17 @@ case class RangeExec(range:

[GitHub] spark issue #17081: [SPARK-18726][SQL][FOLLOW-UP]resolveRelation for FileFor...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17081 **[Test build #73733 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73733/testReport)** for PR 17081 at commit

[GitHub] spark pull request #16938: [SPARK-19583][SQL]CTAS for data source table with...

Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16938 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #16910: [SPARK-19575][SQL]Reading from or writing to a hive serd...

Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16910 can you resolve the conflict? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request #17122: [SPARK-19786][SQL] Facilitate loop optimizations ...

Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17122#discussion_r103861241 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala --- @@ -206,6 +207,13 @@ trait CodegenSupport extends

[GitHub] spark issue #17081: [SPARK-18726][SQL][FOLLOW-UP]resolveRelation for FileFor...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17081 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73726/ Test PASSed. ---

[GitHub] spark issue #17081: [SPARK-18726][SQL][FOLLOW-UP]resolveRelation for FileFor...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17081 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16938: [SPARK-19583][SQL]CTAS for data source table with a crea...

Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16938 thanks, merging to master! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #17081: [SPARK-18726][SQL][FOLLOW-UP]resolveRelation for FileFor...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17081 **[Test build #73726 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73726/testReport)** for PR 17081 at commit

[GitHub] spark pull request #17122: [SPARK-19786][SQL] Facilitate loop optimizations ...

Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17122#discussion_r103860895 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala --- @@ -77,6 +77,7 @@ trait CodegenSupport extends SparkPlan {

[GitHub] spark pull request #17122: [SPARK-19786][SQL] Facilitate loop optimizations ...

Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17122#discussion_r103860938 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala --- @@ -206,6 +207,13 @@ trait CodegenSupport extends

[GitHub] spark pull request #17125: [SPARK-19211][SQL] Explicitly prevent Insert into...

Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/17125#discussion_r103860516 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala --- @@ -128,6 +129,15 @@ case class CreateViewCommand(

[GitHub] spark issue #17076: [SPARK-19745][ML] SVCAggregator captures coefficients in...

Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/17076 @sethah Thanks for the good catch. I verified this optimization and found it indeed reduced the size of shuffle data. This looks good to me. BTW, like @MLnick 's suggestion, could you add the

[GitHub] spark pull request #17125: [SPARK-19211][SQL] Explicitly prevent Insert into...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17125#discussion_r103860095 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala --- @@ -128,6 +129,15 @@ case class CreateViewCommand(

[GitHub] spark pull request #17081: [SPARK-18726][SQL][FOLLOW-UP]resolveRelation for ...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17081#discussion_r103859650 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -364,7 +364,8 @@ case class DataSource(

[GitHub] spark issue #17131: [SPARK-19766][SQL][BRANCH-2.0] Constant alias columns in...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17131 **[Test build #73732 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73732/consoleFull)** for PR 17131 at commit

[GitHub] spark issue #17119: [SPARK-19784][SQL][WIP]refresh table after alter the loc...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17119 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17119: [SPARK-19784][SQL][WIP]refresh table after alter the loc...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17119 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73727/ Test FAILed. ---

[GitHub] spark issue #17119: [SPARK-19784][SQL][WIP]refresh table after alter the loc...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17119 **[Test build #73727 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73727/testReport)** for PR 17119 at commit

[GitHub] spark issue #17131: [SPARK-19766][SQL][BRANCH-2.0] Constant alias columns in...

Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17131 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark pull request #17125: [SPARK-19211][SQL] Explicitly prevent Insert into...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17125#discussion_r103859056 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala --- @@ -128,6 +129,15 @@ case class CreateViewCommand(

[GitHub] spark pull request #17125: [SPARK-19211][SQL] Explicitly prevent Insert into...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17125#discussion_r103858978 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala --- @@ -128,6 +129,15 @@ case class CreateViewCommand(

[GitHub] spark pull request #17125: [SPARK-19211][SQL] Explicitly prevent Insert into...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17125#discussion_r103858997 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala --- @@ -128,6 +129,15 @@ case class CreateViewCommand(

[GitHub] spark issue #17131: [SPARK-19766][SQL][BRANCH-2.0] Constant alias columns in...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17131 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #17034: [SPARK-19704][ML] AFTSurvivalRegression should support n...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17034 **[Test build #73731 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73731/testReport)** for PR 17034 at commit

[GitHub] spark issue #17122: [SPARK-19786][SQL] Facilitate loop optimizations in a JI...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17122 **[Test build #73730 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73730/testReport)** for PR 17122 at commit

[GitHub] spark pull request #17125: [SPARK-19211][SQL] Explicitly prevent Insert into...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17125#discussion_r103858555 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -604,7 +604,14 @@ class Analyzer( def

[GitHub] spark pull request #17122: [SPARK-19786][SQL] Facilitate loop optimizations ...

Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/17122#discussion_r103858494 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala --- @@ -77,6 +77,10 @@ trait CodegenSupport extends SparkPlan {

[GitHub] spark pull request #17122: [SPARK-19786][SQL] Facilitate loop optimizations ...

Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/17122#discussion_r103858474 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala --- @@ -69,6 +69,7 @@ trait BaseLimitExec extends UnaryExecNode with

[GitHub] spark pull request #17131: [SPARK-19766][SQL][BRANCH-2.0] Constant alias col...

GitHub user stanzhai opened a pull request: https://github.com/apache/spark/pull/17131 [SPARK-19766][SQL][BRANCH-2.0] Constant alias columns in INNER JOIN should not be folded by FoldablePropagation rule This PR fix for branch-2.0 Refer #17099 @gatorsmile You

[GitHub] spark pull request #17034: [SPARK-19704][ML] AFTSurvivalRegression should su...

Github user zhengruifeng commented on a diff in the pull request: https://github.com/apache/spark/pull/17034#discussion_r103858261 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/AFTSurvivalRegressionSuite.scala --- @@ -27,6 +27,8 @@ import

[GitHub] spark pull request #17034: [SPARK-19704][ML] AFTSurvivalRegression should su...

Github user zhengruifeng commented on a diff in the pull request: https://github.com/apache/spark/pull/17034#discussion_r103858210 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/AFTSurvivalRegressionSuite.scala --- @@ -361,6 +363,36 @@ class

  1   2   3   4   5   6   >