Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17265
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74421/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17265
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17265
**[Test build #74421 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74421/testReport)**
for PR 17265 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17175
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17175
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74419/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17175
**[Test build #74419 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74419/testReport)**
for PR 17175 at commit
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17087#discussion_r105592254
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala ---
@@ -355,7 +357,21 @@ abstract class SparkPlan extends
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16729
**[Test build #74423 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74423/testReport)**
for PR 16729 at commit
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/16729
Sorry that I forgot to address that comment. Fixed now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/17271#discussion_r105591776
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala ---
@@ -566,13 +566,17 @@ private[client] class Shim_v0_13 extends
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17271
**[Test build #74422 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74422/testReport)**
for PR 17271 at commit
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/17255#discussion_r105591511
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonDataSource.scala
---
@@ -123,24 +124,31 @@ object JsonDataSource
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/17271
@gatorsmile . This is the PR for showing failure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/17271
[SPARK-19912][SQL] String literals should be escaped for Hive metastore
partition pruning
## What changes were proposed in this pull request?
This is not for merging.
This shows
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17087#discussion_r105591395
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala ---
@@ -355,7 +357,21 @@ abstract class SparkPlan extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17087#discussion_r105591252
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala ---
@@ -355,7 +357,21 @@ abstract class SparkPlan extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17087#discussion_r105590942
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala
---
@@ -32,6 +32,7 @@ import
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17087#discussion_r105590889
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala ---
@@ -355,7 +357,21 @@ abstract class SparkPlan extends
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16729#discussion_r105590741
--- Diff: R/pkg/R/mllib_regression.R ---
@@ -67,17 +54,20 @@ tweedie <- function(var.power = 0.0, link.power = 1.0 -
var.power) {
#'
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17087#discussion_r105590457
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -951,10 +965,10 @@ object CodeGenerator
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/16596
right, i think we could either leave it as-is, or
- check for java like this PR was trying to do originally; or
- check that it resolved to an empty string in spark-submit, and echo an
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17265
**[Test build #74421 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74421/testReport)**
for PR 17265 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17265#discussion_r105589953
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala ---
@@ -733,12 +733,8 @@ private[client] class Shim_v0_14 extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17087#discussion_r105589421
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -372,7 +374,7 @@ case class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17087#discussion_r105589232
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -372,7 +374,7 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17255#discussion_r105589166
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonDataSource.scala
---
@@ -123,24 +124,31 @@ object JsonDataSource {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17255#discussion_r105589100
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonDataSource.scala
---
@@ -123,24 +124,31 @@ object JsonDataSource {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17175#discussion_r105588851
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryTableScanExec.scala
---
@@ -42,10 +42,34 @@ case class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16971#discussion_r105588823
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproximatePercentile.scala
---
@@ -245,7 +245,7 @@ object
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16971#discussion_r105588798
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/QuantileSummariesSuite.scala
---
@@ -55,7 +55,7 @@ class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17175#discussion_r105588806
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryTableScanExec.scala
---
@@ -42,10 +42,34 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17175#discussion_r105588697
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryTableScanExec.scala
---
@@ -42,10 +42,34 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17175#discussion_r105588650
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryTableScanExec.scala
---
@@ -42,10 +42,34 @@ case class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16971#discussion_r105588596
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproximatePercentile.scala
---
@@ -245,7 +245,7 @@ object
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17265#discussion_r105588537
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -94,6 +95,12 @@ private[spark] class
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/17266
Yep. I see. Thank for the guide, @gatorsmile !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17266
Ok, how about submitting a separate PR by escaping the string? You can show
the reviewers the failure cases there.
---
If your project is set up for it, you can reply to this email and have
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17265#discussion_r105588448
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala ---
@@ -733,12 +733,8 @@ private[client] class Shim_v0_14 extends
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/17266
If you want, I will make some other failure test cases in this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17265#discussion_r105588331
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -94,6 +95,12 @@ private[spark] class HiveExternalCatalog(conf:
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/17266
It's not bug of Hive CLI, it seems a limitation of that API.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17266
Could you try Hive to double check it? Is this a bug in Hive?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17265#discussion_r105588196
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala ---
@@ -733,12 +733,8 @@ private[client] class Shim_v0_14 extends
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/17266
Yes. What I meant was that is not supported correctly from Hive
documentation.
For the mixed case, all combination of the escaping fails.
---
If your project is set up for it, you can
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17253
**[Test build #74420 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74420/testReport)**
for PR 17253 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17253#discussion_r105587493
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormat.scala
---
@@ -90,16 +90,14 @@ trait FileFormat {
*
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16373#discussion_r105587160
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -642,18 +644,34 @@ case class ShowTablesCommand(
//
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16373#discussion_r105586710
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -642,18 +644,34 @@ case class ShowTablesCommand(
//
Github user uncleGen commented on the issue:
https://github.com/apache/spark/pull/17267
@viirya Thanks for you review.
cc @srowen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/17267
Thanks for working on this. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17175
**[Test build #74419 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74419/testReport)**
for PR 17175 at commit
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17175#discussion_r105584772
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryTableScanExec.scala
---
@@ -42,10 +42,34 @@ case class
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17171
ping @hvanhovell @cloud-fan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/17062
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17062
Thanks! Merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user ZunwenYou commented on the issue:
https://github.com/apache/spark/pull/17000
ping @yanboliang , please has a look at this improvement.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17266#discussion_r105583152
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala ---
@@ -566,13 +566,24 @@ private[client] class Shim_v0_13 extends
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/17270
As an application developer we want to know hive table's location, we can
use the command 'show create table ...' to get the table's data location when
the hive table is EXTERNAL but
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17266
Have you tried C-style escaping? `"'` -> `\"\'`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/16596
Ok. That sounds like a bigger change then. I guess we could leave this out
of branch-2.1 and do this for 2.2
---
If your project is set up for it, you can reply to this email and have your
reply
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17250
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17250
**[Test build #74418 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74418/testReport)**
for PR 17250 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17250
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74418/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17270
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user ouyangxiaochen opened a pull request:
https://github.com/apache/spark/pull/17270
[SPARK-19929] [SQL] Showing Hive Managed table's LOATION when Using 'show
create table ...'
## What changes were proposed in this pull request?
Show Hive table's LOCATION property
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17250
**[Test build #74418 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74418/testReport)**
for PR 17250 at commit
Github user CodingCat commented on the issue:
https://github.com/apache/spark/pull/17126
ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user budde commented on the issue:
https://github.com/apache/spark/pull/17250
Found a bit more time to work on this. Changes made:
* Added implementations of ```KinesisDStream.builder()``` that take
```JavaStreamingContext``` instead of ```StreamingContext```
*
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16729
**[Test build #74417 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74417/testReport)**
for PR 16729 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16729
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74417/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16729
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user windpiger commented on the issue:
https://github.com/apache/spark/pull/15918
this change of `schemaFor` will affect the default behavior.
For example:
[udf in
Github user facaiy commented on a diff in the pull request:
https://github.com/apache/spark/pull/14547#discussion_r105576961
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impurity/ApproxBernoulliImpurity.scala
---
@@ -0,0 +1,155 @@
+/*
+ * Licensed to the Apache
Github user windpiger commented on the issue:
https://github.com/apache/spark/pull/17001
@gatorsmile thanks for your suggestion~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17211#discussion_r105576214
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -167,599 +153,6 @@ case class DescribeDatabaseCommand(
}
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16729
**[Test build #74417 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74417/testReport)**
for PR 16729 at commit
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/16729
@felixcheung Thanks for the feedback. Made a new commit that
1. change `variancePower` and `linkPower` to `var.power` and `link.power`.
2. use `link = NULL` for tweedie family.
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16729#discussion_r105576051
--- Diff: R/pkg/R/mllib_regression.R ---
@@ -100,6 +120,12 @@ setMethod("spark.glm", signature(data =
"SparkDataFrame", formula = "formula"),
Github user uncleGen commented on a diff in the pull request:
https://github.com/apache/spark/pull/17209#discussion_r105575677
--- Diff:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSourceSuite.scala
---
@@ -606,6 +607,24 @@ class KafkaSourceSuite
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17062
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74416/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17062
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17062
**[Test build #74416 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74416/testReport)**
for PR 17062 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/17209
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/17209
Thanks. Merging to master and 2.1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/17209#discussion_r105575111
--- Diff:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSourceSuite.scala
---
@@ -606,6 +607,24 @@ class KafkaSourceSuite
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17255
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17255
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74415/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17255
**[Test build #74415 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74415/testReport)**
for PR 17255 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17062
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17062
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74414/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17062
**[Test build #74414 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74414/testReport)**
for PR 17062 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17178
Thank you @felixcheung. Let me try to handle the comments soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/17266
BTW, I forgot to thank you. :) Thank you for review.
For the non-mixed cases, I think we don't need to escape.
---
If your project is set up for it, you can reply to this email and have
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/17266#discussion_r105572873
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala ---
@@ -566,13 +566,24 @@ private[client] class Shim_v0_13 extends
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17255
Let me take a look for that. I think we can replace `sample` at least.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17266
Based on Hive' doc
(https://cwiki.apache.org/confluence/display/Hive/LanguageManual+Types):
> String literals can be expressed with either single quotes (') or double
quotes ("). Hive uses
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/17266
Yep. I tried escaping first, but it doesn't work inside Hive side.
Also, I tried `'"'"'"` for `"'` because it works in Hive. But, for filter
parsing, it fails at parsing Lexer layer.
---
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/17266#discussion_r105572627
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala ---
@@ -566,13 +566,24 @@ private[client] class Shim_v0_13 extends
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17266
We should add the escape, instead of adding quotes. Right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17266#discussion_r105572354
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala ---
@@ -566,13 +566,24 @@ private[client] class Shim_v0_13 extends
1 - 100 of 253 matches
Mail list logo
