[GitHub] spark pull request #17348: [SPARK-20018][SQL] Pivot with timestamp and count...

2017-03-21 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17348#discussion_r107337310 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFramePivotSuite.scala --- @@ -230,4 +230,17 @@ class DataFramePivotSuite extends QueryTest

[GitHub] spark pull request #17348: [SPARK-20018][SQL] Pivot with timestamp and count...

2017-03-21 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17348#discussion_r107335518 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFramePivotSuite.scala --- @@ -230,4 +230,17 @@ class DataFramePivotSuite extends QueryTest

[GitHub] spark issue #17381: [SPARK-20023] [SQL] Output table comment for DESC FORMAT...

2017-03-21 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17381 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark pull request #17381: [SPARK-20023] [SQL] Output table comment for DESC...

2017-03-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17381#discussion_r107335448 --- Diff: sql/core/src/test/resources/sql-tests/results/describe.sql.out --- @@ -79,30 +92,114 @@ d string -- !query

[GitHub] spark pull request #17348: [SPARK-20018][SQL] Pivot with timestamp and count...

2017-03-21 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17348#discussion_r107335421 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFramePivotSuite.scala --- @@ -230,4 +230,17 @@ class DataFramePivotSuite extends QueryTest

[GitHub] spark pull request #17381: [SPARK-20023] [SQL] Output table comment for DESC...

2017-03-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17381#discussion_r107335417 --- Diff: sql/core/src/test/resources/sql-tests/results/describe.sql.out --- @@ -79,30 +92,114 @@ d string -- !query

[GitHub] spark pull request #17348: [SPARK-20018][SQL] Pivot with timestamp and count...

2017-03-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17348#discussion_r107335293 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFramePivotSuite.scala --- @@ -230,4 +230,17 @@ class DataFramePivotSuite extends QueryTest

[GitHub] spark issue #13932: [SPARK-15354] [CORE] Topology aware block replication st...

2017-03-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13932 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75020/ Test PASSed. ---

[GitHub] spark issue #13932: [SPARK-15354] [CORE] Topology aware block replication st...

2017-03-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13932 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13932: [SPARK-15354] [CORE] Topology aware block replication st...

2017-03-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13932 **[Test build #75020 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75020/testReport)** for PR 13932 at commit

[GitHub] spark issue #17308: [SPARK-19968][SS] Use a cached instance of `KafkaProduce...

2017-03-21 Thread ScrapCodes
Github user ScrapCodes commented on the issue: https://github.com/apache/spark/pull/17308 @tcondie and @zsxwing any comments on this patch. I would be happy, if this bug is fixed before 2.2 is released. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark issue #17358: [SPARK-20027][DOCS] Compilation fix in java docs.

2017-03-21 Thread ScrapCodes
Github user ScrapCodes commented on the issue: https://github.com/apache/spark/pull/17358 Actually thank you for your comments, I missed one file in swarm of errors from generated files. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #17358: [SPARK-20027][DOCS] Compilation fix in java docs.

2017-03-21 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17358 Sorry for making this PR dragged. I am fine. Let me cope with it separately. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark issue #17358: [SPARK-20027][DOCS] Compilation fix in java docs.

2017-03-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17358 **[Test build #75028 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75028/testReport)** for PR 17358 at commit

[GitHub] spark issue #17358: [SPARK-20027][DOCS] Compilation fix in java docs.

2017-03-21 Thread ScrapCodes
Github user ScrapCodes commented on the issue: https://github.com/apache/spark/pull/17358 @HyukjinKwon, Fixing those errors require fixing unidoc plugin's java code generation. IMO, that has a broader scope. What do you think ? --- If your project is set up for it, you can reply to

[GitHub] spark issue #17251: [SPARK-19910][SQL] `stack` should not reject NULL values...

2017-03-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17251 **[Test build #75027 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75027/testReport)** for PR 17251 at commit

[GitHub] spark issue #17251: [SPARK-19910][SQL] `stack` should not reject NULL values...

2017-03-21 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/17251 Retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #17363: [SPARK-19970][SQL][BRANCH-2.1] Table owner should be USE...

2017-03-21 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/17363 Hi, @vanzin . Could you review this backport when you have some time? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request #17274: [SPARK-19925][SPARKR] Fix SparkR spark.getSparkFi...

2017-03-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17274 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #17274: [SPARK-19925][SPARKR] Fix SparkR spark.getSparkFiles fai...

2017-03-21 Thread yanboliang
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/17274 Merged into master, I'd prepare a separate PR for branch-2.1. Thanks for reviewing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request #17330: [SPARK-19993][SQL] Caching logical plans containi...

2017-03-21 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/17330#discussion_r107332590 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala --- @@ -61,6 +63,37 @@ abstract class

[GitHub] spark issue #17274: [SPARK-19925][SPARKR] Fix SparkR spark.getSparkFiles fai...

2017-03-21 Thread yanboliang
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/17274 @felixcheung Yeah, this PR not aim to make users can call SparkR package inside UDF, it only focus on users can call ```spark.getSparkFiles``` on workers. I don't think we should support using

[GitHub] spark pull request #17330: [SPARK-19993][SQL] Caching logical plans containi...

2017-03-21 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17330#discussion_r107331403 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala --- @@ -61,6 +63,37 @@ abstract class SubqueryExpression(

[GitHub] spark pull request #17342: [SPARK-12868][SQL] Allow adding jars from hdfs

2017-03-21 Thread weiqingy
Github user weiqingy commented on a diff in the pull request: https://github.com/apache/spark/pull/17342#discussion_r107331216 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala --- @@ -148,6 +149,8 @@ private[sql] class SharedState(val sparkContext:

[GitHub] spark pull request #17361: [SPARK-20030][SS] Event-time-based timeout for Ma...

2017-03-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17361 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #17250: [SPARK-19911][STREAMING] Add builder interface fo...

2017-03-21 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17250#discussion_r107330754 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/SerializableCredentialsProvider.scala --- @@ -83,3 +84,146 @@

[GitHub] spark issue #17348: [SPARK-20018][SQL] Pivot with timestamp and count should...

2017-03-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17348 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17348: [SPARK-20018][SQL] Pivot with timestamp and count should...

2017-03-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17348 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75019/ Test PASSed. ---

[GitHub] spark pull request #17348: [SPARK-20018][SQL] Pivot with timestamp and count...

2017-03-21 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17348#discussion_r107330581 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFramePivotSuite.scala --- @@ -230,4 +230,17 @@ class DataFramePivotSuite extends QueryTest

[GitHub] spark issue #17348: [SPARK-20018][SQL] Pivot with timestamp and count should...

2017-03-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17348 **[Test build #75019 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75019/testReport)** for PR 17348 at commit

[GitHub] spark issue #17381: [SPARK-20023] [SQL] Output table comment for DESC FORMAT...

2017-03-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17381 **[Test build #75026 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75026/testReport)** for PR 17381 at commit

[GitHub] spark pull request #17348: [SPARK-20018][SQL] Pivot with timestamp and count...

2017-03-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17348#discussion_r107329860 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFramePivotSuite.scala --- @@ -230,4 +230,17 @@ class DataFramePivotSuite extends QueryTest

[GitHub] spark pull request #17302: [SPARK-19959][SQL] Fix to throw NullPointerExcept...

2017-03-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17302#discussion_r107329634 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/object.scala --- @@ -41,7 +41,20 @@ object CatalystSerde { }

[GitHub] spark issue #16596: [SPARK-19237][SPARKR][CORE] On Windows spark-submit shou...

2017-03-21 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/16596 Thanks for cc'ing me. I just ran a build against branch-2.1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #17361: [SPARK-20030][SS] Event-time-based timeout for MapGroups...

2017-03-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17361 **[Test build #3604 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3604/testReport)** for PR 17361 at commit

[GitHub] spark issue #16596: [SPARK-19237][SPARKR][CORE] On Windows spark-submit shou...

2017-03-21 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/16596 Build started: [SparkR][BRANCH-2.1]

[GitHub] spark issue #17348: [SPARK-20018][SQL] Pivot with timestamp and count should...

2017-03-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17348 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75018/ Test PASSed. ---

[GitHub] spark issue #17348: [SPARK-20018][SQL] Pivot with timestamp and count should...

2017-03-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17348 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #17302: [SPARK-19959][SQL] Fix to throw NullPointerExcept...

2017-03-21 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17302#discussion_r107329376 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/object.scala --- @@ -41,7 +41,20 @@ object CatalystSerde { }

[GitHub] spark pull request #17302: [SPARK-19959][SQL] Fix to throw NullPointerExcept...

2017-03-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17302#discussion_r107329399 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/object.scala --- @@ -41,7 +41,20 @@ object CatalystSerde { }

[GitHub] spark issue #17348: [SPARK-20018][SQL] Pivot with timestamp and count should...

2017-03-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17348 **[Test build #75018 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75018/testReport)** for PR 17348 at commit

[GitHub] spark pull request #17302: [SPARK-19959][SQL] Fix to throw NullPointerExcept...

2017-03-21 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17302#discussion_r107328723 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/object.scala --- @@ -41,7 +41,20 @@ object CatalystSerde { }

[GitHub] spark pull request #17302: [SPARK-19959][SQL] Fix to throw NullPointerExcept...

2017-03-21 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/17302#discussion_r107328381 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/object.scala --- @@ -41,7 +41,20 @@ object CatalystSerde { }

[GitHub] spark issue #17300: [SPARK-19956][Core]Optimize a location order of blocks w...

2017-03-21 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/17300 The fix LGTM, I think it is nice to have such topology priority. CC @mridulm . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request #17381: [SPARK-20023] [SQL] Output table comment for DESC...

2017-03-21 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17381#discussion_r107327958 --- Diff: sql/core/src/test/resources/sql-tests/inputs/describe.sql --- @@ -8,6 +8,10 @@ DESC t; DESC TABLE t; +DESC FORMATTED t;

[GitHub] spark pull request #17381: [SPARK-20023] [SQL] Output table comment for DESC...

2017-03-21 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17381#discussion_r107327852 --- Diff: sql/core/src/test/resources/sql-tests/inputs/describe.sql --- @@ -8,6 +8,10 @@ DESC t; DESC TABLE t; +DESC FORMATTED t;

[GitHub] spark issue #17100: [SPARK-13947][PYTHON][SQL] PySpark DataFrames: The error...

2017-03-21 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17100 To detect duplicate names, you need to pass SQLConf `conf` in `checkAnalysis` for supporting the case sensitivity in name resolution. For each missing attribute, you can try using

[GitHub] spark pull request #17381: [SPARK-20023] [SQL] Output table comment for DESC...

2017-03-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17381#discussion_r107327601 --- Diff: sql/core/src/test/resources/sql-tests/inputs/describe.sql --- @@ -8,6 +8,10 @@ DESC t; DESC TABLE t; +DESC FORMATTED t;

[GitHub] spark issue #17355: [SPARK-19955][WIP][PySpark] Jenkins Python Conda based t...

2017-03-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17355 **[Test build #75025 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75025/testReport)** for PR 17355 at commit

[GitHub] spark pull request #17295: [SPARK-19556][core] Do not encrypt block manager ...

2017-03-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17295#discussion_r107327362 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -56,6 +57,44 @@ private[spark] class BlockResult( val bytes:

[GitHub] spark pull request #17295: [SPARK-19556][core] Do not encrypt block manager ...

2017-03-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17295#discussion_r107327188 --- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala --- @@ -17,48 +17,67 @@ package org.apache.spark.storage

[GitHub] spark pull request #17348: [SPARK-20018][SQL] Pivot with timestamp and count...

2017-03-21 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17348#discussion_r107326950 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -486,14 +486,16 @@ class Analyzer( case

[GitHub] spark issue #17342: [SPARK-12868][SQL] Allow adding jars from hdfs

2017-03-21 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/17342 CC @vanzin @tgravescs , can you please also review this PR? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request #17295: [SPARK-19556][core] Do not encrypt block manager ...

2017-03-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17295#discussion_r107326715 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -1065,7 +1084,7 @@ private[spark] class BlockManager( try

[GitHub] spark issue #14617: [SPARK-17019][Core] Expose on-heap and off-heap memory u...

2017-03-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14617 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75022/ Test FAILed. ---

[GitHub] spark pull request #17342: [SPARK-12868][SQL] Allow adding jars from hdfs

2017-03-21 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/17342#discussion_r107326694 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala --- @@ -148,6 +149,8 @@ private[sql] class SharedState(val

[GitHub] spark issue #14617: [SPARK-17019][Core] Expose on-heap and off-heap memory u...

2017-03-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14617 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14617: [SPARK-17019][Core] Expose on-heap and off-heap memory u...

2017-03-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14617 **[Test build #75022 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75022/testReport)** for PR 14617 at commit

[GitHub] spark issue #17361: [SPARK-20030][SS] Event-time-based timeout for MapGroups...

2017-03-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17361 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75017/ Test PASSed. ---

[GitHub] spark issue #17361: [SPARK-20030][SS] Event-time-based timeout for MapGroups...

2017-03-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17361 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15435: [SPARK-17139][ML] Add model summary for MultinomialLogis...

2017-03-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15435 **[Test build #75024 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75024/testReport)** for PR 15435 at commit

[GitHub] spark issue #17361: [SPARK-20030][SS] Event-time-based timeout for MapGroups...

2017-03-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17361 **[Test build #75017 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75017/testReport)** for PR 17361 at commit

[GitHub] spark issue #15435: [SPARK-17139][ML] Add model summary for MultinomialLogis...

2017-03-21 Thread WeichenXu123
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/15435 @sethah Code updated. cc @yanboliang Pls help boost this PR thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request #15435: [SPARK-17139][ML] Add model summary for Multinomi...

2017-03-21 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/15435#discussion_r107326057 --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala --- @@ -1786,51 +1793,98 @@ class

[GitHub] spark pull request #15435: [SPARK-17139][ML] Add model summary for Multinomi...

2017-03-21 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/15435#discussion_r107325971 --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala --- @@ -194,15 +207,9 @@ class

[GitHub] spark issue #14617: [SPARK-17019][Core] Expose on-heap and off-heap memory u...

2017-03-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14617 **[Test build #75023 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75023/testReport)** for PR 14617 at commit

[GitHub] spark pull request #17100: [SPARK-13947][PYTHON][SQL] PySpark DataFrames: Th...

2017-03-21 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17100#discussion_r107325822 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -337,11 +337,29 @@ trait CheckAnalysis extends

[GitHub] spark pull request #17348: [SPARK-20018][SQL] Pivot with timestamp and count...

2017-03-21 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/17348#discussion_r107325633 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -486,14 +486,16 @@ class Analyzer( case

[GitHub] spark issue #14617: [SPARK-17019][Core] Expose on-heap and off-heap memory u...

2017-03-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14617 **[Test build #75022 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75022/testReport)** for PR 14617 at commit

[GitHub] spark issue #14617: [SPARK-17019][Core] Expose on-heap and off-heap memory u...

2017-03-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14617 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14617: [SPARK-17019][Core] Expose on-heap and off-heap memory u...

2017-03-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14617 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75021/ Test FAILed. ---

[GitHub] spark issue #14617: [SPARK-17019][Core] Expose on-heap and off-heap memory u...

2017-03-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14617 **[Test build #75021 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75021/testReport)** for PR 14617 at commit

[GitHub] spark issue #14617: [SPARK-17019][Core] Expose on-heap and off-heap memory u...

2017-03-21 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/14617 Hi All, thanks a lot for your comments. Here is the UI after changed: ![screen shot 2017-03-22 at 11 10 22

[GitHub] spark issue #17100: [SPARK-13947][PYTHON][SQL] PySpark DataFrames: The error...

2017-03-21 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17100 Can you remove `[PYTHON]` from the PR title? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request #17295: [SPARK-19556][core] Do not encrypt block manager ...

2017-03-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17295#discussion_r107324613 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManagerManagedBuffer.scala --- @@ -31,17 +35,31 @@ import

[GitHub] spark pull request #17295: [SPARK-19556][core] Do not encrypt block manager ...

2017-03-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17295#discussion_r107324480 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManagerManagedBuffer.scala --- @@ -31,17 +35,31 @@ import

[GitHub] spark pull request #17295: [SPARK-19556][core] Do not encrypt block manager ...

2017-03-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17295#discussion_r107324269 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManagerManagedBuffer.scala --- @@ -17,11 +17,15 @@ package

[GitHub] spark issue #14617: [SPARK-17019][Core] Expose on-heap and off-heap memory u...

2017-03-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14617 **[Test build #75021 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75021/testReport)** for PR 14617 at commit

[GitHub] spark pull request #17295: [SPARK-19556][core] Do not encrypt block manager ...

2017-03-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17295#discussion_r107323983 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -56,6 +57,44 @@ private[spark] class BlockResult( val bytes:

[GitHub] spark issue #17014: [SPARK-18608][ML] Fix double-caching in ML algorithms

2017-03-21 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/17014 ping @hhbyyh I updated the PR, can you please help reviewing this? Thank in advance. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request #17295: [SPARK-19556][core] Do not encrypt block manager ...

2017-03-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17295#discussion_r107323833 --- Diff: core/src/main/scala/org/apache/spark/serializer/SerializerManager.scala --- @@ -167,30 +167,26 @@ private[spark] class SerializerManager(

[GitHub] spark pull request #17295: [SPARK-19556][core] Do not encrypt block manager ...

2017-03-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17295#discussion_r107323552 --- Diff: core/src/main/scala/org/apache/spark/security/CryptoStreamUtils.scala --- @@ -48,12 +51,30 @@ private[spark] object CryptoStreamUtils extends

[GitHub] spark issue #15628: [SPARK-17471][ML] Add compressed method to ML matrices

2017-03-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15628 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15628: [SPARK-17471][ML] Add compressed method to ML matrices

2017-03-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15628 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75016/ Test FAILed. ---

[GitHub] spark issue #15628: [SPARK-17471][ML] Add compressed method to ML matrices

2017-03-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15628 **[Test build #75016 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75016/testReport)** for PR 15628 at commit

[GitHub] spark pull request #17295: [SPARK-19556][core] Do not encrypt block manager ...

2017-03-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17295#discussion_r107323246 --- Diff: core/src/main/scala/org/apache/spark/security/CryptoStreamUtils.scala --- @@ -63,12 +84,27 @@ private[spark] object CryptoStreamUtils extends

[GitHub] spark pull request #17302: [SPARK-19959][SQL] Fix to throw NullPointerExcept...

2017-03-21 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17302#discussion_r107323253 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameImplicitsSuite.scala --- @@ -51,4 +51,15 @@ class DataFrameImplicitsSuite extends

[GitHub] spark pull request #17302: [SPARK-19959][SQL] Fix to throw NullPointerExcept...

2017-03-21 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17302#discussion_r107323158 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/object.scala --- @@ -41,7 +41,20 @@ object CatalystSerde { }

[GitHub] spark pull request #17295: [SPARK-19556][core] Do not encrypt block manager ...

2017-03-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17295#discussion_r107323085 --- Diff: core/src/main/scala/org/apache/spark/security/CryptoStreamUtils.scala --- @@ -48,12 +51,30 @@ private[spark] object CryptoStreamUtils extends

[GitHub] spark pull request #17295: [SPARK-19556][core] Do not encrypt block manager ...

2017-03-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17295#discussion_r107322905 --- Diff: core/src/main/scala/org/apache/spark/broadcast/TorrentBroadcast.scala --- @@ -219,18 +219,22 @@ private[spark] class TorrentBroadcast[T:

[GitHub] spark issue #17378: [SPARK-20046][SQL] Facilitate loop optimizations in a JI...

2017-03-21 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/17378 cc @hvanhovell --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark issue #17358: [SPARK-20027][DOCS] Compilation fix in java docs.

2017-03-21 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17358 If my suggestion is the reason to hold off this PR currently and you are not sure of it, I am fine. I can double-check and deal with this in a separate PR. --- If your project is set up for

[GitHub] spark pull request #17302: [SPARK-19959][SQL] Fix to throw NullPointerExcept...

2017-03-21 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/17302#discussion_r107321520 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/object.scala --- @@ -41,7 +41,20 @@ object CatalystSerde { }

[GitHub] spark issue #13932: [SPARK-15354] [CORE] Topology aware block replication st...

2017-03-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13932 **[Test build #75020 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75020/testReport)** for PR 13932 at commit

[GitHub] spark issue #13932: [SPARK-15354] [CORE] Topology aware block replication st...

2017-03-21 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/13932 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #17350: [SPARK-20017][SQL] change the nullability of function 'S...

2017-03-21 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17350 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark issue #17379: [SPARK-20048][SQL] Cloning SessionState does not clone q...

2017-03-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17379 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17382: [SPARK-20051][SS] Fix StreamSuite flaky test - recover f...

2017-03-21 Thread kunalkhamar
Github user kunalkhamar commented on the issue: https://github.com/apache/spark/pull/17382 @tdas all tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #17379: [SPARK-20048][SQL] Cloning SessionState does not clone q...

2017-03-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17379 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75015/ Test PASSed. ---

[GitHub] spark issue #17382: [SPARK-20051][SS] Fix StreamSuite flaky test - recover f...

2017-03-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17382 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

  1   2   3   4   5   6   7   8   >