[GitHub] spark issue #17276: [SPARK-19937] Collect metrics of block sizes when shuffl...

2017-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17276 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75229/ Test PASSed. ---

[GitHub] spark issue #17276: [SPARK-19937] Collect metrics of block sizes when shuffl...

2017-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17276 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17276: [SPARK-19937] Collect metrics of block sizes when shuffl...

2017-03-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17276 **[Test build #75229 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75229/testReport)** for PR 17276 at commit

[GitHub] spark issue #17406: [SPARK-20009][SQL] Use DDL strings for defining schema i...

2017-03-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17406 **[Test build #75231 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75231/testReport)** for PR 17406 at commit

[GitHub] spark issue #17421: [SPARK-20040][ML][python] pyspark wrapper for ChiSquareT...

2017-03-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17421 **[Test build #3615 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3615/testReport)** for PR 17421 at commit

[GitHub] spark issue #17406: [SPARK-20009][SQL] Use DDL strings for defining schema i...

2017-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17406 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17406: [SPARK-20009][SQL] Use DDL strings for defining schema i...

2017-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17406 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75228/ Test PASSed. ---

[GitHub] spark issue #17406: [SPARK-20009][SQL] Use DDL strings for defining schema i...

2017-03-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17406 **[Test build #75228 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75228/testReport)** for PR 17406 at commit

[GitHub] spark issue #17406: [SPARK-20009][SQL] Use DDL strings for defining schema i...

2017-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17406 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75227/ Test PASSed. ---

[GitHub] spark issue #17406: [SPARK-20009][SQL] Use DDL strings for defining schema i...

2017-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17406 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17406: [SPARK-20009][SQL] Use DDL strings for defining schema i...

2017-03-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17406 **[Test build #75227 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75227/testReport)** for PR 17406 at commit

[GitHub] spark issue #17406: [SPARK-20009][SQL] Use DDL strings for defining schema i...

2017-03-25 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17406 cc @marmbrus @brkyvz --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #17406: [SPARK-20009][SQL] Use DDL strings for defining schema i...

2017-03-25 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17406 LGTM pending Jenkins. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #17406: [SPARK-20009][SQL] Use DDL strings for defining s...

2017-03-25 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17406#discussion_r108051425 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/DataType.scala --- @@ -103,6 +104,12 @@ object DataType { def

[GitHub] spark issue #17218: [SPARK-19281][PYTHON][ML] spark.ml Python API for FPGrow...

2017-03-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17218 **[Test build #75230 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75230/testReport)** for PR 17218 at commit

[GitHub] spark pull request #17430: [SPARK-20096][Spark Submit][Minor]Expose the righ...

2017-03-25 Thread yaooqinn
Github user yaooqinn commented on a diff in the pull request: https://github.com/apache/spark/pull/17430#discussion_r108051074 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala --- @@ -190,6 +190,7 @@ private[deploy] class SparkSubmitArguments(args:

[GitHub] spark pull request #17430: [SPARK-20096][Spark Submit][Minor]Expose the righ...

2017-03-25 Thread yaooqinn
Github user yaooqinn commented on a diff in the pull request: https://github.com/apache/spark/pull/17430#discussion_r108051067 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala --- @@ -307,7 +308,7 @@ private[deploy] class SparkSubmitArguments(args:

[GitHub] spark issue #17276: [WIP][SPARK-19937] Collect metrics of block sizes when s...

2017-03-25 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/17276 @squito Thanks a lot for taking time looking into this pr. I updated the pr. Currently just add two metrics: a) the total size of underestimated blocks size, b) the size of blocks shuffled

[GitHub] spark issue #17276: [WIP][SPARK-19937] Collect metrics of block sizes when s...

2017-03-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17276 **[Test build #75229 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75229/testReport)** for PR 17276 at commit

[GitHub] spark issue #17419: [SPARK-19634][ML] Multivariate summarizer - dataframes A...

2017-03-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17419 **[Test build #3614 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3614/testReport)** for PR 17419 at commit

[GitHub] spark issue #17295: [SPARK-19556][core] Do not encrypt block manager data in...

2017-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17295 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75226/ Test PASSed. ---

[GitHub] spark issue #17295: [SPARK-19556][core] Do not encrypt block manager data in...

2017-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17295 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #17218: [SPARK-19281][PYTHON][ML] spark.ml Python API for...

2017-03-25 Thread zero323
Github user zero323 commented on a diff in the pull request: https://github.com/apache/spark/pull/17218#discussion_r108050687 --- Diff: dev/sparktestsupport/modules.py --- @@ -423,15 +423,16 @@ def __hash__(self): "python/pyspark/ml/" ],

[GitHub] spark issue #17295: [SPARK-19556][core] Do not encrypt block manager data in...

2017-03-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17295 **[Test build #75226 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75226/testReport)** for PR 17295 at commit

[GitHub] spark pull request #17394: [SPARK-20067] [SQL] Use treeString to print out t...

2017-03-25 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17394#discussion_r108050651 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala --- @@ -273,28 +278,32 @@ case class CatalogTable(

[GitHub] spark pull request #17394: [SPARK-20067] [SQL] Use treeString to print out t...

2017-03-25 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17394#discussion_r108050555 --- Diff: sql/core/src/test/resources/sql-tests/results/describe.sql.out --- @@ -68,67 +68,74 @@ DESC FORMATTED t -- !query 5 schema

[GitHub] spark pull request #17394: [SPARK-20067] [SQL] Use treeString to print out t...

2017-03-25 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17394#discussion_r108050438 --- Diff: sql/core/src/test/resources/sql-tests/results/describe.sql.out --- @@ -68,67 +68,74 @@ DESC FORMATTED t -- !query 5 schema

[GitHub] spark issue #17406: [SPARK-20009][SQL] Use DDL strings for defining schema i...

2017-03-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17406 **[Test build #75228 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75228/testReport)** for PR 17406 at commit

[GitHub] spark issue #17406: [SPARK-20009][SQL] Use DDL strings for defining schema i...

2017-03-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17406 **[Test build #75227 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75227/testReport)** for PR 17406 at commit

[GitHub] spark pull request #17406: [SPARK-20009][SQL] Use DDL strings for defining s...

2017-03-25 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17406#discussion_r108050303 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/types/DataTypeSuite.scala --- @@ -169,30 +169,45 @@ class DataTypeSuite extends SparkFunSuite

[GitHub] spark pull request #17407: [SPARK-20043][ML] DecisionTreeModel can't recongn...

2017-03-25 Thread facaiy
Github user facaiy commented on a diff in the pull request: https://github.com/apache/spark/pull/17407#discussion_r108050269 --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/DecisionTreeClassifierSuite.scala --- @@ -385,6 +385,22 @@ class

[GitHub] spark pull request #17407: [SPARK-20043][ML] DecisionTreeModel can't recongn...

2017-03-25 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/17407#discussion_r108050236 --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/DecisionTreeClassifierSuite.scala --- @@ -385,6 +385,22 @@ class

[GitHub] spark issue #17421: [SPARK-20040][ML][python] pyspark wrapper for ChiSquareT...

2017-03-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17421 **[Test build #3615 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3615/testReport)** for PR 17421 at commit

[GitHub] spark issue #17423: [SPARK-20088] Do not create new SparkContext in SparkR c...

2017-03-25 Thread yhuai
Github user yhuai commented on the issue: https://github.com/apache/spark/pull/17423 @felixcheung `SparkContext.getOrCreate` is the preferred way to create a SparkContext. So, even we have check, it is still better to use `getOrCreate`. --- If your project is set up for it, you can

[GitHub] spark issue #17421: [SPARK-20040][ML][python] pyspark wrapper for ChiSquareT...

2017-03-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17421 **[Test build #3612 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3612/testReport)** for PR 17421 at commit

[GitHub] spark pull request #17407: [SPARK-20043][ML] DecisionTreeModel can't recongn...

2017-03-25 Thread facaiy
Github user facaiy commented on a diff in the pull request: https://github.com/apache/spark/pull/17407#discussion_r108050110 --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/DecisionTreeClassifierSuite.scala --- @@ -385,6 +385,20 @@ class

[GitHub] spark pull request #17407: [SPARK-20043][ML] DecisionTreeModel can't recongn...

2017-03-25 Thread facaiy
Github user facaiy commented on a diff in the pull request: https://github.com/apache/spark/pull/17407#discussion_r108050099 --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/DecisionTreeClassifierSuite.scala --- @@ -385,6 +385,20 @@ class

[GitHub] spark pull request #17407: [SPARK-20043][ML] DecisionTreeModel can't recongn...

2017-03-25 Thread facaiy
Github user facaiy commented on a diff in the pull request: https://github.com/apache/spark/pull/17407#discussion_r108050103 --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/DecisionTreeClassifierSuite.scala --- @@ -385,6 +385,20 @@ class

[GitHub] spark pull request #17407: [SPARK-20043][ML] DecisionTreeModel can't recongn...

2017-03-25 Thread facaiy
Github user facaiy commented on a diff in the pull request: https://github.com/apache/spark/pull/17407#discussion_r108050101 --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/DecisionTreeClassifierSuite.scala --- @@ -385,6 +385,20 @@ class

[GitHub] spark issue #17427: [SPARK-20092][R][PROJECT INFRA] Add the detection for Sc...

2017-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17427 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17427: [SPARK-20092][R][PROJECT INFRA] Add the detection for Sc...

2017-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17427 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75225/ Test PASSed. ---

[GitHub] spark issue #17427: [SPARK-20092][R][PROJECT INFRA] Add the detection for Sc...

2017-03-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17427 **[Test build #75225 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75225/testReport)** for PR 17427 at commit

[GitHub] spark pull request #17406: [SPARK-20009][SQL] Use DDL strings for defining s...

2017-03-25 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17406#discussion_r108049895 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/types/DataTypeSuite.scala --- @@ -169,30 +169,45 @@ class DataTypeSuite extends SparkFunSuite {

[GitHub] spark pull request #17406: [SPARK-20009][SQL] Use DDL strings for defining s...

2017-03-25 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17406#discussion_r108049886 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/types/DataTypeSuite.scala --- @@ -169,30 +169,45 @@ class DataTypeSuite extends SparkFunSuite {

[GitHub] spark pull request #17329: [SPARK-19991]FileSegmentManagedBuffer performance...

2017-03-25 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/17329#discussion_r108049460 --- Diff: common/network-common/src/main/java/org/apache/spark/network/buffer/FileSegmentManagedBuffer.java --- @@ -37,13 +37,24 @@ * A {@link

[GitHub] spark issue #17355: [SPARK-19955][WIP][PySpark] Jenkins Python Conda based t...

2017-03-25 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/17355 Oops @bryancutler damn phone keyboard. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17355: [SPARK-19955][WIP][PySpark] Jenkins Python Conda based t...

2017-03-25 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/17355 .@bryanxutler so I left out pypandoc because there isn't pandoc on the machines and it's optional (prints a warning to stderr - but should work fine). I get back from vacation next week so let's

[GitHub] spark issue #17407: [SPARK-20043][ML] DecisionTreeModel can't recongnize Imp...

2017-03-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17407 **[Test build #3613 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3613/testReport)** for PR 17407 at commit

[GitHub] spark issue #17419: [SPARK-19634][ML] Multivariate summarizer - dataframes A...

2017-03-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17419 **[Test build #3614 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3614/testReport)** for PR 17419 at commit

[GitHub] spark pull request #17218: [SPARK-19281][PYTHON][ML] spark.ml Python API for...

2017-03-25 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/17218#discussion_r108048733 --- Diff: python/pyspark/ml/fpm.py --- @@ -0,0 +1,232 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +#

[GitHub] spark pull request #17218: [SPARK-19281][PYTHON][ML] spark.ml Python API for...

2017-03-25 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/17218#discussion_r108048613 --- Diff: python/pyspark/ml/fpm.py --- @@ -0,0 +1,232 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +#

[GitHub] spark pull request #17218: [SPARK-19281][PYTHON][ML] spark.ml Python API for...

2017-03-25 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/17218#discussion_r108048426 --- Diff: dev/sparktestsupport/modules.py --- @@ -423,15 +423,16 @@ def __hash__(self): "python/pyspark/ml/" ],

[GitHub] spark pull request #17218: [SPARK-19281][PYTHON][ML] spark.ml Python API for...

2017-03-25 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/17218#discussion_r108048659 --- Diff: python/pyspark/ml/fpm.py --- @@ -0,0 +1,232 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +#

[GitHub] spark pull request #17218: [SPARK-19281][PYTHON][ML] spark.ml Python API for...

2017-03-25 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/17218#discussion_r108048627 --- Diff: python/pyspark/ml/fpm.py --- @@ -0,0 +1,232 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +#

[GitHub] spark pull request #17218: [SPARK-19281][PYTHON][ML] spark.ml Python API for...

2017-03-25 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/17218#discussion_r108048696 --- Diff: python/pyspark/ml/fpm.py --- @@ -0,0 +1,232 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +#

[GitHub] spark issue #17355: [SPARK-19955][WIP][PySpark] Jenkins Python Conda based t...

2017-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17355 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17355: [SPARK-19955][WIP][PySpark] Jenkins Python Conda based t...

2017-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17355 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75224/ Test PASSed. ---

[GitHub] spark issue #17355: [SPARK-19955][WIP][PySpark] Jenkins Python Conda based t...

2017-03-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17355 **[Test build #75224 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75224/testReport)** for PR 17355 at commit

[GitHub] spark issue #17295: [SPARK-19556][core] Do not encrypt block manager data in...

2017-03-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17295 **[Test build #75226 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75226/testReport)** for PR 17295 at commit

[GitHub] spark issue #17295: [SPARK-19556][core] Do not encrypt block manager data in...

2017-03-25 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/17295 I removed `StorageUtils.unmap()` in my last commit (see commit message for details). That makes the confusion go away. The replication tests fail from time to time but they seem to be flaky

[GitHub] spark pull request #17407: [SPARK-20043][ML] DecisionTreeModel can't recongn...

2017-03-25 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/17407#discussion_r108048393 --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/DecisionTreeClassifierSuite.scala --- @@ -385,6 +385,20 @@ class

[GitHub] spark pull request #17407: [SPARK-20043][ML] DecisionTreeModel can't recongn...

2017-03-25 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/17407#discussion_r108048376 --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/DecisionTreeClassifierSuite.scala --- @@ -385,6 +385,20 @@ class

[GitHub] spark pull request #17407: [SPARK-20043][ML] DecisionTreeModel can't recongn...

2017-03-25 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/17407#discussion_r108048375 --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/DecisionTreeClassifierSuite.scala --- @@ -385,6 +385,20 @@ class

[GitHub] spark pull request #17407: [SPARK-20043][ML] DecisionTreeModel can't recongn...

2017-03-25 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/17407#discussion_r108048398 --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/DecisionTreeClassifierSuite.scala --- @@ -385,6 +385,20 @@ class

[GitHub] spark issue #17407: [SPARK-20043][ML] DecisionTreeModel can't recongnize Imp...

2017-03-25 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/17407 I agree it'd be nice to come up with a generic fix for making String Params robust to case, but I don't have a good solution right now. I'll think about how we might put some generic testing in

[GitHub] spark issue #17407: [SPARK-20043][ML] DecisionTreeModel can't recongnize Imp...

2017-03-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17407 **[Test build #3613 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3613/testReport)** for PR 17407 at commit

[GitHub] spark issue #17421: [SPARK-20040][ML][python] pyspark wrapper for ChiSquareT...

2017-03-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17421 **[Test build #3612 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3612/testReport)** for PR 17421 at commit

[GitHub] spark pull request #17429: [MINOR][DOCS] Match several documentation changes...

2017-03-25 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17429#discussion_r108047783 --- Diff: python/pyspark/sql/functions.py --- @@ -1675,15 +1675,18 @@ def array(*cols): @since(1.5) def array_contains(col, value):

[GitHub] spark pull request #17429: [MINOR][DOCS] Match several documentation changes...

2017-03-25 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17429#discussion_r108047754 --- Diff: R/pkg/R/functions.R --- @@ -3548,7 +3548,7 @@ setMethod("row_number", #' array_contains #' -#' Returns true if the array

[GitHub] spark issue #17427: [SPARK-20092][R][PROJECT INFRA] Add the detection for Sc...

2017-03-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17427 **[Test build #75225 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75225/testReport)** for PR 17427 at commit

[GitHub] spark pull request #17295: [SPARK-19556][core] Do not encrypt block manager ...

2017-03-25 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/17295#discussion_r108046997 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -56,6 +57,49 @@ private[spark] class BlockResult( val bytes: Long)

[GitHub] spark pull request #17384: [SPARK-20056][ML] IsotonicRegression support Nume...

2017-03-25 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17384#discussion_r108046716 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/IsotonicRegression.scala --- @@ -84,7 +84,7 @@ private[regression] trait

[GitHub] spark pull request #17430: [SPARK-20096][Spark Submit][Minor]Expose the righ...

2017-03-25 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17430#discussion_r108046703 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala --- @@ -307,7 +308,7 @@ private[deploy] class

[GitHub] spark pull request #17430: [SPARK-20096][Spark Submit][Minor]Expose the righ...

2017-03-25 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17430#discussion_r108046680 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala --- @@ -190,6 +190,7 @@ private[deploy] class

[GitHub] spark pull request #17295: [SPARK-19556][core] Do not encrypt block manager ...

2017-03-25 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/17295#discussion_r108046686 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -56,6 +57,49 @@ private[spark] class BlockResult( val bytes: Long)

[GitHub] spark issue #17355: [SPARK-19955][WIP][PySpark] Jenkins Python Conda based t...

2017-03-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17355 **[Test build #75224 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75224/testReport)** for PR 17355 at commit

[GitHub] spark issue #17427: [SPARK-20092][R][PROJECT INFRA] Add the detection for Sc...

2017-03-25 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/17427 Thanks! this has always bug me. Please add `mllib/src/main/scala/org/apache/spark/ml/r` too --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #17423: [SPARK-20088] Do not create new SparkContext in SparkR c...

2017-03-25 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/17423 this is already checked on the R side and we should never call `createSparkContext ` more than once --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request #17429: [MINOR][DOCS] Match several documentation changes...

2017-03-25 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17429#discussion_r108046277 --- Diff: R/pkg/R/functions.R --- @@ -3548,7 +3548,7 @@ setMethod("row_number", #' array_contains #' -#' Returns true if the array

[GitHub] spark pull request #17429: [MINOR][DOCS] Match several documentation changes...

2017-03-25 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17429#discussion_r108046296 --- Diff: python/pyspark/sql/functions.py --- @@ -1675,15 +1675,18 @@ def array(*cols): @since(1.5) def array_contains(col, value):

[GitHub] spark issue #17415: [SPARK-19408][SQL] filter estimation on two columns of s...

2017-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17415 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17415: [SPARK-19408][SQL] filter estimation on two columns of s...

2017-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17415 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75223/ Test PASSed. ---

[GitHub] spark issue #17415: [SPARK-19408][SQL] filter estimation on two columns of s...

2017-03-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17415 **[Test build #75223 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75223/testReport)** for PR 17415 at commit

[GitHub] spark issue #17394: [SPARK-20067] [SQL] Use treeString to print out the tabl...

2017-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17394 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17394: [SPARK-20067] [SQL] Use treeString to print out the tabl...

2017-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17394 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75221/ Test PASSed. ---

[GitHub] spark issue #17394: [SPARK-20067] [SQL] Use treeString to print out the tabl...

2017-03-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17394 **[Test build #75221 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75221/testReport)** for PR 17394 at commit

[GitHub] spark issue #17424: [SPARK-20089] [SQL] [TEST] Added DESC FUNCTION and DESC ...

2017-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17424 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75222/ Test PASSed. ---

[GitHub] spark issue #17424: [SPARK-20089] [SQL] [TEST] Added DESC FUNCTION and DESC ...

2017-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17424 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17424: [SPARK-20089] [SQL] [TEST] Added DESC FUNCTION and DESC ...

2017-03-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17424 **[Test build #75222 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75222/testReport)** for PR 17424 at commit

[GitHub] spark issue #17415: [SPARK-19408][SQL] filter estimation on two columns of s...

2017-03-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17415 **[Test build #75223 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75223/testReport)** for PR 17415 at commit

[GitHub] spark issue #17415: [SPARK-19408][SQL] filter estimation on two columns of s...

2017-03-25 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17415 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark pull request #17408: [SPARK-19949][SQL][follow-up] move FailureSafePar...

2017-03-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17408 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #17408: [SPARK-19949][SQL][follow-up] move FailureSafeParser fro...

2017-03-25 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17408 Thanks! Merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #17406: [SPARK-20009][SQL] Use DDL strings for defining s...

2017-03-25 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17406#discussion_r108042419 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/types/DataTypeSuite.scala --- @@ -201,7 +216,7 @@ class DataTypeSuite extends SparkFunSuite {

[GitHub] spark pull request #17406: [SPARK-20009][SQL] Use DDL strings for defining s...

2017-03-25 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17406#discussion_r108042411 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/types/DataTypeSuite.scala --- @@ -169,30 +169,45 @@ class DataTypeSuite extends SparkFunSuite

[GitHub] spark pull request #17406: [SPARK-20009][SQL] Use DDL strings for defining s...

2017-03-25 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17406#discussion_r108042372 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/types/DataTypeSuite.scala --- @@ -169,30 +169,45 @@ class DataTypeSuite extends SparkFunSuite

[GitHub] spark issue #17276: [WIP][SPARK-19937] Collect metrics of block sizes when s...

2017-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17276 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17276: [WIP][SPARK-19937] Collect metrics of block sizes when s...

2017-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17276 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75220/ Test PASSed. ---

[GitHub] spark issue #17276: [WIP][SPARK-19937] Collect metrics of block sizes when s...

2017-03-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17276 **[Test build #75220 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75220/testReport)** for PR 17276 at commit

[GitHub] spark pull request #17426: [SPARK-17137][ML][WIP] Compress logistic regressi...

2017-03-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17426 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

  1   2   3   >