[GitHub] spark issue #16781: [SPARK-12297][SQL] Hive compatibility for Parquet Timest...

2017-04-11 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/16781 @ueshin thanks for taking a look earlier, sorry it has taken me some time to update this. Things to note since last time: 1) Hive has seen been updated in

[GitHub] spark issue #17598: [SPARK-20284][CORE] Make {Des,S}erializationStream exten...

2017-04-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17598 **[Test build #3659 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3659/testReport)** for PR 17598 at commit

[GitHub] spark pull request #17606: [SPARK-20291][SQL] NaNvl(FloatType, NullType) sho...

2017-04-11 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17606#discussion_r110901338 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercionSuite.scala --- @@ -656,14 +656,20 @@ class TypeCoercionSuite

[GitHub] spark pull request #17606: [SPARK-20291][SQL] NaNvl(FloatType, NullType) sho...

2017-04-11 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17606#discussion_r110901088 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercionSuite.scala --- @@ -656,14 +656,20 @@ class TypeCoercionSuite

[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...

2017-04-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/9571 **[Test build #75708 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75708/testReport)** for PR 9571 at commit

[GitHub] spark pull request #17436: [SPARK-20101][SQL] Use OffHeapColumnVector when "...

2017-04-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17436#discussion_r110891992 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala --- @@ -351,11 +351,12 @@ class

[GitHub] spark pull request #17491: [SPARK-20175][SQL] Exists should not be evaluated...

2017-04-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17491 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #17491: [SPARK-20175][SQL] Exists should not be evaluated in Joi...

2017-04-11 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17491 LGTM, merging to master! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #17436: [SPARK-20101][SQL] Use OffHeapColumnVector when "...

2017-04-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17436#discussion_r110889293 --- Diff: core/src/test/scala/org/apache/spark/memory/StaticMemoryManagerSuite.scala --- @@ -48,7 +48,10 @@ class StaticMemoryManagerSuite extends

[GitHub] spark pull request #17587: [SPARK-20274][SQL] support compatible array eleme...

2017-04-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17587 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #17589: [SPARK-16544][SQL] Support for conversion from numeric c...

2017-04-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17589 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75705/ Test PASSed. ---

[GitHub] spark issue #17589: [SPARK-16544][SQL] Support for conversion from numeric c...

2017-04-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17589 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17589: [SPARK-16544][SQL] Support for conversion from numeric c...

2017-04-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17589 **[Test build #75705 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75705/testReport)** for PR 17589 at commit

[GitHub] spark issue #17491: [SPARK-20175][SQL] Exists should not be evaluated in Joi...

2017-04-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17491 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75703/ Test PASSed. ---

[GitHub] spark issue #17491: [SPARK-20175][SQL] Exists should not be evaluated in Joi...

2017-04-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17491 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17587: [SPARK-20274][SQL] support compatible array element type...

2017-04-11 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17587 thanks for the review, merging to master! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #17491: [SPARK-20175][SQL] Exists should not be evaluated in Joi...

2017-04-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17491 **[Test build #75703 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75703/testReport)** for PR 17491 at commit

[GitHub] spark issue #17330: [SPARK-19993][SQL] Caching logical plans containing subq...

2017-04-11 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17330 LGTM except some minor comments about test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #17330: [SPARK-19993][SQL] Caching logical plans containi...

2017-04-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17330#discussion_r110885997 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala --- @@ -76,6 +76,13 @@ class CachedTableSuite extends QueryTest with

[GitHub] spark pull request #17330: [SPARK-19993][SQL] Caching logical plans containi...

2017-04-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17330#discussion_r110885627 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala --- @@ -670,4 +677,139 @@ class CachedTableSuite extends QueryTest with

[GitHub] spark pull request #17330: [SPARK-19993][SQL] Caching logical plans containi...

2017-04-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17330#discussion_r110885501 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala --- @@ -670,4 +677,139 @@ class CachedTableSuite extends QueryTest with

[GitHub] spark issue #17150: [SPARK-19810][BUILD][CORE] Remove support for Scala 2.10

2017-04-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17150 **[Test build #75707 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75707/testReport)** for PR 17150 at commit

[GitHub] spark issue #16677: [SPARK-19355][SQL] Use map output statistices to improve...

2017-04-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16677 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16677: [SPARK-19355][SQL] Use map output statistices to improve...

2017-04-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16677 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75699/ Test PASSed. ---

[GitHub] spark issue #16677: [SPARK-19355][SQL] Use map output statistices to improve...

2017-04-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16677 **[Test build #75699 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75699/testReport)** for PR 16677 at commit

[GitHub] spark pull request #12574: [SPARK-13857][ML][WIP] Add "recommend all" functi...

2017-04-11 Thread MLnick
Github user MLnick closed the pull request at: https://github.com/apache/spark/pull/12574 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #17598: [SPARK-20284][CORE] Make {Des,S}erializationStream exten...

2017-04-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17598 **[Test build #3659 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3659/testReport)** for PR 17598 at commit

[GitHub] spark issue #17608: [SPARK-20293][WEB UI][History]In the page of 'jobs' or '...

2017-04-11 Thread guoxiaolongzte
Github user guoxiaolongzte commented on the issue: https://github.com/apache/spark/pull/17608 Is this, the only way to encode, will not let the browser to escape our special characters.The page will not be error. --- If your project is set up for it, you can reply to this email and

[GitHub] spark issue #17587: [SPARK-20274][SQL] support compatible array element type...

2017-04-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17587 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17608: [SPARK-20293][WEB UI][History]In the page of 'jobs' or '...

2017-04-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17608 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #17587: [SPARK-20274][SQL] support compatible array element type...

2017-04-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17587 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75701/ Test PASSed. ---

[GitHub] spark issue #17587: [SPARK-20274][SQL] support compatible array element type...

2017-04-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17587 **[Test build #75701 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75701/testReport)** for PR 17587 at commit

[GitHub] spark issue #17608: [SPARK-20293][WEB UI][History]In the page of 'jobs' or '...

2017-04-11 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/17608 I don't quite understand, in that you say that the problem was URL-encoding the URL, but the solution here is to URL-encode it again. Is that right? maybe you can show a more concrete example of the

[GitHub] spark pull request #17608: [SPARK-20293][WEB UI][History]In the page of 'job...

2017-04-11 Thread guoxiaolongzte
GitHub user guoxiaolongzte opened a pull request: https://github.com/apache/spark/pull/17608 [SPARK-20293][WEB UI][History]In the page of 'jobs' or 'stages' of history server web ui,,click the 'Go' button, query paging data, the page error ## What changes were proposed in this pull

[GitHub] spark issue #17607: [DOCS] Add docstrings to non-operator binary ops in pysp...

2017-04-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17607 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17607: [DOCS] Add docstrings to non-operator binary ops in pysp...

2017-04-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17607 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75706/ Test PASSed. ---

[GitHub] spark issue #17607: [DOCS] Add docstrings to non-operator binary ops in pysp...

2017-04-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17607 **[Test build #75706 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75706/testReport)** for PR 17607 at commit

[GitHub] spark issue #17606: [SPARK-20291][SQL] NaNvl(FloatType, NullType) should not...

2017-04-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17606 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17606: [SPARK-20291][SQL] NaNvl(FloatType, NullType) should not...

2017-04-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17606 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75702/ Test FAILed. ---

[GitHub] spark pull request #17607: [DOCS] Add docstrings to non-operator binary ops ...

2017-04-11 Thread zero323
Github user zero323 closed the pull request at: https://github.com/apache/spark/pull/17607 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #17606: [SPARK-20291][SQL] NaNvl(FloatType, NullType) should not...

2017-04-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17606 **[Test build #75702 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75702/testReport)** for PR 17606 at commit

[GitHub] spark issue #17604: [SPARK-20289][SQL] Use StaticInvoke to box primitive typ...

2017-04-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17604 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17604: [SPARK-20289][SQL] Use StaticInvoke to box primitive typ...

2017-04-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17604 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75698/ Test PASSed. ---

[GitHub] spark issue #17604: [SPARK-20289][SQL] Use StaticInvoke to box primitive typ...

2017-04-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17604 **[Test build #75698 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75698/testReport)** for PR 17604 at commit

[GitHub] spark issue #17607: [DOCS] Add docstrings to non-operator binary ops in pysp...

2017-04-11 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17607 Or I believe one of both PRs could handle all of them. Cc @map222. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #17607: [DOCS] Add docstrings to non-operator binary ops in pysp...

2017-04-11 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17607 Actually, there is a similar PR - https://github.com/apache/spark/pull/17469. How about doing only non-duplicated ones? --- If your project is set up for it, you can reply to this email and

[GitHub] spark issue #17607: [DOCS] Add docstrings to non-operator binary ops in pysp...

2017-04-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17607 **[Test build #75706 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75706/testReport)** for PR 17607 at commit

[GitHub] spark issue #17607: [DOCS] Add docstrings to non-operator binary ops in pysp...

2017-04-11 Thread zero323
Github user zero323 commented on the issue: https://github.com/apache/spark/pull/17607 cc @holdenk --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark pull request #17607: [DOCS] Add docstrings to non-operator binary ops ...

2017-04-11 Thread zero323
GitHub user zero323 opened a pull request: https://github.com/apache/spark/pull/17607 [DOCS] Add docstrings to non-operator binary ops in pyspark.sql.Column ## What changes were proposed in this pull request? Add docstrings to the following `pyspark.sql.Column` binary ops:

[GitHub] spark issue #17606: [SPARK-20291][SQL] NaNvl(FloatType, NullType) should not...

2017-04-11 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17606 LGTM, except for a question which might not be related to this issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #17533: [WIP][SPARK-20219] Schedule tasks based on size of input...

2017-04-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17533 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17533: [WIP][SPARK-20219] Schedule tasks based on size of input...

2017-04-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17533 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75697/ Test PASSed. ---

[GitHub] spark issue #17533: [WIP][SPARK-20219] Schedule tasks based on size of input...

2017-04-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17533 **[Test build #75697 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75697/testReport)** for PR 17533 at commit

[GitHub] spark issue #17589: [SPARK-16544][SQL] Support for conversion from numeric c...

2017-04-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17589 **[Test build #75705 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75705/testReport)** for PR 17589 at commit

[GitHub] spark pull request #17606: [SPARK-20291][SQL] NaNvl(FloatType, NullType) sho...

2017-04-11 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17606#discussion_r110864960 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -571,6 +571,7 @@ object TypeCoercion {

[GitHub] spark issue #17603: [SPARK-20288] Avoid generating the MapStatus by stageId ...

2017-04-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17603 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17603: [SPARK-20288] Avoid generating the MapStatus by stageId ...

2017-04-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17603 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75696/ Test PASSed. ---

[GitHub] spark issue #17603: [SPARK-20288] Avoid generating the MapStatus by stageId ...

2017-04-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17603 **[Test build #75696 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75696/testReport)** for PR 17603 at commit

[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...

2017-04-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/9571 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...

2017-04-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/9571 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75704/ Test FAILed. ---

[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...

2017-04-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/9571 **[Test build #75704 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75704/testReport)** for PR 9571 at commit

[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...

2017-04-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/9571 **[Test build #75704 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75704/testReport)** for PR 9571 at commit

[GitHub] spark issue #17491: [SPARK-20175][SQL] Exists should not be evaluated in Joi...

2017-04-11 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17491 @cloud-fan The optimization rule is removed now. This patch now is just making `Exists` subquery without correlated references work. Please take a look again. Thanks. --- If your project is set up

[GitHub] spark issue #17491: [SPARK-20175][SQL] Exists should not be evaluated in Joi...

2017-04-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17491 **[Test build #75703 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75703/testReport)** for PR 17491 at commit

[GitHub] spark pull request #17491: [SPARK-20175][SQL] Exists should not be evaluated...

2017-04-11 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17491#discussion_r110859934 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala --- @@ -498,3 +498,32 @@ object

[GitHub] spark pull request #17491: [SPARK-20175][SQL] Exists should not be evaluated...

2017-04-11 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17491#discussion_r110858379 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala --- @@ -498,3 +498,32 @@ object

[GitHub] spark pull request #17491: [SPARK-20175][SQL] Exists should not be evaluated...

2017-04-11 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17491#discussion_r110858303 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala --- @@ -498,3 +498,32 @@ object

[GitHub] spark issue #17455: [Spark-20044][Web UI] Support Spark UI behind front-end ...

2017-04-11 Thread okoethibm
Github user okoethibm commented on the issue: https://github.com/apache/spark/pull/17455 @ajbozarth Any other comments on this PR? Why is it not testing even though it has an "ok to test"? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request #17584: Document Master URL format in high availability s...

2017-04-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17584 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #17584: Document Master URL format in high availability set up

2017-04-11 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/17584 merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark pull request #17604: [SPARK-20289][SQL] Use StaticInvoke to box primit...

2017-04-11 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/17604#discussion_r110855845 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/JavaTypeInference.scala --- @@ -204,20 +204,19 @@ object JavaTypeInference {

[GitHub] spark pull request #17604: [SPARK-20289][SQL] Use StaticInvoke to box primit...

2017-04-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17604#discussion_r110855725 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/JavaTypeInference.scala --- @@ -204,20 +204,19 @@ object JavaTypeInference {

[GitHub] spark pull request #17587: [SPARK-20274][SQL] support compatible array eleme...

2017-04-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17587#discussion_r110855414 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/EncoderResolutionSuite.scala --- @@ -66,6 +68,27 @@ class

[GitHub] spark pull request #17604: [SPARK-20289][SQL] Use StaticInvoke to box primit...

2017-04-11 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/17604#discussion_r110853394 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/JavaTypeInference.scala --- @@ -204,20 +204,19 @@ object JavaTypeInference {

[GitHub] spark issue #17605: [SPARK-20290][MINOR][PYTHON][SQL] Add PySpark wrapper fo...

2017-04-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17605 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75700/ Test PASSed. ---

[GitHub] spark issue #17605: [SPARK-20290][MINOR][PYTHON][SQL] Add PySpark wrapper fo...

2017-04-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17605 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17605: [SPARK-20290][MINOR][PYTHON][SQL] Add PySpark wrapper fo...

2017-04-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17605 **[Test build #75700 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75700/testReport)** for PR 17605 at commit

[GitHub] spark issue #16347: [SPARK-18934][SQL] Writing to dynamic partitions does no...

2017-04-11 Thread junegunn
Github user junegunn commented on the issue: https://github.com/apache/spark/pull/16347 @cloud-fan It's not a problem in the context of DataFrame API. But when it comes to Spark SQL, it makes Spark SQL incompatible to equivalent HiveQL in a subtle way. At least we may need to revisit

[GitHub] spark pull request #17491: [SPARK-20175][SQL] Exists should not be evaluated...

2017-04-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17491#discussion_r110852640 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala --- @@ -498,3 +498,32 @@ object

[GitHub] spark issue #17606: [SPARK-20291][SQL] NaNvl(FloatType, NullType) should not...

2017-04-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17606 **[Test build #75702 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75702/testReport)** for PR 17606 at commit

[GitHub] spark pull request #17606: [SPARK-20291][SQL] NaNvl(FloatType, NullType) sho...

2017-04-11 Thread dbtsai
GitHub user dbtsai opened a pull request: https://github.com/apache/spark/pull/17606 [SPARK-20291][SQL] NaNvl(FloatType, NullType) should not be cast to NaNvl(DoubleType, DoubleType) ## What changes were proposed in this pull request? `NaNvl(float value, null)` will be

[GitHub] spark issue #17568: [SPARK-20254][SQL] Remove unnecessary data conversion fo...

2017-04-11 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/17568 @cloud-fan I would appreciate it if you have time to look at this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request #17587: [SPARK-20274][SQL] support compatible array eleme...

2017-04-11 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17587#discussion_r110848126 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/EncoderResolutionSuite.scala --- @@ -66,6 +68,27 @@ class

[GitHub] spark pull request #17546: [SPARK-20233] [SQL] Apply star-join filter heuris...

2017-04-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17546#discussion_r110848185 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CostBasedJoinReorder.scala --- @@ -54,8 +54,6 @@ case class

[GitHub] spark issue #17605: [SPARK-20290][MINOR][PYTHON][SQL] Add PySpark wrapper fo...

2017-04-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17605 **[Test build #75700 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75700/testReport)** for PR 17605 at commit

[GitHub] spark issue #17587: [SPARK-20274][SQL] support compatible array element type...

2017-04-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17587 **[Test build #75701 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75701/testReport)** for PR 17587 at commit

[GitHub] spark issue #17557: [SPARK-20208][R][DOCS] Document R fpGrowth support

2017-04-11 Thread zero323
Github user zero323 commented on the issue: https://github.com/apache/spark/pull/17557 @felixcheung For vignette I used a bit larger synthetic dataset which should show all the features implemented by `fpm`. For examples I used the same data as #17130. --- If your project is set

[GitHub] spark pull request #17587: [SPARK-20274][SQL] support compatible array eleme...

2017-04-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17587#discussion_r110847204 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/EncoderResolutionSuite.scala --- @@ -66,6 +68,27 @@ class

[GitHub] spark pull request #17605: [SPARK-20290][MINOR][PYTHON][SQL] Add PySpark wra...

2017-04-11 Thread zero323
GitHub user zero323 opened a pull request: https://github.com/apache/spark/pull/17605 [SPARK-20290][MINOR][PYTHON][SQL] Add PySpark wrapper for eqNullSafe ## What changes were proposed in this pull request? Adds Python bindings for `Column.eqNullSafe` ## How was

[GitHub] spark issue #16677: [SPARK-19355][SQL] Use map output statistices to improve...

2017-04-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16677 **[Test build #75699 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75699/testReport)** for PR 16677 at commit

[GitHub] spark issue #16677: [SPARK-19355][SQL] Use map output statistices to improve...

2017-04-11 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/16677 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #16347: [SPARK-18934][SQL] Writing to dynamic partitions does no...

2017-04-11 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16347 @junegunn I think it's not a problem, `df.write.xxx` is not guaranteed to retain the ordering of `df` when writing data output. Currently the `DataFrameWriter` doesn't provide an

[GitHub] spark issue #17604: [SPARK-20289][SQL] Use StaticInvoke to box primitive typ...

2017-04-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17604 **[Test build #75698 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75698/testReport)** for PR 17604 at commit

[GitHub] spark issue #17604: [SPARK-20289][SQL] Use StaticInvoke to box primitive typ...

2017-04-11 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17604 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark pull request #17604: [SPARK-20289][SQL] Use StaticInvoke to box primit...

2017-04-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17604#discussion_r110840736 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala --- @@ -204,37 +204,37 @@ object ScalaReflection extends

[GitHub] spark pull request #17604: [SPARK-20289][SQL] Use StaticInvoke to box primit...

2017-04-11 Thread rxin
GitHub user rxin opened a pull request: https://github.com/apache/spark/pull/17604 [SPARK-20289][SQL] Use StaticInvoke to box primitive types ## What changes were proposed in this pull request? Dataset typed API currently uses NewInstance to box primitive types (i.e. calling

[GitHub] spark pull request #17575: [SPARK-20265][MLlib] Improve Prefix'span pre-proc...

2017-04-11 Thread Syrux
Github user Syrux commented on a diff in the pull request: https://github.com/apache/spark/pull/17575#discussion_r110839571 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -232,6 +200,69 @@ class PrefixSpan private ( object PrefixSpan extends

[GitHub] spark pull request #17575: [SPARK-20265][MLlib] Improve Prefix'span pre-proc...

2017-04-11 Thread Syrux
Github user Syrux commented on a diff in the pull request: https://github.com/apache/spark/pull/17575#discussion_r110839623 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -232,6 +200,69 @@ class PrefixSpan private ( object PrefixSpan extends

[GitHub] spark pull request #17436: [SPARK-20101][SQL] Use OffHeapColumnVector when "...

2017-04-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17436#discussion_r110838855 --- Diff: core/src/main/java/org/apache/spark/memory/MemoryConsumer.java --- @@ -41,7 +41,7 @@ protected MemoryConsumer(TaskMemoryManager

[GitHub] spark issue #17575: [SPARK-20265][MLlib] Improve Prefix'span pre-processing ...

2017-04-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17575 **[Test build #3658 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3658/testReport)** for PR 17575 at commit

<    1   2   3   4   >