[GitHub] spark issue #17640: [SPARK-17608][SPARKR]:Long type has incorrect serializat...

2017-04-16 Thread wangmiao1981
Github user wangmiao1981 commented on the issue: https://github.com/apache/spark/pull/17640 Based on my understanding, it does not directly solvethe 12360. This one just solves the serialization of a specific type `bigint` in struct field. --- If your project is set up for it, you

[GitHub] spark issue #17640: [SPARK-17608][SPARKR]:Long type has incorrect serializat...

2017-04-16 Thread wangmiao1981
Github user wangmiao1981 commented on the issue: https://github.com/apache/spark/pull/17640 For `Inf` case, I used a very large number:

[GitHub] spark issue #17620: [SPARK-20305][Spark Core]Master may keep in the state of...

2017-04-16 Thread lvdongr
Github user lvdongr commented on the issue: https://github.com/apache/spark/pull/17620 Execute me, Can this issue be closed or threre are some other problem? @jerryshao --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark issue #17540: [SPARK-20213][SQL][UI] Fix DataFrameWriter operations in...

2017-04-16 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17540 yea let's remove that test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #15398: [SPARK-17647][SQL] Fix backslash escaping in 'LIKE' patt...

2017-04-16 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/15398 Re-checked the current change, I think it is in a good shape. Do we have unsolved issues or decisions on this? ping @jodersky Would you like to update this with master? Thanks. --- If

[GitHub] spark issue #17568: [SPARK-20254][SQL] Remove unnecessary data conversion fo...

2017-04-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17568 **[Test build #75850 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75850/testReport)** for PR 17568 at commit

[GitHub] spark pull request #17568: [SPARK-20254][SQL] Remove unnecessary data conver...

2017-04-16 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17568#discussion_r111704431 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala --- @@ -368,6 +369,8 @@ case class NullPropagation(conf:

[GitHub] spark issue #15435: [SPARK-17139][ML] Add model summary for MultinomialLogis...

2017-04-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15435 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15435: [SPARK-17139][ML] Add model summary for MultinomialLogis...

2017-04-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15435 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75847/ Test PASSed. ---

[GitHub] spark pull request #17568: [SPARK-20254][SQL] Remove unnecessary data conver...

2017-04-16 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/17568#discussion_r111704129 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/objects.scala --- @@ -96,3 +98,30 @@ object CombineTypedFilters extends

[GitHub] spark issue #17655: [SPARK-20156] [SQL] [FOLLOW-UP] Java String toLowerCase ...

2017-04-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17655 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17655: [SPARK-20156] [SQL] [FOLLOW-UP] Java String toLowerCase ...

2017-04-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17655 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75849/ Test PASSed. ---

[GitHub] spark pull request #17568: [SPARK-20254][SQL] Remove unnecessary data conver...

2017-04-16 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/17568#discussion_r111704118 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala --- @@ -368,6 +369,8 @@ case class NullPropagation(conf:

[GitHub] spark issue #15435: [SPARK-17139][ML] Add model summary for MultinomialLogis...

2017-04-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15435 **[Test build #75847 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75847/testReport)** for PR 15435 at commit

[GitHub] spark issue #17655: [SPARK-20156] [SQL] [FOLLOW-UP] Java String toLowerCase ...

2017-04-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17655 **[Test build #75849 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75849/testReport)** for PR 17655 at commit

[GitHub] spark pull request #15398: [SPARK-17647][SQL] Fix backslash escaping in 'LIK...

2017-04-16 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/15398#discussion_r111704017 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala --- @@ -68,7 +68,30 @@ trait StringRegexExpression

[GitHub] spark issue #15435: [SPARK-17139][ML] Add model summary for MultinomialLogis...

2017-04-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15435 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75846/ Test PASSed. ---

[GitHub] spark pull request #17540: [SPARK-20213][SQL][UI] Fix DataFrameWriter operat...

2017-04-16 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17540#discussion_r111703865 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala --- @@ -39,6 +39,32 @@ object SQLExecution {

[GitHub] spark issue #15435: [SPARK-17139][ML] Add model summary for MultinomialLogis...

2017-04-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15435 Build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #15435: [SPARK-17139][ML] Add model summary for MultinomialLogis...

2017-04-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15435 **[Test build #75846 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75846/testReport)** for PR 15435 at commit

[GitHub] spark pull request #17540: [SPARK-20213][SQL][UI] Fix DataFrameWriter operat...

2017-04-16 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17540#discussion_r111703744 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -180,9 +180,9 @@ class Dataset[T] private[sql]( // to happen right

[GitHub] spark issue #17655: [SPARK-20156] [SQL] [FOLLOW-UP] Java String toLowerCase ...

2017-04-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17655 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17655: [SPARK-20156] [SQL] [FOLLOW-UP] Java String toLowerCase ...

2017-04-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17655 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75848/ Test PASSed. ---

[GitHub] spark issue #17655: [SPARK-20156] [SQL] [FOLLOW-UP] Java String toLowerCase ...

2017-04-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17655 **[Test build #75848 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75848/testReport)** for PR 17655 at commit

[GitHub] spark pull request #17641: [SPARK-20329][SQL] Make timezone aware expression...

2017-04-16 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17641#discussion_r111703152 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveInlineTables.scala --- @@ -99,12 +99,9 @@ case class

[GitHub] spark pull request #17641: [SPARK-20329][SQL] Make timezone aware expression...

2017-04-16 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/17641#discussion_r111702719 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveInlineTables.scala --- @@ -99,12 +99,9 @@ case class

[GitHub] spark issue #17623: [SPARK-20292][SQL] Clean up string representation of Tre...

2017-04-16 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17623 > What are the external impacts of these changes? Which commands are impacted? This patch mainly cleans up the definition of two string representation methods: `simpleString`,

[GitHub] spark pull request #17641: [SPARK-20329][SQL] Make timezone aware expression...

2017-04-16 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17641#discussion_r111701221 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveInlineTables.scala --- @@ -99,12 +99,9 @@ case class

[GitHub] spark issue #17149: [SPARK-19257][SQL]location for table/partition/database ...

2017-04-16 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17149 @gatorsmile, Thanks for your pointer. There is a good discussion there. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #17149: [SPARK-19257][SQL]location for table/partition/database ...

2017-04-16 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17149 Our parser might need a change regarding escape handling. We are having a related discussion in another PR: https://github.com/apache/spark/pull/15398 --- If your project is set up for it, you

[GitHub] spark issue #17644: [SPARK-17729] [SQL] Enable creating hive bucketed tables

2017-04-16 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17644 I'll review it after branch 2.2 is cut --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #17568: [SPARK-20254][SQL] Remove unnecessary data conver...

2017-04-16 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17568#discussion_r111699305 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/objects.scala --- @@ -96,3 +98,30 @@ object CombineTypedFilters extends

[GitHub] spark pull request #17568: [SPARK-20254][SQL] Remove unnecessary data conver...

2017-04-16 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17568#discussion_r111699178 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala --- @@ -368,6 +369,8 @@ case class NullPropagation(conf:

[GitHub] spark issue #17375: [SPARK-19019][PYTHON][BRANCH-1.6] Fix hijacked `collecti...

2017-04-16 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17375 gentle ping ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #17622: [SPARK-20300][ML][PYSPARK] Python API for ALSModel.recom...

2017-04-16 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17622 LGTM except for a doc comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #17622: [SPARK-20300][ML][PYSPARK] Python API for ALSMode...

2017-04-16 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17622#discussion_r111698372 --- Diff: python/pyspark/ml/recommendation.py --- @@ -384,6 +392,28 @@ def itemFactors(self): """ return

[GitHub] spark pull request #17568: [SPARK-20254][SQL] Remove unnecessary data conver...

2017-04-16 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17568#discussion_r111697961 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/objects.scala --- @@ -96,3 +98,30 @@ object CombineTypedFilters extends

[GitHub] spark pull request #17568: [SPARK-20254][SQL] Remove unnecessary data conver...

2017-04-16 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17568#discussion_r111697946 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/objects.scala --- @@ -96,3 +98,30 @@ object CombineTypedFilters extends

[GitHub] spark issue #17655: [SPARK-20156] [SQL] [FOLLOW-UP] Java String toLowerCase ...

2017-04-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17655 **[Test build #75849 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75849/testReport)** for PR 17655 at commit

[GitHub] spark issue #17655: [SPARK-20156] [SQL] [FOLLOW-UP] Java String toLowerCase ...

2017-04-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17655 **[Test build #75848 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75848/testReport)** for PR 17655 at commit

[GitHub] spark pull request #17568: [SPARK-20254][SQL] Remove unnecessary data conver...

2017-04-16 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/17568#discussion_r111697079 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/objects.scala --- @@ -96,3 +98,30 @@ object CombineTypedFilters extends

[GitHub] spark issue #17655: [SPARK-20156] [SQL] [FOLLOW-UP] Java String toLowerCase ...

2017-04-16 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17655 cc @srowen @HyukjinKwon @cloud-fan @nihavend --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #17655: [SPARK-20156] [SQL] [FOLLOW-UP] Java String toLow...

2017-04-16 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/17655 [SPARK-20156] [SQL] [FOLLOW-UP] Java String toLowerCase "Turkish locale bug" in Database and Table DDLs ### What changes were proposed in this pull request? Database and Table names conform

[GitHub] spark issue #15435: [SPARK-17139][ML] Add model summary for MultinomialLogis...

2017-04-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15435 **[Test build #75847 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75847/testReport)** for PR 15435 at commit

[GitHub] spark pull request #17568: [SPARK-20254][SQL] Remove unnecessary data conver...

2017-04-16 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/17568#discussion_r111696732 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/objects.scala --- @@ -96,3 +98,30 @@ object CombineTypedFilters extends

[GitHub] spark pull request #17649: [SPARK-20023][SQL][follow up] Output table commen...

2017-04-16 Thread sujith71955
Github user sujith71955 commented on a diff in the pull request: https://github.com/apache/spark/pull/17649#discussion_r111696709 --- Diff: sql/core/src/test/resources/sql-tests/inputs/describe_tbleproperty_validation.sql --- @@ -0,0 +1,24 @@ +CREATE TABLE table_with_comment

[GitHub] spark issue #15435: [SPARK-17139][ML] Add model summary for MultinomialLogis...

2017-04-16 Thread WeichenXu123
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/15435 @sethah Thanks! I have merged your updates and fix mima file conflicts. @yanboliang has just come back from trip and will help review and merge it into 2.2 so don't worry about it! --- If

[GitHub] spark pull request #17649: [SPARK-20023][SQL][follow up] Output table commen...

2017-04-16 Thread sujith71955
Github user sujith71955 commented on a diff in the pull request: https://github.com/apache/spark/pull/17649#discussion_r111696418 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -232,7 +232,9 @@ case class AlterTableSetPropertiesCommand(

[GitHub] spark issue #15435: [SPARK-17139][ML] Add model summary for MultinomialLogis...

2017-04-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15435 **[Test build #75846 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75846/testReport)** for PR 15435 at commit

[GitHub] spark issue #17654: [SPARK-20351] [ML] Add trait hasTrainingSummary to repla...

2017-04-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17654 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17654: [SPARK-20351] [ML] Add trait hasTrainingSummary to repla...

2017-04-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17654 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75845/ Test PASSed. ---

[GitHub] spark issue #17654: [SPARK-20351] [ML] Add trait hasTrainingSummary to repla...

2017-04-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17654 **[Test build #75845 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75845/testReport)** for PR 17654 at commit

[GitHub] spark issue #17651: [SPARK-20343][BUILD] Force Avro 1.7.7 in sbt build to re...

2017-04-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17651 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75843/ Test PASSed. ---

[GitHub] spark issue #17651: [SPARK-20343][BUILD] Force Avro 1.7.7 in sbt build to re...

2017-04-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17651 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17651: [SPARK-20343][BUILD] Force Avro 1.7.7 in sbt build to re...

2017-04-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17651 **[Test build #75843 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75843/testReport)** for PR 17651 at commit

[GitHub] spark issue #17654: [SPARK-20351] [ML] Add trait hasTrainingSummary to repla...

2017-04-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17654 **[Test build #75845 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75845/testReport)** for PR 17654 at commit

[GitHub] spark pull request #17654: [SPARK-20351] [ML] Add trait hasTrainingSummary t...

2017-04-16 Thread hhbyyh
GitHub user hhbyyh opened a pull request: https://github.com/apache/spark/pull/17654 [SPARK-20351] [ML] Add trait hasTrainingSummary to replace the duplicate code ## What changes were proposed in this pull request? Add a trait HasTrainingSummary to avoid code duplicate

[GitHub] spark issue #17527: [SPARK-20156][CORE][SQL][STREAMING][MLLIB] Java String t...

2017-04-16 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17527 Yes. The codes have the bug. For example, when the locale is TR, users are unable to create a table with a table name containing `I`. This does not make sense to me. I believe we have more

[GitHub] spark issue #16722: [SPARK-19591][ML][MLlib] Add sample weights to decision ...

2017-04-16 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/16722 Btw, I've been working on this and just posted some thoughts about one design choice here: https://issues.apache.org/jira/browse/SPARK-9478 --- If your project is set up for it, you can reply to

[GitHub] spark issue #17653: [SPARK-19828][R][FOLLOWUP] Rename asJsonArray to as.json...

2017-04-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17653 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17653: [SPARK-19828][R][FOLLOWUP] Rename asJsonArray to as.json...

2017-04-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17653 **[Test build #75844 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75844/testReport)** for PR 17653 at commit

[GitHub] spark issue #17653: [SPARK-19828][R][FOLLOWUP] Rename asJsonArray to as.json...

2017-04-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17653 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75844/ Test PASSed. ---

[GitHub] spark issue #17652: [SPARK-20335] [SQL] [BACKPORT-2.1] Children expressions ...

2017-04-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17652 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75842/ Test PASSed. ---

[GitHub] spark issue #17652: [SPARK-20335] [SQL] [BACKPORT-2.1] Children expressions ...

2017-04-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17652 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17652: [SPARK-20335] [SQL] [BACKPORT-2.1] Children expressions ...

2017-04-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17652 **[Test build #75842 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75842/testReport)** for PR 17652 at commit

[GitHub] spark issue #15435: [SPARK-17139][ML] Add model summary for MultinomialLogis...

2017-04-16 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/15435 @WeichenXu123 I made a PR to your branch. Can you check it? I think you'll still need to update the Mima file. Also, this may not make 2.2, so then you'd have to update the since tags. --- If your

[GitHub] spark issue #17653: [SPARK-19828][R][FOLLOWUP] Rename asJsonArray to as.json...

2017-04-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17653 **[Test build #75844 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75844/testReport)** for PR 17653 at commit

[GitHub] spark issue #17653: [SPARK-19828][R][FOLLOWUP] Rename asJsonArray to as.json...

2017-04-16 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17653 cc @felixcheung, this simply renames it to `as.json.array`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request #17653: [SPARK-19828][R][FOLLOWUP] Rename asJsonArray to ...

2017-04-16 Thread HyukjinKwon
GitHub user HyukjinKwon opened a pull request: https://github.com/apache/spark/pull/17653 [SPARK-19828][R][FOLLOWUP] Rename asJsonArray to as.json.array in from_json function in R ## What changes were proposed in this pull request? This was suggested to be `as.json.array`

[GitHub] spark issue #17651: [SPARK-20343][BUILD] Force Avro 1.7.7 in sbt build to re...

2017-04-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17651 **[Test build #75843 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75843/testReport)** for PR 17651 at commit

[GitHub] spark issue #17651: [SPARK-20343][BUILD] Force Avro 1.7.7 in sbt build to re...

2017-04-16 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17651 cc @srowen, could you check if it makes sense to you? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request #17650: [SPARK-20350] Add optimization rules to apply Com...

2017-04-16 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/17650#discussion_r111692337 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala --- @@ -153,6 +153,11 @@ object BooleanSimplification

[GitHub] spark pull request #17650: [SPARK-20350] Add optimization rules to apply Com...

2017-04-16 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/17650#discussion_r111692327 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/BooleanSimplificationSuite.scala --- @@ -160,4 +166,12 @@ class

[GitHub] spark issue #17590: [SPARK-20278][R] Disable 'multiple_dots_linter' lint rul...

2017-04-16 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17590 Sure, thank you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #17527: [SPARK-20156][CORE][SQL][STREAMING][MLLIB] Java String t...

2017-04-16 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17527 Ah, sorry, it was only about fixing tests. I thought we have bugs in the main codes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request #17650: [SPARK-20350] Add optimization rules to apply Com...

2017-04-16 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/17650#discussion_r111692175 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala --- @@ -153,6 +153,11 @@ object BooleanSimplification

[GitHub] spark issue #17651: [SPARK-20343][BUILD] Force Avro 1.7.7 in sbt build to re...

2017-04-16 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17651 I left a uesless comment and removed it back (I misunderstood). Yes, I will add a small comment. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #17652: [SPARK-20335] [SQL] [BACKPORT-2.1] Children expressions ...

2017-04-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17652 **[Test build #75842 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75842/testReport)** for PR 17652 at commit

[GitHub] spark issue #17651: [SPARK-20343][BUILD] Force Avro 1.7.7 in sbt build to re...

2017-04-16 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17651 Yea, pom was the first try and it was kind if a failed. Please check out the discussion in https://github.com/apache/spark/pull/17642 --- If your project is set up for it, you can reply to

[GitHub] spark pull request #17652: [SPARK-20335] [SQL] [BACKPORT-2.1] Children expre...

2017-04-16 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/17652 [SPARK-20335] [SQL] [BACKPORT-2.1] Children expressions of Hive UDF impacts the determinism of Hive UDF ### What changes were proposed in this pull request? This PR is to backport

[GitHub] spark issue #17651: [SPARK-20343][BUILD] Force Avro 1.7.7 in sbt build to re...

2017-04-16 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/17651 perhaps have a reference in pom.xml to this so they both change together the next time? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request #17633: [SPARK-20331][SQL] Enhanced Hive partition prunin...

2017-04-16 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/17633#discussion_r111691537 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala --- @@ -589,18 +590,34 @@ private[client] class Shim_v0_13 extends

[GitHub] spark issue #17524: [SPARK-19235] [SQL] [TEST] [FOLLOW-UP] Enable Test Cases...

2017-04-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17524 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75841/ Test FAILed. ---

[GitHub] spark issue #17524: [SPARK-19235] [SQL] [TEST] [FOLLOW-UP] Enable Test Cases...

2017-04-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17524 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17524: [SPARK-19235] [SQL] [TEST] [FOLLOW-UP] Enable Test Cases...

2017-04-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17524 **[Test build #75841 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75841/testReport)** for PR 17524 at commit

[GitHub] spark issue #17527: [SPARK-20156][CORE][SQL][STREAMING][MLLIB] Java String t...

2017-04-16 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/17527 Yes you have a point. It is minor in that it is just a test that is now locale sensitive and supporting the locale in tests is much less important. However ideally whatever fails should be fixed as

[GitHub] spark issue #17527: [SPARK-20156][CORE][SQL][STREAMING][MLLIB] Java String t...

2017-04-16 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17527 Sorry, my previous comment is to @HyukjinKwon --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #17644: [SPARK-17729] [SQL] Enable creating hive bucketed tables

2017-04-16 Thread tejasapatil
Github user tejasapatil commented on the issue: https://github.com/apache/spark/pull/17644 cc @cloud-fan @hvanhovell @sameeragarwal for review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #17527: [SPARK-20156][CORE][SQL][STREAMING][MLLIB] Java String t...

2017-04-16 Thread nihavend
Github user nihavend commented on the issue: https://github.com/apache/spark/pull/17527 maybe --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #17650: [SPARK-20350] Add optimization rules to apply Complement...

2017-04-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17650 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75839/ Test PASSed. ---

[GitHub] spark issue #17650: [SPARK-20350] Add optimization rules to apply Complement...

2017-04-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17650 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17650: [SPARK-20350] Add optimization rules to apply Complement...

2017-04-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17650 **[Test build #75839 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75839/testReport)** for PR 17650 at commit

[GitHub] spark pull request #17557: [SPARK-20208][R][DOCS] Document R fpGrowth suppor...

2017-04-16 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17557#discussion_r111690507 --- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd --- @@ -906,6 +910,37 @@ predicted <- predict(model, df) head(predicted) ``` +

[GitHub] spark pull request #17557: [SPARK-20208][R][DOCS] Document R fpGrowth suppor...

2017-04-16 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17557#discussion_r111690515 --- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd --- @@ -906,6 +910,37 @@ predicted <- predict(model, df) head(predicted) ``` +

[GitHub] spark issue #17644: [SPARK-17729] [SQL] Enable creating hive bucketed tables

2017-04-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17644 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75838/ Test PASSed. ---

[GitHub] spark issue #17644: [SPARK-17729] [SQL] Enable creating hive bucketed tables

2017-04-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17644 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17644: [SPARK-17729] [SQL] Enable creating hive bucketed tables

2017-04-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17644 **[Test build #75838 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75838/testReport)** for PR 17644 at commit

[GitHub] spark issue #17527: [SPARK-20156][CORE][SQL][STREAMING][MLLIB] Java String t...

2017-04-16 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17527 : ) It sounds like you did not get my points. Anyway, I will fix it later. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #17649: [SPARK-20023][SQL][follow up] Output table comment for D...

2017-04-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17649 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17651: [SPARK-20343][BUILD] Force Avro 1.7.7 in sbt build to re...

2017-04-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17651 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

  1   2   >