Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17596
**[Test build #76017 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76017/testReport)**
for PR 17596 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17681
The implementation of function existence checking is a little bit messy. We
might need to clean up it before starting the impl of this PR.
---
If your project is set up for it, you can reply to
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17711
**[Test build #76016 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76016/testReport)**
for PR 17711 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17707#discussion_r112611803
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -214,8 +214,11 @@ class AstBuilder extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17707#discussion_r112611620
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -214,8 +214,11 @@ class AstBuilder extends
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17711#discussion_r112611521
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/SparkSqlParserSuite.scala
---
@@ -290,4 +290,14 @@ class SparkSqlParserSuite extends
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17700
**[Test build #76015 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76015/testReport)**
for PR 17700 at commit
Github user yssharma commented on the issue:
https://github.com/apache/spark/pull/17467
@budde @brkyvz - Implemented the review changes. Please review.
- Using SparkConf for all the user parameters
- removed kinesisWait to be val instead of var
- fixed documentation
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/17712
cc: @gatorsmile
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17712
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17712
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76013/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17712
**[Test build #76013 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76013/testReport)**
for PR 17712 at commit
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/16699
@yanboliang @sethah
Any suggestion on moving this PR forward? Appreciate your comments and
reviews.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17711
**[Test build #76014 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76014/testReport)**
for PR 17711 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17191
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76011/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17191
Build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17191
**[Test build #76011 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76011/testReport)**
for PR 17191 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17191
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76012/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17191
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17191
**[Test build #76012 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76012/testReport)**
for PR 17191 at commit
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/17540#discussion_r112606757
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLListener.scala ---
@@ -353,11 +353,19 @@ class SQLListener(conf: SparkConf) extends
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/17540#discussion_r112606701
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/util/DataFrameCallbackSuite.scala
---
@@ -183,21 +183,22 @@ class DataFrameCallbackSuite extends
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/17540#discussion_r112606599
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLListener.scala ---
@@ -353,11 +353,19 @@ class SQLListener(conf: SparkConf) extends
Github user vundela commented on the issue:
https://github.com/apache/spark/pull/17688
Hi @felixcheung Thanks for the review. I have added a small testcase.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r112605454
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -136,6 +136,7 @@ class Analyzer(
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17711
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17711
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76010/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17711
**[Test build #76010 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76010/testReport)**
for PR 17711 at commit
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/17638#discussion_r112603493
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala ---
@@ -50,22 +49,22 @@ import org.apache.spark.util.{JsonProtocol,
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r112603375
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -136,6 +136,7 @@ class Analyzer(
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17711#discussion_r112602983
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/SparkSqlParserSuite.scala
---
@@ -290,4 +290,14 @@ class SparkSqlParserSuite extends
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17711#discussion_r112602929
--- Diff: sql/core/src/test/resources/sql-tests/inputs/string-functions.sql
---
@@ -1,3 +1,6 @@
+-- A pipe operation for string concatenation
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17711#discussion_r112602578
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/SparkSqlParserSuite.scala
---
@@ -290,4 +290,14 @@ class SparkSqlParserSuite extends
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/17681
The proposal LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17711#discussion_r112602421
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/SparkSqlParserSuite.scala
---
@@ -290,4 +290,14 @@ class SparkSqlParserSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17540#discussion_r112601926
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLListener.scala ---
@@ -353,11 +353,19 @@ class SQLListener(conf: SparkConf)
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17712
**[Test build #76013 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76013/testReport)**
for PR 17712 at commit
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/17702
@marmbrus Can you take a look of this? Thanks :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user maropu opened a pull request:
https://github.com/apache/spark/pull/17712
[SPARK-20416][SQL] Print UDF names in EXPLAIN
## What changes were proposed in this pull request?
This pr added `withName` in `UserDefinedFunction` for printing UDF names in
EXPLAIN
##
Github user zuotingbing commented on a diff in the pull request:
https://github.com/apache/spark/pull/17638#discussion_r112601515
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala ---
@@ -50,22 +49,22 @@ import org.apache.spark.util.{JsonProtocol,
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17540#discussion_r112601511
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/util/DataFrameCallbackSuite.scala
---
@@ -183,21 +183,22 @@ class DataFrameCallbackSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17540#discussion_r112601099
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLListener.scala ---
@@ -353,11 +353,19 @@ class SQLListener(conf: SparkConf)
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17540#discussion_r112601049
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -281,42 +281,54 @@ class StreamExecution(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17711#discussion_r112599634
--- Diff: sql/core/src/test/resources/sql-tests/inputs/string-functions.sql
---
@@ -1,3 +1,6 @@
+-- A pipe operation for string concatenation
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/17670
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17670
Thanks! Merging to master/2.2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r112597680
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkAppHandle.java ---
@@ -95,7 +95,8 @@ public boolean isFinal() {
void kill();
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17191
**[Test build #76012 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76012/testReport)**
for PR 17191 at commit
Github user zuotingbing commented on a diff in the pull request:
https://github.com/apache/spark/pull/17638#discussion_r112597030
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -405,9 +405,7 @@ class SparkContext(config: SparkConf) extends Logging {
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/17638#discussion_r112596999
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala ---
@@ -50,22 +49,22 @@ import org.apache.spark.util.{JsonProtocol,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17191
**[Test build #76011 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76011/testReport)**
for PR 17191 at commit
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/13440#discussion_r112596837
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/impurity/ChiSquared.scala ---
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/17641
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user zuotingbing commented on a diff in the pull request:
https://github.com/apache/spark/pull/17638#discussion_r112596553
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala ---
@@ -50,22 +49,22 @@ import org.apache.spark.util.{JsonProtocol,
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/17641
LGTM, merging to master/2.2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/17638#discussion_r112595717
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -405,9 +405,7 @@ class SparkContext(config: SparkConf) extends Logging {
Github user zuotingbing commented on a diff in the pull request:
https://github.com/apache/spark/pull/17638#discussion_r112595663
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala ---
@@ -50,22 +49,22 @@ import org.apache.spark.util.{JsonProtocol,
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/17638#discussion_r112595579
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala ---
@@ -50,22 +49,22 @@ import org.apache.spark.util.{JsonProtocol,
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/17707
looks like we need to fix a test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/17703
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r112595036
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1005,6 +1005,31 @@ class Analyzer(
}
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/17703
thanks, merging to master/2.2!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r112594814
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1005,6 +1005,31 @@ class Analyzer(
}
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17711
**[Test build #76010 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76010/testReport)**
for PR 17711 at commit
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/17638#discussion_r112594234
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala ---
@@ -50,22 +49,22 @@ import org.apache.spark.util.{JsonProtocol,
Github user zuotingbing commented on a diff in the pull request:
https://github.com/apache/spark/pull/17638#discussion_r112594056
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala ---
@@ -50,22 +49,22 @@ import org.apache.spark.util.{JsonProtocol,
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/17582
Just update the description, please review again @vanzin , thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user zuotingbing commented on a diff in the pull request:
https://github.com/apache/spark/pull/17638#discussion_r112593597
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -405,9 +405,7 @@ class SparkContext(config: SparkConf) extends Logging {
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/17191
ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/17666
ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/17670
ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/17711
okay, I'll add soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17711#discussion_r112591328
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -1483,4 +1483,12 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/17700
Thanks @squito for clarification, sorry I misunderstood it.
Regarding this new `memoryMetrics`, will all the memory related metrics be
shown here, like what you mentioned in the JIRA?
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17711
**[Test build #76009 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76009/testReport)**
for PR 17711 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17711
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76009/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17711
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17711
**[Test build #76009 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76009/testReport)**
for PR 17711 at commit
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/17711
can you add a test case in sql query file tests?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/17711#discussion_r112590613
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -1483,4 +1483,12 @@ class SparkSqlAstBuilder(conf: SQLConf)
GitHub user maropu opened a pull request:
https://github.com/apache/spark/pull/17711
[SPARK-19951][SQL] Add string concatenate operator || to Spark SQL
## What changes were proposed in this pull request?
This pr added code to support `||` for string concatenation. This string
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17709
Yea, good to match the titles to other PRs and according to the guide
lines. It does not block this PR though.
---
If your project is set up for it, you can reply to this email and have your
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17710
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76007/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17710
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17710
**[Test build #76007 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76007/testReport)**
for PR 17710 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17665
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17665
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76008/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17665
**[Test build #76008 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76008/testReport)**
for PR 17665 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17693#discussion_r112587862
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
---
@@ -393,7 +393,7 @@ case class
Github user umehrot2 commented on the issue:
https://github.com/apache/spark/pull/17445
@kayousterhout @mridulm @rxin @lins05 @markhamstra @tgravescs @squito Can
you take a look at this ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17680
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76006/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17680
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17680
**[Test build #76006 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76006/testReport)**
for PR 17680 at commit
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/17693#discussion_r112584915
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
---
@@ -149,7 +149,7 @@ case class
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17693
I like the idea but I am not sure of `DROPMALFORMED` mode though. If we use
an expression with the mode enabled, whole record (not only the column but all
columns) will be dropped in some json
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17693#discussion_r112584338
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
---
@@ -149,7 +149,7 @@ case class
Github user kevinyu98 commented on the issue:
https://github.com/apache/spark/pull/12646
@hvanhovell: Would you have some cycles to review this PR? I would
appreciated some feedback on this.. Thanks.
---
If your project is set up for it, you can reply to this email and have your
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17693
@liancheng Good suggestion! Just like what we did for `from_json/to_json`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/17495
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/17495
LGTM, merging to master / 2.2.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
1 - 100 of 449 matches
Mail list logo
