[GitHub] spark issue #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqNullSafe...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17783 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqNullSafe...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17783 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76295/ Test PASSed. ---

[GitHub] spark issue #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqNullSafe...

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17783 **[Test build #76295 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76295/testReport)** for PR 17783 at commit

[GitHub] spark issue #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqNullSafe...

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17783 **[Test build #76295 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76295/testReport)** for PR 17783 at commit

[GitHub] spark issue #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqNullSafe...

2017-04-28 Thread zero323
Github user zero323 commented on the issue: https://github.com/apache/spark/pull/17783 Jenkins retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #17807: [SPARK-20532][SPARKR] Implement grouping and grouping_id

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17807 **[Test build #76294 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76294/testReport)** for PR 17807 at commit

[GitHub] spark issue #17807: [SPARK-20532][SPARKR] Implement grouping and grouping_id

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17807 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76294/ Test FAILed. ---

[GitHub] spark issue #17807: [SPARK-20532][SPARKR] Implement grouping and grouping_id

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17807 **[Test build #76294 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76294/testReport)** for PR 17807 at commit

[GitHub] spark issue #17807: [SPARK-20532][SPARKR] Implement grouping and grouping_id

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17807 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #17807: [SPARK-20532][SPARKR] Implement grouping and grou...

2017-04-28 Thread zero323
GitHub user zero323 opened a pull request: https://github.com/apache/spark/pull/17807 [SPARK-20532][SPARKR] Implement grouping and grouping_id ## What changes were proposed in this pull request? Adds R wrappers for: - `o.a.s.sql.functions.grouping` as

[GitHub] spark issue #17346: [SPARK-19965][SS] DataFrame batch reader may fail to inf...

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17346 **[Test build #76293 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76293/testReport)** for PR 17346 at commit

[GitHub] spark issue #17346: [SPARK-19965][SS] DataFrame batch reader may fail to inf...

2017-04-28 Thread lw-lin
Github user lw-lin commented on the issue: https://github.com/apache/spark/pull/17346 Jenkins retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #17793: [SPARK-20484][MLLIB] Add documentation to ALS cod...

2017-04-28 Thread danielyli
Github user danielyli commented on a diff in the pull request: https://github.com/apache/spark/pull/17793#discussion_r114044512 --- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala --- @@ -910,26 +944,127 @@ object ALS extends DefaultParamsReadable[ALS] with

[GitHub] spark issue #17723: [SPARK-20434][YARN][CORE] Move kerberos delegation token...

2017-04-28 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/17723 @mridulm if you're talking about `ServiceCredentialProvider.obtainCredentials`, which is a public interface that exposes UGI (`Credentials` in this case), then sure, it's probably worth to tweak it

[GitHub] spark issue #17556: [SPARK-16957][MLlib] Use weighted midpoints for split va...

2017-04-28 Thread facaiy
Github user facaiy commented on the issue: https://github.com/apache/spark/pull/17556 By the way, it's safe to use mean value as it is match the other libraries. If requested, I'd like to modify the PR. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark issue #17793: [SPARK-20484][MLLIB] Add documentation to ALS code

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17793 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17793: [SPARK-20484][MLLIB] Add documentation to ALS code

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17793 **[Test build #76292 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76292/testReport)** for PR 17793 at commit

[GitHub] spark issue #17793: [SPARK-20484][MLLIB] Add documentation to ALS code

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17793 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76292/ Test PASSed. ---

[GitHub] spark issue #17736: [SPARK-20399][SQL] Can't use same regex pattern between ...

2017-04-28 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17736 @cloud-fan although @hvanhovell haven't comment yet, I will go to fix the inconsistency first and see if we have defined tests against it. --- If your project is set up for it, you can reply to

[GitHub] spark issue #17556: [SPARK-16957][MLlib] Use weighted midpoints for split va...

2017-04-28 Thread facaiy
Github user facaiy commented on the issue: https://github.com/apache/spark/pull/17556 For a (train) sample of continuous series, say {x0, x1, x2, x3, ..., x100}. Now spark select quantile as split point. Suppose 10-quantiles is used, and x2 is 1st quantile, and x10 is 2nd

[GitHub] spark issue #17770: [SPARK-20392][SQL][WIP] Set barrier to prevent re-enteri...

2017-04-28 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17770 @hvanhovell @rxin I've updated this accordingly. Do you have more comments on this? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #15009: [SPARK-17443][SPARK-11035] Stop Spark Application if lau...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15009 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76288/ Test PASSed. ---

[GitHub] spark issue #15009: [SPARK-17443][SPARK-11035] Stop Spark Application if lau...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15009 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15009: [SPARK-17443][SPARK-11035] Stop Spark Application if lau...

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15009 **[Test build #76288 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76288/testReport)** for PR 15009 at commit

[GitHub] spark pull request #17556: [SPARK-16957][MLlib] Use weighted midpoints for s...

2017-04-28 Thread facaiy
Github user facaiy commented on a diff in the pull request: https://github.com/apache/spark/pull/17556#discussion_r114043568 --- Diff: mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala --- @@ -138,9 +169,10 @@ class RandomForestSuite extends SparkFunSuite

[GitHub] spark pull request #17556: [SPARK-16957][MLlib] Use weighted midpoints for s...

2017-04-28 Thread facaiy
Github user facaiy commented on a diff in the pull request: https://github.com/apache/spark/pull/17556#discussion_r114043558 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala --- @@ -1037,7 +1051,10 @@ private[spark] object RandomForest extends

[GitHub] spark pull request #17556: [SPARK-16957][MLlib] Use weighted midpoints for s...

2017-04-28 Thread facaiy
Github user facaiy commented on a diff in the pull request: https://github.com/apache/spark/pull/17556#discussion_r114043563 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala --- @@ -1009,10 +1009,24 @@ private[spark] object RandomForest extends

[GitHub] spark pull request #15435: [SPARK-17139][ML] Add model summary for Multinomi...

2017-04-28 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/15435#discussion_r114043519 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -1231,6 +1295,109 @@ class

[GitHub] spark pull request #17556: [SPARK-16957][MLlib] Use weighted midpoints for s...

2017-04-28 Thread facaiy
Github user facaiy commented on a diff in the pull request: https://github.com/apache/spark/pull/17556#discussion_r114043439 --- Diff: mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala --- @@ -112,9 +138,11 @@ class RandomForestSuite extends SparkFunSuite

[GitHub] spark issue #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqNullSafe...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17783 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqNullSafe...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17783 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76291/ Test PASSed. ---

[GitHub] spark issue #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqNullSafe...

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17783 **[Test build #76291 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76291/testReport)** for PR 17783 at commit

[GitHub] spark issue #17795: [SPARK-20517][UI] Fix broken history UI download link

2017-04-28 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/17795 I assume only event log download will be effected with #17582 . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #17795: [SPARK-20517][UI] Fix broken history UI download link

2017-04-28 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/17795 @ajbozarth , I checked the UI related to attemptId, seems fine without issue. Can you please point out in which code potentially has the regression? Thanks! --- If your project is set up for

[GitHub] spark issue #17793: [SPARK-20484][MLLIB] Add documentation to ALS code

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17793 **[Test build #76292 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76292/testReport)** for PR 17793 at commit

[GitHub] spark issue #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqNullSafe...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17783 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76290/ Test FAILed. ---

[GitHub] spark issue #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqNullSafe...

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17783 **[Test build #76290 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76290/testReport)** for PR 17783 at commit

[GitHub] spark issue #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqNullSafe...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17783 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqNullSafe...

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17783 **[Test build #76291 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76291/testReport)** for PR 17783 at commit

[GitHub] spark issue #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqNullSafe...

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17783 **[Test build #76290 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76290/testReport)** for PR 17783 at commit

[GitHub] spark issue #17395: [SPARK-20065][SS][WIP] Avoid to output empty parquet fil...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17395 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76286/ Test PASSed. ---

[GitHub] spark issue #17395: [SPARK-20065][SS][WIP] Avoid to output empty parquet fil...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17395 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17395: [SPARK-20065][SS][WIP] Avoid to output empty parquet fil...

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17395 **[Test build #76286 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76286/testReport)** for PR 17395 at commit

[GitHub] spark pull request #17723: [SPARK-20434][YARN][CORE] Move kerberos delegatio...

2017-04-28 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/17723#discussion_r114040288 --- Diff: core/pom.xml --- @@ -357,6 +357,34 @@ org.apache.commons commons-crypto + + + +

[GitHub] spark issue #17723: [SPARK-20434][YARN][CORE] Move kerberos delegation token...

2017-04-28 Thread mridulm
Github user mridulm commented on the issue: https://github.com/apache/spark/pull/17723 @vanzin While UGI does provide credential store and implementations for GSSAPI, it also does a bunch of other things - which are leveraged by hadoop ipc, hadoop common, etc. Leveraging ugi

[GitHub] spark issue #17795: [SPARK-20517][UI] Fix broken history UI download link

2017-04-28 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/17795 @ajbozarth OK, I will verify it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #17793: [SPARK-20484][MLLIB] Add documentation to ALS code

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17793 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76289/ Test FAILed. ---

[GitHub] spark issue #17793: [SPARK-20484][MLLIB] Add documentation to ALS code

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17793 **[Test build #76289 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76289/testReport)** for PR 17793 at commit

[GitHub] spark issue #17793: [SPARK-20484][MLLIB] Add documentation to ALS code

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17793 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17795: [SPARK-20517][UI] Fix broken history UI download link

2017-04-28 Thread ajbozarth
Github user ajbozarth commented on the issue: https://github.com/apache/spark/pull/17795 Oh ok, I see why this is needed now that I see how #17582 changes how the api works, though I'm a bit worried this might not be the only thing that might've broken. You may want to look around

[GitHub] spark issue #17795: [SPARK-20517][UI] Fix broken history UI download link

2017-04-28 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/17795 @vanzin , can you please review this PR, thanks! The download link is broken after this change #17582 . Now it will check SparkUI with given appid and attemptId. Previous way of setting attemptId

[GitHub] spark issue #17723: [SPARK-20434][YARN][CORE] Move kerberos delegation token...

2017-04-28 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/17723 > For example, use of UGI for spark security in core. UGI, as far as I understand, is being used mostly as a credential store and wrapper around the JAAS / GSSAPI code. Replicating that code

[GitHub] spark pull request #17723: [SPARK-20434][YARN][CORE] Move kerberos delegatio...

2017-04-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/17723#discussion_r114039586 --- Diff: core/pom.xml --- @@ -357,6 +357,34 @@ org.apache.commons commons-crypto + + + +

[GitHub] spark issue #17795: [SPARK-20517][UI] Fix broken history UI download link

2017-04-28 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/17795 This is due to my changes in #17582 , with this change, download API will verify with correct ACL, so if attemptId is not found, then `withSparkUI` will be failed to get correct SparkUI to do

[GitHub] spark issue #17130: [SPARK-19791] [ML] Add doc and example for fpgrowth

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17130 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17130: [SPARK-19791] [ML] Add doc and example for fpgrowth

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17130 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76287/ Test PASSed. ---

[GitHub] spark issue #17130: [SPARK-19791] [ML] Add doc and example for fpgrowth

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17130 **[Test build #76287 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76287/testReport)** for PR 17130 at commit

[GitHub] spark pull request #17723: [SPARK-20434][YARN][CORE] Move kerberos delegatio...

2017-04-28 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/17723#discussion_r114038568 --- Diff: core/src/main/scala/org/apache/spark/deploy/security/ConfigurableCredentialManager.scala --- @@ -0,0 +1,133 @@ +/* + * Licensed to the

[GitHub] spark pull request #17723: [SPARK-20434][YARN][CORE] Move kerberos delegatio...

2017-04-28 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/17723#discussion_r114038350 --- Diff: core/src/main/scala/org/apache/spark/deploy/security/ConfigurableCredentialManager.scala --- @@ -0,0 +1,133 @@ +/* + * Licensed to the

[GitHub] spark pull request #17723: [SPARK-20434][YARN][CORE] Move kerberos delegatio...

2017-04-28 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/17723#discussion_r114038878 --- Diff: core/src/main/scala/org/apache/spark/deploy/security/DefaultHadoopAccessManager.scala --- @@ -0,0 +1,38 @@ +/* + * Licensed to the

[GitHub] spark pull request #17723: [SPARK-20434][YARN][CORE] Move kerberos delegatio...

2017-04-28 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/17723#discussion_r114038193 --- Diff: core/pom.xml --- @@ -357,6 +357,34 @@ org.apache.commons commons-crypto + + + +

[GitHub] spark issue #17793: [SPARK-20484][MLLIB] Add documentation to ALS code

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17793 **[Test build #76289 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76289/testReport)** for PR 17793 at commit

[GitHub] spark pull request #17793: [SPARK-20484][MLLIB] Add documentation to ALS cod...

2017-04-28 Thread danielyli
Github user danielyli commented on a diff in the pull request: https://github.com/apache/spark/pull/17793#discussion_r114039105 --- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala --- @@ -1026,7 +1161,24 @@ object ALS extends DefaultParamsReadable[ALS] with

[GitHub] spark issue #17795: [SPARK-20517][UI] Fix broken history UI download link

2017-04-28 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/17795 @ajbozarth the key point is that several spark applications doesn't have attempt id. It's not related to one attempt or two, for example: ``` { "id" :

[GitHub] spark pull request #17793: [SPARK-20484][MLLIB] Add documentation to ALS cod...

2017-04-28 Thread danielyli
Github user danielyli commented on a diff in the pull request: https://github.com/apache/spark/pull/17793#discussion_r114038722 --- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala --- @@ -910,26 +944,127 @@ object ALS extends DefaultParamsReadable[ALS] with

[GitHub] spark pull request #17793: [SPARK-20484][MLLIB] Add documentation to ALS cod...

2017-04-28 Thread danielyli
Github user danielyli commented on a diff in the pull request: https://github.com/apache/spark/pull/17793#discussion_r114038705 --- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala --- @@ -910,26 +944,127 @@ object ALS extends DefaultParamsReadable[ALS] with

[GitHub] spark pull request #17793: [SPARK-20484][MLLIB] Add documentation to ALS cod...

2017-04-28 Thread danielyli
Github user danielyli commented on a diff in the pull request: https://github.com/apache/spark/pull/17793#discussion_r114038426 --- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala --- @@ -910,26 +944,127 @@ object ALS extends DefaultParamsReadable[ALS] with

[GitHub] spark pull request #17793: [SPARK-20484][MLLIB] Add documentation to ALS cod...

2017-04-28 Thread danielyli
Github user danielyli commented on a diff in the pull request: https://github.com/apache/spark/pull/17793#discussion_r114038185 --- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala --- @@ -791,32 +813,43 @@ object ALS extends DefaultParamsReadable[ALS] with

[GitHub] spark pull request #17723: [SPARK-20434][YARN][CORE] Move kerberos delegatio...

2017-04-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/17723#discussion_r114035264 --- Diff: core/src/main/scala/org/apache/spark/deploy/security/ConfigurableCredentialManager.scala --- @@ -0,0 +1,133 @@ +/* + * Licensed to the

[GitHub] spark pull request #17723: [SPARK-20434][YARN][CORE] Move kerberos delegatio...

2017-04-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/17723#discussion_r114036949 --- Diff: core/src/test/scala/org/apache/spark/deploy/security/ConfigurableCredentialManagerSuite.scala --- @@ -130,9 +129,9 @@ class

[GitHub] spark pull request #17723: [SPARK-20434][YARN][CORE] Move kerberos delegatio...

2017-04-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/17723#discussion_r114037569 --- Diff: resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/security/YARNConfigurableCredentialManagerSuite.scala --- @@ -0,0 +1,74 @@

[GitHub] spark pull request #17723: [SPARK-20434][YARN][CORE] Move kerberos delegatio...

2017-04-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/17723#discussion_r114037710 --- Diff: resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/security/YARNConfigurableCredentialManagerSuite.scala --- @@ -0,0 +1,74 @@

[GitHub] spark pull request #17723: [SPARK-20434][YARN][CORE] Move kerberos delegatio...

2017-04-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/17723#discussion_r114037045 --- Diff: docs/configuration.md --- @@ -685,23 +685,23 @@ Apart from these, the following properties are also available, and may be useful

[GitHub] spark pull request #17723: [SPARK-20434][YARN][CORE] Move kerberos delegatio...

2017-04-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/17723#discussion_r114035613 --- Diff: core/src/main/scala/org/apache/spark/deploy/security/ConfigurableCredentialManager.scala --- @@ -0,0 +1,133 @@ +/* + * Licensed to the

[GitHub] spark pull request #17723: [SPARK-20434][YARN][CORE] Move kerberos delegatio...

2017-04-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/17723#discussion_r114037318 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/security/YARNConfigurableCredentialManager.scala --- @@ -0,0 +1,77 @@ +/*

[GitHub] spark pull request #17723: [SPARK-20434][YARN][CORE] Move kerberos delegatio...

2017-04-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/17723#discussion_r114035656 --- Diff: core/src/main/scala/org/apache/spark/deploy/security/DefaultHadoopAccessManager.scala --- @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #17723: [SPARK-20434][YARN][CORE] Move kerberos delegatio...

2017-04-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/17723#discussion_r114036751 --- Diff: core/src/main/scala/org/apache/spark/deploy/security/ServiceCredentialProvider.scala --- @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #17723: [SPARK-20434][YARN][CORE] Move kerberos delegatio...

2017-04-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/17723#discussion_r114037214 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/security/YARNConfigurableCredentialManager.scala --- @@ -0,0 +1,77 @@ +/*

[GitHub] spark pull request #17723: [SPARK-20434][YARN][CORE] Move kerberos delegatio...

2017-04-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/17723#discussion_r114036690 --- Diff: core/src/main/scala/org/apache/spark/deploy/security/ServiceCredentialProvider.scala --- @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #17723: [SPARK-20434][YARN][CORE] Move kerberos delegatio...

2017-04-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/17723#discussion_r114037394 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/security/YARNHadoopAccessManager.scala --- @@ -21,66 +21,47 @@ import

[GitHub] spark pull request #17723: [SPARK-20434][YARN][CORE] Move kerberos delegatio...

2017-04-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/17723#discussion_r114035526 --- Diff: core/src/main/scala/org/apache/spark/deploy/security/ConfigurableCredentialManager.scala --- @@ -0,0 +1,133 @@ +/* + * Licensed to the

[GitHub] spark pull request #17723: [SPARK-20434][YARN][CORE] Move kerberos delegatio...

2017-04-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/17723#discussion_r114037549 --- Diff: resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/security/YARNConfigurableCredentialManagerSuite.scala --- @@ -0,0 +1,74 @@

[GitHub] spark pull request #17723: [SPARK-20434][YARN][CORE] Move kerberos delegatio...

2017-04-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/17723#discussion_r114036708 --- Diff: core/src/main/scala/org/apache/spark/deploy/security/ServiceCredentialProvider.scala --- @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache

[GitHub] spark issue #17451: [SPARK-19866][ML][PySpark] Add local version of Word2Vec...

2017-04-28 Thread keypointt
Github user keypointt commented on the issue: https://github.com/apache/spark/pull/17451 thank you Holden and Joseph, I'm on it now :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #17806: [SPARK-20487][SQL] Display `serde` for `HiveTableScan` n...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17806 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76284/ Test PASSed. ---

[GitHub] spark issue #17806: [SPARK-20487][SQL] Display `serde` for `HiveTableScan` n...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17806 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17806: [SPARK-20487][SQL] Display `serde` for `HiveTableScan` n...

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17806 **[Test build #76284 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76284/testReport)** for PR 17806 at commit

[GitHub] spark issue #17130: [SPARK-19791] [ML] Add doc and example for fpgrowth

2017-04-28 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/17130 LGTM, thanks for adding this! @felixcheung OK with merging? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #17451: [SPARK-19866][ML][PySpark] Add local version of Word2Vec...

2017-04-28 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/17451 Either that, or we could add a private helper method to the Scala API which Python calls to get a nicer type. (E.g., the Scala helper could return a tuple of 2 arrays, rather than an array of

[GitHub] spark issue #17806: [SPARK-20487][SQL] Display `serde` for `HiveTableScan` n...

2017-04-28 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/17806 @gatorsmile i will let you merge ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #17456: Branch 2.1

2017-04-28 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/17456 Please close this issue --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #17180: [SPARK-19839][Core]release longArray in BytesToBytesMap

2017-04-28 Thread tejasapatil
Github user tejasapatil commented on the issue: https://github.com/apache/spark/pull/17180 ping @JoshRosen @davies @sameeragarwal --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #17180: [SPARK-19839][Core]release longArray in BytesToBy...

2017-04-28 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/17180#discussion_r114036088 --- Diff: core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java --- @@ -358,10 +358,20 @@ public long spill(long numBytes) throws

[GitHub] spark issue #15009: [SPARK-17443][SPARK-11035] Stop Spark Application if lau...

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15009 **[Test build #76288 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76288/testReport)** for PR 15009 at commit

[GitHub] spark issue #17806: [SPARK-20487][SQL] Display `serde` for `HiveTableScan` n...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17806 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76283/ Test PASSed. ---

[GitHub] spark issue #17806: [SPARK-20487][SQL] Display `serde` for `HiveTableScan` n...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17806 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15009: [SPARK-17443][SPARK-11035] Stop Spark Application if lau...

2017-04-28 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/15009 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #17806: [SPARK-20487][SQL] Display `serde` for `HiveTableScan` n...

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17806 **[Test build #76283 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76283/testReport)** for PR 17806 at commit

[GitHub] spark issue #17130: [SPARK-19791] [ML] Add doc and example for fpgrowth

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17130 **[Test build #76287 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76287/testReport)** for PR 17130 at commit

[GitHub] spark issue #17130: [SPARK-19791] [ML] Add doc and example for fpgrowth

2017-04-28 Thread hhbyyh
Github user hhbyyh commented on the issue: https://github.com/apache/spark/pull/17130 @felixcheung, reverted the code change of `transform` as requested. Please check the update. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on

  1   2   3   4   >