[GitHub] spark issue #17807: [SPARK-20532][SPARKR] Implement grouping and grouping_id

2017-04-29 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/17807 right, there's a bunch of *Col in ml. I think people would associate `col` to a reference to a/another column in the dataframe I do see your point about `is_grouping`, and also that

[GitHub] spark pull request #17809: [SPARK-20535][SPARKR] R wrappers for explode_oute...

2017-04-29 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17809#discussion_r114067242 --- Diff: R/pkg/R/functions.R --- @@ -3803,3 +3803,58 @@ setMethod("repeat_string", jc <- callJStatic("org.apache.spark.sql.functions",

[GitHub] spark pull request #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqN...

2017-04-29 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17783#discussion_r114067173 --- Diff: R/pkg/R/column.R --- @@ -302,3 +301,56 @@ setMethod("otherwise", jc <- callJMethod(x@jc, "otherwise", value)

[GitHub] spark issue #17736: [SPARK-20399][SQL][WIP] Can't use same regex pattern bet...

2017-04-29 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17736 As I am trying to fix the inconsistency, one issue I found is `'\\Z'`, the ASCII 26 - CTRL + Z (EOF on windows). If we make the string literal parsing as consistent with 1.6, we can't support it.

[GitHub] spark issue #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqNullSafe...

2017-04-29 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/17783 I'm surprised `@name %<=>%` does too --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #17810: [SPARK-20534][SQL] Make outer generate exec retur...

2017-04-29 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/17810#discussion_r114066762 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/GeneratorFunctionSuite.scala --- @@ -91,7 +91,7 @@ class GeneratorFunctionSuite extends QueryTest

[GitHub] spark issue #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqNullSafe...

2017-04-29 Thread zero323
Github user zero323 commented on the issue: https://github.com/apache/spark/pull/17783 Huh, seems to work after all. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #12646: [SPARK-14878][SQL] Trim characters string function suppo...

2017-04-29 Thread kevinyu98
Github user kevinyu98 commented on the issue: https://github.com/apache/spark/pull/12646 There are two failing test cases: the original TRIM function syntax should stay the same in UTF8StringSuite.java. The new test case needs to be adjusted in StringFunctionsSuite.scala. I have ran

[GitHub] spark issue #12646: [SPARK-14878][SQL] Trim characters string function suppo...

2017-04-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/12646 **[Test build #76315 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76315/testReport)** for PR 12646 at commit

[GitHub] spark pull request #17793: [SPARK-20484][MLLIB] Add documentation to ALS cod...

2017-04-29 Thread danielyli
Github user danielyli commented on a diff in the pull request: https://github.com/apache/spark/pull/17793#discussion_r114065812 --- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala --- @@ -910,26 +944,127 @@ object ALS extends DefaultParamsReadable[ALS] with

[GitHub] spark issue #17644: [SPARK-17729] [SQL] Enable creating hive bucketed tables

2017-04-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17644 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76312/ Test PASSed. ---

[GitHub] spark issue #17644: [SPARK-17729] [SQL] Enable creating hive bucketed tables

2017-04-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17644 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17644: [SPARK-17729] [SQL] Enable creating hive bucketed tables

2017-04-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17644 **[Test build #76312 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76312/testReport)** for PR 17644 at commit

[GitHub] spark issue #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqNullSafe...

2017-04-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17783 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqNullSafe...

2017-04-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17783 **[Test build #76314 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76314/testReport)** for PR 17783 at commit

[GitHub] spark issue #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqNullSafe...

2017-04-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17783 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76314/ Test PASSed. ---

[GitHub] spark issue #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqNullSafe...

2017-04-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17783 **[Test build #76314 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76314/testReport)** for PR 17783 at commit

[GitHub] spark issue #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqNullSafe...

2017-04-29 Thread zero323
Github user zero323 commented on the issue: https://github.com/apache/spark/pull/17783 > didn't it warn about @rdname column being lower cased? We use lower case `column` as `@rdname` for both `column` and `Column-class` so it is OK. We just have both in the same output file

[GitHub] spark pull request #17807: [SPARK-20532][SPARKR] Implement grouping and grou...

2017-04-29 Thread zero323
Github user zero323 commented on a diff in the pull request: https://github.com/apache/spark/pull/17807#discussion_r114064713 --- Diff: R/pkg/R/functions.R --- @@ -3803,3 +3803,89 @@ setMethod("repeat_string", jc <- callJStatic("org.apache.spark.sql.functions",

[GitHub] spark pull request #17810: [SPARK-20534][SQL] Make outer generate exec retur...

2017-04-29 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17810#discussion_r114064702 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/GeneratorFunctionSuite.scala --- @@ -91,7 +91,7 @@ class GeneratorFunctionSuite extends QueryTest

[GitHub] spark issue #17605: [SPARK-20290][MINOR][PYTHON][SQL] Add PySpark wrapper fo...

2017-04-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17605 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76313/ Test PASSed. ---

[GitHub] spark issue #17605: [SPARK-20290][MINOR][PYTHON][SQL] Add PySpark wrapper fo...

2017-04-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17605 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17605: [SPARK-20290][MINOR][PYTHON][SQL] Add PySpark wrapper fo...

2017-04-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17605 **[Test build #76313 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76313/testReport)** for PR 17605 at commit

[GitHub] spark pull request #17807: [SPARK-20532][SPARKR] Implement grouping and grou...

2017-04-29 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17807#discussion_r114064627 --- Diff: R/pkg/R/functions.R --- @@ -3803,3 +3803,89 @@ setMethod("repeat_string", jc <- callJStatic("org.apache.spark.sql.functions",

[GitHub] spark pull request #17807: [SPARK-20532][SPARKR] Implement grouping and grou...

2017-04-29 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17807#discussion_r114064615 --- Diff: R/pkg/R/functions.R --- @@ -3803,3 +3803,89 @@ setMethod("repeat_string", jc <- callJStatic("org.apache.spark.sql.functions",

[GitHub] spark issue #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqNullSafe...

2017-04-29 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/17783 didn't it warn about `@rdname column` being lower cased? Not sure how later tests are passing. what if we change both `@rdname` and `@name`? ``` #' @rdname not #' @name not

[GitHub] spark issue #17605: [SPARK-20290][MINOR][PYTHON][SQL] Add PySpark wrapper fo...

2017-04-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17605 **[Test build #76313 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76313/testReport)** for PR 17605 at commit

[GitHub] spark issue #17810: [SPARK-20534][SQL] Make outer generate exec return empty...

2017-04-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17810 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17810: [SPARK-20534][SQL] Make outer generate exec return empty...

2017-04-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17810 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76311/ Test PASSed. ---

[GitHub] spark issue #17810: [SPARK-20534][SQL] Make outer generate exec return empty...

2017-04-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17810 **[Test build #76311 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76311/testReport)** for PR 17810 at commit

[GitHub] spark issue #17807: [SPARK-20532][SPARKR] Implement grouping and grouping_id

2017-04-29 Thread zero323
Github user zero323 commented on the issue: https://github.com/apache/spark/pull/17807 > Didn't we added something_col recently? I don't think we did. There was `itemsCol` in `fpGrowth`, but it is not relevant here. ` git grep "_col" | grep "\.R"` shows only a bunch of

[GitHub] spark issue #17810: [SPARK-20534][SQL] Make outer generate exec return empty...

2017-04-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17810 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17810: [SPARK-20534][SQL] Make outer generate exec return empty...

2017-04-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17810 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76310/ Test PASSed. ---

[GitHub] spark issue #17810: [SPARK-20534][SQL] Make outer generate exec return empty...

2017-04-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17810 **[Test build #76310 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76310/testReport)** for PR 17810 at commit

[GitHub] spark issue #17810: [SPARK-20534][SQL] Make outer generate exec return empty...

2017-04-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17810 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17810: [SPARK-20534][SQL] Make outer generate exec return empty...

2017-04-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17810 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76309/ Test PASSed. ---

[GitHub] spark issue #17810: [SPARK-20534][SQL] Make outer generate exec return empty...

2017-04-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17810 **[Test build #76309 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76309/testReport)** for PR 17810 at commit

[GitHub] spark issue #17644: [SPARK-17729] [SQL] Enable creating hive bucketed tables

2017-04-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17644 **[Test build #76312 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76312/testReport)** for PR 17644 at commit

[GitHub] spark issue #17644: [SPARK-17729] [SQL] Enable creating hive bucketed tables

2017-04-29 Thread tejasapatil
Github user tejasapatil commented on the issue: https://github.com/apache/spark/pull/17644 Jenkins test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #17798: [SPARK-20521][DOC][CORE]The default of 'spark.worker.cle...

2017-04-29 Thread guoxiaolongzte
Github user guoxiaolongzte commented on the issue: https://github.com/apache/spark/pull/17798 @felixcheung I have changed, thank you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #17798: [SPARK-20521][DOC][CORE]The default of 'spark.worker.cle...

2017-04-29 Thread guoxiaolongzte
Github user guoxiaolongzte commented on the issue: https://github.com/apache/spark/pull/17798 @HyukjinKwon i has filled up the PR title,thank you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request #17798: [SPARK-20521][DOC][CORE]The default of 'spark.wor...

2017-04-29 Thread guoxiaolongzte
Github user guoxiaolongzte commented on a diff in the pull request: https://github.com/apache/spark/pull/17798#discussion_r114063875 --- Diff: docs/spark-standalone.md --- @@ -242,7 +242,7 @@ SPARK_WORKER_OPTS supports the following system properties:

[GitHub] spark issue #17640: [SPARK-17608][SPARKR]:Long type has incorrect serializat...

2017-04-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17640 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17640: [SPARK-17608][SPARKR]:Long type has incorrect serializat...

2017-04-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17640 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76307/ Test FAILed. ---

[GitHub] spark issue #17640: [SPARK-17608][SPARKR]:Long type has incorrect serializat...

2017-04-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17640 **[Test build #76307 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76307/testReport)** for PR 17640 at commit

[GitHub] spark issue #17640: [SPARK-17608][SPARKR]:Long type has incorrect serializat...

2017-04-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17640 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17640: [SPARK-17608][SPARKR]:Long type has incorrect serializat...

2017-04-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17640 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76306/ Test FAILed. ---

[GitHub] spark issue #17640: [SPARK-17608][SPARKR]:Long type has incorrect serializat...

2017-04-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17640 **[Test build #76306 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76306/testReport)** for PR 17640 at commit

[GitHub] spark issue #17810: [SPARK-20534][SQL] Make outer generate exec return empty...

2017-04-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17810 **[Test build #76311 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76311/testReport)** for PR 17810 at commit

[GitHub] spark issue #17810: [SPARK-20534][SQL] Make outer generate exec return empty...

2017-04-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17810 **[Test build #76310 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76310/testReport)** for PR 17810 at commit

[GitHub] spark issue #17810: [SPARK-20534][SQL] Make outer generate exec return empty...

2017-04-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17810 **[Test build #76309 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76309/testReport)** for PR 17810 at commit

[GitHub] spark pull request #17810: [SPARK-20534][SQL] Make outer generate exec retur...

2017-04-29 Thread hvanhovell
GitHub user hvanhovell opened a pull request: https://github.com/apache/spark/pull/17810 [SPARK-20534][SQL] Make outer generate exec return empty rows ## What changes were proposed in this pull request? Generate exec does not produce `null` values if the generator for the input

[GitHub] spark issue #17605: [SPARK-20290][MINOR][PYTHON][SQL] Add PySpark wrapper fo...

2017-04-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17605 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17605: [SPARK-20290][MINOR][PYTHON][SQL] Add PySpark wrapper fo...

2017-04-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17605 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76308/ Test PASSed. ---

[GitHub] spark issue #17605: [SPARK-20290][MINOR][PYTHON][SQL] Add PySpark wrapper fo...

2017-04-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17605 **[Test build #76308 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76308/testReport)** for PR 17605 at commit

[GitHub] spark pull request #17793: [SPARK-20484][MLLIB] Add documentation to ALS cod...

2017-04-29 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/17793#discussion_r114061940 --- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala --- @@ -910,26 +944,127 @@ object ALS extends DefaultParamsReadable[ALS] with

[GitHub] spark issue #17807: [SPARK-20532][SPARKR] Implement grouping and grouping_id

2017-04-29 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/17807 Didn't we added something_col recently? I worry if the meaning diverge from the earlier case. Also if grouping_id(a$col) == grouping(a$col) maybe we just need one, grouping_id is good

[GitHub] spark pull request #17737: [SPARK-20442][PYTHON][DOCS] Fill up documentation...

2017-04-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17737 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #17605: [SPARK-20290][MINOR][PYTHON][SQL] Add PySpark wrapper fo...

2017-04-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17605 **[Test build #76308 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76308/testReport)** for PR 17605 at commit

[GitHub] spark pull request #17605: [SPARK-20290][MINOR][PYTHON][SQL] Add PySpark wra...

2017-04-29 Thread zero323
Github user zero323 commented on a diff in the pull request: https://github.com/apache/spark/pull/17605#discussion_r114061694 --- Diff: python/pyspark/sql/column.py --- @@ -171,6 +171,40 @@ def __init__(self, jc): __ge__ = _bin_op("geq") __gt__ = _bin_op("gt")

[GitHub] spark issue #17737: [SPARK-20442][PYTHON][DOCS] Fill up documentations for f...

2017-04-29 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/17737 And thanks to everyone for reviewing, I'll merge this to master :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request #17737: [SPARK-20442][PYTHON][DOCS] Fill up documentation...

2017-04-29 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/17737#discussion_r114061394 --- Diff: python/pyspark/sql/column.py --- @@ -269,17 +305,17 @@ def __iter__(self): [Row(age=2, name=u'Alice')] """

[GitHub] spark issue #17737: [SPARK-20442][PYTHON][DOCS] Fill up documentations for f...

2017-04-29 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/17737 Thank you for improving the documentation @HyukjinKwon looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #17809: [SPARK-20535][SPARKR] R wrappers for explode_outer and p...

2017-04-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17809 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76305/ Test PASSed. ---

[GitHub] spark issue #17809: [SPARK-20535][SPARKR] R wrappers for explode_outer and p...

2017-04-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17809 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17809: [SPARK-20535][SPARKR] R wrappers for explode_outer and p...

2017-04-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17809 **[Test build #76305 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76305/testReport)** for PR 17809 at commit

[GitHub] spark issue #17640: [SPARK-17608][SPARKR]:Long type has incorrect serializat...

2017-04-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17640 **[Test build #76307 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76307/testReport)** for PR 17640 at commit

[GitHub] spark issue #17640: [SPARK-17608][SPARKR]:Long type has incorrect serializat...

2017-04-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17640 **[Test build #76306 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76306/testReport)** for PR 17640 at commit

[GitHub] spark issue #17785: [SPARK-20493][R] De-duplicate parse logics for DDL-like ...

2017-04-29 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17785 Thank you for checking this closely with me and merging it @felixcheung. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #17808: [SPARK-20533][SparkR]:SparkR Wrappers Model should be pr...

2017-04-29 Thread wangmiao1981
Github user wangmiao1981 commented on the issue: https://github.com/apache/spark/pull/17808 I think we don't have to back-port. This is a small improvement/optimization of the original code. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark issue #17809: [SPARK-20535][SPARKR] R wrappers for explode_outer and p...

2017-04-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17809 **[Test build #76305 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76305/testReport)** for PR 17809 at commit

[GitHub] spark pull request #17809: [SPARK-20535][SPARKR] R wrappers for explode_oute...

2017-04-29 Thread zero323
GitHub user zero323 opened a pull request: https://github.com/apache/spark/pull/17809 [SPARK-20535][SPARKR] R wrappers for explode_outer and posexplode_outer ## What changes were proposed in this pull request? Ad R wrappers for - `o.a.s.sql.functions.explode_outer`

[GitHub] spark pull request #17807: [SPARK-20532][SPARKR] Implement grouping and grou...

2017-04-29 Thread zero323
Github user zero323 commented on a diff in the pull request: https://github.com/apache/spark/pull/17807#discussion_r114060455 --- Diff: R/pkg/R/functions.R --- @@ -3803,3 +3803,89 @@ setMethod("repeat_string", jc <- callJStatic("org.apache.spark.sql.functions",

[GitHub] spark issue #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqNullSafe...

2017-04-29 Thread zero323
Github user zero323 commented on the issue: https://github.com/apache/spark/pull/17783 In short, depending on how you set `@rdname` and `@name` we get warnings ``` `prepare_Rd: not.Rd: \name should not contain !` ``` or ``` Undocumented S4 methods:

[GitHub] spark issue #17807: [SPARK-20532][SPARKR] Implement grouping and grouping_id

2017-04-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17807 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76304/ Test PASSed. ---

[GitHub] spark issue #17807: [SPARK-20532][SPARKR] Implement grouping and grouping_id

2017-04-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17807 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17807: [SPARK-20532][SPARKR] Implement grouping and grouping_id

2017-04-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17807 **[Test build #76304 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76304/testReport)** for PR 17807 at commit

[GitHub] spark pull request #17807: [SPARK-20532][SPARKR] Implement grouping and grou...

2017-04-29 Thread zero323
Github user zero323 commented on a diff in the pull request: https://github.com/apache/spark/pull/17807#discussion_r114060158 --- Diff: R/pkg/R/functions.R --- @@ -3803,3 +3803,89 @@ setMethod("repeat_string", jc <- callJStatic("org.apache.spark.sql.functions",

[GitHub] spark issue #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqNullSafe...

2017-04-29 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/17783 Sounds good - I didn't look very closely - what's the issue with ! doc --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request #17807: [SPARK-20532][SPARKR] Implement grouping and grou...

2017-04-29 Thread zero323
Github user zero323 commented on a diff in the pull request: https://github.com/apache/spark/pull/17807#discussion_r114059745 --- Diff: R/pkg/R/functions.R --- @@ -3803,3 +3803,89 @@ setMethod("repeat_string", jc <- callJStatic("org.apache.spark.sql.functions",

[GitHub] spark issue #17807: [SPARK-20532][SPARKR] Implement grouping and grouping_id

2017-04-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17807 **[Test build #76304 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76304/testReport)** for PR 17807 at commit

[GitHub] spark pull request #17807: [SPARK-20532][SPARKR] Implement grouping and grou...

2017-04-29 Thread zero323
Github user zero323 commented on a diff in the pull request: https://github.com/apache/spark/pull/17807#discussion_r114059534 --- Diff: R/pkg/R/functions.R --- @@ -3803,3 +3803,89 @@ setMethod("repeat_string", jc <- callJStatic("org.apache.spark.sql.functions",

[GitHub] spark issue #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqNullSafe...

2017-04-29 Thread zero323
Github user zero323 commented on the issue: https://github.com/apache/spark/pull/17783 > we could try but the number of methods and examples we have is much? higher than a lot of other packages Yeah... Maybe it is possible to hack docs generation process instead. Leave

[GitHub] spark pull request #17807: [SPARK-20532][SPARKR] Implement grouping and grou...

2017-04-29 Thread zero323
Github user zero323 commented on a diff in the pull request: https://github.com/apache/spark/pull/17807#discussion_r114059050 --- Diff: R/pkg/R/functions.R --- @@ -3803,3 +3803,89 @@ setMethod("repeat_string", jc <- callJStatic("org.apache.spark.sql.functions",

[GitHub] spark pull request #17807: [SPARK-20532][SPARKR] Implement grouping and grou...

2017-04-29 Thread zero323
Github user zero323 commented on a diff in the pull request: https://github.com/apache/spark/pull/17807#discussion_r114059014 --- Diff: R/pkg/R/functions.R --- @@ -3803,3 +3803,89 @@ setMethod("repeat_string", jc <- callJStatic("org.apache.spark.sql.functions",

[GitHub] spark pull request #17807: [SPARK-20532][SPARKR] Implement grouping and grou...

2017-04-29 Thread zero323
Github user zero323 commented on a diff in the pull request: https://github.com/apache/spark/pull/17807#discussion_r114058802 --- Diff: R/pkg/R/functions.R --- @@ -3803,3 +3803,89 @@ setMethod("repeat_string", jc <- callJStatic("org.apache.spark.sql.functions",

[GitHub] spark pull request #17807: [SPARK-20532][SPARKR] Implement grouping and grou...

2017-04-29 Thread zero323
Github user zero323 commented on a diff in the pull request: https://github.com/apache/spark/pull/17807#discussion_r114058765 --- Diff: R/pkg/R/functions.R --- @@ -3803,3 +3803,89 @@ setMethod("repeat_string", jc <- callJStatic("org.apache.spark.sql.functions",

[GitHub] spark issue #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqNullSafe...

2017-04-29 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/17783 > I wonder if we could actually remove \dontrun, push sparkR.session into \dontshow and still keep inside the CRAN time limits... we could try but the number of methods and examples we

[GitHub] spark pull request #17807: [SPARK-20532][SPARKR] Implement grouping and grou...

2017-04-29 Thread zero323
Github user zero323 commented on a diff in the pull request: https://github.com/apache/spark/pull/17807#discussion_r114058688 --- Diff: R/pkg/R/functions.R --- @@ -3803,3 +3803,89 @@ setMethod("repeat_string", jc <- callJStatic("org.apache.spark.sql.functions",

[GitHub] spark pull request #17798: [SPARK-20521][DOC][CORE]

2017-04-29 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17798#discussion_r114058622 --- Diff: docs/spark-standalone.md --- @@ -242,7 +242,7 @@ SPARK_WORKER_OPTS supports the following system properties:

[GitHub] spark pull request #17785: [SPARK-20493][R] De-duplicate parse logics for DD...

2017-04-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17785 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #17785: [SPARK-20493][R] De-duplicate parse logics for DDL-like ...

2017-04-29 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/17785 merged to master, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #17808: [SPARK-20533][SparkR]:SparkR Wrappers Model shoul...

2017-04-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17808 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #17808: [SPARK-20533][SparkR]:SparkR Wrappers Model should be pr...

2017-04-29 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/17808 merged to master - let me know if you think this should go to 2.2 as well --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #17808: [SPARK-20533][SparkR]:SparkR Wrappers Model should be pr...

2017-04-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17808 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17808: [SPARK-20533][SparkR]:SparkR Wrappers Model should be pr...

2017-04-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17808 **[Test build #76303 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76303/testReport)** for PR 17808 at commit

[GitHub] spark issue #17808: [SPARK-20533][SparkR]:SparkR Wrappers Model should be pr...

2017-04-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17808 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76303/ Test PASSed. ---

[GitHub] spark pull request #17130: [SPARK-19791] [ML] Add doc and example for fpgrow...

2017-04-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17130 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #17130: [SPARK-19791] [ML] Add doc and example for fpgrowth

2017-04-29 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/17130 merged to master/2.2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqN...

2017-04-29 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17783#discussion_r114058191 --- Diff: R/pkg/R/column.R --- @@ -67,8 +67,7 @@ operators <- list( "+" = "plus", "-" = "minus", "*" = "multiply", "/" = "divide", "%%" = "mod",

  1   2   >