[GitHub] spark issue #17825: [SPARK-20550][SPARKR] R wrapper for Dataset.alias

2017-05-04 Thread zero323
Github user zero323 commented on the issue: https://github.com/apache/spark/pull/17825 Oh right `stats::alias` is S3. Scratch that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #17851: [SPARK-20585][SPARKR] R generic hint support

2017-05-04 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17851#discussion_r114708146 --- Diff: R/pkg/R/DataFrame.R --- @@ -3715,3 +3715,34 @@ setMethod("rollup", sgd <- callJMethod(x@sdf, "rollup", jcol)

[GitHub] spark issue #17851: [SPARK-20585][SPARKR] R generic hint support

2017-05-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17851 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17851: [SPARK-20585][SPARKR] R generic hint support

2017-05-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17851 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76442/ Test PASSed. ---

[GitHub] spark issue #17851: [SPARK-20585][SPARKR] R generic hint support

2017-05-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17851 **[Test build #76442 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76442/testReport)** for PR 17851 at commit

[GitHub] spark issue #17845: [SPARK-20587][ML] Improve performance of ML ALS recommen...

2017-05-04 Thread MLnick
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/17845 Thanks @sethah will update shortly --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request #17845: [SPARK-20587][ML] Improve performance of ML ALS r...

2017-05-04 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/17845#discussion_r114706875 --- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala --- @@ -389,6 +436,17 @@ class ALSModel private[ml] ( )

[GitHub] spark pull request #17845: [SPARK-20587][ML] Improve performance of ML ALS r...

2017-05-04 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/17845#discussion_r114706892 --- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala --- @@ -389,6 +436,17 @@ class ALSModel private[ml] ( )

[GitHub] spark pull request #17845: [SPARK-20587][ML] Improve performance of ML ALS r...

2017-05-04 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/17845#discussion_r114706857 --- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala --- @@ -372,11 +385,45 @@ class ALSModel private[ml] ( num: Int):

[GitHub] spark pull request #17845: [SPARK-20587][ML] Improve performance of ML ALS r...

2017-05-04 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/17845#discussion_r114706758 --- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala --- @@ -372,11 +385,45 @@ class ALSModel private[ml] ( num: Int):

[GitHub] spark pull request #17742: [Spark-11968][ML][MLLIB]Optimize MLLIB ALS recomm...

2017-05-04 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/17742#discussion_r114706645 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/recommendation/MatrixFactorizationModel.scala --- @@ -274,46 +275,62 @@ object

[GitHub] spark issue #17222: [SPARK-19439][PYSPARK][SQL] PySpark's registerJavaFuncti...

2017-05-04 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/spark/pull/17222 @holdenk @gatorsmile Any more comments ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #17845: [SPARK-20587][ML] Improve performance of ML ALS r...

2017-05-04 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/17845#discussion_r114706687 --- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala --- @@ -356,6 +356,19 @@ class ALSModel private[ml] ( /** *

[GitHub] spark issue #17736: [SPARK-20399][SQL] Can't use same regex pattern between ...

2017-05-04 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17736 @hvanhovell What you think about adding a config to fallback string literal parsing consistent with old SQL parser behavior (don't unescape input string). --- If your project is set up for it, you

[GitHub] spark issue #17678: [SPARK-20381][SQL] Add SQL metrics of numOutputRows for ...

2017-05-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17678 **[Test build #76443 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76443/testReport)** for PR 17678 at commit

[GitHub] spark issue #17851: [SPARK-20585][SPARKR] R generic hint support

2017-05-04 Thread zero323
Github user zero323 commented on the issue: https://github.com/apache/spark/pull/17851 @felixcheung Do you think this makes `o.a.s.sql.functions.broadcast` obsolete? I a have WIP on this but it is a tricky one. There is an internal, non-generic `broadcast, with different signature

[GitHub] spark issue #17851: [SPARK-20585][SPARKR] R generic hint support

2017-05-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17851 **[Test build #76442 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76442/testReport)** for PR 17851 at commit

[GitHub] spark pull request #17851: [SPARK-20585][SPARKR] R generic hint support

2017-05-04 Thread zero323
Github user zero323 commented on a diff in the pull request: https://github.com/apache/spark/pull/17851#discussion_r114704425 --- Diff: R/pkg/R/DataFrame.R --- @@ -3715,3 +3715,34 @@ setMethod("rollup", sgd <- callJMethod(x@sdf, "rollup", jcol)

<    1   2   3   4   5