[GitHub] spark issue #17395: [SPARK-20065][SS][WIP] Avoid to output empty parquet fil...

2017-05-07 Thread uncleGen
Github user uncleGen commented on the issue: https://github.com/apache/spark/pull/17395 @HyukjinKwon Sorry for the long absence. I will keep online for next period of time. Please give me some time. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark issue #17896: [SPARK-20373][SQL][SS] Batch queries with 'Dataset/DataF...

2017-05-07 Thread uncleGen
Github user uncleGen commented on the issue: https://github.com/apache/spark/pull/17896 cc @zsxwing and @tdas --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #17896: [SPARK-20373][SQL][SS] Batch queries with 'Dataset/DataF...

2017-05-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17896 **[Test build #76561 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76561/testReport)** for PR 17896 at commit

[GitHub] spark pull request #17896: [SPARK-20373][SQL][SS] Batch queries with 'Datase...

2017-05-07 Thread uncleGen
GitHub user uncleGen opened a pull request: https://github.com/apache/spark/pull/17896 [SPARK-20373][SQL][SS] Batch queries with 'Dataset/DataFrame.withWatermark()` does not execute ## What changes were proposed in this pull request? Any Dataset/DataFrame batch query with

[GitHub] spark issue #17887: [SPARK-20399][SQL][WIP] Add a config to fallback string ...

2017-05-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17887 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17887: [SPARK-20399][SQL][WIP] Add a config to fallback string ...

2017-05-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17887 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76559/ Test PASSed. ---

[GitHub] spark issue #17887: [SPARK-20399][SQL][WIP] Add a config to fallback string ...

2017-05-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17887 **[Test build #76559 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76559/testReport)** for PR 17887 at commit

[GitHub] spark issue #17887: [SPARK-20399][SQL][WIP] Add a config to fallback string ...

2017-05-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17887 **[Test build #76560 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76560/testReport)** for PR 17887 at commit

[GitHub] spark issue #2633: [https://issues.apache.org/jira/browse/SPARK-4392] Event ...

2017-05-07 Thread Mobe91
Github user Mobe91 commented on the issue: https://github.com/apache/spark/pull/2633 When is this going the be merged? Would be really useful. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #17874: [SPARK-20612][SQL] Throw exception when there is unresol...

2017-05-07 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17874 Maybe another point of view is, we can split `df.select("y").where("x=1")` to two different DataFrames: val onlyY = df.select("y") // The schema of onlyY is just "y" attribute

[GitHub] spark issue #17869: [SPARK-20609][CORE]Run the SortShuffleSuite unit tests h...

2017-05-07 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17869 Test results are fine. I think my question is why this happens and how the current change solves the issue above. Another question is, does second run of the test cases fail due to this? ---

[GitHub] spark issue #17874: [SPARK-20612][SQL] Throw exception when there is unresol...

2017-05-07 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17874 `select a from t where b > 0` works. However, it can be seen logically as: Project [a] Filter [b > 0] Relation t [a, b] It seems to me Spark also parses the

[GitHub] spark issue #17796: [SPARK-20519][SQL][CORE]Modify to prevent some possible ...

2017-05-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17796 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76557/ Test PASSed. ---

[GitHub] spark issue #17796: [SPARK-20519][SQL][CORE]Modify to prevent some possible ...

2017-05-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17796 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17796: [SPARK-20519][SQL][CORE]Modify to prevent some possible ...

2017-05-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17796 **[Test build #76557 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76557/testReport)** for PR 17796 at commit

[GitHub] spark issue #17894: [SPARK-17134][ML] Use level 2 BLAS operations in Logisti...

2017-05-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17894 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76558/ Test PASSed. ---

[GitHub] spark issue #17894: [SPARK-17134][ML] Use level 2 BLAS operations in Logisti...

2017-05-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17894 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17894: [SPARK-17134][ML] Use level 2 BLAS operations in Logisti...

2017-05-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17894 **[Test build #76558 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76558/testReport)** for PR 17894 at commit

[GitHub] spark pull request #16781: [SPARK-12297][SQL] Hive compatibility for Parquet...

2017-05-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16781 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #17874: [SPARK-20612][SQL] Throw exception when there is unresol...

2017-05-07 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17874 in postgres, `select a from t where b > 0` can work, I think it's reasonable if `df.select("y").where("x=1")` works in spark. ``` Seq(1).toDF("c1").createOrReplaceTempView("onerow")

[GitHub] spark issue #16781: [SPARK-12297][SQL] Hive compatibility for Parquet Timest...

2017-05-07 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/16781 Thanks! Merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #17222: [SPARK-19439][PYSPARK][SQL] PySpark's registerJav...

2017-05-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17222#discussion_r115166927 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/UDFRegistration.scala --- @@ -475,20 +475,42 @@ class UDFRegistration private[sql]

[GitHub] spark pull request #17077: [SPARK-16931][PYTHON][SQL] Add Python wrapper for...

2017-05-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17077 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #17077: [SPARK-16931][PYTHON][SQL] Add Python wrapper for bucket...

2017-05-07 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17077 thanks, merging to master! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #17887: [SPARK-20399][SQL][WIP] Add a config to fallback string ...

2017-05-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17887 **[Test build #76559 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76559/testReport)** for PR 17887 at commit

[GitHub] spark issue #17895: Branch 2.0

2017-05-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17895 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #17895: Branch 2.0

2017-05-07 Thread fjh100456
GitHub user fjh100456 opened a pull request: https://github.com/apache/spark/pull/17895 Branch 2.0 ## What changes were proposed in this pull request? (Please fill in changes proposed in this fix) ## How was this patch tested? (Please explain how this

[GitHub] spark issue #16781: [SPARK-12297][SQL] Hive compatibility for Parquet Timest...

2017-05-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16781 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76556/ Test PASSed. ---

[GitHub] spark issue #16781: [SPARK-12297][SQL] Hive compatibility for Parquet Timest...

2017-05-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16781 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16781: [SPARK-12297][SQL] Hive compatibility for Parquet Timest...

2017-05-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16781 **[Test build #76556 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76556/testReport)** for PR 16781 at commit

[GitHub] spark issue #17894: [SPARK-17134][ML] Use level 2 BLAS operations in Logisti...

2017-05-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17894 **[Test build #76558 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76558/testReport)** for PR 17894 at commit

[GitHub] spark pull request #17894: [SPARK-17134][ML] Use level 2 BLAS operations in ...

2017-05-07 Thread VinceShieh
GitHub user VinceShieh opened a pull request: https://github.com/apache/spark/pull/17894 [SPARK-17134][ML] Use level 2 BLAS operations in LogisticAggregator ## What changes were proposed in this pull request? Multinomial logistic regression uses LogisticAggregator class for

[GitHub] spark issue #17869: [SPARK-20609][CORE]Run the SortShuffleSuite unit tests h...

2017-05-07 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/17869 @HyukjinKwon this changes before and after deleting files log information: **Before changes** > Run the unit test: SortShuffleManager properly cleans up files for shuffles that

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-07 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17770 I've removed the path of `resolveOperators`. After ran the same benchmark, I didn't find obvious performance regression. @hvanhovell @marmbrus @cloud-fan @rxin @srinathshankar --- If your project

[GitHub] spark issue #17893: FileFormatWriter wrap the FetchFailedException which bre...

2017-05-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17893 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #17893: FileFormatWriter wrap the FetchFailedException which bre...

2017-05-07 Thread mridulm
Github user mridulm commented on the issue: https://github.com/apache/spark/pull/17893 This is not required anymore - post @squito's change. Though it cant hurt I guess. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #17893: FileFormatWriter wrap the FetchFailedException which bre...

2017-05-07 Thread lshmouse
Github user lshmouse commented on the issue: https://github.com/apache/spark/pull/17893 Pending. I am formatting the pull name~ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #17893: FileFormatWriter wrap the FetchFailedException wh...

2017-05-07 Thread lshmouse
GitHub user lshmouse opened a pull request: https://github.com/apache/spark/pull/17893 FileFormatWriter wrap the FetchFailedException which breaks job's failover ## What changes were proposed in this pull request? Handle the fetch failed exception separately in FileFormatWriter.

[GitHub] spark issue #17702: [SPARK-20408][SQL] Get the glob path in parallel to redu...

2017-05-07 Thread xuanyuanking
Github user xuanyuanking commented on the issue: https://github.com/apache/spark/pull/17702 @gatorsmile @cloud-fan, do we need other performance test? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request #17887: [SPARK-20399][SQL][WIP] Add a config to fallback ...

2017-05-07 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17887#discussion_r115162164 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -196,6 +196,14 @@ object SQLConf { .booleanConf

[GitHub] spark pull request #17887: [SPARK-20399][SQL][WIP] Add a config to fallback ...

2017-05-07 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17887#discussion_r115162152 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -196,6 +196,14 @@ object SQLConf { .booleanConf

[GitHub] spark pull request #17887: [SPARK-20399][SQL][WIP] Add a config to fallback ...

2017-05-07 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17887#discussion_r115162139 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/ParserUtils.scala --- @@ -68,6 +68,11 @@ object ParserUtils { /** Convert

[GitHub] spark issue #17077: [SPARK-16931][PYTHON][SQL] Add Python wrapper for bucket...

2017-05-07 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17077 LGTM too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark issue #17713: [SPARK-20417][SQL] Move subquery error handling to check...

2017-05-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17713 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17713: [SPARK-20417][SQL] Move subquery error handling to check...

2017-05-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17713 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76553/ Test PASSed. ---

[GitHub] spark issue #17713: [SPARK-20417][SQL] Move subquery error handling to check...

2017-05-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17713 **[Test build #76553 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76553/testReport)** for PR 17713 at commit

[GitHub] spark issue #17796: [SPARK-20519][SQL][CORE]Modify to prevent some possible ...

2017-05-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17796 **[Test build #76557 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76557/testReport)** for PR 17796 at commit

[GitHub] spark issue #16781: [SPARK-12297][SQL] Hive compatibility for Parquet Timest...

2017-05-07 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/16781 LGTM, pending Jenkins. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark pull request #17892: [SPARK-20626][SPARKR] address date test warning w...

2017-05-07 Thread felixcheung
GitHub user felixcheung reopened a pull request: https://github.com/apache/spark/pull/17892 [SPARK-20626][SPARKR] address date test warning with timezone on windows ## What changes were proposed in this pull request? set timezone on windows ## How was this patch

[GitHub] spark pull request #17892: [SPARK-20626][SPARKR] address date test warning w...

2017-05-07 Thread felixcheung
Github user felixcheung closed the pull request at: https://github.com/apache/spark/pull/17892 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark issue #17892: [SPARK-20626][SPARKR] address date test warning with tim...

2017-05-07 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/17892 similar flaky test around ml, with this in the log ``` Exception in thread "SparkListenerBus" java.lang.IllegalAccessError: Attempted to access garbage collected accumulator 50693

[GitHub] spark issue #16781: [SPARK-12297][SQL] Hive compatibility for Parquet Timest...

2017-05-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16781 **[Test build #76556 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76556/testReport)** for PR 16781 at commit

[GitHub] spark issue #16781: [SPARK-12297][SQL] Hive compatibility for Parquet Timest...

2017-05-07 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/16781 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #17884: [SparkR][Doc] fix typo in vignettes

2017-05-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17884 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76555/ Test PASSed. ---

[GitHub] spark issue #17884: [SparkR][Doc] fix typo in vignettes

2017-05-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17884 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17884: [SparkR][Doc] fix typo in vignettes

2017-05-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17884 **[Test build #76555 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76555/testReport)** for PR 17884 at commit

[GitHub] spark issue #17892: [SPARK-20626][SPARKR] address date test warning with tim...

2017-05-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17892 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76554/ Test PASSed. ---

[GitHub] spark issue #17892: [SPARK-20626][SPARKR] address date test warning with tim...

2017-05-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17892 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17892: [SPARK-20626][SPARKR] address date test warning with tim...

2017-05-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17892 **[Test build #76554 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76554/testReport)** for PR 17892 at commit

[GitHub] spark issue #17649: [SPARK-20380][SQL] Unable to set/unset table comment pro...

2017-05-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17649 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17649: [SPARK-20380][SQL] Unable to set/unset table comment pro...

2017-05-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17649 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76551/ Test PASSed. ---

[GitHub] spark issue #17649: [SPARK-20380][SQL] Unable to set/unset table comment pro...

2017-05-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17649 **[Test build #76551 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76551/testReport)** for PR 17649 at commit

[GitHub] spark pull request #17884: [SparkR][Doc] fix typo in vignettes

2017-05-07 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17884#discussion_r115157452 --- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd --- @@ -1079,19 +1079,19 @@ There are three main object classes in SparkR you may be working with.

[GitHub] spark pull request #17825: [SPARK-20550][SPARKR] R wrapper for Dataset.alias

2017-05-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17825 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #17825: [SPARK-20550][SPARKR] R wrapper for Dataset.alias

2017-05-07 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/17825 merged to master. thank you for working on this and hopefully we could really improve a lot of the things we have discussed. 👍 --- If your project is set up for it, you can reply to

[GitHub] spark pull request #17884: [SparkR][Doc] fix typo in vignettes

2017-05-07 Thread actuaryzhang
Github user actuaryzhang commented on a diff in the pull request: https://github.com/apache/spark/pull/17884#discussion_r115157036 --- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd --- @@ -405,7 +405,7 @@ result <- gapply( head(arrange(result, "max_mpg", decreasing = TRUE))

[GitHub] spark pull request #17884: [SparkR][Doc] fix typo in vignettes

2017-05-07 Thread actuaryzhang
Github user actuaryzhang commented on a diff in the pull request: https://github.com/apache/spark/pull/17884#discussion_r115157013 --- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd --- @@ -1079,19 +1079,19 @@ There are three main object classes in SparkR you may be working with.

[GitHub] spark issue #17884: [SparkR][Doc] fix typo in vignettes

2017-05-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17884 **[Test build #76555 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76555/testReport)** for PR 17884 at commit

[GitHub] spark issue #17892: [SPARK-20626][SPARKR] address date test warning with tim...

2017-05-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17892 **[Test build #76554 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76554/testReport)** for PR 17892 at commit

[GitHub] spark pull request #17892: [SPARK-20626][SPARKR] address date test warning w...

2017-05-07 Thread felixcheung
GitHub user felixcheung opened a pull request: https://github.com/apache/spark/pull/17892 [SPARK-20626][SPARKR] address date test warning with timezone on windows ## What changes were proposed in this pull request? set timezone on windows ## How was this patch

[GitHub] spark issue #17887: [SPARK-20399][SQL][WIP] Add a config to fallback string ...

2017-05-07 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17887 Generally, it looks reasonable to me. Also cc @jodersky who hit this issue before. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2017-05-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14963 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2017-05-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14963 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76550/ Test PASSed. ---

[GitHub] spark pull request #17887: [SPARK-20399][SQL][WIP] Add a config to fallback ...

2017-05-07 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17887#discussion_r115156337 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -196,6 +196,14 @@ object SQLConf { .booleanConf

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2017-05-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14963 **[Test build #76550 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76550/testReport)** for PR 14963 at commit

[GitHub] spark issue #17713: [SPARK-20417][SQL] Move subquery error handling to check...

2017-05-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17713 **[Test build #76553 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76553/testReport)** for PR 17713 at commit

[GitHub] spark issue #17793: [SPARK-20484][MLLIB] Add documentation to ALS code

2017-05-07 Thread danielyli
Github user danielyli commented on the issue: https://github.com/apache/spark/pull/17793 Thanks all. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark pull request #17887: [SPARK-20399][SQL][WIP] Add a config to fallback ...

2017-05-07 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17887#discussion_r115155941 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/ParserUtils.scala --- @@ -68,6 +68,11 @@ object ParserUtils { /**

[GitHub] spark issue #17825: [SPARK-20550][SPARKR] R wrapper for Dataset.alias

2017-05-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17825 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76552/ Test PASSed. ---

[GitHub] spark issue #17825: [SPARK-20550][SPARKR] R wrapper for Dataset.alias

2017-05-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17825 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17825: [SPARK-20550][SPARKR] R wrapper for Dataset.alias

2017-05-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17825 **[Test build #76552 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76552/testReport)** for PR 17825 at commit

[GitHub] spark pull request #17887: [SPARK-20399][SQL][WIP] Add a config to fallback ...

2017-05-07 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17887#discussion_r115155773 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -196,6 +196,14 @@ object SQLConf { .booleanConf

[GitHub] spark issue #17825: [SPARK-20550][SPARKR] R wrapper for Dataset.alias

2017-05-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17825 **[Test build #76552 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76552/testReport)** for PR 17825 at commit

[GitHub] spark pull request #17713: [SPARK-20417][SQL] Move subquery error handling t...

2017-05-07 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/17713#discussion_r115154716 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala --- @@ -137,32 +137,46 @@ case class In(value:

[GitHub] spark pull request #17713: [SPARK-20417][SQL] Move subquery error handling t...

2017-05-07 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/17713#discussion_r115154718 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -386,16 +386,12 @@ trait CheckAnalysis extends

[GitHub] spark issue #17649: [SPARK-20380][SQL] Unable to set/unset table comment pro...

2017-05-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17649 **[Test build #76551 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76551/testReport)** for PR 17649 at commit

[GitHub] spark issue #17649: [SPARK-20380][SQL] Unable to set/unset table comment pro...

2017-05-07 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17649 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #17713: [SPARK-20417][SQL] Move subquery error handling to check...

2017-05-07 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17713 LGTM except minor comments. cc @hvanhovell --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request #17713: [SPARK-20417][SQL] Move subquery error handling t...

2017-05-07 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17713#discussion_r115154225 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -386,16 +386,12 @@ trait CheckAnalysis extends

[GitHub] spark pull request #17713: [SPARK-20417][SQL] Move subquery error handling t...

2017-05-07 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17713#discussion_r115154162 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala --- @@ -137,32 +137,46 @@ case class In(value:

[GitHub] spark pull request #17801: [MINOR][SQL][DOCS] Improve unix_timestamp's scala...

2017-05-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17801 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #17801: [MINOR][SQL][DOCS] Improve unix_timestamp's scaladoc (an...

2017-05-07 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17801 Thanks! Merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #17077: [SPARK-16931][PYTHON][SQL] Add Python wrapper for bucket...

2017-05-07 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17077 The SQL document update can be a separate PR. Thanks for your work! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #17077: [SPARK-16931][PYTHON][SQL] Add Python wrapper for bucket...

2017-05-07 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17077 LGTM `[SPARK-16931][PYTHON][SQL] Add Python wrapper for bucketBy` -> `[SPARK-16931][PYTHON][SQL] Add Python wrapper for bucketBy and sortBy` --- If your project is set up for it, you

[GitHub] spark pull request #17077: [SPARK-16931][PYTHON][SQL] Add Python wrapper for...

2017-05-07 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17077#discussion_r115153524 --- Diff: python/pyspark/sql/readwriter.py --- @@ -563,6 +563,63 @@ def partitionBy(self, *cols): self._jwrite =

[GitHub] spark pull request #17077: [SPARK-16931][PYTHON][SQL] Add Python wrapper for...

2017-05-07 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17077#discussion_r115153302 --- Diff: python/pyspark/sql/readwriter.py --- @@ -563,6 +563,63 @@ def partitionBy(self, *cols): self._jwrite =

[GitHub] spark issue #17825: [SPARK-20550][SPARKR] R wrapper for Dataset.alias

2017-05-07 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/17825 could you keep the description and return type in the same order in this https://github.com/apache/spark/pull/17825#discussion_r115113331 it's not great, but it's the best we can do

[GitHub] spark pull request #17825: [SPARK-20550][SPARKR] R wrapper for Dataset.alias

2017-05-07 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17825#discussion_r115152814 --- Diff: R/pkg/R/DataFrame.R --- @@ -3745,3 +3745,26 @@ setMethod("hint", jdf <- callJMethod(x@sdf, "hint", name, parameters)

[GitHub] spark issue #17891: [SPARK-20631][PYTHON][ML] LogisticRegression._checkThres...

2017-05-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17891 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76549/ Test PASSed. ---

[GitHub] spark issue #17891: [SPARK-20631][PYTHON][ML] LogisticRegression._checkThres...

2017-05-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17891 **[Test build #76549 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76549/testReport)** for PR 17891 at commit

  1   2   3   >