[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-05-15 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r116659903 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -461,68 +462,249 @@ case class

[GitHub] spark issue #17990: [YARN] [SPARK-20756][WIP] yarn-shuffle jar references un...

2017-05-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17990 **[Test build #76955 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76955/testReport)** for PR 17990 at commit

[GitHub] spark issue #17990: [YARN] [SPARK-20756][WIP] yarn-shuffle jar references un...

2017-05-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17990 **[Test build #76954 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76954/testReport)** for PR 17990 at commit

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-05-15 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r116657546 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -461,68 +462,249 @@ case class

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-05-15 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r116656846 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -461,68 +462,249 @@ case class

[GitHub] spark pull request #17935: [SPARK-20690][SQL] Subqueries in FROM should have...

2017-05-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17935#discussion_r116656440 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -473,7 +473,7 @@ identifierComment

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-05-15 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r116656190 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -461,68 +462,249 @@ case class

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-05-15 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r116655649 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -461,68 +462,249 @@ case class

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-05-15 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r116655664 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -461,68 +462,249 @@ case class

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-05-15 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r116655632 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -461,68 +462,249 @@ case class

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-05-15 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r116646341 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -2306,7 +2306,15 @@ object functions { * @group string_funcs *

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-05-15 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r116656332 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -461,68 +462,249 @@ case class

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-05-15 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r116646257 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -2382,7 +2390,15 @@ object functions { * @group string_funcs *

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-05-15 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r116646329 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -2382,7 +2390,15 @@ object functions { * @group string_funcs *

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-05-15 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r116656230 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -461,68 +462,249 @@ case class

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-05-15 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r116645110 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -1086,10 +1106,22 @@ class AstBuilder extends

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-05-15 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r116656069 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -461,68 +462,249 @@ case class

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-05-15 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r116655023 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -2447,7 +2463,15 @@ object functions { * @group string_funcs *

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-05-15 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r116644643 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -1106,10 +1126,22 @@ class AstBuilder(conf: SQLConf)

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-05-15 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r116655691 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -461,68 +462,249 @@ case class

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-05-15 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r116646246 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -2306,7 +2306,15 @@ object functions { * @group string_funcs *

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-05-15 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r116644377 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -1091,6 +1094,23 @@ class AstBuilder(conf: SQLConf)

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-05-15 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r116655997 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -461,68 +462,249 @@ case class

[GitHub] spark issue #17994: [SPARK-20505][ML] Add docs and examples for ml.stat.Corr...

2017-05-15 Thread yanboliang
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/17994 cc @jkbradley --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark pull request #17994: [SPARK-20505][ML] Add docs and examples for ml.st...

2017-05-15 Thread yanboliang
GitHub user yanboliang opened a pull request: https://github.com/apache/spark/pull/17994 [SPARK-20505][ML] Add docs and examples for ml.stat.Correlation and ml.stat.ChiSquareTest. ## What changes were proposed in this pull request? Add docs and examples for

[GitHub] spark pull request #16598: [SPARK-19236][Core] Added createOrReplaceGlobalTe...

2017-05-15 Thread arman1371
Github user arman1371 commented on a diff in the pull request: https://github.com/apache/spark/pull/16598#discussion_r116655733 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -2603,6 +2603,21 @@ class Dataset[T] private[sql]( def

[GitHub] spark issue #17946: [SPARK-20707] [ML] ML deprecated APIs should be removed ...

2017-05-15 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/17946 LGTM Thanks for doing this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request #17935: [SPARK-20690][SQL] Subqueries in FROM should have...

2017-05-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17935#discussion_r116655663 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SubquerySuite.scala --- @@ -868,6 +868,29 @@ class SubquerySuite extends QueryTest with

[GitHub] spark pull request #17978: [SPARK-20736][Python] PySpark StringIndexer suppo...

2017-05-15 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17978#discussion_r116655296 --- Diff: python/pyspark/ml/feature.py --- @@ -2111,26 +2112,45 @@ class StringIndexer(JavaEstimator, HasInputCol, HasOutputCol, HasHandleInvalid,

[GitHub] spark issue #17978: [SPARK-20736][Python] PySpark StringIndexer supports Str...

2017-05-15 Thread actuaryzhang
Github user actuaryzhang commented on the issue: https://github.com/apache/spark/pull/17978 @felixcheung Thanks so much for the review. I addressed most of the comments except auto generating code for defining `stringOrderType`. This parameter is not a shared trait on the Scala side,

[GitHub] spark pull request #17978: [SPARK-20736][Python] PySpark StringIndexer suppo...

2017-05-15 Thread actuaryzhang
Github user actuaryzhang commented on a diff in the pull request: https://github.com/apache/spark/pull/17978#discussion_r116655031 --- Diff: python/pyspark/ml/feature.py --- @@ -2111,26 +2112,45 @@ class StringIndexer(JavaEstimator, HasInputCol, HasOutputCol, HasHandleInvalid,

[GitHub] spark issue #17983: [SPARK-20738][BUILD] Option to turn off building docs in...

2017-05-15 Thread ScrapCodes
Github user ScrapCodes commented on the issue: https://github.com/apache/spark/pull/17983 @srowen Can you please take a look ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #17978: [SPARK-20736][Python] PySpark StringIndexer suppo...

2017-05-15 Thread actuaryzhang
Github user actuaryzhang commented on a diff in the pull request: https://github.com/apache/spark/pull/17978#discussion_r116654554 --- Diff: python/pyspark/ml/feature.py --- @@ -2082,8 +2082,9 @@ class StringIndexer(JavaEstimator, HasInputCol, HasOutputCol, HasHandleInvalid,

[GitHub] spark pull request #17978: [SPARK-20736][Python] PySpark StringIndexer suppo...

2017-05-15 Thread actuaryzhang
Github user actuaryzhang commented on a diff in the pull request: https://github.com/apache/spark/pull/17978#discussion_r116654542 --- Diff: python/pyspark/ml/feature.py --- @@ -2139,6 +2159,20 @@ def setParams(self, inputCol=None, outputCol=None, handleInvalid="error"):

[GitHub] spark pull request #17934: [SPARK-20501] [ML] ML 2.2 QA: New Scala APIs, doc...

2017-05-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17934 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #17934: [SPARK-20501] [ML] ML 2.2 QA: New Scala APIs, docs

2017-05-15 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/17934 LGTM I'll merge this with master and branch-2.2 Thanks all! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request #17978: [SPARK-20736][Python] PySpark StringIndexer suppo...

2017-05-15 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17978#discussion_r116652156 --- Diff: python/pyspark/ml/feature.py --- @@ -2082,8 +2082,9 @@ class StringIndexer(JavaEstimator, HasInputCol, HasOutputCol, HasHandleInvalid,

[GitHub] spark pull request #17978: [SPARK-20736][Python] PySpark StringIndexer suppo...

2017-05-15 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17978#discussion_r116652194 --- Diff: python/pyspark/ml/feature.py --- @@ -2139,6 +2159,20 @@ def setParams(self, inputCol=None, outputCol=None, handleInvalid="error"):

[GitHub] spark pull request #17978: [SPARK-20736][Python] PySpark StringIndexer suppo...

2017-05-15 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17978#discussion_r116652102 --- Diff: python/pyspark/ml/feature.py --- @@ -2111,26 +2112,45 @@ class StringIndexer(JavaEstimator, HasInputCol, HasOutputCol, HasHandleInvalid,

[GitHub] spark issue #17672: [SPARK-20371][R] Add wrappers for collect_list and colle...

2017-05-15 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/17672 @zero323 I think that its license needs to be compatible with Apache 2.0 and it can't be big (since example data is in the release; no more than a few MB?) https://www.apache.org/licenses/

[GitHub] spark issue #17941: [SPARK-20684][R] Expose createGlobalTempView and dropGlo...

2017-05-15 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/17941 @rxin it was from a while back in SPARK-17865 essentially these are exactly the same in standalone SparkR: ``` sparkR.session() ... createGlobalTempView(df, "foo")

[GitHub] spark pull request #17981: [SPARK-15767][ML][SparkR] Decision Tree wrapper i...

2017-05-15 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17981#discussion_r116650195 --- Diff: R/pkg/R/mllib_tree.R --- @@ -45,6 +45,20 @@ setClass("RandomForestRegressionModel", representation(jobj = "jobj")) #' @note

[GitHub] spark pull request #17981: [SPARK-15767][ML][SparkR] Decision Tree wrapper i...

2017-05-15 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17981#discussion_r116649550 --- Diff: R/pkg/R/mllib_utils.R --- @@ -38,6 +38,7 @@ #' @seealso \link{spark.lda}, \link{spark.logit}, #' @seealso \link{spark.mlp},

[GitHub] spark pull request #17981: [SPARK-15767][ML][SparkR] Decision Tree wrapper i...

2017-05-15 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17981#discussion_r116649599 --- Diff: R/pkg/inst/tests/testthat/test_mllib_tree.R --- @@ -209,4 +209,91 @@ test_that("spark.randomForest", {

[GitHub] spark pull request #17981: [SPARK-15767][ML][SparkR] Decision Tree wrapper i...

2017-05-15 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17981#discussion_r116649559 --- Diff: R/pkg/R/mllib_utils.R --- @@ -52,7 +53,8 @@ NULL #' @seealso \link{spark.gbt}, \link{spark.glm}, \link{glm}, \link{spark.isoreg},

[GitHub] spark pull request #17981: [SPARK-15767][ML][SparkR] Decision Tree wrapper i...

2017-05-15 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17981#discussion_r116649021 --- Diff: R/pkg/R/mllib_tree.R --- @@ -45,6 +45,20 @@ setClass("RandomForestRegressionModel", representation(jobj = "jobj")) #' @note

[GitHub] spark issue #17993: [SPARK-20758][SQL] Add Constant propagation optimization

2017-05-15 Thread tejasapatil
Github user tejasapatil commented on the issue: https://github.com/apache/spark/pull/17993 Jenkins test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #17992: [SPARK-20759] SCALA_VERSION in _config.yml should...

2017-05-15 Thread liu-zhaokun
GitHub user liu-zhaokun opened a pull request: https://github.com/apache/spark/pull/17992 [SPARK-20759] SCALA_VERSION in _config.yml should be consistent with pom.xml [https://issues.apache.org/jira/browse/SPARK-20759](https://issues.apache.org/jira/browse/SPARK-20759)

[GitHub] spark pull request #17993: [SPARK-20758][SQL] Add Constant propagation optim...

2017-05-15 Thread tejasapatil
GitHub user tejasapatil opened a pull request: https://github.com/apache/spark/pull/17993 [SPARK-20758][SQL] Add Constant propagation optimization ## What changes were proposed in this pull request? Added a rule based on this logic: - look for expression node with an

[GitHub] spark pull request #17991: [SPARK-20757][DOC][CORE]Spark timeout several sma...

2017-05-15 Thread guoxiaolongzte
GitHub user guoxiaolongzte opened a pull request: https://github.com/apache/spark/pull/17991 [SPARK-20757][DOC][CORE]Spark timeout several small optimization ## What changes were proposed in this pull request? 1. ‘spark.storage.blockManagerSlaveTimeoutMs’ has not been

[GitHub] spark issue #17934: [SPARK-20501] [ML] ML 2.2 QA: New Scala APIs, docs

2017-05-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17934 **[Test build #76956 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76956/testReport)** for PR 17934 at commit

[GitHub] spark issue #17984: [ SPARK-20739][CORE][TEST]Supplement the new unit tests ...

2017-05-15 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/17984 Sorry, surgical test? I didn't understand . Can you explain in more detail? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #17680: [SPARK-20364][SQL] Support Parquet predicate pushdown on...

2017-05-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17680 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17680: [SPARK-20364][SQL] Support Parquet predicate pushdown on...

2017-05-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17680 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76951/ Test PASSed. ---

[GitHub] spark pull request #17984: [ SPARK-20739][CORE][TEST]Supplement the new unit...

2017-05-15 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/17984#discussion_r116642520 --- Diff: core/src/test/scala/org/apache/spark/SparkContextSchedulerCreationSuite.scala --- @@ -129,4 +129,29 @@ class

[GitHub] spark pull request #17946: [SPARK-20707] [ML] ML deprecated APIs should be r...

2017-05-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17946 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #17946: [SPARK-20707] [ML] ML deprecated APIs should be removed ...

2017-05-15 Thread yanboliang
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/17946 Since this blocks 2.2 release, I'll merge it into master and branch-2.2. If anyone has more comments, I can address them in follow-up work. Thanks. --- If your project is set up for it, you can

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-05-15 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r116642218 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -461,68 +462,249 @@ case class

[GitHub] spark issue #17934: [SPARK-20501] [ML] ML 2.2 QA: New Scala APIs, docs

2017-05-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17934 **[Test build #76956 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76956/testReport)** for PR 17934 at commit

[GitHub] spark pull request #17934: [SPARK-20501] [ML] ML 2.2 QA: New Scala APIs, doc...

2017-05-15 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/17934#discussion_r116641577 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala --- @@ -146,7 +146,7 @@ object StringIndexer extends

[GitHub] spark issue #17680: [SPARK-20364][SQL] Support Parquet predicate pushdown on...

2017-05-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17680 **[Test build #76951 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76951/testReport)** for PR 17680 at commit

[GitHub] spark issue #17990: [YARN] [SPARK-20756][WIP] yarn-shuffle jar references un...

2017-05-15 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/17990 Also please remove the remaining of the boilerplate message from your commit message. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request #17990: [YARN] [SPARK-20756][WIP] yarn-shuffle jar refere...

2017-05-15 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/17990#discussion_r116641153 --- Diff: common/network-yarn/pom.xml --- @@ -113,6 +116,13 @@ io.netty.** + +

[GitHub] spark issue #17990: [YARN] [SPARK-20756][WIP] yarn-shuffle jar references un...

2017-05-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17990 **[Test build #76955 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76955/testReport)** for PR 17990 at commit

[GitHub] spark issue #17910: [SPARK-20669][ML] LoR.family and LDA.optimizer should be...

2017-05-15 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/17910 @sethah Good point. Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #17990: [YARN] [SPARK-20756] yarn-shuffle jar references unshade...

2017-05-15 Thread markgrover
Github user markgrover commented on the issue: https://github.com/apache/spark/pull/17990 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #17990: [YARN] [SPARK-20756] yarn-shuffle jar references unshade...

2017-05-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17990 **[Test build #76954 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76954/testReport)** for PR 17990 at commit

[GitHub] spark pull request #17990: [YARN] [SPARK-20756] yarn-shuffle jar references ...

2017-05-15 Thread markgrover
GitHub user markgrover opened a pull request: https://github.com/apache/spark/pull/17990 [YARN] [SPARK-20756] yarn-shuffle jar references unshaded guava and contains scala classes ## What changes were proposed in this pull request? This change ensures that all

[GitHub] spark issue #17087: [SPARK-19372][SQL] Fix throwing a Java exception at df.f...

2017-05-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17087 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17087: [SPARK-19372][SQL] Fix throwing a Java exception at df.f...

2017-05-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17087 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76949/ Test PASSed. ---

[GitHub] spark issue #17087: [SPARK-19372][SQL] Fix throwing a Java exception at df.f...

2017-05-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17087 **[Test build #76949 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76949/testReport)** for PR 17087 at commit

[GitHub] spark issue #17989: [SPARK-6628][SQL][Branch-1.6] Fix ClassCastException whe...

2017-05-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17989 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76953/ Test FAILed. ---

[GitHub] spark issue #17989: [SPARK-6628][SQL][Branch-1.6] Fix ClassCastException whe...

2017-05-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17989 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17989: [SPARK-6628][SQL][Branch-1.6] Fix ClassCastException whe...

2017-05-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17989 **[Test build #76953 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76953/consoleFull)** for PR 17989 at commit

[GitHub] spark issue #17989: [SPARK-6628][SQL][Branch-1.6] Fix ClassCastException whe...

2017-05-15 Thread weiqingy
Github user weiqingy commented on the issue: https://github.com/apache/spark/pull/17989 Jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #17989: [SPARK-6628][SQL][Branch-1.6] Fix ClassCastException whe...

2017-05-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17989 **[Test build #76953 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76953/consoleFull)** for PR 17989 at commit

[GitHub] spark issue #17989: [SPARK-6628][SQL][Branch-1.6] Fix ClassCastException whe...

2017-05-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17989 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17989: [SPARK-6628][SQL][Branch-1.6] Fix ClassCastException whe...

2017-05-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17989 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76952/ Test FAILed. ---

[GitHub] spark issue #17989: [SPARK-6628][SQL][Branch-1.6] Fix ClassCastException whe...

2017-05-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17989 **[Test build #76952 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76952/consoleFull)** for PR 17989 at commit

[GitHub] spark pull request #17989: [SPARK-6628][SQL][Branch-1.6] Fix ClassCastExcept...

2017-05-15 Thread weiqingy
Github user weiqingy commented on a diff in the pull request: https://github.com/apache/spark/pull/17989#discussion_r116631706 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveWriterContainers.scala --- @@ -70,8 +70,11 @@ private[hive] class

[GitHub] spark issue #17989: [SPARK-6628][SQL][Branch-1.6] Fix ClassCastException whe...

2017-05-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17989 **[Test build #76952 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76952/consoleFull)** for PR 17989 at commit

[GitHub] spark pull request #17989: [SPARK-6628][SQL] Fix ClassCastException when exe...

2017-05-15 Thread weiqingy
GitHub user weiqingy opened a pull request: https://github.com/apache/spark/pull/17989 [SPARK-6628][SQL] Fix ClassCastException when executing sql statement 'insert into' on hbase table ## What changes were proposed in this pull request? The major issue of SPARK-6628 is:

[GitHub] spark pull request #17934: [SPARK-20501] [ML] ML 2.2 QA: New Scala APIs, doc...

2017-05-15 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/17934#discussion_r116631097 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala --- @@ -146,7 +146,7 @@ object StringIndexer extends

[GitHub] spark issue #17988: [DOCS][MINOR] Use consistent names in rollup and cube ex...

2017-05-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17988 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76950/ Test PASSed. ---

[GitHub] spark issue #17988: [DOCS][MINOR] Use consistent names in rollup and cube ex...

2017-05-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17988 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17988: [DOCS][MINOR] Use consistent names in rollup and cube ex...

2017-05-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17988 **[Test build #76950 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76950/testReport)** for PR 17988 at commit

[GitHub] spark issue #17680: [SPARK-20364][SQL] Support Parquet predicate pushdown on...

2017-05-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17680 **[Test build #76951 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76951/testReport)** for PR 17680 at commit

[GitHub] spark issue #17963: [SPARK-20722][CORE] Replay newer event log that hasn't b...

2017-05-15 Thread sharkdtu
Github user sharkdtu commented on the issue: https://github.com/apache/spark/pull/17963 @ajbozarth Yes, this case is a big issue in my production cluster, where run nearly 20,000 applications every day. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request #17933: [SPARK-20588][SQL] Cache TimeZone instances.

2017-05-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17933 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #17933: [SPARK-20588][SQL] Cache TimeZone instances.

2017-05-15 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17933 Thanks! Merging to master/2.2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #17988: [DOCS][MINOR] Use consistent names in rollup and cube ex...

2017-05-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17988 **[Test build #76950 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76950/testReport)** for PR 17988 at commit

[GitHub] spark pull request #17988: [DOCS][MINOR] Use consistent names in rollup and ...

2017-05-15 Thread zero323
GitHub user zero323 opened a pull request: https://github.com/apache/spark/pull/17988 [DOCS][MINOR] Use consistent names in rollup and cube examples ## What changes were proposed in this pull request? Rename `carsDF` to `df` in SparkR `rollup` and `cube` examples.

[GitHub] spark pull request #16598: [SPARK-19236][Core] Added createOrReplaceGlobalTe...

2017-05-15 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16598#discussion_r116625893 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -2603,6 +2603,21 @@ class Dataset[T] private[sql]( def

[GitHub] spark issue #17902: [SPARK-20641][core] Add key-value store abstraction and ...

2017-05-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17902 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76948/ Test PASSed. ---

[GitHub] spark issue #17902: [SPARK-20641][core] Add key-value store abstraction and ...

2017-05-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17902 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17902: [SPARK-20641][core] Add key-value store abstraction and ...

2017-05-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17902 **[Test build #76948 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76948/testReport)** for PR 17902 at commit

[GitHub] spark issue #17680: [SPARK-20364][SQL] Support Parquet predicate pushdown on...

2017-05-15 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17680 Yes. Please open the PR to stop predicate push-down for this corner cases. Will review it when it is done. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark issue #17829: [SPARK-20047][FOLLOWUP][ML] Constrained Logistic Regress...

2017-05-15 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/17829 Awesome, thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #17680: [SPARK-20364][SQL] Support Parquet predicate pushdown on...

2017-05-15 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17680 Yes, it looks related with that, in particular, here https://github.com/apache/spark/pull/17680#discussion_r112285883. Up to my knowledge, we don't support pushing down filters with

[GitHub] spark issue #17944: Revert "[SPARK-20606][ML] ML 2.2 QA: Remove deprecated m...

2017-05-15 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/17944 Thanks a lot @yanboliang ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

  1   2   3   4   >