[GitHub] spark pull request #18158: Lack of an important case about the test of resol...

2017-05-31 Thread zuotingbing
Github user zuotingbing commented on a diff in the pull request: https://github.com/apache/spark/pull/18158#discussion_r119511454 --- Diff: core/src/test/scala/org/apache/spark/util/UtilsSuite.scala --- @@ -473,7 +474,7 @@ class UtilsSuite extends SparkFunSuite with

[GitHub] spark issue #18156: [SPARK-20933][SQL]when the input parameter is float type...

2017-05-31 Thread 10110346
Github user 10110346 commented on the issue: https://github.com/apache/spark/pull/18156 Yes,Floating point representation is inexact .But I think if the length of Floating point value is less than 7, it should be exact. Evaluating 3.1415f < 3.1415, firstly, 3.1415f will be

[GitHub] spark issue #18075: [SPARK-18016][SQL][CATALYST] Code Generation: Constant P...

2017-05-31 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/18075 LGTM, cc @cloud-fan. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #17947: [SPARK-20708][CORE] Make `addExclusionRules` up-to-date

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17947 **[Test build #77615 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77615/testReport)** for PR 17947 at commit

[GitHub] spark issue #18155: [SPARK-20876][SQL][Backport-2.2]If the input parameter i...

2017-05-31 Thread 10110346
Github user 10110346 commented on the issue: https://github.com/apache/spark/pull/18155 @gatorsmile OK,thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark pull request #18155: [SPARK-20876][SQL][Backport-2.2]If the input para...

2017-05-31 Thread 10110346
Github user 10110346 closed the pull request at: https://github.com/apache/spark/pull/18155 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #17947: [SPARK-20708][CORE] Make `addExclusionRules` up-to-date

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17947 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77614/ Test FAILed. ---

[GitHub] spark issue #17947: [SPARK-20708][CORE] Make `addExclusionRules` up-to-date

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17947 **[Test build #77614 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77614/testReport)** for PR 17947 at commit

[GitHub] spark issue #17947: [SPARK-20708][CORE] Make `addExclusionRules` up-to-date

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17947 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18136: [SPARK-20910][SQL] Add build-int SQL function - UUID

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18136 **[Test build #77613 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77613/testReport)** for PR 18136 at commit

[GitHub] spark issue #17947: [SPARK-20708][CORE] Make `addExclusionRules` up-to-date

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17947 **[Test build #77614 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77614/testReport)** for PR 17947 at commit

[GitHub] spark issue #18169: [SPARK-20941] [SQL] Fix SubqueryExec Reuse

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18169 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77609/ Test PASSed. ---

[GitHub] spark issue #17947: [SPARK-20708][CORE] Make `addExclusionRules` up-to-date

2017-05-31 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/17947 @brkyvz . Sure. I renamed it into `IVY_DEFAULT_EXCLUDES` and add more documents about that. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #18169: [SPARK-20941] [SQL] Fix SubqueryExec Reuse

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18169 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18169: [SPARK-20941] [SQL] Fix SubqueryExec Reuse

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18169 **[Test build #77609 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77609/testReport)** for PR 18169 at commit

[GitHub] spark pull request #18168: [SPARK-20940][Core]Replace IllegalAccessError wit...

2017-05-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18168 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #18149: [SPARK-20894][SS]Resolve the checkpoint location ...

2017-05-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18149 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #18168: [SPARK-20940][Core]Replace IllegalAccessError with Illeg...

2017-05-31 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/18168 > Lgtm, I wonder if an Error is thrown anywhere else. Really shouldn't be. @srowen IllegalAccessError are not used in other places. However, I didn't search other types of errors. --- If

[GitHub] spark issue #18168: [SPARK-20940][Core]Replace IllegalAccessError with Illeg...

2017-05-31 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/18168 Thanks! Merging to master, 2.2, 2.1 and 2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #18149: [SPARK-20894][SS]Resolve the checkpoint location in driv...

2017-05-31 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/18149 Thanks! Merging to master and 2.2. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #17436: [SPARK-20101][SQL] Use OffHeapColumnVector when "spark.m...

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17436 **[Test build #77612 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77612/testReport)** for PR 17436 at commit

[GitHub] spark issue #17436: [SPARK-20101][SQL] Use OffHeapColumnVector when "spark.m...

2017-05-31 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17436 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #18169: [SPARK-20941] [SQL] Fix SubqueryExec Reuse

2017-05-31 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18169 @cloud-fan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #18168: [SPARK-20940][Core]Replace IllegalAccessError with Illeg...

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18168 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #17947: [SPARK-20708][CORE] Make `addExclusionRules` up-t...

2017-05-31 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17947#discussion_r119504377 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -833,6 +833,14 @@ private[spark] object SparkSubmitUtils { // Exposed

[GitHub] spark issue #18168: [SPARK-20940][Core]Replace IllegalAccessError with Illeg...

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18168 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77608/ Test PASSed. ---

[GitHub] spark issue #18168: [SPARK-20940][Core]Replace IllegalAccessError with Illeg...

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18168 **[Test build #77608 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77608/testReport)** for PR 18168 at commit

[GitHub] spark issue #12506: [SPARK-14736][core] Deadlock in registering applications...

2017-05-31 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/12506 Are you still working on this? @nirandaperera --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #18025: [SPARK-20889][SparkR] Grouped documentation for AGGREGAT...

2017-05-31 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18025 Will give a shot to help double check examples and contents about correctness and consistency at my best tonight too. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark issue #10506: [SPARK-12552][Core]Correctly count the driver resource w...

2017-05-31 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/10506 Could you rebase this? @jerryshao --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #12646: [SPARK-14878][SQL] Trim characters string function suppo...

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/12646 **[Test build #77611 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77611/testReport)** for PR 12646 at commit

[GitHub] spark issue #18025: [SPARK-20889][SparkR] Grouped documentation for AGGREGAT...

2017-05-31 Thread actuaryzhang
Github user actuaryzhang commented on the issue: https://github.com/apache/spark/pull/18025 Thanks for the update. Look forward to your feedback. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request #18165: [Core][Minor][Test] Fix comment and unnecessary c...

2017-05-31 Thread jiangxb1987
Github user jiangxb1987 closed the pull request at: https://github.com/apache/spark/pull/18165 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark issue #18165: [Core][Minor][Test] Fix comment and unnecessary code in ...

2017-05-31 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/18165 Ok, I'll close this and merge that in my next PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request #17617: [SPARK-20244][Core] Handle incorrect bytesRead me...

2017-05-31 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17617#discussion_r119495777 --- Diff: core/src/test/scala/org/apache/spark/metrics/InputOutputMetricsSuite.scala --- @@ -319,6 +319,37 @@ class InputOutputMetricsSuite extends

[GitHub] spark pull request #17617: [SPARK-20244][Core] Handle incorrect bytesRead me...

2017-05-31 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17617#discussion_r119495029 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala --- @@ -143,14 +144,30 @@ class SparkHadoopUtil extends Logging { *

[GitHub] spark issue #18165: [Core][Minor][Test] Fix comment and unnecessary code in ...

2017-05-31 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18165 This honestly doesn't seem like the kind of thing worth opening a PR for --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #18166: [SPARK-20922][core] Add whitelist of classes that can be...

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18166 **[Test build #77610 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77610/testReport)** for PR 18166 at commit

[GitHub] spark issue #14428: [SPARK-16810] Refactor registerSinks with multiple const...

2017-05-31 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/14428 Are you still working on this @lovexi ? Or should we temporarily close the PR if you happen to don't have time for now? Thank you! --- If your project is set up for it, you can reply to this

[GitHub] spark issue #18149: [SPARK-20894][SS]Resolve the checkpoint location in driv...

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18149 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77605/ Test PASSed. ---

[GitHub] spark issue #18149: [SPARK-20894][SS]Resolve the checkpoint location in driv...

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18149 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18149: [SPARK-20894][SS]Resolve the checkpoint location in driv...

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18149 **[Test build #77605 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77605/testReport)** for PR 18149 at commit

[GitHub] spark issue #18168: [SPARK-20940][Core]Replace IllegalAccessError with Illeg...

2017-05-31 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18168 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #18169: [SPARK-20941] [SQL] Fix SubqueryExec Reuse

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18169 **[Test build #77609 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77609/testReport)** for PR 18169 at commit

[GitHub] spark pull request #18169: [SPARK-20941] [SQL] Fix SubqueryExec Reuse

2017-05-31 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/18169 [SPARK-20941] [SQL] Fix SubqueryExec Reuse ### What changes were proposed in this pull request? Before this PR, Subquery reuse does not work. Below are three issues: - Subquery reuse

[GitHub] spark issue #17750: [SPARK-4899][MESOS] Support for Checkpointing on Coarse ...

2017-05-31 Thread tegataiprime
Github user tegataiprime commented on the issue: https://github.com/apache/spark/pull/17750 @gkc2104 @mgummelt Will there be a separate issue & pr for adding the failover_timeout? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark issue #18128: [SPARK-20906][SparkR]:Constrained Logistic Regression fo...

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18128 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18128: [SPARK-20906][SparkR]:Constrained Logistic Regression fo...

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18128 **[Test build #77607 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77607/testReport)** for PR 18128 at commit

[GitHub] spark issue #18128: [SPARK-20906][SparkR]:Constrained Logistic Regression fo...

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18128 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77607/ Test PASSed. ---

[GitHub] spark issue #18162: [SPARK-20923] Remove TaskMetrics._updatedBlockStatuses

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18162 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18162: [SPARK-20923] Remove TaskMetrics._updatedBlockStatuses

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18162 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77603/ Test PASSed. ---

[GitHub] spark issue #18162: [SPARK-20923] Remove TaskMetrics._updatedBlockStatuses

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18162 **[Test build #77603 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77603/testReport)** for PR 18162 at commit

[GitHub] spark issue #18162: [SPARK-20923] Remove TaskMetrics._updatedBlockStatuses

2017-05-31 Thread tgravescs
Github user tgravescs commented on the issue: https://github.com/apache/spark/pull/18162 taskMetrics doesn't take the sparkconf or anything to get at a config so we would have to config out everywhere its incrementing or adding things. I think that wouldn't be to hard. I'll put

[GitHub] spark issue #18075: [SPARK-18016][SQL][CATALYST] Code Generation: Constant P...

2017-05-31 Thread bdrillard
Github user bdrillard commented on the issue: https://github.com/apache/spark/pull/18075 The earlier failure occurred when the

[GitHub] spark issue #17459: [SPARK-20109][MLlib] Rewrote toBlockMatrix method on Ind...

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17459 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17459: [SPARK-20109][MLlib] Rewrote toBlockMatrix method on Ind...

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17459 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77606/ Test PASSed. ---

[GitHub] spark issue #17459: [SPARK-20109][MLlib] Rewrote toBlockMatrix method on Ind...

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17459 **[Test build #77606 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77606/testReport)** for PR 17459 at commit

[GitHub] spark issue #18168: [SPARK-20940][Core]Replace IllegalAccessError with Illeg...

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18168 **[Test build #77608 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77608/testReport)** for PR 18168 at commit

[GitHub] spark issue #18168: [SPARK-20940][Core]Replace IllegalAccessError with Illeg...

2017-05-31 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/18168 cc @cloud-fan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark pull request #18168: [SPARK-20940][Core]Replace IllegalAccessError wit...

2017-05-31 Thread zsxwing
GitHub user zsxwing opened a pull request: https://github.com/apache/spark/pull/18168 [SPARK-20940][Core]Replace IllegalAccessError with IllegalStateException ## What changes were proposed in this pull request? `IllegalAccessError` is a fatal error (a subclass of

[GitHub] spark issue #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as function i...

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18142 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as function i...

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18142 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77602/ Test PASSed. ---

[GitHub] spark issue #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as function i...

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18142 **[Test build #77602 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77602/testReport)** for PR 18142 at commit

[GitHub] spark issue #18128: [SPARK-20906][SparkR]:Constrained Logistic Regression fo...

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18128 **[Test build #77607 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77607/testReport)** for PR 18128 at commit

[GitHub] spark pull request #18151: [SPARK-20929][ML] LinearSVC should use its own th...

2017-05-31 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/18151#discussion_r119472374 --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/LinearSVCSuite.scala --- @@ -127,6 +127,27 @@ class LinearSVCSuite extends SparkFunSuite

[GitHub] spark issue #18166: [SPARK-20922][core] Add whitelist of classes that can be...

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18166 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77599/ Test PASSed. ---

[GitHub] spark issue #18166: [SPARK-20922][core] Add whitelist of classes that can be...

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18166 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18166: [SPARK-20922][core] Add whitelist of classes that can be...

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18166 **[Test build #77599 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77599/testReport)** for PR 18166 at commit

[GitHub] spark issue #18162: [SPARK-20923] Remove TaskMetrics._updatedBlockStatuses

2017-05-31 Thread JoshRosen
Github user JoshRosen commented on the issue: https://github.com/apache/spark/pull/18162 @tgravescs, I guess the question is whether any user has a SparkListener which actually uses the value of `updatedBlockStatuses` for some monitoring application or something similar. In that case

[GitHub] spark issue #18128: [SPARK-20906][SparkR]:Constrained Logistic Regression fo...

2017-05-31 Thread wangmiao1981
Github user wangmiao1981 commented on the issue: https://github.com/apache/spark/pull/18128 @yanboliang Can you take a look? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #18167: [SPARK-19236][SQL][BACKPORT-2.2] Added createOrReplaceGl...

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18167 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77600/ Test PASSed. ---

[GitHub] spark issue #18167: [SPARK-19236][SQL][BACKPORT-2.2] Added createOrReplaceGl...

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18167 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18167: [SPARK-19236][SQL][BACKPORT-2.2] Added createOrReplaceGl...

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18167 **[Test build #77600 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77600/testReport)** for PR 18167 at commit

[GitHub] spark issue #17459: [SPARK-20109][MLlib] Rewrote toBlockMatrix method on Ind...

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17459 **[Test build #77606 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77606/testReport)** for PR 17459 at commit

[GitHub] spark issue #17459: [SPARK-20109][MLlib] Rewrote toBlockMatrix method on Ind...

2017-05-31 Thread johnc1231
Github user johnc1231 commented on the issue: https://github.com/apache/spark/pull/17459 @srowen @viirya All comments addressed, back to you guys. Hopefully we've just about reached something ready to commit. --- If your project is set up for it, you can reply to this email and

[GitHub] spark issue #18151: [SPARK-20929][ML] LinearSVC should use its own threshold...

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18151 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77604/ Test PASSed. ---

[GitHub] spark issue #18151: [SPARK-20929][ML] LinearSVC should use its own threshold...

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18151 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #17459: [SPARK-20109][MLlib] Rewrote toBlockMatrix method...

2017-05-31 Thread johnc1231
Github user johnc1231 commented on a diff in the pull request: https://github.com/apache/spark/pull/17459#discussion_r119463845 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/IndexedRowMatrix.scala --- @@ -108,8 +108,69 @@ class IndexedRowMatrix

[GitHub] spark issue #18151: [SPARK-20929][ML] LinearSVC should use its own threshold...

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18151 **[Test build #77604 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77604/testReport)** for PR 18151 at commit

[GitHub] spark issue #18165: [Core][Minor][Test] Fix comment and unnecessary code in ...

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18165 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77598/ Test PASSed. ---

[GitHub] spark issue #18165: [Core][Minor][Test] Fix comment and unnecessary code in ...

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18165 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18165: [Core][Minor][Test] Fix comment and unnecessary code in ...

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18165 **[Test build #77598 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77598/testReport)** for PR 18165 at commit

[GitHub] spark issue #18149: [SPARK-20894][SS]Resolve the checkpoint location in driv...

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18149 **[Test build #77605 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77605/testReport)** for PR 18149 at commit

[GitHub] spark pull request #17902: [SPARK-20641][core] Add key-value store abstracti...

2017-05-31 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/17902#discussion_r119461586 --- Diff: common/kvstore/src/main/java/org/apache/spark/kvstore/LevelDB.java --- @@ -0,0 +1,303 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #17902: [SPARK-20641][core] Add key-value store abstracti...

2017-05-31 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/17902#discussion_r119459850 --- Diff: common/kvstore/src/main/java/org/apache/spark/kvstore/KVTypeInfo.java --- @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache Software

[GitHub] spark issue #18149: [SPARK-20894][SS]Resolve the checkpoint location in driv...

2017-05-31 Thread tdas
Github user tdas commented on the issue: https://github.com/apache/spark/pull/18149 roughly LGTM, as long as you resolve conflicts and tests pass. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request #18149: [SPARK-20894][SS]Resolve the checkpoint location ...

2017-05-31 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/18149#discussion_r119458097 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamSuite.scala --- @@ -614,6 +614,24 @@ class StreamSuite extends StreamTest {

[GitHub] spark pull request #18149: [SPARK-20894][SS]Resolve the checkpoint location ...

2017-05-31 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/18149#discussion_r119457510 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala --- @@ -595,6 +601,7 @@ class StreamExecution(

[GitHub] spark issue #18140: [SPARK-20917][ML][SparkR] SparkR supports string encodin...

2017-05-31 Thread actuaryzhang
Github user actuaryzhang commented on the issue: https://github.com/apache/spark/pull/18140 @felixcheung Yes, the first one is the default. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #18075: [SPARK-18016][SQL][CATALYST] Code Generation: Constant P...

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18075 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77597/ Test PASSed. ---

[GitHub] spark issue #18075: [SPARK-18016][SQL][CATALYST] Code Generation: Constant P...

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18075 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18075: [SPARK-18016][SQL][CATALYST] Code Generation: Constant P...

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18075 **[Test build #77597 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77597/testReport)** for PR 18075 at commit

[GitHub] spark issue #18140: [SPARK-20917][ML][SparkR] SparkR supports string encodin...

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18140 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77601/ Test PASSed. ---

[GitHub] spark issue #18140: [SPARK-20917][ML][SparkR] SparkR supports string encodin...

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18140 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18140: [SPARK-20917][ML][SparkR] SparkR supports string encodin...

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18140 **[Test build #77601 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77601/testReport)** for PR 18140 at commit

[GitHub] spark issue #18151: [SPARK-20929][ML] LinearSVC should use its own threshold...

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18151 **[Test build #77604 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77604/testReport)** for PR 18151 at commit

[GitHub] spark issue #18151: [SPARK-20929][ML] LinearSVC should use its own threshold...

2017-05-31 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/18151 So...good thing you asked for the test b/c transform() wasn't going through the corrected code path. Another bit of evidence that the Prediction APIs don't generalize that well... --- If your

[GitHub] spark issue #18162: [SPARK-20923] Remove TaskMetrics._updatedBlockStatuses

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18162 **[Test build #77603 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77603/testReport)** for PR 18162 at commit

[GitHub] spark issue #18162: [SPARK-20923] Remove TaskMetrics._updatedBlockStatuses

2017-05-31 Thread tgravescs
Github user tgravescs commented on the issue: https://github.com/apache/spark/pull/18162 Updated, I put the TaskMetrics api back with deprecated marking and just had it return Nil. @JoshRosen Were you thinking of adding more back? --- If your project is set up for it, you can

[GitHub] spark pull request #18162: [SPARK-20923] Remove TaskMetrics._updatedBlockSta...

2017-05-31 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/18162#discussion_r119444253 --- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala --- @@ -368,8 +356,7 @@ private[spark] object JsonProtocol { ("Shuffle

<    1   2   3   4   5   >