[GitHub] spark issue #18108: [SPARK-20884] Spark' masters will be both standby due to...

2017-05-31 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18108 Generally you need to evaluate the impact of updating a minor version of a dependency. Does it cause any compatibility problems? What version does Hadoop use? Does it add new transitive deps? You

[GitHub] spark pull request #18143: [SPARK-20919][SS] Simplificaiton of CachedKafkaCo...

2017-05-31 Thread ScrapCodes
Github user ScrapCodes commented on a diff in the pull request: https://github.com/apache/spark/pull/18143#discussion_r119277567 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/CachedKafkaConsumer.scala --- @@ -310,62 +308,45 @@ private[kafka010]

[GitHub] spark issue #18129: [SPARK-20365][YARN] Remove LocalSchem when add path to C...

2017-05-31 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/18129 CC @vanzin to take a review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #18153: [SPARK-20931][SQL] ABS function support string type.

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18153 **[Test build #77576 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77576/testReport)** for PR 18153 at commit

[GitHub] spark pull request #18129: [SPARK-20365][YARN] Remove LocalSchem when add pa...

2017-05-31 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/18129#discussion_r119277116 --- Diff: resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientSuite.scala --- @@ -116,15 +116,16 @@ class ClientSuite extends

[GitHub] spark pull request #17617: [SPARK-20244][Core] Handle incorrect bytesRead me...

2017-05-31 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/17617#discussion_r119276245 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala --- @@ -143,14 +144,18 @@ class SparkHadoopUtil extends Logging { *

<    1   2   3   4   5