[GitHub] spark issue #18257: [SPARK-21041][SQL] SparkSession.range should be consiste...

2017-06-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18257 **[Test build #77915 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77915/testReport)** for PR 18257 at commit

[GitHub] spark issue #18236: [SPARK-21015] Check field name is not null and empty in ...

2017-06-11 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18236 How about just updating the comment of this function to explain the behavior we have now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark issue #17758: [SPARK-20460][SQL] Make it more consistent to handle col...

2017-06-11 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/17758 ok, I'll also check again. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #18266: [SPARK-20427][SQL] Read JDBC table use custom schema

2017-06-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18266 **[Test build #77908 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77908/testReport)** for PR 18266 at commit

[GitHub] spark issue #18266: [SPARK-20427][SQL] Read JDBC table use custom schema

2017-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18266 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77908/ Test FAILed. ---

[GitHub] spark issue #17645: [SPARK-20348] [ML] Support squared hinge loss (L2 loss) ...

2017-06-11 Thread hhbyyh
Github user hhbyyh commented on the issue: https://github.com/apache/spark/pull/17645 OK. I'll close it for now and try to merge it with https://github.com/apache/spark/pull/17862. Thanks for the comment from @yanboliang --- If your project is set up for it, you can reply to

[GitHub] spark issue #18266: [SPARK-20427][SQL] Read JDBC table use custom schema

2017-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18266 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #17645: [SPARK-20348] [ML] Support squared hinge loss (L2...

2017-06-11 Thread hhbyyh
Github user hhbyyh closed the pull request at: https://github.com/apache/spark/pull/17645 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #18257: [SPARK-21041][SQL] SparkSession.range should be c...

2017-06-11 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/18257#discussion_r121313742 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameRangeSuite.scala --- @@ -191,6 +191,17 @@ class DataFrameRangeSuite extends QueryTest

[GitHub] spark pull request #18266: [SPARK-20427][SQL] Read JDBC table use custom sch...

2017-06-11 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18266#discussion_r121313654 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/Metadata.scala --- @@ -273,6 +273,9 @@ class MetadataBuilder { /** Puts a

[GitHub] spark issue #17251: [SPARK-19910][SQL] `stack` should not reject NULL values...

2017-06-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17251 **[Test build #77914 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77914/testReport)** for PR 17251 at commit

[GitHub] spark issue #17251: [SPARK-19910][SQL] `stack` should not reject NULL values...

2017-06-11 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17251 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #17758: [SPARK-20460][SQL] Make it more consistent to handle col...

2017-06-11 Thread wzhfy
Github user wzhfy commented on the issue: https://github.com/apache/spark/pull/17758 Hi @maropu , I just did some simple search, and found many other places also related to duplicate columns. e.g. `InsertIntoHadoopFsRelationCommand`, `PartitioningUtils.normalizePartitionSpec`,

[GitHub] spark pull request #17583: [SPARK-20271]Add FuncTransformer to simplify cust...

2017-06-11 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/17583#discussion_r121312651 --- Diff: mllib/src/main/scala/org/apache/spark/ml/FuncTransformer.scala --- @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request #18082: [SPARK-20665][SQL][FOLLOW-UP]Move test case to Ma...

2017-06-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18082 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #17583: [SPARK-20271]Add FuncTransformer to simplify cust...

2017-06-11 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/17583#discussion_r121312459 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/FuncTransformer.scala --- @@ -0,0 +1,150 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #18257: [SPARK-21041][SQL] SparkSession.range should be c...

2017-06-11 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18257#discussion_r121312457 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameRangeSuite.scala --- @@ -191,6 +191,17 @@ class DataFrameRangeSuite extends QueryTest with

[GitHub] spark issue #18230: [SPARK-19688] [STREAMING] Not to read `spark.yarn.creden...

2017-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18230 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18230: [SPARK-19688] [STREAMING] Not to read `spark.yarn.creden...

2017-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18230 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77910/ Test PASSed. ---

[GitHub] spark issue #18082: [SPARK-20665][SQL][FOLLOW-UP]Move test case to MathExpre...

2017-06-11 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18082 Thanks! Merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #18230: [SPARK-19688] [STREAMING] Not to read `spark.yarn.creden...

2017-06-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18230 **[Test build #77910 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77910/testReport)** for PR 18230 at commit

[GitHub] spark issue #18260: [SPARK-21046][SQL] simplify the array offset and length ...

2017-06-11 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18260 LGTM except for two comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #18270: [SPARK-21055][SQL] replace grouping__id with grouping_id...

2017-06-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18270 **[Test build #77913 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77913/testReport)** for PR 18270 at commit

[GitHub] spark pull request #18260: [SPARK-21046][SQL] simplify the array offset and ...

2017-06-11 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18260#discussion_r121311872 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVector.java --- @@ -518,19 +519,13 @@ private void

[GitHub] spark issue #18257: [SPARK-21041][SQL] SparkSession.range should be consiste...

2017-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18257 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18257: [SPARK-21041][SQL] SparkSession.range should be consiste...

2017-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18257 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77906/ Test PASSed. ---

[GitHub] spark issue #18257: [SPARK-21041][SQL] SparkSession.range should be consiste...

2017-06-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18257 **[Test build #77906 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77906/testReport)** for PR 18257 at commit

[GitHub] spark pull request #18260: [SPARK-21046][SQL] simplify the array offset and ...

2017-06-11 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18260#discussion_r121311563 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OnHeapColumnVector.java --- @@ -43,14 +43,12 @@ private byte[] byteData;

[GitHub] spark issue #18271: [MINOR][DOCS] Improve Running R Tests docs

2017-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18271 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18271: [MINOR][DOCS] Improve Running R Tests docs

2017-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18271 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77911/ Test PASSed. ---

[GitHub] spark issue #18271: [MINOR][DOCS] Improve Running R Tests docs

2017-06-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18271 **[Test build #77911 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77911/testReport)** for PR 18271 at commit

[GitHub] spark issue #18260: [SPARK-21046][SQL] simplify the array offset and length ...

2017-06-11 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18260 @viirya @kiszk good catch! fixed by using long to store offset and size. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #18260: [SPARK-21046][SQL] simplify the array offset and length ...

2017-06-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18260 **[Test build #77912 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77912/testReport)** for PR 18260 at commit

[GitHub] spark issue #18271: [MINOR][DOCS] Improve Running R Tests docs

2017-06-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18271 **[Test build #77911 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77911/testReport)** for PR 18271 at commit

[GitHub] spark issue #18128: [SPARK-20906][SparkR]:Constrained Logistic Regression fo...

2017-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18128 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18128: [SPARK-20906][SparkR]:Constrained Logistic Regression fo...

2017-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18128 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77909/ Test PASSed. ---

[GitHub] spark issue #18128: [SPARK-20906][SparkR]:Constrained Logistic Regression fo...

2017-06-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18128 **[Test build #77909 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77909/testReport)** for PR 18128 at commit

[GitHub] spark issue #18260: [SPARK-21046][SQL] simplify the array offset and length ...

2017-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18260 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77905/ Test PASSed. ---

[GitHub] spark issue #18260: [SPARK-21046][SQL] simplify the array offset and length ...

2017-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18260 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18260: [SPARK-21046][SQL] simplify the array offset and length ...

2017-06-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18260 **[Test build #77905 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77905/testReport)** for PR 18260 at commit

[GitHub] spark issue #18260: [SPARK-21046][SQL] simplify the array offset and length ...

2017-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18260 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18260: [SPARK-21046][SQL] simplify the array offset and length ...

2017-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18260 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77900/ Test FAILed. ---

[GitHub] spark issue #18260: [SPARK-21046][SQL] simplify the array offset and length ...

2017-06-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18260 **[Test build #77900 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77900/testReport)** for PR 18260 at commit

[GitHub] spark issue #18082: [SPARK-20665][SQL][FOLLOW-UP]Move test case to MathExpre...

2017-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18082 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18082: [SPARK-20665][SQL][FOLLOW-UP]Move test case to MathExpre...

2017-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18082 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77904/ Test PASSed. ---

[GitHub] spark issue #18082: [SPARK-20665][SQL][FOLLOW-UP]Move test case to MathExpre...

2017-06-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18082 **[Test build #77904 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77904/testReport)** for PR 18082 at commit

[GitHub] spark pull request #18260: [SPARK-21046][SQL] simplify the array offset and ...

2017-06-11 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18260#discussion_r121307879 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OnHeapColumnVector.java --- @@ -42,15 +42,13 @@ // Array for each type.

[GitHub] spark issue #18230: [SPARK-19688] [STREAMING] Not to read `spark.yarn.creden...

2017-06-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18230 **[Test build #77910 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77910/testReport)** for PR 18230 at commit

[GitHub] spark pull request #18260: [SPARK-21046][SQL] simplify the array offset and ...

2017-06-11 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18260#discussion_r121307570 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OnHeapColumnVector.java --- @@ -366,55 +364,22 @@ public double getDouble(int

[GitHub] spark issue #18230: [SPARK-19688] [STREAMING] Not to read `spark.yarn.creden...

2017-06-11 Thread saturday-shi
Github user saturday-shi commented on the issue: https://github.com/apache/spark/pull/18230 No, I don't mean to insist on my opinion. I'm just curious to know the reason for the changing (as it looks like another point fix). --- If your project is set up for it, you can reply to

[GitHub] spark issue #18260: [SPARK-21046][SQL] simplify the array offset and length ...

2017-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18260 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18260: [SPARK-21046][SQL] simplify the array offset and length ...

2017-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18260 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77903/ Test PASSed. ---

[GitHub] spark pull request #18260: [SPARK-21046][SQL] simplify the array offset and ...

2017-06-11 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18260#discussion_r121306993 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OnHeapColumnVector.java --- @@ -42,15 +42,13 @@ // Array for each type.

[GitHub] spark pull request #18260: [SPARK-21046][SQL] simplify the array offset and ...

2017-06-11 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/18260#discussion_r121306979 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OnHeapColumnVector.java --- @@ -42,15 +42,13 @@ // Array for each type.

[GitHub] spark issue #18260: [SPARK-21046][SQL] simplify the array offset and length ...

2017-06-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18260 **[Test build #77903 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77903/testReport)** for PR 18260 at commit

[GitHub] spark pull request #18260: [SPARK-21046][SQL] simplify the array offset and ...

2017-06-11 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18260#discussion_r121306584 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OnHeapColumnVector.java --- @@ -42,15 +42,13 @@ // Array for each type.

[GitHub] spark issue #18128: [SPARK-20906][SparkR]:Constrained Logistic Regression fo...

2017-06-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18128 **[Test build #77909 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77909/testReport)** for PR 18128 at commit

[GitHub] spark issue #18266: [SPARK-20427][SQL] Read JDBC table use custom schema

2017-06-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18266 **[Test build #77908 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77908/testReport)** for PR 18266 at commit

[GitHub] spark issue #18260: [SPARK-21046][SQL] simplify the array offset and length ...

2017-06-11 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18260 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark pull request #18271: [MINOR][DOCS] Improve Running R Tests docs

2017-06-11 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18271#discussion_r121305976 --- Diff: docs/building-spark.md --- @@ -219,7 +219,7 @@ The run-tests script also can be limited to a specific Python version or a speci ##

[GitHub] spark issue #18266: [SPARK-20427][SQL] Read JDBC table use custom schema

2017-06-11 Thread wangyum
Github user wangyum commented on the issue: https://github.com/apache/spark/pull/18266 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #18271: [MINOR][DOCS] Improve docs to Running R Tests

2017-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18271 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18271: [MINOR][DOCS] Improve docs to Running R Tests

2017-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18271 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77907/ Test PASSed. ---

[GitHub] spark issue #18271: [MINOR][DOCS] Improve docs to Running R Tests

2017-06-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18271 **[Test build #77907 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77907/testReport)** for PR 18271 at commit

[GitHub] spark issue #18260: [SPARK-21046][SQL] simplify the array offset and length ...

2017-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18260 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77902/ Test PASSed. ---

[GitHub] spark issue #18260: [SPARK-21046][SQL] simplify the array offset and length ...

2017-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18260 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18260: [SPARK-21046][SQL] simplify the array offset and length ...

2017-06-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18260 **[Test build #77902 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77902/testReport)** for PR 18260 at commit

[GitHub] spark issue #18266: [SPARK-20427][SQL] Read JDBC table use custom schema

2017-06-11 Thread wangyum
Github user wangyum commented on the issue: https://github.com/apache/spark/pull/18266 retest please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #18199: [SPARK-20979][SS]Add RateSource to generate values for t...

2017-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18199 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77901/ Test PASSed. ---

[GitHub] spark issue #18199: [SPARK-20979][SS]Add RateSource to generate values for t...

2017-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18199 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18199: [SPARK-20979][SS]Add RateSource to generate values for t...

2017-06-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18199 **[Test build #77901 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77901/testReport)** for PR 18199 at commit

[GitHub] spark issue #18271: [MINOR][DOCS] Improve docs to Running R Tests

2017-06-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18271 **[Test build #77907 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77907/testReport)** for PR 18271 at commit

[GitHub] spark pull request #18271: [MINOR][DOCS] Improve docs to Running R Tests

2017-06-11 Thread wangyum
GitHub user wangyum opened a pull request: https://github.com/apache/spark/pull/18271 [MINOR][DOCS] Improve docs to Running R Tests ## What changes were proposed in this pull request? `install.packages(testthat)` should be `install.packages("testthat")`, otherwise: ```

[GitHub] spark pull request #18260: [SPARK-21046][SQL] simplify the array offset and ...

2017-06-11 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18260#discussion_r121303857 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OffHeapColumnVector.java --- @@ -438,10 +401,8 @@ public void

[GitHub] spark pull request #18260: [SPARK-21046][SQL] simplify the array offset and ...

2017-06-11 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18260#discussion_r121303697 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OffHeapColumnVector.java --- @@ -438,10 +401,8 @@ public void

[GitHub] spark issue #18236: [SPARK-21015] Check field name is not null and empty in ...

2017-06-11 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/spark/pull/18236 @rxin @HyukjinKwon Thank you looking into this PR :D Maybe I don't make it clearly : `GenericRowWithSchema` fetch field with field name and the field name shouldn't null or empty .

[GitHub] spark pull request #18257: [SPARK-21041][SQL] SparkSession.range should be c...

2017-06-11 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/18257#discussion_r121302955 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala --- @@ -347,8 +347,12 @@ case class RangeExec(range:

[GitHub] spark issue #18257: [SPARK-21041][SQL] SparkSession.range should be consiste...

2017-06-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18257 **[Test build #77906 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77906/testReport)** for PR 18257 at commit

[GitHub] spark issue #18258: [SPARK-21051][SQL] Add hash map metrics to aggregate

2017-06-11 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18258 cc @cloud-fan @gatorsmile for review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18260: [SPARK-21046][SQL] simplify the array offset and length ...

2017-06-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18260 **[Test build #77905 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77905/testReport)** for PR 18260 at commit

[GitHub] spark issue #18230: [SPARK-19688] [STREAMING] Not to read `spark.yarn.creden...

2017-06-11 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/18230 I don't agree with your point of view, there's already some potential issues regarding to internal configurations, either they will potentially lead to unexpected state, either they're

[GitHub] spark issue #18260: [SPARK-21046][SQL] simplify the array offset and length ...

2017-06-11 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/18260 LGTM except for one comment, pending Jenkins. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #17955: [SPARK-20715] Store MapStatuses only in MapOutput...

2017-06-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17955 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #17955: [SPARK-20715] Store MapStatuses only in MapOutputTracker...

2017-06-11 Thread JoshRosen
Github user JoshRosen commented on the issue: https://github.com/apache/spark/pull/17955 I've merged this to master (2.3.0). Thanks to everyone who helped to review. If there is additional feedback at this point then I'll address it in a quick followup. --- If your project

[GitHub] spark issue #18082: [SPARK-20665][SQL][FOLLOW-UP]Move test case to MathExpre...

2017-06-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18082 **[Test build #77904 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77904/testReport)** for PR 18082 at commit

[GitHub] spark issue #18230: [SPARK-19688] [STREAMING] Not to read `spark.yarn.creden...

2017-06-11 Thread saturday-shi
Github user saturday-shi commented on the issue: https://github.com/apache/spark/pull/18230 @jerryshao Sorry for the delay. Currently, Spark checkpoint ALL the configurations no matter it is "internal" or not. So we have to reload ones that should be updated at launching.

[GitHub] spark pull request #18260: [SPARK-21046][SQL] simplify the array offset and ...

2017-06-11 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/18260#discussion_r121298160 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/vectorized/ColumnarBatchSuite.scala --- @@ -659,18 +659,18 @@ class ColumnarBatchSuite

[GitHub] spark issue #18260: [SPARK-21046][SQL] simplify the array offset and length ...

2017-06-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18260 **[Test build #77903 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77903/testReport)** for PR 18260 at commit

[GitHub] spark pull request #18260: [SPARK-21046][SQL] simplify the array offset and ...

2017-06-11 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/18260#discussion_r121297255 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OffHeapColumnVector.java --- @@ -438,10 +401,9 @@ public void

[GitHub] spark issue #18257: [SPARK-21041][SQL] SparkSession.range should be consiste...

2017-06-11 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/18257 I see, @cloud-fan. I'll update like that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #18260: [SPARK-21046][SQL] simplify the array offset and length ...

2017-06-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18260 **[Test build #77902 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77902/testReport)** for PR 18260 at commit

[GitHub] spark pull request #18260: [SPARK-21046][SQL] simplify the array offset and ...

2017-06-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18260#discussion_r121296861 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OnHeapColumnVector.java --- @@ -366,55 +364,23 @@ public double getDouble(int

[GitHub] spark pull request #18260: [SPARK-21046][SQL] simplify the array offset and ...

2017-06-11 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/18260#discussion_r121296826 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OffHeapColumnVector.java --- @@ -438,10 +401,9 @@ public void

[GitHub] spark pull request #18260: [SPARK-21046][SQL] simplify the array offset and ...

2017-06-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18260#discussion_r121296821 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OnHeapColumnVector.java --- @@ -366,55 +364,23 @@ public double getDouble(int

[GitHub] spark issue #18238: [SPARK-21016][core]Improve code fault tolerance for conv...

2017-06-11 Thread 10110346
Github user 10110346 commented on the issue: https://github.com/apache/spark/pull/18238 @HyukjinKwon I agree with you ,but i think if add `trim`', it would be better --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request #18260: [SPARK-21046][SQL] simplify the array offset and ...

2017-06-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18260#discussion_r121296775 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OffHeapColumnVector.java --- @@ -438,10 +401,9 @@ public void

[GitHub] spark issue #18259: [SPARK-21006][TESTS][FOLLOW-UP]Some Worker's RpcEnv is l...

2017-06-11 Thread 10110346
Github user 10110346 commented on the issue: https://github.com/apache/spark/pull/18259 @srowen Thanks. I have checked in the whole project,there are no more related changes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #18257: [SPARK-21041][SQL] SparkSession.range should be consiste...

2017-06-11 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18257 is it very hard? Seems we can just output 0-partition RDD for invalid parameters in `RangeExec`. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request #16986: [SPARK-18891][SQL] Support for Scala Map collecti...

2017-06-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16986 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #18009: [SPARK-18891][SQL] Support for specific Java List...

2017-06-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18009 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

  1   2   3   >