Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18852
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80292/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18852
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/18769#discussion_r131534966
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/SetCommand.scala
---
@@ -87,6 +88,13 @@ case class SetCommand(kv: Option[(String,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18852
**[Test build #80292 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80292/testReport)**
for PR 18852 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18769#discussion_r131534846
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/SetCommand.scala
---
@@ -87,6 +88,13 @@ case class SetCommand(kv:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18856
To cut this short, it was ...
- 3.3.2 release for Linux only
- Gives the latest as 3.3.2 and the download link for 3.3.1 becomes
`windows/base/old`
- 3.3.2 release for WIndows
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18856
Ah, I meant, the PR I linked actually describes a case when we were using
3.3.1 but it was broken after 3.3.2 release. The reason was, 3.3.2 was released
but 3.3.2 for Windows was not synced
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18856
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80291/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18856
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18856
**[Test build #80291 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80291/testReport)**
for PR 18856 at commit
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/18856
It's the latest but it's not new - 3.4.1 was release a month ago. I think
there shouldn't be the sync problem.
---
If your project is set up for it, you can reply to this email and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18576
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80293/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18576
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18576
**[Test build #80293 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80293/testReport)**
for PR 18576 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18856
@felixcheung, BTW, I think optionally we could also consider setting it
3.4.0 a bit more conservatively for now. There was a rather minor problem for
using the latest version (see
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/18852
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18852#discussion_r131534323
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala ---
@@ -270,4 +270,15 @@ class SQLConfSuite extends QueryTest with
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18852#discussion_r131534296
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala ---
@@ -270,4 +270,15 @@ class SQLConfSuite extends QueryTest with
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18852#discussion_r131534275
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala ---
@@ -270,4 +270,15 @@ class SQLConfSuite extends QueryTest with
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18724
ping @LucaCanali
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18852#discussion_r131534246
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala ---
@@ -270,4 +270,15 @@ class SQLConfSuite extends QueryTest with
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18852#discussion_r131534235
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala ---
@@ -270,4 +270,15 @@ class SQLConfSuite extends QueryTest with
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18852#discussion_r131534222
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala ---
@@ -270,4 +270,15 @@ class SQLConfSuite extends QueryTest with
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r131534214
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -502,69 +503,311 @@ case class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18852#discussion_r131534217
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala ---
@@ -270,4 +270,15 @@ class SQLConfSuite extends QueryTest with
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r131534204
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -1121,6 +1125,30 @@ class AstBuilder(conf: SQLConf)
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r131534200
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -1108,7 +1108,11 @@ class AstBuilder(conf: SQLConf)
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r131534165
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2658,4 +2659,23 @@ class SQLQuerySuite extends QueryTest with
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r131534145
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -1121,6 +1125,30 @@ class AstBuilder(conf: SQLConf)
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18852#discussion_r131534140
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala ---
@@ -270,4 +270,15 @@ class SQLConfSuite extends QueryTest with
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r131534107
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -1121,6 +1125,30 @@ class AstBuilder(conf: SQLConf)
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r131534098
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -1121,6 +1125,30 @@ class AstBuilder(conf: SQLConf)
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18831
Thanks both for the comments. Yes, I think it's be to keep this PR on
offset and we can address the other improvements later.
---
If your project is set up for it, you can reply to this
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18857
**[Test build #80294 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80294/testReport)**
for PR 18857 at commit
GitHub user maropu opened a pull request:
https://github.com/apache/spark/pull/18857
[SPARK-20963][SQL][FOLLOW-UP] Use UnresolvedSubqueryColumnAliases for
visitTableName
## What changes were proposed in this pull request?
This pr (follow-up of #18772) used
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r131533855
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2304,7 +2304,15 @@ object functions {
* @group string_funcs
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18576
**[Test build #80293 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80293/testReport)**
for PR 18576 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/18772
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/18772
Thanks! I'll make a pr later to fix
[this](https://github.com/apache/spark/pull/18772#issuecomment-318967315) as
follow-up.
---
If your project is set up for it, you can reply to this email and
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18772
Thanks! Merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18852
LGTM pending Jenkins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18790#discussion_r131533778
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -872,6 +886,25 @@ object PushDownPredicate extends
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/18576
Yea, if we can do so, I feel it might be the best. I'll check if we can
remove nullability update in `FilterExec`.
---
If your project is set up for it, you can reply to this email and have your
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18852
**[Test build #80292 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80292/testReport)**
for PR 18852 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18772
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18772
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80290/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18772
**[Test build #80290 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80290/testReport)**
for PR 18772 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18576
If we can update the nullability in Optimizer rules, do we still need to do
it in `FilterExec`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18856
**[Test build #80291 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80291/testReport)**
for PR 18856 at commit
GitHub user felixcheung opened a pull request:
https://github.com/apache/spark/pull/18856
[SPARKR][BUILD] AppVeyor change to latest R version
## What changes were proposed in this pull request?
R version update
## How was this patch tested?
AppVeyor
You
Github user goldmedal closed the pull request at:
https://github.com/apache/spark/pull/18854
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user goldmedal commented on the issue:
https://github.com/apache/spark/pull/18854
@gatorsmile @viirya Thanks a lot. You are right. I close it for now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/18576
@gatorsmile If you get time, could you also check this? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18772
LGTM pending Jenkins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18841#discussion_r131532373
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -170,29 +193,29 @@ case class Pi() extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18841#discussion_r131532351
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -170,29 +193,29 @@ case class Pi() extends
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/18854
Ok. I think this should not be a problem. We should close this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18854#discussion_r131532208
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -396,6 +396,8 @@ case class Or(left: Expression,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18772
**[Test build #80290 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80290/testReport)**
for PR 18772 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18772
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18664#discussion_r131532115
--- Diff: python/pyspark/sql/tests.py ---
@@ -3036,6 +3052,9 @@ def test_toPandas_arrow_toggle(self):
pdf = df.toPandas()
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/18668
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18668
Thanks everyone! Merging it to master.
If any other comment, we can address it in the follow-up PRs.
---
If your project is set up for it, you can reply to this email and have your
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18854#discussion_r131532024
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -396,6 +396,8 @@ case class Or(left:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18854#discussion_r131531879
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -396,6 +396,8 @@ case class Or(left: Expression,
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18854#discussion_r131531690
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -396,6 +396,8 @@ case class Or(left: Expression,
Github user guoxiaolongzte closed the pull request at:
https://github.com/apache/spark/pull/18815
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user guoxiaolongzte closed the pull request at:
https://github.com/apache/spark/pull/18829
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18854#discussion_r131530967
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -396,6 +396,8 @@ case class Or(left:
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/18851#discussion_r131530034
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -643,6 +657,27 @@ case class
Github user eyalfa commented on the issue:
https://github.com/apache/spark/pull/18855
@rxin, @JoshRosen , @cloud-fan ,
you seem to be the last guys to touch this class, can you please review?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18855
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user facaiy commented on a diff in the pull request:
https://github.com/apache/spark/pull/18763#discussion_r131529768
--- Diff: python/pyspark/ml/classification.py ---
@@ -1423,7 +1425,18 @@ def _fit(self, dataset):
numClasses = int(dataset.agg({labelCol:
GitHub user eyalfa opened a pull request:
https://github.com/apache/spark/pull/18855
[Spark 3151][Block Manager] DiskStore.getBytes fails for files larger than
2GB
## What changes were proposed in this pull request?
introduced `DiskBlockData`, a new implementation of
Github user facaiy commented on a diff in the pull request:
https://github.com/apache/spark/pull/18764#discussion_r131529693
--- Diff: python/pyspark/ml/classification.py ---
@@ -1344,7 +1346,19 @@ def _fit(self, dataset):
numClasses = int(dataset.agg({labelCol:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18790
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80289/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18790
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18790
**[Test build #80289 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80289/testReport)**
for PR 18790 at commit
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/18828#discussion_r131529489
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/SparkPlanSuite.scala ---
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18668
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18668
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80288/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18668
**[Test build #80288 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80288/testReport)**
for PR 18668 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/18460
Hi, @cloud-fan and @gatorsmile .
Could you review this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18790
**[Test build #80289 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80289/testReport)**
for PR 18790 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18790
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18668
LGTM pending Jenkins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/18844
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18844
Thanks! Merging to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18852
LGTM except a comment in test cases.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18852#discussion_r131527017
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala ---
@@ -270,4 +270,10 @@ class SQLConfSuite extends QueryTest with
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18854#discussion_r131526168
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -396,6 +396,8 @@ case class Or(left:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18828
There is another zero argument
[ResetCommand](https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/command/SetCommand.scala#L155)
---
If your
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/18749
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18749
LGTM.
Thanks! Merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18668
**[Test build #80288 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80288/testReport)**
for PR 18668 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18668
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/18831
@felixcheung Sorry for misunderstand, I agree we can support
```df$myoffset``` as well, the requirement make sense for R users. Let's create
a separate JIRA to track it and do this change for
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/18841#discussion_r131525404
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -170,29 +193,29 @@ case class Pi() extends
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/18831
To be clear, I'm not suggesting to rename the parameter. I'm suggest we
should support the type being passed in as column like df$myoffset in addition
to it being a string. This will be more R
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/18797#discussion_r131524755
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/optimization/LBFGSSuite.scala ---
@@ -191,8 +191,8 @@ class LBFGSSuite extends SparkFunSuite with
1 - 100 of 213 matches
Mail list logo
