[GitHub] spark issue #19111: [SPARK-21801][SPARKR][TEST][WIP] set random seed for pre...

2017-09-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19111 **[Test build #81355 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81355/testReport)** for PR 19111 at commit

[GitHub] spark issue #19111: [SPARK-21801][SPARKR][TEST][WIP] set random seed for pre...

2017-09-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19111 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #19018: [SPARK-21801][SPARKR][TEST] unit test randomly fail with...

2017-09-03 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/19018 #19111 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark issue #19111: [SPARK-21801][SPARKR][TEST][WIP] set random seed for pre...

2017-09-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19111 **[Test build #81355 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81355/testReport)** for PR 19111 at commit

[GitHub] spark pull request #19111: [SPARK-21801][SPARKR][TEST][WIP] set random seed ...

2017-09-03 Thread felixcheung
GitHub user felixcheung opened a pull request: https://github.com/apache/spark/pull/19111 [SPARK-21801][SPARKR][TEST][WIP] set random seed for predictable test ## What changes were proposed in this pull request? set.seed() before running tests ## How was this patch

[GitHub] spark issue #19082: [SPARK-21870][SQL] Split aggregation code into small fun...

2017-09-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19082 **[Test build #81354 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81354/testReport)** for PR 19082 at commit

[GitHub] spark issue #19082: [SPARK-21870][SQL] Split aggregation code into small fun...

2017-09-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19082 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #19082: [SPARK-21870][SQL] Split aggregation code into small fun...

2017-09-03 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/19082 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #19082: [SPARK-21870][SQL] Split aggregation code into small fun...

2017-09-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19082 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81351/ Test FAILed. ---

[GitHub] spark issue #19082: [SPARK-21870][SQL] Split aggregation code into small fun...

2017-09-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19082 **[Test build #81351 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81351/testReport)** for PR 19082 at commit

[GitHub] spark issue #19110: [SPARK-21027][ML][PYTHON] Added tunable parallelism to o...

2017-09-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19110 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81352/ Test PASSed. ---

[GitHub] spark issue #19110: [SPARK-21027][ML][PYTHON] Added tunable parallelism to o...

2017-09-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19110 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #19110: [SPARK-21027][ML][PYTHON] Added tunable parallelism to o...

2017-09-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19110 **[Test build #81352 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81352/testReport)** for PR 19110 at commit

[GitHub] spark issue #19018: [SPARK-21801][SPARKR][TEST] unit test randomly fail with...

2017-09-03 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/19018 ouch. I think this is because ``` # Test unseen labels data <- data.frame(clicked = base::sample(c(0, 1), 10, replace = TRUE), someString = base::sample(c("this", "that"), 10,

[GitHub] spark pull request #18869: [SPARK-21654][SQL] Complement SQL predicates expr...

2017-09-03 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18869#discussion_r136709446 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/PredicateSuite.scala --- @@ -151,29 +151,63 @@ class PredicateSuite extends

[GitHub] spark issue #18869: [SPARK-21654][SQL] Complement SQL predicates expression ...

2017-09-03 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18869 @gatorsmile As I said in https://github.com/apache/spark/pull/18869#discussion_r136706025, we already have tests in `ExpressionTypeCheckingSuite` to check the predicates don't support map type. Do

[GitHub] spark issue #18869: [SPARK-21654][SQL] Complement SQL predicates expression ...

2017-09-03 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18869 Could you also add negative test cases for map? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #19109: Update index.md

2017-09-03 Thread demoonism
Github user demoonism commented on a diff in the pull request: https://github.com/apache/spark/pull/19109#discussion_r136709158 --- Diff: docs/index.md --- @@ -24,7 +24,7 @@ source, visit [Building Spark](building-spark.html). Spark runs on both Windows and UNIX-like

[GitHub] spark pull request #18869: [SPARK-21654][SQL] Complement SQL predicates expr...

2017-09-03 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18869#discussion_r136709144 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/PredicateSuite.scala --- @@ -151,29 +151,63 @@ class PredicateSuite

[GitHub] spark issue #18869: [SPARK-21654][SQL] Complement SQL predicates expression ...

2017-09-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18869 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81349/ Test PASSed. ---

[GitHub] spark issue #18869: [SPARK-21654][SQL] Complement SQL predicates expression ...

2017-09-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18869 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18869: [SPARK-21654][SQL] Complement SQL predicates expression ...

2017-09-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18869 **[Test build #81349 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81349/testReport)** for PR 18869 at commit

[GitHub] spark issue #18869: [SPARK-21654][SQL] Complement SQL predicates expression ...

2017-09-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18869 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18869: [SPARK-21654][SQL] Complement SQL predicates expression ...

2017-09-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18869 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81348/ Test PASSed. ---

[GitHub] spark issue #18869: [SPARK-21654][SQL] Complement SQL predicates expression ...

2017-09-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18869 **[Test build #81348 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81348/testReport)** for PR 18869 at commit

[GitHub] spark issue #18865: [SPARK-21610][SQL] Corrupt records are not handled prope...

2017-09-03 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18865 After looking the change, found another two points we should address. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request #18865: [SPARK-21610][SQL] Corrupt records are not handle...

2017-09-03 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18865#discussion_r136709025 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonFileFormat.scala --- @@ -114,6 +114,17 @@ class JsonFileFormat

[GitHub] spark issue #18865: [SPARK-21610][SQL] Corrupt records are not handled prope...

2017-09-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18865 **[Test build #81353 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81353/testReport)** for PR 18865 at commit

[GitHub] spark issue #18865: [SPARK-21610][SQL] Corrupt records are not handled prope...

2017-09-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18865 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81353/ Test FAILed. ---

[GitHub] spark issue #18865: [SPARK-21610][SQL] Corrupt records are not handled prope...

2017-09-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18865 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #18865: [SPARK-21610][SQL] Corrupt records are not handle...

2017-09-03 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18865#discussion_r136708996 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonFileFormat.scala --- @@ -114,6 +114,17 @@ class JsonFileFormat

[GitHub] spark issue #18865: [SPARK-21610][SQL] Corrupt records are not handled prope...

2017-09-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18865 **[Test build #81353 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81353/testReport)** for PR 18865 at commit

[GitHub] spark issue #18865: [SPARK-21610][SQL] Corrupt records are not handled prope...

2017-09-03 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18865 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #18865: [SPARK-21610][SQL] Corrupt records are not handled prope...

2017-09-03 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18865 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

<    1   2   3