[GitHub] spark issue #18950: [SPARK-20589][Core][Scheduler] Allow limiting task concu...

2017-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18950 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81464/ Test PASSed. ---

[GitHub] spark issue #18950: [SPARK-20589][Core][Scheduler] Allow limiting task concu...

2017-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18950 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #18950: [SPARK-20589][Core][Scheduler] Allow limiting task concu...

2017-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18950 **[Test build #81464 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81464/testReport)** for PR 18950 at commit

[GitHub] spark pull request #19077: [SPARK-21860][core]Improve memory reuse for heap ...

2017-09-06 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/19077#discussion_r137361142 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/memory/HeapMemoryAllocator.java --- @@ -47,23 +47,29 @@ private boolean shouldPool(long

[GitHub] spark issue #18339: [SPARK-21094][PYTHON] Add popen_kwargs to launch_gateway

2017-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18339 **[Test build #81472 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81472/testReport)** for PR 18339 at commit

[GitHub] spark pull request #18339: [SPARK-21094][PYTHON] Add popen_kwargs to launch_...

2017-09-06 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/18339#discussion_r137360888 --- Diff: python/pyspark/java_gateway.py --- @@ -33,14 +33,18 @@ from pyspark.serializers import read_int -def

[GitHub] spark pull request #18339: [SPARK-21094][PYTHON] Add popen_kwargs to launch_...

2017-09-06 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/18339#discussion_r137360945 --- Diff: python/pyspark/java_gateway.py --- @@ -33,14 +33,18 @@ from pyspark.serializers import read_int -def

[GitHub] spark issue #18339: [SPARK-21094][PYTHON] Add popen_kwargs to launch_gateway

2017-09-06 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/18339 Jenkins ok to test. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #18982: [SPARK-21685][PYTHON][ML] PySpark Params isSet state sho...

2017-09-06 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/18982 @BryanCutler sorry my slowness, responded with a note on the tests. If you have a chance to update the test and update to master I'd love to try and get this in. ---

[GitHub] spark pull request #18982: [SPARK-21685][PYTHON][ML] PySpark Params isSet st...

2017-09-06 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/18982#discussion_r137360294 --- Diff: python/pyspark/ml/wrapper.py --- @@ -118,11 +118,13 @@ def _transfer_params_to_java(self): """ Transforms the embedded

[GitHub] spark pull request #18982: [SPARK-21685][PYTHON][ML] PySpark Params isSet st...

2017-09-06 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/18982#discussion_r137360175 --- Diff: python/pyspark/ml/tests.py --- @@ -455,6 +455,14 @@ def test_logistic_regression_check_thresholds(self): LogisticRegression,

[GitHub] spark pull request #19148: [SPARK-21936][SQL][WIP] backward compatibility te...

2017-09-06 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19148#discussion_r137357440 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala --- @@ -0,0 +1,199 @@ +/* + * Licensed to

[GitHub] spark pull request #19148: [SPARK-21936][SQL][WIP] backward compatibility te...

2017-09-06 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19148#discussion_r137357402 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala --- @@ -0,0 +1,199 @@ +/* + * Licensed to

[GitHub] spark issue #19148: [SPARK-21936][SQL][WIP] backward compatibility test fram...

2017-09-06 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19148 The test cases pass in my local environment when I run this test suite individually. It took 4 mins. It is not too bad. ``` [info] Run completed in 4 minutes, 25 seconds. [info] Total

[GitHub] spark issue #19140: [SPARK-21890] Credentials not being passed to add the to...

2017-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19140 **[Test build #81471 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81471/testReport)** for PR 19140 at commit

[GitHub] spark issue #19140: [SPARK-21890] Credentials not being passed to add the to...

2017-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19140 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19140: [SPARK-21890] Credentials not being passed to add the to...

2017-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19140 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81471/ Test FAILed. ---

[GitHub] spark issue #19140: [SPARK-21890] Credentials not being passed to add the to...

2017-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19140 **[Test build #81471 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81471/testReport)** for PR 19140 at commit

[GitHub] spark issue #19140: [SPARK-21890] Credentials not being passed to add the to...

2017-09-06 Thread redsanket
Github user redsanket commented on the issue: https://github.com/apache/spark/pull/19140 Added principal check back and tested in secure hadoop env. Let me know if this looks fine with you @jerryshao @vanzin @tgravescs ---

[GitHub] spark pull request #19056: [SPARK-21765] Check that optimization doesn't aff...

2017-09-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19056 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19149: [SPARK-21652][SQL][FOLLOW-UP] Fix rule confliction betwe...

2017-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19149 **[Test build #81470 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81470/testReport)** for PR 19149 at commit

[GitHub] spark issue #19149: [SPARK-21652][SQL][FOLLOW-UP] Fix rule confliction betwe...

2017-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19149 **[Test build #81469 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81469/testReport)** for PR 19149 at commit

[GitHub] spark pull request #19149: [SPARK-21652][SQL][FOLLOW-UP] Fix rule conflictio...

2017-09-06 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/19149 [SPARK-21652][SQL][FOLLOW-UP] Fix rule confliction between InferFiltersFromConstraints and ConstantPropagation ## What changes were proposed in this pull request? The two rules

[GitHub] spark issue #19148: [SPARK-21936][SQL][WIP] backward compatibility test fram...

2017-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19148 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19148: [SPARK-21936][SQL][WIP] backward compatibility test fram...

2017-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19148 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81465/ Test FAILed. ---

[GitHub] spark issue #19148: [SPARK-21936][SQL][WIP] backward compatibility test fram...

2017-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19148 **[Test build #81465 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81465/testReport)** for PR 19148 at commit

[GitHub] spark pull request #18029: [SPARK-20168] [DStream] Add changes to use kinesi...

2017-09-06 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/18029#discussion_r137343555 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/InitialPosition.scala --- @@ -0,0 +1,104 @@ +/* + * Licensed to

[GitHub] spark issue #18975: [SPARK-4131] Support "Writing data into the filesystem f...

2017-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18975 **[Test build #81468 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81468/testReport)** for PR 18975 at commit

[GitHub] spark pull request #18692: [SPARK-21417][SQL] Infer join conditions using pr...

2017-09-06 Thread aokolnychyi
Github user aokolnychyi commented on a diff in the pull request: https://github.com/apache/spark/pull/18692#discussion_r137343500 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala --- @@ -152,3 +152,71 @@ object EliminateOuterJoin extends

[GitHub] spark pull request #18692: [SPARK-21417][SQL] Infer join conditions using pr...

2017-09-06 Thread aokolnychyi
Github user aokolnychyi commented on a diff in the pull request: https://github.com/apache/spark/pull/18692#discussion_r137343433 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala --- @@ -152,3 +152,71 @@ object EliminateOuterJoin extends

[GitHub] spark pull request #18029: [SPARK-20168] [DStream] Add changes to use kinesi...

2017-09-06 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/18029#discussion_r137342850 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/InitialPosition.scala --- @@ -0,0 +1,104 @@ +/* + * Licensed to

[GitHub] spark issue #18975: [SPARK-4131] Support "Writing data into the filesystem f...

2017-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18975 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #18975: [SPARK-4131] Support "Writing data into the filesystem f...

2017-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18975 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81462/ Test FAILed. ---

[GitHub] spark issue #19141: [SPARK-21384] [YARN] Spark + YARN fails with LocalFileSy...

2017-09-06 Thread devaraj-kavali
Github user devaraj-kavali commented on the issue: https://github.com/apache/spark/pull/19141 Thanks @jerryshao for looking into this PR. > Can you please describe your usage scenario and steps to reproduce your issue, from my understanding. Did you configure your default FS

[GitHub] spark issue #18975: [SPARK-4131] Support "Writing data into the filesystem f...

2017-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18975 **[Test build #81462 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81462/testReport)** for PR 18975 at commit

[GitHub] spark issue #18875: [SPARK-21513][SQL] Allow UDF to_json support converting ...

2017-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18875 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81461/ Test PASSed. ---

[GitHub] spark issue #18875: [SPARK-21513][SQL] Allow UDF to_json support converting ...

2017-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18875 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #18875: [SPARK-21513][SQL] Allow UDF to_json support converting ...

2017-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18875 **[Test build #81461 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81461/testReport)** for PR 18875 at commit

[GitHub] spark pull request #19140: [SPARK-21890] Credentials not being passed to add...

2017-09-06 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19140#discussion_r137334603 --- Diff: core/src/main/scala/org/apache/spark/deploy/security/HadoopFSDelegationTokenProvider.scala --- @@ -103,15 +103,17 @@ private[deploy] class

[GitHub] spark pull request #19136: [DO NOT MERGE][SPARK-15689][SQL] data source v2

2017-09-06 Thread RussellSpitzer
Github user RussellSpitzer commented on a diff in the pull request: https://github.com/apache/spark/pull/19136#discussion_r137333974 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/DataSourceV2Reader.java --- @@ -0,0 +1,126 @@ +/* + * Licensed to

[GitHub] spark issue #18515: [SPARK-21287][SQL] Ability to use Integer.MIN_VALUE as a...

2017-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18515 **[Test build #81467 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81467/testReport)** for PR 18515 at commit

[GitHub] spark issue #18538: [SPARK-14516][ML] Adding ClusteringEvaluator with the im...

2017-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18538 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #18538: [SPARK-14516][ML] Adding ClusteringEvaluator with the im...

2017-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18538 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81463/ Test PASSed. ---

[GitHub] spark issue #18538: [SPARK-14516][ML] Adding ClusteringEvaluator with the im...

2017-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18538 **[Test build #81463 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81463/testReport)** for PR 18538 at commit

[GitHub] spark issue #19136: [DO NOT MERGE][SPARK-15689][SQL] data source v2

2017-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19136 **[Test build #81466 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81466/testReport)** for PR 19136 at commit

[GitHub] spark pull request #19111: [SPARK-21801][SPARKR][TEST] set random seed for p...

2017-09-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19111 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19136: [DO NOT MERGE][SPARK-15689][SQL] data source v2

2017-09-06 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19136 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19111: [SPARK-21801][SPARKR][TEST] set random seed for predicta...

2017-09-06 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/19111 merged to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19148: [SPARK-21936][SQL][WIP] backward compatibility test fram...

2017-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19148 **[Test build #81465 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81465/testReport)** for PR 19148 at commit

[GitHub] spark issue #19148: [SPARK-21936][SQL][WIP] backward compatibility test fram...

2017-09-06 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19148 cc @gatorsmile --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19148: [SPARK-21936][SQL][WIP] backward compatibility te...

2017-09-06 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/19148 [SPARK-21936][SQL][WIP] backward compatibility test framework for HiveExternalCatalog ## What changes were proposed in this pull request? `HiveExternalCatalog` is a semi-public

[GitHub] spark issue #18956: [SPARK-21726][SQL] Check for structural integrity of the...

2017-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18956 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #18956: [SPARK-21726][SQL] Check for structural integrity of the...

2017-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18956 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81460/ Test FAILed. ---

[GitHub] spark issue #19110: [SPARK-21027][ML][PYTHON] Added tunable parallelism to o...

2017-09-06 Thread BryanCutler
Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/19110 LGTM! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #18956: [SPARK-21726][SQL] Check for structural integrity of the...

2017-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18956 **[Test build #81460 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81460/testReport)** for PR 18956 at commit

[GitHub] spark issue #19147: [WIP][SPARK-21190][SQL][PYTHON] Vectorized UDFs in Pytho...

2017-09-06 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/19147 relaying my questions from the dev@ thread: +1 for type in string form. Would it be correct to assume there will be data type check, for example the returned pandas data frame

[GitHub] spark issue #18875: [SPARK-21513][SQL] Allow UDF to_json support converting ...

2017-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18875 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81458/ Test PASSed. ---

[GitHub] spark issue #18875: [SPARK-21513][SQL] Allow UDF to_json support converting ...

2017-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18875 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #18875: [SPARK-21513][SQL] Allow UDF to_json support converting ...

2017-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18875 **[Test build #81458 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81458/testReport)** for PR 18875 at commit

[GitHub] spark issue #19126: [SPARK-21915][ML][PySpark]Model 1 and Model 2 ParamMaps ...

2017-09-06 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19126 No, no change has been made. @BryanCutler suggests that the change isn't needed in `master` but could be applied to `branch-2.2`. To do that you need to reopen a new PR against that branch. It still

[GitHub] spark issue #18950: [SPARK-20589][Core][Scheduler] Allow limiting task concu...

2017-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18950 **[Test build #81464 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81464/testReport)** for PR 18950 at commit

[GitHub] spark issue #19126: [SPARK-21915][ML][PySpark]Model 1 and Model 2 ParamMaps ...

2017-09-06 Thread marktab
Github user marktab commented on the issue: https://github.com/apache/spark/pull/19126 @srowen since I am a new to this review process, should I be seeing the change at http://spark.apache.org/docs/latest/ml-pipeline.html ---

[GitHub] spark issue #18950: [SPARK-20589][Core][Scheduler] Allow limiting task concu...

2017-09-06 Thread tgravescs
Github user tgravescs commented on the issue: https://github.com/apache/spark/pull/18950 Jenkins, test this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #18538: [SPARK-14516][ML] Adding ClusteringEvaluator with the im...

2017-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18538 **[Test build #81463 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81463/testReport)** for PR 18538 at commit

[GitHub] spark pull request #18538: [SPARK-14516][ML] Adding ClusteringEvaluator with...

2017-09-06 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/18538#discussion_r137310194 --- Diff: mllib/src/test/scala/org/apache/spark/ml/evaluation/ClusteringEvaluatorSuite.scala --- @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache

[GitHub] spark issue #18975: [SPARK-4131] Support "Writing data into the filesystem f...

2017-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18975 **[Test build #81462 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81462/testReport)** for PR 18975 at commit

[GitHub] spark issue #19131: [MINOR][SQL]remove unuse import class

2017-09-06 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/19131 @srowen, @jerryshao several other components, Include spark streaming, launcher,graphx,core,mllib,mllib-local, except for their tests. thanks. ---

[GitHub] spark issue #18981: Fixed pandoc dependency issue in python/setup.py

2017-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18981 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81459/ Test PASSed. ---

[GitHub] spark issue #18981: Fixed pandoc dependency issue in python/setup.py

2017-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18981 **[Test build #81459 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81459/testReport)** for PR 18981 at commit

[GitHub] spark issue #18981: Fixed pandoc dependency issue in python/setup.py

2017-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18981 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #18875: [SPARK-21513][SQL] Allow UDF to_json support converting ...

2017-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18875 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #18875: [SPARK-21513][SQL] Allow UDF to_json support converting ...

2017-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18875 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81454/ Test PASSed. ---

[GitHub] spark issue #18875: [SPARK-21513][SQL] Allow UDF to_json support converting ...

2017-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18875 **[Test build #81454 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81454/testReport)** for PR 18875 at commit

[GitHub] spark issue #18875: [SPARK-21513][SQL] Allow UDF to_json support converting ...

2017-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18875 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #18875: [SPARK-21513][SQL] Allow UDF to_json support converting ...

2017-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18875 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81455/ Test FAILed. ---

[GitHub] spark issue #18875: [SPARK-21513][SQL] Allow UDF to_json support converting ...

2017-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18875 **[Test build #81455 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81455/testReport)** for PR 18875 at commit

[GitHub] spark issue #18875: [SPARK-21513][SQL] Allow UDF to_json support converting ...

2017-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18875 **[Test build #81461 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81461/testReport)** for PR 18875 at commit

[GitHub] spark issue #18950: [SPARK-20589][Core][Scheduler] Allow limiting task concu...

2017-09-06 Thread tgravescs
Github user tgravescs commented on the issue: https://github.com/apache/spark/pull/18950 Test this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #18956: [SPARK-21726][SQL] Check for structural integrity of the...

2017-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18956 **[Test build #81460 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81460/testReport)** for PR 18956 at commit

[GitHub] spark issue #18956: [SPARK-21726][SQL] Check for structural integrity of the...

2017-09-06 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18956 retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #18956: [SPARK-21726][SQL] Check for structural integrity of the...

2017-09-06 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18956 #19050 is merged now. Let's see if there is any rule can fail this structural integrity check. --- - To unsubscribe, e-mail:

[GitHub] spark issue #19147: [WIP][SPARK-21190][SQL][PYTHON] Vectorized UDFs in Pytho...

2017-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19147 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81453/ Test FAILed. ---

[GitHub] spark issue #19147: [WIP][SPARK-21190][SQL][PYTHON] Vectorized UDFs in Pytho...

2017-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19147 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19147: [WIP][SPARK-21190][SQL][PYTHON] Vectorized UDFs in Pytho...

2017-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19147 **[Test build #81453 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81453/testReport)** for PR 19147 at commit

[GitHub] spark issue #18981: Fixed pandoc dependency issue in python/setup.py

2017-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18981 **[Test build #81459 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81459/testReport)** for PR 18981 at commit

[GitHub] spark issue #18981: Fixed pandoc dependency issue in python/setup.py

2017-09-06 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18981 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #18981: Fixed pandoc dependency issue in python/setup.py

2017-09-06 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18981 LGTM too. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19050: [SPARK-21835][SQL] RewritePredicateSubquery shoul...

2017-09-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19050 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18875: [SPARK-21513][SQL] Allow UDF to_json support conv...

2017-09-06 Thread goldmedal
Github user goldmedal commented on a diff in the pull request: https://github.com/apache/spark/pull/18875#discussion_r137288735 --- Diff: sql/core/src/test/resources/sql-tests/results/cross-join.sql.out --- @@ -128,6 +128,7 @@ two 2 two 2 one 1 two

[GitHub] spark issue #18685: [SPARK-21439] Support for ABCMeta in PySpark

2017-09-06 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18685 @maver1ck, would you mind resolving the conflicts? I will try to review this. --- - To unsubscribe, e-mail:

[GitHub] spark issue #19050: [SPARK-21835][SQL] RewritePredicateSubquery should not p...

2017-09-06 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19050 Thanks! Merging to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19147: [WIP][SPARK-21190][SQL][PYTHON] Vectorized UDFs i...

2017-09-06 Thread icexelloss
Github user icexelloss commented on a diff in the pull request: https://github.com/apache/spark/pull/19147#discussion_r137287302 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/python/VectorizedPythonRunner.scala --- @@ -0,0 +1,329 @@ +/* + * Licensed to

[GitHub] spark pull request #18875: [SPARK-21513][SQL] Allow UDF to_json support conv...

2017-09-06 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18875#discussion_r137287045 --- Diff: sql/core/src/test/resources/sql-tests/results/cross-join.sql.out --- @@ -128,6 +128,7 @@ two 2 two 2 one 1 two

[GitHub] spark pull request #19147: [WIP][SPARK-21190][SQL][PYTHON] Vectorized UDFs i...

2017-09-06 Thread icexelloss
Github user icexelloss commented on a diff in the pull request: https://github.com/apache/spark/pull/19147#discussion_r137286685 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/python/VectorizedPythonRunner.scala --- @@ -0,0 +1,329 @@ +/* + * Licensed to

[GitHub] spark pull request #18875: [SPARK-21513][SQL] Allow UDF to_json support conv...

2017-09-06 Thread goldmedal
Github user goldmedal commented on a diff in the pull request: https://github.com/apache/spark/pull/18875#discussion_r137285989 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala --- @@ -669,14 +679,25 @@ case class

[GitHub] spark issue #19146: [SPARK-21903][BUILD][FOLLOWUP] Upgrade scalastyle-maven-...

2017-09-06 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19146 Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19146: [SPARK-21903][BUILD][FOLLOWUP] Upgrade scalastyle...

2017-09-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19146 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18875: [SPARK-21513][SQL] Allow UDF to_json support conv...

2017-09-06 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18875#discussion_r137284596 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonGenerator.scala --- @@ -22,24 +22,49 @@ import java.io.Writer import

[GitHub] spark pull request #18875: [SPARK-21513][SQL] Allow UDF to_json support conv...

2017-09-06 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18875#discussion_r137284389 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala --- @@ -669,14 +679,25 @@ case class StructsToJson(

[GitHub] spark pull request #18875: [SPARK-21513][SQL] Allow UDF to_json support conv...

2017-09-06 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18875#discussion_r137283687 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonGenerator.scala --- @@ -22,24 +22,49 @@ import java.io.Writer import

<    1   2   3   4   5   >