[GitHub] spark issue #19136: [DO NOT MERGE][SPARK-15689][SQL] data source v2

2017-09-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19136 **[Test build #81510 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81510/testReport)** for PR 19136 at commit

[GitHub] spark issue #17435: [SPARK-20098][PYSPARK] dataType's typeName fix

2017-09-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17435 **[Test build #81511 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81511/testReport)** for PR 17435 at commit

[GitHub] spark issue #19086: [SPARK-21874][SQL] Support changing database when rename...

2017-09-07 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/19086 @gatorsmile I feel sorry if this pr breaks rules of current code. But I think the function is a good(convenient for user) one. In our warehouse, there hundreds ETLs are using this function

[GitHub] spark issue #19154: Fix DiskBlockManager crashing when a root local folder h...

2017-09-07 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19154 I don't think it's reasonable to handle the case where people arbitrarily delete data from under Spark. This can may be easy to fix; others won't. This also isn't how changes are proposed:

[GitHub] spark issue #19155: [MINOR][TEST] Tables created in unit tests should be dro...

2017-09-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19155 **[Test build #81509 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81509/testReport)** for PR 19155 at commit

[GitHub] spark issue #17451: [SPARK-19866][ML][PySpark] Add local version of Word2Vec...

2017-09-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17451 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #17451: [SPARK-19866][ML][PySpark] Add local version of Word2Vec...

2017-09-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17451 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81503/ Test FAILed. ---

[GitHub] spark pull request #19155: [MINOR][TEST] Tables created in unit tests should...

2017-09-07 Thread 10110346
GitHub user 10110346 opened a pull request: https://github.com/apache/spark/pull/19155 [MINOR][TEST] Tables created in unit tests should be dropped after use ## What changes were proposed in this pull request? Tables should be dropped after use in unit tests. ## How was

[GitHub] spark issue #17451: [SPARK-19866][ML][PySpark] Add local version of Word2Vec...

2017-09-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17451 **[Test build #81503 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81503/testReport)** for PR 17451 at commit

[GitHub] spark issue #19077: [SPARK-21860][core]Improve memory reuse for heap memory ...

2017-09-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19077 **[Test build #81508 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81508/testReport)** for PR 19077 at commit

[GitHub] spark issue #19154: Fix DiskBlockManager crashing when a root local folder h...

2017-09-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19154 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #19154: Fix DiskBlockManager crashing when a root local f...

2017-09-07 Thread rshest
GitHub user rshest opened a pull request: https://github.com/apache/spark/pull/19154 Fix DiskBlockManager crashing when a root local folder has been externally deleted ## What changes were proposed in this pull request? **The problem:** `DiskBlockManager has a

[GitHub] spark issue #19086: [SPARK-21874][SQL] Support changing database when rename...

2017-09-07 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/19086 I'm from Meituan, a Chinese company --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19077: [SPARK-21860][core]Improve memory reuse for heap memory ...

2017-09-07 Thread 10110346
Github user 10110346 commented on the issue: https://github.com/apache/spark/pull/19077 restest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19083: [SPARK-21871][SQL] Check actual bytecode size when compi...

2017-09-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19083 **[Test build #81507 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81507/testReport)** for PR 19083 at commit

[GitHub] spark issue #19153: SPARK-21941 Stop storing unused attemptId in SQLTaskMetr...

2017-09-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19153 **[Test build #81505 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81505/testReport)** for PR 19153 at commit

[GitHub] spark issue #19136: [DO NOT MERGE][SPARK-15689][SQL] data source v2

2017-09-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19136 **[Test build #81506 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81506/testReport)** for PR 19136 at commit

[GitHub] spark issue #19083: [SPARK-21871][SQL] Check actual bytecode size when compi...

2017-09-07 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/19083 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #18956: [SPARK-21726][SQL] Check for structural integrity of the...

2017-09-07 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18956 retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #18956: [SPARK-21726][SQL] Check for structural integrity of the...

2017-09-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18956 **[Test build #81504 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81504/testReport)** for PR 18956 at commit

[GitHub] spark pull request #19153: SPARK-21941 Stop storing unused attemptId in SQLT...

2017-09-07 Thread ash211
GitHub user ash211 opened a pull request: https://github.com/apache/spark/pull/19153 SPARK-21941 Stop storing unused attemptId in SQLTaskMetrics ## What changes were proposed in this pull request? In a driver heap dump containing 390,105 instances of SQLTaskMetrics this

[GitHub] spark issue #17451: [SPARK-19866][ML][PySpark] Add local version of Word2Vec...

2017-09-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17451 **[Test build #81503 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81503/testReport)** for PR 17451 at commit

[GitHub] spark issue #19149: [SPARK-21652][SQL][FOLLOW-UP] Fix rule conflict between ...

2017-09-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19149 **[Test build #81502 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81502/testReport)** for PR 19149 at commit

[GitHub] spark issue #19150: [SPARK-21939][TEST] Use TimeLimits instead of Timeouts

2017-09-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19150 **[Test build #81501 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81501/testReport)** for PR 19150 at commit

[GitHub] spark issue #19150: [SPARK-21939][TEST] Use TimeLimits instead of Timeouts

2017-09-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19150 **[Test build #81500 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81500/testReport)** for PR 19150 at commit

[GitHub] spark issue #19150: [SPARK-21939][TEST] Use TimeLimits instead of Timeouts

2017-09-07 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/19150 Retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

2017-09-07 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137461450 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertSuite.scala --- @@ -534,4 +534,150 @@ class InsertIntoHiveTableSuite extends QueryTest

[GitHub] spark issue #19149: [SPARK-21652][SQL][FOLLOW-UP] Fix rule conflict between ...

2017-09-07 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19149 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #17451: [SPARK-19866][ML][PySpark] Add local version of Word2Vec...

2017-09-07 Thread keypointt
Github user keypointt commented on the issue: https://github.com/apache/spark/pull/17451 Jenkins, retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #19083: [SPARK-21871][SQL] Check actual bytecode size when compi...

2017-09-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19083 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19150: [SPARK-21939][TEST] Use TimeLimits instead of Timeouts

2017-09-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19150 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19077: [SPARK-21860][core]Improve memory reuse for heap memory ...

2017-09-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19077 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19077: [SPARK-21860][core]Improve memory reuse for heap memory ...

2017-09-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19077 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81492/ Test FAILed. ---

[GitHub] spark issue #19149: [SPARK-21652][SQL][FOLLOW-UP] Fix rule conflict between ...

2017-09-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19149 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81495/ Test FAILed. ---

[GitHub] spark issue #18956: [SPARK-21726][SQL] Check for structural integrity of the...

2017-09-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18956 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #18956: [SPARK-21726][SQL] Check for structural integrity of the...

2017-09-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18956 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81496/ Test FAILed. ---

[GitHub] spark issue #19083: [SPARK-21871][SQL] Check actual bytecode size when compi...

2017-09-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19083 **[Test build #81498 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81498/testReport)** for PR 19083 at commit

[GitHub] spark issue #19150: [SPARK-21939][TEST] Use TimeLimits instead of Timeouts

2017-09-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19150 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81494/ Test FAILed. ---

[GitHub] spark issue #17451: [SPARK-19866][ML][PySpark] Add local version of Word2Vec...

2017-09-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17451 **[Test build #81499 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81499/testReport)** for PR 17451 at commit

[GitHub] spark issue #17451: [SPARK-19866][ML][PySpark] Add local version of Word2Vec...

2017-09-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17451 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19149: [SPARK-21652][SQL][FOLLOW-UP] Fix rule conflict between ...

2017-09-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19149 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19150: [SPARK-21939][TEST] Use TimeLimits instead of Timeouts

2017-09-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19150 **[Test build #81494 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81494/testReport)** for PR 19150 at commit

[GitHub] spark issue #19083: [SPARK-21871][SQL] Check actual bytecode size when compi...

2017-09-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19083 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81498/ Test FAILed. ---

[GitHub] spark issue #19077: [SPARK-21860][core]Improve memory reuse for heap memory ...

2017-09-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19077 **[Test build #81492 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81492/testReport)** for PR 19077 at commit

[GitHub] spark issue #18956: [SPARK-21726][SQL] Check for structural integrity of the...

2017-09-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18956 **[Test build #81496 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81496/testReport)** for PR 18956 at commit

[GitHub] spark issue #17451: [SPARK-19866][ML][PySpark] Add local version of Word2Vec...

2017-09-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17451 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81499/ Test FAILed. ---

[GitHub] spark issue #19149: [SPARK-21652][SQL][FOLLOW-UP] Fix rule conflict between ...

2017-09-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19149 **[Test build #81495 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81495/testReport)** for PR 19149 at commit

[GitHub] spark pull request #8676: [SPARK-9078] [SQL] Allow jdbc dialects to override...

2017-09-07 Thread toddleo
Github user toddleo commented on a diff in the pull request: https://github.com/apache/spark/pull/8676#discussion_r137460965 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala --- @@ -88,6 +88,17 @@ abstract class JdbcDialect { def

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

2017-09-07 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137460756 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/InsertIntoDataSourceDirCommand.scala --- @@ -0,0 +1,81 @@ +/* + *

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

2017-09-07 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137460842 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/InsertIntoDataSourceDirCommand.scala --- @@ -0,0 +1,81 @@ +/* + *

[GitHub] spark issue #17451: [SPARK-19866][ML][PySpark] Add local version of Word2Vec...

2017-09-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17451 **[Test build #81499 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81499/testReport)** for PR 17451 at commit

[GitHub] spark issue #17451: [SPARK-19866][ML][PySpark] Add local version of Word2Vec...

2017-09-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17451 **[Test build #81497 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81497/testReport)** for PR 17451 at commit

[GitHub] spark issue #17451: [SPARK-19866][ML][PySpark] Add local version of Word2Vec...

2017-09-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17451 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #17451: [SPARK-19866][ML][PySpark] Add local version of Word2Vec...

2017-09-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17451 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81497/ Test FAILed. ---

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

2017-09-07 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137456014 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveDirCommand.scala --- @@ -0,0 +1,138 @@ +/* + * Licensed to

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

2017-09-07 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137455829 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveDirCommand.scala --- @@ -0,0 +1,138 @@ +/* + * Licensed to

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

2017-09-07 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137455718 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveDirCommand.scala --- @@ -0,0 +1,138 @@ +/* + * Licensed to

[GitHub] spark pull request #19136: [DO NOT MERGE][SPARK-15689][SQL] data source v2

2017-09-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19136#discussion_r137455199 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/DataSourceV2Options.java --- @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

2017-09-07 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137455095 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveDirCommand.scala --- @@ -0,0 +1,138 @@ +/* + * Licensed to

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

2017-09-07 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137454780 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveTmpPath.scala --- @@ -0,0 +1,202 @@ +/* + * Licensed to the Apache

[GitHub] spark issue #19083: [SPARK-21871][SQL] Check actual bytecode size when compi...

2017-09-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19083 **[Test build #81498 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81498/testReport)** for PR 19083 at commit

[GitHub] spark pull request #19136: [DO NOT MERGE][SPARK-15689][SQL] data source v2

2017-09-07 Thread sureshthalamati
Github user sureshthalamati commented on a diff in the pull request: https://github.com/apache/spark/pull/19136#discussion_r137454044 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/DataSourceV2Options.java --- @@ -0,0 +1,56 @@ +/* + * Licensed to the

[GitHub] spark pull request #19136: [DO NOT MERGE][SPARK-15689][SQL] data source v2

2017-09-07 Thread sureshthalamati
Github user sureshthalamati commented on a diff in the pull request: https://github.com/apache/spark/pull/19136#discussion_r137453919 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/DataSourceV2Reader.java --- @@ -0,0 +1,126 @@ +/* + * Licensed to

[GitHub] spark pull request #19083: [SPARK-21871][SQL] Check actual bytecode size whe...

2017-09-07 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/19083#discussion_r137453624 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CodeGenerationSuite.scala --- @@ -98,19 +99,23 @@ class CodeGenerationSuite

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

2017-09-07 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137453643 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/sources/InsertSuite.scala --- @@ -366,4 +367,43 @@ class InsertSuite extends DataSourceTest with

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

2017-09-07 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137453352 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLParserSuite.scala --- @@ -524,6 +525,50 @@ class DDLParserSuite extends

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

2017-09-07 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137452938 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala --- @@ -140,6 +143,14 @@ case class

[GitHub] spark issue #17451: [SPARK-19866][ML][PySpark] Add local version of Word2Vec...

2017-09-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17451 **[Test build #81497 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81497/testReport)** for PR 17451 at commit

[GitHub] spark issue #18956: [SPARK-21726][SQL] Check for structural integrity of the...

2017-09-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18956 **[Test build #81496 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81496/testReport)** for PR 18956 at commit

[GitHub] spark pull request #19136: [DO NOT MERGE][SPARK-15689][SQL] data source v2

2017-09-07 Thread sureshthalamati
Github user sureshthalamati commented on a diff in the pull request: https://github.com/apache/spark/pull/19136#discussion_r137452697 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/SchemaRequiredDataSourceV2.java --- @@ -0,0 +1,42 @@ +/* + * Licensed to

[GitHub] spark issue #19151: [SPARK-21835][SQL][FOLLOW-UP] RewritePredicateSubquery s...

2017-09-07 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/19151 Thanks @gatorsmile --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

2017-09-07 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137452482 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLParserSuite.scala --- @@ -524,6 +525,50 @@ class DDLParserSuite extends

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

2017-09-07 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137452336 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLParserSuite.scala --- @@ -524,6 +525,50 @@ class DDLParserSuite extends

[GitHub] spark issue #19077: [SPARK-21860][core]Improve memory reuse for heap memory ...

2017-09-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19077 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81491/ Test PASSed. ---

[GitHub] spark issue #19077: [SPARK-21860][core]Improve memory reuse for heap memory ...

2017-09-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19077 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19077: [SPARK-21860][core]Improve memory reuse for heap memory ...

2017-09-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19077 **[Test build #81491 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81491/testReport)** for PR 19077 at commit

<    1   2   3   4