[GitHub] spark issue #19156: [SPARK-19634][FOLLOW-UP][ML] Improve interface of datafr...

2017-09-13 Thread WeichenXu123
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/19156 ping @yanboliang Any other comments ? We need merge this before 2.3 release. --- - To unsubscribe, e-mail:

[GitHub] spark issue #19132: [SPARK-21922] Fix duration always updating when task fai...

2017-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19132 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81710/ Test PASSed. ---

[GitHub] spark issue #19132: [SPARK-21922] Fix duration always updating when task fai...

2017-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19132 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19216: [SPARK-21990][SQL] QueryPlanConstraints misses some cons...

2017-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19216 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19216: [SPARK-21990][SQL] QueryPlanConstraints misses some cons...

2017-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19216 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81711/ Test FAILed. ---

[GitHub] spark issue #19132: [SPARK-21922] Fix duration always updating when task fai...

2017-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19132 **[Test build #81710 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81710/testReport)** for PR 19132 at commit

[GitHub] spark issue #19216: [SPARK-21990][SQL] QueryPlanConstraints misses some cons...

2017-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19216 **[Test build #81711 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81711/testReport)** for PR 19216 at commit

[GitHub] spark issue #19219: [SPARK-21993][SQL] Close sessionState in shutdown hook.

2017-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19219 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81713/ Test PASSed. ---

[GitHub] spark issue #19219: [SPARK-21993][SQL] Close sessionState in shutdown hook.

2017-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19219 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19219: [SPARK-21993][SQL] Close sessionState in shutdown hook.

2017-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19219 **[Test build #81713 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81713/testReport)** for PR 19219 at commit

[GitHub] spark pull request #19219: [SPARK-21993][SQL] Close sessionState in shutdown...

2017-09-13 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19219#discussion_r138585002 --- Diff: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala --- @@ -116,7 +116,10 @@ private[hive] object

[GitHub] spark issue #19219: [SPARK-21993][SQL] Close sessionState in shutdown hook.

2017-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19219 **[Test build #81713 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81713/testReport)** for PR 19219 at commit

[GitHub] spark issue #19136: [SPARK-15689][SQL] data source v2

2017-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19136 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19136: [SPARK-15689][SQL] data source v2

2017-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19136 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81712/ Test FAILed. ---

[GitHub] spark pull request #19219: [SPARK-21993][SQL] Close sessionState in shutdown...

2017-09-13 Thread jinxing64
GitHub user jinxing64 opened a pull request: https://github.com/apache/spark/pull/19219 [SPARK-21993][SQL] Close sessionState in shutdown hook. ## What changes were proposed in this pull request? In current code, `SessionState` in `SparkSQLCLIDriver` is not guaranteed to

[GitHub] spark issue #19136: [SPARK-15689][SQL] data source v2

2017-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19136 **[Test build #81712 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81712/testReport)** for PR 19136 at commit

[GitHub] spark issue #19204: [SPARK-21981][PYTHON][ML] Added Python interface for Clu...

2017-09-13 Thread WeichenXu123
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/19204 Jenkins, test this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #19186: [SPARK-21972][ML] Add param handlePersistence

2017-09-13 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/19186#discussion_r138577518 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -483,24 +488,24 @@ class LogisticRegression

[GitHub] spark issue #16578: [SPARK-4502][SQL] Parquet nested column pruning

2017-09-13 Thread vkhristenko
Github user vkhristenko commented on the issue: https://github.com/apache/spark/pull/16578 Hi, My name is Viktor and I'm working at CERN on ROOT I/O DataSource for JVM and an interface for Spark. ROOT I/O is the format that is used for CERN's LHC data. ROOT data format

[GitHub] spark issue #19068: [SPARK-21428][SQL][FOLLOWUP]CliSessionState should point...

2017-09-13 Thread yaooqinn
Github user yaooqinn commented on the issue: https://github.com/apache/spark/pull/19068 jenkins unreachable cc @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #19068: [SPARK-21428][SQL][FOLLOWUP]CliSessionState shoul...

2017-09-13 Thread yaooqinn
Github user yaooqinn commented on a diff in the pull request: https://github.com/apache/spark/pull/19068#discussion_r138557791 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala --- @@ -132,43 +134,26 @@ private[hive] class HiveClientImpl(

[GitHub] spark pull request #19068: [SPARK-21428][SQL][FOLLOWUP]CliSessionState shoul...

2017-09-13 Thread yaooqinn
Github user yaooqinn commented on a diff in the pull request: https://github.com/apache/spark/pull/19068#discussion_r138564306 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala --- @@ -231,6 +231,42 @@ private[spark] object HiveUtils extends Logging {

[GitHub] spark pull request #19068: [SPARK-21428][SQL][FOLLOWUP]CliSessionState shoul...

2017-09-13 Thread yaooqinn
Github user yaooqinn commented on a diff in the pull request: https://github.com/apache/spark/pull/19068#discussion_r138557772 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala --- @@ -231,6 +231,42 @@ private[spark] object HiveUtils extends Logging {

[GitHub] spark pull request #19068: [SPARK-21428][SQL][FOLLOWUP]CliSessionState shoul...

2017-09-13 Thread yaooqinn
Github user yaooqinn commented on a diff in the pull request: https://github.com/apache/spark/pull/19068#discussion_r138556873 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala --- @@ -231,6 +231,42 @@ private[spark] object HiveUtils extends Logging {

[GitHub] spark issue #19218: [SPARK-21786][SQL] The 'spark.sql.parquet.compression.co...

2017-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19218 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #19218: [SPARK-21786][SQL] The 'spark.sql.parquet.compres...

2017-09-13 Thread fjh100456
GitHub user fjh100456 opened a pull request: https://github.com/apache/spark/pull/19218 [SPARK-21786][SQL] The 'spark.sql.parquet.compression.codec' configuration doesn't take effect on tables with partition field(s) [SPARK-21786][SQL] The 'spark.sql.parquet.compression.codec'

[GitHub] spark issue #19206: [SPARK-19206][yarn]Client and ApplicationMaster resolveP...

2017-09-13 Thread Chaos-Ju
Github user Chaos-Ju commented on the issue: https://github.com/apache/spark/pull/19206 @srowen you think should close the jira and this is pointless? --- - To unsubscribe, e-mail:

[GitHub] spark issue #19217: [SPARK-21991][LAUNCHER] LauncherServer acceptConnections...

2017-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19217 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #19217: [SPARK-21991][LAUNCHER] LauncherServer acceptConn...

2017-09-13 Thread nivox
GitHub user nivox opened a pull request: https://github.com/apache/spark/pull/19217 [SPARK-21991][LAUNCHER] LauncherServer acceptConnections thread sometime dies if machine has very high load ## What changes were proposed in this pull request? This patch changes the order in

[GitHub] spark pull request #19134: [SPARK-21893][BUILD][STREAMING][WIP] Put Kafka 0....

2017-09-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19134 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19134: [SPARK-21893][BUILD][STREAMING][WIP] Put Kafka 0.8 behin...

2017-09-13 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19134 Merged to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19145: [spark-21933][yarn] Spark Streaming request more executo...

2017-09-13 Thread klion26
Github user klion26 commented on the issue: https://github.com/apache/spark/pull/19145 Will the same completed message will be reported more than twice, if these message will not be reported more than twice, then i could use `completedContainerIdSet.remove(containerId)` instead

[GitHub] spark issue #18731: [SPARK-20990][SQL] Read all JSON documents in files when...

2017-09-13 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/18731 I close this, I will prepare a new PR, cleaner. Thanks --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark pull request #18731: [SPARK-20990][SQL] Read all JSON documents in fil...

2017-09-13 Thread mgaido91
Github user mgaido91 closed the pull request at: https://github.com/apache/spark/pull/18731 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18515: [SPARK-21287][SQL] Ability to use Integer.MIN_VAL...

2017-09-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18515 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18949: [SPARK-12961][CORE][FOLLOW-UP] Remove wrapper cod...

2017-09-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18949 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19091: Merge pull request #1 from apache/master

2017-09-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19091 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19154: [SPARK-21942][CORE] Fix DiskBlockManager crashing...

2017-09-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19154 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19203: [BUILD] Close stale PRs

2017-09-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19203 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18806: [SPARK-21600][docs] The description of "this requ...

2017-09-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18806 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19142: When the number of attempting to restart receiver...

2017-09-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19142 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19205: [SPARK-21982] Set locale to US

2017-09-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19205 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18879: [SPARK-21662] modify the appname to [SparkSQL::lo...

2017-09-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18879 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19070: Branch 2.2

2017-09-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19070 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19187: Branch 2.1

2017-09-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19187 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19162: Merge pull request #1 from apache/master

2017-09-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19162 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19039: [SPARK-21829][CORE] Enable config to permanently ...

2017-09-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19039 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18891: updateMerge pull request #1 from apache/master

2017-09-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18891 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #17722: [SPARK-12717][PYSPARK][BRANCH-1.6] Resolving race...

2017-09-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17722 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18948: Add the validation of spark.cores.max under Strea...

2017-09-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18948 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18522: [CORE][MINOR]Closes stream and releases any syste...

2017-09-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18522 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19205: [SPARK-21982] Set locale to US

2017-09-13 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19205 Merged to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19214: [SPARK-21027][MINOR][FOLLOW-UP] add missing since...

2017-09-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19214 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19182: [SPARK-21970][Core] Fix Redundant Throws Declarations in...

2017-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19182 **[Test build #3921 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3921/testReport)** for PR 19182 at commit

[GitHub] spark issue #19214: [SPARK-21027][MINOR][FOLLOW-UP] add missing since tag

2017-09-13 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19214 Merged to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19136: [SPARK-15689][SQL] data source v2

2017-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19136 **[Test build #81712 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81712/testReport)** for PR 19136 at commit

[GitHub] spark issue #19216: [SPARK-21990][SQL] QueryPlanConstraints misses some cons...

2017-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19216 **[Test build #81711 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81711/testReport)** for PR 19216 at commit

[GitHub] spark issue #19136: [SPARK-15689][SQL] data source v2

2017-09-13 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19136 I think I've addressed all the comments, but I still have some naming that I'm not confident about. 1. is it OK to add the `V2` suffix in all related classes and packages? 2. I

[GitHub] spark pull request #19216: [SPARK-21990][SQL] QueryPlanConstraints misses so...

2017-09-13 Thread viirya
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/19216 [SPARK-21990][SQL] QueryPlanConstraints misses some constraints that can be recursively inferred ## What changes were proposed in this pull request? When I inspected the latest change of

[GitHub] spark issue #19174: [SPARK-21963][CORE][TEST]Create temp file should be dele...

2017-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19174 **[Test build #3919 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3919/testReport)** for PR 19174 at commit

[GitHub] spark issue #18337: [SPARK-21131][GraphX] Fix batch gradient bug in SVDPlusP...

2017-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18337 **[Test build #3920 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3920/testReport)** for PR 18337 at commit

[GitHub] spark pull request #19136: [SPARK-15689][SQL] data source v2

2017-09-13 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19136#discussion_r138554005 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala --- @@ -0,0 +1,95 @@ +/* + * Licensed

[GitHub] spark pull request #19188: [SPARK-21973][SQL] Add an new option to filter qu...

2017-09-13 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19188#discussion_r138547730 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/TPCDSQueryBenchmark.scala --- @@ -29,9 +30,9 @@ import

[GitHub] spark pull request #19188: [SPARK-21973][SQL] Add an new option to filter qu...

2017-09-13 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/19188#discussion_r138547442 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/TPCDSQueryBenchmark.scala --- @@ -29,9 +30,9 @@ import

[GitHub] spark issue #19206: [SPARK-19206][yarn]Client and ApplicationMaster resolveP...

2017-09-13 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19206 @Chaos-Ju this is connected to the wrong JIRA --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #19188: [SPARK-21973][SQL] Add an new option to filter qu...

2017-09-13 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19188#discussion_r138547038 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/TPCDSQueryBenchmark.scala --- @@ -29,9 +30,9 @@ import

[GitHub] spark pull request #19188: [SPARK-21973][SQL] Add an new option to filter qu...

2017-09-13 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/19188#discussion_r138546493 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/TPCDSQueryBenchmark.scala --- @@ -29,9 +30,9 @@ import

[GitHub] spark pull request #19136: [SPARK-15689][SQL] data source v2

2017-09-13 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19136#discussion_r138546295 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/ReadTask.java --- @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache

[GitHub] spark issue #19132: [SPARK-21922] Fix duration always updating when task fai...

2017-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19132 **[Test build #81710 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81710/testReport)** for PR 19132 at commit

[GitHub] spark pull request #19188: [SPARK-21973][SQL] Add an new option to filter qu...

2017-09-13 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19188#discussion_r138545182 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/TPCDSQueryBenchmark.scala --- @@ -29,9 +30,9 @@ import

[GitHub] spark pull request #19068: [SPARK-21428][SQL][FOLLOWUP]CliSessionState shoul...

2017-09-13 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19068#discussion_r138544218 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala --- @@ -231,6 +231,42 @@ private[spark] object HiveUtils extends Logging {

[GitHub] spark pull request #19068: [SPARK-21428][SQL][FOLLOWUP]CliSessionState shoul...

2017-09-13 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19068#discussion_r138543749 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala --- @@ -231,6 +231,42 @@ private[spark] object HiveUtils extends Logging {

[GitHub] spark pull request #19068: [SPARK-21428][SQL][FOLLOWUP]CliSessionState shoul...

2017-09-13 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19068#discussion_r138543230 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala --- @@ -132,43 +134,26 @@ private[hive] class HiveClientImpl(

[GitHub] spark issue #19213: [SPARK-17642] [SQL] [FOLLOWUP] improve comments

2017-09-13 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19213 LGTM, please also address one more comment that drop testing tables. --- - To unsubscribe, e-mail:

[GitHub] spark pull request #15544: [SPARK-17997] [SQL] Add an aggregation function f...

2017-09-13 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/15544#discussion_r138541717 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/HyperLogLogPlusPlusHelper.scala --- @@ -0,0 +1,373 @@ +/* + * Licensed to

[GitHub] spark pull request #16422: [SPARK-17642] [SQL] support DESC EXTENDED/FORMATT...

2017-09-13 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/16422#discussion_r138540329 --- Diff: sql/core/src/test/resources/sql-tests/inputs/describe-table-column.sql --- @@ -0,0 +1,35 @@ +-- Test temp table +CREATE TEMPORARY VIEW

[GitHub] spark issue #15544: [SPARK-17997] [SQL] Add an aggregation function for coun...

2017-09-13 Thread wzhfy
Github user wzhfy commented on the issue: https://github.com/apache/spark/pull/15544 @cloud-fan @gatorsmile @sameeragarwal Because we are going to add equi-height histogram, I reopened this PR and updated description and code. Please help review it. Thanks. ---

[GitHub] spark pull request #16422: [SPARK-17642] [SQL] support DESC EXTENDED/FORMATT...

2017-09-13 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/16422#discussion_r138539525 --- Diff: sql/core/src/test/resources/sql-tests/results/describe-table-column.sql.out --- @@ -0,0 +1,184 @@ +-- Automatically generated by

[GitHub] spark issue #19132: [SPARK-21922] Fix duration always updating when task fai...

2017-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19132 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81709/ Test FAILed. ---

[GitHub] spark issue #19132: [SPARK-21922] Fix duration always updating when task fai...

2017-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19132 **[Test build #81709 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81709/testReport)** for PR 19132 at commit

[GitHub] spark issue #19132: [SPARK-21922] Fix duration always updating when task fai...

2017-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19132 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19215: [MINOR][SQL] Only populate type metadata for required ty...

2017-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19215 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19215: [MINOR][SQL] Only populate type metadata for required ty...

2017-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19215 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81708/ Test PASSed. ---

[GitHub] spark issue #19068: [SPARK-21428][SQL][FOLLOWUP]CliSessionState should point...

2017-09-13 Thread yaooqinn
Github user yaooqinn commented on the issue: https://github.com/apache/spark/pull/19068 @cloud-fan The cliSessionState is meant to be reused but discarded for isolated hive client classloader couldn't get it through `SessionState.get()`, so hive client will generated a

[GitHub] spark issue #19215: [MINOR][SQL] Only populate type metadata for required ty...

2017-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19215 **[Test build #81708 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81708/testReport)** for PR 19215 at commit

[GitHub] spark issue #19186: [SPARK-21972][ML] Add param handlePersistence

2017-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19186 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19186: [SPARK-21972][ML] Add param handlePersistence

2017-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19186 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81704/ Test PASSed. ---

[GitHub] spark issue #19186: [SPARK-21972][ML] Add param handlePersistence

2017-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19186 **[Test build #81704 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81704/testReport)** for PR 19186 at commit

[GitHub] spark issue #19160: [SPARK-21934][CORE] Expose Shuffle Netty memory usage to...

2017-09-13 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19160 @squito would you please help to review this PR, thanks a lot. --- - To unsubscribe, e-mail:

[GitHub] spark issue #19210: Fix Graphite re-connects for Graphite instances behind E...

2017-09-13 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19210 You should also update the the files under `dev/deps`. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #19068: [SPARK-21428][SQL][FOLLOWUP]CliSessionState should point...

2017-09-13 Thread dilipbiswal
Github user dilipbiswal commented on the issue: https://github.com/apache/spark/pull/19068 @cloud-fan it didn't trigger the test ? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #19132: [SPARK-21922] Fix duration always updating when t...

2017-09-13 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19132#discussion_r138533547 --- Diff: core/src/main/scala/org/apache/spark/status/api/v1/AllStagesResource.scala --- @@ -47,7 +47,8 @@ private[v1] class AllStagesResource(ui:

[GitHub] spark issue #18576: [SPARK-21351][SQL] Update nullability based on children'...

2017-09-13 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/18576 ping --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19188: [SPARK-21973][SQL] Add an new option to filter queries i...

2017-09-13 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/19188 @gatorsmile could u check? Thanks~ --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #19188: [SPARK-21973][SQL] Add an new option to filter queries i...

2017-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19188 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81703/ Test PASSed. ---

[GitHub] spark issue #19188: [SPARK-21973][SQL] Add an new option to filter queries i...

2017-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19188 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19188: [SPARK-21973][SQL] Add an new option to filter queries i...

2017-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19188 **[Test build #81703 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81703/testReport)** for PR 19188 at commit

<    1   2   3   4   5