[GitHub] spark issue #19171: [SPARK-21902][CORE] Print root cause for BlockManager#do...

2017-09-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19171 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81807/ Test PASSed. ---

[GitHub] spark issue #19171: [SPARK-21902][CORE] Print root cause for BlockManager#do...

2017-09-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19171 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19171: [SPARK-21902][CORE] Print root cause for BlockManager#do...

2017-09-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19171 **[Test build #81807 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81807/testReport)** for PR 19171 at commit

[GitHub] spark issue #19130: [SPARK-21917][CORE][YARN] Supporting adding http(s) reso...

2017-09-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19130 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19130: [SPARK-21917][CORE][YARN] Supporting adding http(s) reso...

2017-09-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19130 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81804/ Test PASSed. ---

[GitHub] spark issue #19130: [SPARK-21917][CORE][YARN] Supporting adding http(s) reso...

2017-09-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19130 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81805/ Test PASSed. ---

[GitHub] spark issue #19130: [SPARK-21917][CORE][YARN] Supporting adding http(s) reso...

2017-09-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19130 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19130: [SPARK-21917][CORE][YARN] Supporting adding http(s) reso...

2017-09-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19130 **[Test build #81805 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81805/testReport)** for PR 19130 at commit

[GitHub] spark issue #19130: [SPARK-21917][CORE][YARN] Supporting adding http(s) reso...

2017-09-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19130 **[Test build #81804 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81804/testReport)** for PR 19130 at commit

[GitHub] spark pull request #19240: [SPARK-22018][SQL]Preserve top-level alias metada...

2017-09-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19240 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-09-14 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r139064657 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -503,69 +504,307 @@ case class

[GitHub] spark issue #19235: [SPARK-14387][SPARK-19459][SQL] Enable Hive-1.x ORC comp...

2017-09-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19235 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19235: [SPARK-14387][SPARK-19459][SQL] Enable Hive-1.x ORC comp...

2017-09-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19235 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81806/ Test PASSed. ---

[GitHub] spark issue #19235: [SPARK-14387][SPARK-19459][SQL] Enable Hive-1.x ORC comp...

2017-09-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19235 **[Test build #81806 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81806/testReport)** for PR 19235 at commit

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-09-14 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r139063658 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -535,6 +585,51 @@ public UTF8String trimRight() { }

[GitHub] spark issue #19239: [SPARK-22017] Take minimum of all watermark execs in Str...

2017-09-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19239 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81803/ Test PASSed. ---

[GitHub] spark issue #19239: [SPARK-22017] Take minimum of all watermark execs in Str...

2017-09-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19239 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19239: [SPARK-22017] Take minimum of all watermark execs in Str...

2017-09-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19239 **[Test build #81803 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81803/testReport)** for PR 19239 at commit

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-09-14 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r139063428 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -535,6 +585,51 @@ public UTF8String trimRight() { }

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-09-14 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r139063323 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -522,6 +537,41 @@ public UTF8String trimLeft() { }

[GitHub] spark issue #19226: [SPARK-21985][PySpark] PairDeserializer is broken for do...

2017-09-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19226 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81811/ Test PASSed. ---

[GitHub] spark issue #19226: [SPARK-21985][PySpark] PairDeserializer is broken for do...

2017-09-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19226 **[Test build #81811 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81811/testReport)** for PR 19226 at commit

[GitHub] spark issue #19226: [SPARK-21985][PySpark] PairDeserializer is broken for do...

2017-09-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19226 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-09-14 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r139062541 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -503,69 +504,307 @@ case class

[GitHub] spark issue #18853: [SPARK-21646][SQL] CommonType for binary comparison

2017-09-14 Thread wangyum
Github user wangyum commented on the issue: https://github.com/apache/spark/pull/18853 I provide 2 SQL scripts to validate the different result between Spark and Hive: | Engine | [SPARK_21646_1.txt](https://github.com/apache/spark/files/1305185/SPARK_21646_1.txt) |

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-09-14 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r139062566 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -503,69 +504,307 @@ case class

[GitHub] spark issue #19210: Fix Graphite re-connects for Graphite instances behind E...

2017-09-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19210 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19210: Fix Graphite re-connects for Graphite instances behind E...

2017-09-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19210 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81802/ Test PASSed. ---

[GitHub] spark issue #19210: Fix Graphite re-connects for Graphite instances behind E...

2017-09-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19210 **[Test build #81802 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81802/testReport)** for PR 19210 at commit

[GitHub] spark issue #19226: [SPARK-21985][PySpark] PairDeserializer is broken for do...

2017-09-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19226 **[Test build #81811 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81811/testReport)** for PR 19226 at commit

[GitHub] spark issue #19226: [SPARK-21985][PySpark] PairDeserializer is broken for do...

2017-09-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19226 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19226: [SPARK-21985][PySpark] PairDeserializer is broken for do...

2017-09-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19226 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81810/ Test FAILed. ---

[GitHub] spark issue #19226: [SPARK-21985][PySpark] PairDeserializer is broken for do...

2017-09-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19226 **[Test build #81810 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81810/testReport)** for PR 19226 at commit

[GitHub] spark issue #19226: [SPARK-21985][PySpark] PairDeserializer is broken for do...

2017-09-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19226 **[Test build #81810 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81810/testReport)** for PR 19226 at commit

[GitHub] spark issue #19171: [SPARK-21902][CORE] Print root cause for BlockManager#do...

2017-09-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19171 **[Test build #81808 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81808/testReport)** for PR 19171 at commit

[GitHub] spark issue #19136: [SPARK-15689][SQL] data source v2 read path

2017-09-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19136 **[Test build #81809 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81809/testReport)** for PR 19136 at commit

[GitHub] spark pull request #19171: [SPARK-21902][CORE] Print root cause for BlockMan...

2017-09-14 Thread caneGuy
Github user caneGuy commented on a diff in the pull request: https://github.com/apache/spark/pull/19171#discussion_r139058928 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -988,6 +988,12 @@ private[spark] class BlockManager(

[GitHub] spark issue #16832: [SPARK-19490][SQL] ignore case sensitivity when filterin...

2017-09-14 Thread LantaoJin
Github user LantaoJin commented on the issue: https://github.com/apache/spark/pull/16832 Duplicates to [SPARK-18572](https://github.com/apache/spark/pull/15998) --- - To unsubscribe, e-mail:

[GitHub] spark issue #19240: [SPARK-22018][SQL]Preserve top-level alias metadata when...

2017-09-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19240 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19240: [SPARK-22018][SQL]Preserve top-level alias metadata when...

2017-09-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19240 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81801/ Test PASSed. ---

[GitHub] spark issue #19240: [SPARK-22018][SQL]Preserve top-level alias metadata when...

2017-09-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19240 **[Test build #81801 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81801/testReport)** for PR 19240 at commit

[GitHub] spark pull request #19241: Spark on Kubernetes - basic scheduler backend [WI...

2017-09-14 Thread foxish
Github user foxish closed the pull request at: https://github.com/apache/spark/pull/19241 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19241: Spark on Kubernetes - basic scheduler backend [WIP]

2017-09-14 Thread foxish
Github user foxish commented on the issue: https://github.com/apache/spark/pull/19241 The unnecessary constants and config still needs to be stripped out. Getting this out there to 1) serve as the framework for our first PR, 2) get some insight on the unit test failures ---

[GitHub] spark pull request #19241: Spark on Kubernetes - basic scheduler backend [WI...

2017-09-14 Thread foxish
GitHub user foxish opened a pull request: https://github.com/apache/spark/pull/19241 Spark on Kubernetes - basic scheduler backend [WIP] Stripped out a lot of extraneous things, to create this. Our first PR upstream will likely be this. (note that it is created against the master

[GitHub] spark issue #19223: [SPARK-21513][SQL][FOLLOWUP] Allow UDF to_json support c...

2017-09-14 Thread goldmedal
Github user goldmedal commented on the issue: https://github.com/apache/spark/pull/19223 Thanks @HyukjinKwon @felixcheung @viirya --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19233: [Spark-22008][Streaming]Spark Streaming Dynamic Allocati...

2017-09-14 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19233 IIUC streaming DRA seems an obsolete code. Long ago when I played with it, there existed some bugs, but seems not so many users used this feature. I'm not sure if we really need to put efforts on

[GitHub] spark pull request #19223: [SPARK-21513][SQL][FOLLOWUP] Allow UDF to_json su...

2017-09-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19223 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19231: [SPARK-22002][SQL] Read JDBC table use custom schema sup...

2017-09-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19231 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81800/ Test PASSed. ---

[GitHub] spark issue #19223: [SPARK-21513][SQL][FOLLOWUP] Allow UDF to_json support c...

2017-09-14 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19223 Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19231: [SPARK-22002][SQL] Read JDBC table use custom schema sup...

2017-09-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19231 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19171: [SPARK-21902][CORE] Print root cause for BlockManager#do...

2017-09-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19171 **[Test build #81807 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81807/testReport)** for PR 19171 at commit

[GitHub] spark issue #19223: [SPARK-21513][SQL][FOLLOWUP] Allow UDF to_json support c...

2017-09-14 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/19223 Thanks @felixcheung @HyukjinKwon --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #19235: [SPARK-14387][SPARK-19459][SQL] Enable Hive-1.x O...

2017-09-14 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19235#discussion_r139054047 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcSourceSuite.scala --- @@ -187,8 +188,12 @@ abstract class OrcSuite extends

[GitHub] spark issue #19231: [SPARK-22002][SQL] Read JDBC table use custom schema sup...

2017-09-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19231 **[Test build #81800 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81800/testReport)** for PR 19231 at commit

[GitHub] spark pull request #19130: [SPARK-21917][CORE][YARN] Supporting adding http(...

2017-09-14 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19130#discussion_r139053961 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -367,6 +368,54 @@ object SparkSubmit extends CommandLineUtils with Logging

[GitHub] spark issue #19223: [SPARK-21513][SQL][FOLLOWUP] Allow UDF to_json support c...

2017-09-14 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19223 Looks passed fine. Let me merge this one. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #19206: [SPARK-19206][yarn]Client and ApplicationMaster r...

2017-09-14 Thread Chaos-Ju
Github user Chaos-Ju closed the pull request at: https://github.com/apache/spark/pull/19206 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19171: [SPARK-21902][CORE] Print root cause for BlockManager#do...

2017-09-14 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19171 ok to test. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19235: [SPARK-21997][SQL][WIP] Turn off spark.sql.hive.convertM...

2017-09-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19235 **[Test build #81806 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81806/testReport)** for PR 19235 at commit

[GitHub] spark pull request #19171: [SPARK-21902][CORE] Print root cause for BlockMan...

2017-09-14 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19171#discussion_r139053438 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -988,6 +988,12 @@ private[spark] class BlockManager(

[GitHub] spark issue #19237: [SPARK-21987][SQL] fix a compatibility issue of sql even...

2017-09-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19237 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19237: [SPARK-21987][SQL] fix a compatibility issue of sql even...

2017-09-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19237 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81799/ Test PASSed. ---

[GitHub] spark issue #19237: [SPARK-21987][SQL] fix a compatibility issue of sql even...

2017-09-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19237 **[Test build #81799 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81799/testReport)** for PR 19237 at commit

[GitHub] spark issue #19235: [SPARK-21997][SQL][WIP] Turn off spark.sql.hive.convertM...

2017-09-14 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/19235 Since this PR is invalid, I'll reuse this PR instead of creating new one. --- - To unsubscribe, e-mail:

[GitHub] spark issue #14471: [SPARK-14387][SQL] Enable Hive-1.x ORC compatibility wit...

2017-09-14 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14471 Hi, @rajeshbalamohan . I'll refer your commit for SPARK-19459 . You'll be the main author in case of merge. --- - To

[GitHub] spark issue #19130: [SPARK-21917][CORE][YARN] Supporting adding http(s) reso...

2017-09-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19130 **[Test build #81805 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81805/testReport)** for PR 19130 at commit

[GitHub] spark issue #19235: [SPARK-21997][SQL][WIP] Turn off spark.sql.hive.convertM...

2017-09-14 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/19235 @gatorsmile and @vanzin . I'm comparing with ORC now. Previously, ORC fails with another reason. I'll make another PR for that. I found that #14471 is enough for ORC. In case

[GitHub] spark issue #19130: [SPARK-21917][CORE][YARN] Supporting adding http(s) reso...

2017-09-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19130 **[Test build #81804 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81804/testReport)** for PR 19130 at commit

[GitHub] spark issue #19133: [SPARK-21902][CORE] Uniform calling for DiskBlockManager...

2017-09-14 Thread caneGuy
Github user caneGuy commented on the issue: https://github.com/apache/spark/pull/19133 Actually , initially i put this together with [PR-19171](https://github.com/apache/spark/pull/19171) since i found the api is not unify when fix that problem.All right i will close this one.Cloud

[GitHub] spark pull request #19133: [SPARK-21902][CORE] Uniform calling for DiskBlock...

2017-09-14 Thread caneGuy
Github user caneGuy closed the pull request at: https://github.com/apache/spark/pull/19133 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19231: [SPARK-22002][SQL] Read JDBC table use custom schema sup...

2017-09-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19231 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19231: [SPARK-22002][SQL] Read JDBC table use custom schema sup...

2017-09-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19231 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81798/ Test PASSed. ---

[GitHub] spark issue #19231: [SPARK-22002][SQL] Read JDBC table use custom schema sup...

2017-09-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19231 **[Test build #81798 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81798/testReport)** for PR 19231 at commit

[GitHub] spark issue #19239: [SPARK-22017] Take minimum of all watermark execs in Str...

2017-09-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19239 **[Test build #81803 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81803/testReport)** for PR 19239 at commit

[GitHub] spark issue #19239: [SPARK-22017] Take minimum of all watermark execs in Str...

2017-09-14 Thread joseph-torres
Github user joseph-torres commented on the issue: https://github.com/apache/spark/pull/19239 addressed comments --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #14158: [SPARK-13547] [SQL] [WEBUI] Add SQL query in web UI's SQ...

2017-09-14 Thread nblintao
Github user nblintao commented on the issue: https://github.com/apache/spark/pull/14158 @HyukjinKwon Sorry for the delay. I'm busy looking for jobs these days. I'll try my best to fix it in October. Thank you for reminding me! ---

[GitHub] spark pull request #19135: [SPARK-21923][CORE]Avoid calling reserveUnrollMem...

2017-09-14 Thread ConeyLiu
Github user ConeyLiu commented on a diff in the pull request: https://github.com/apache/spark/pull/19135#discussion_r139049317 --- Diff: core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala --- @@ -325,6 +325,10 @@ private[spark] class MemoryStore(

[GitHub] spark issue #19210: Fix Graphite re-connects for Graphite instances behind E...

2017-09-14 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19210 BTW, can you please create a JIRA, and fix the PR title like other PRs. --- - To unsubscribe, e-mail:

[GitHub] spark issue #19133: [SPARK-21902][CORE] Uniform calling for DiskBlockManager...

2017-09-14 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19133 This is not a necessary fix. We usually don't do such changes without really fix anything. --- - To unsubscribe, e-mail:

[GitHub] spark pull request #19135: [SPARK-21923][CORE]Avoid calling reserveUnrollMem...

2017-09-14 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19135#discussion_r139047702 --- Diff: core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala --- @@ -325,6 +325,10 @@ private[spark] class MemoryStore(

[GitHub] spark issue #19191: [SPARK-21958][ML] Word2VecModel save: transform data in ...

2017-09-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19191 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19210: Fix Graphite re-connects for Graphite instances behind E...

2017-09-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19210 **[Test build #81802 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81802/testReport)** for PR 19210 at commit

[GitHub] spark pull request #19227: [SPARK-20060][CORE] Support accessing secure Hado...

2017-09-14 Thread jerryshao
Github user jerryshao closed the pull request at: https://github.com/apache/spark/pull/19227 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19227: [SPARK-20060][CORE] Support accessing secure Hadoop clus...

2017-09-14 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19227 I see, so based on your comments: 1. Mesos should not honor principal/keytab configuration. Instead of rename them, we should remove the `MESOS` here: ``` if

[GitHub] spark issue #19210: Fix Graphite re-connects for Graphite instances behind E...

2017-09-14 Thread alexmnyc
Github user alexmnyc commented on the issue: https://github.com/apache/spark/pull/19210 @jerryshao done --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19218: [SPARK-21786][SQL] The 'spark.sql.parquet.compression.co...

2017-09-14 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/19218 @gatorsmile Is it worth fixing this? If so, could you trigger tests? --- - To unsubscribe, e-mail:

[GitHub] spark issue #19133: [SPARK-21902][CORE] Uniform calling for DiskBlockManager...

2017-09-14 Thread caneGuy
Github user caneGuy commented on the issue: https://github.com/apache/spark/pull/19133 Ping @kiszk Cloud you help take a look at this? Thanks too much. --- - To unsubscribe, e-mail:

[GitHub] spark pull request #19210: Fix Graphite re-connects for Graphite instances b...

2017-09-14 Thread alexmnyc
Github user alexmnyc commented on a diff in the pull request: https://github.com/apache/spark/pull/19210#discussion_r139046210 --- Diff: core/src/main/scala/org/apache/spark/metrics/sink/GraphiteSink.scala --- @@ -69,7 +69,7 @@ private[spark] class GraphiteSink(val property:

[GitHub] spark issue #19171: [SPARK-21902][CORE] Print root cause for BlockManager#do...

2017-09-14 Thread caneGuy
Github user caneGuy commented on the issue: https://github.com/apache/spark/pull/19171 Ping @kiszk Cloud you help take a look at this? Thanks too much. --- - To unsubscribe, e-mail:

[GitHub] spark issue #19227: [SPARK-20060][CORE] Support accessing secure Hadoop clus...

2017-09-14 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/19227 > Current Spark on Mesos code actually honors it: Then it really shouldn't. Those options are for long lived applications and Mesos don't yet support those. ---

[GitHub] spark issue #19227: [SPARK-20060][CORE] Support accessing secure Hadoop clus...

2017-09-14 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19227 > I don't think Mesos honors it (and it shouldn't be, since IIRC it hasn't implemented long-lived app support yet). Current Spark on Mesos code actually honors it: ``` //

[GitHub] spark issue #19240: [SPARK-22018][SQL]Preserve top-level alias metadata when...

2017-09-14 Thread marmbrus
Github user marmbrus commented on the issue: https://github.com/apache/spark/pull/19240 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19227: [SPARK-20060][CORE] Support accessing secure Hadoop clus...

2017-09-14 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/19227 > so that's why I rename them. What do you think? I think that should be a separate change. I don't think Mesos honors it (and it shouldn't be, since IIRC it hasn't implemented long-lived

[GitHub] spark pull request #18685: [SPARK-21439] Support for ABCMeta in PySpark

2017-09-14 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18685#discussion_r139045469 --- Diff: python/pyspark/cloudpickle.py --- @@ -667,6 +667,13 @@ def save_file(self, obj): else: dispatch[file] = save_file

[GitHub] spark pull request #19210: Fix Graphite re-connects for Graphite instances b...

2017-09-14 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19210#discussion_r139045423 --- Diff: core/src/main/scala/org/apache/spark/metrics/sink/GraphiteSink.scala --- @@ -69,7 +69,7 @@ private[spark] class GraphiteSink(val property:

[GitHub] spark issue #18685: [SPARK-21439] Support for ABCMeta in PySpark

2017-09-14 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18685 gentle ping @maver1ck. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19227: [SPARK-20060][CORE] Support accessing secure Hadoop clus...

2017-09-14 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19227 The purpose of changing configuration name is that these configurations are not only used by yarn mode in `SparkSubmit`, Mesos, local will also honor this, so that's why I rename them. What do

[GitHub] spark issue #19227: [SPARK-20060][CORE] Support accessing secure Hadoop clus...

2017-09-14 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/19227 If you're not touching keytabs why are you changing the property names, which would be an unrelated change? You don't need principal / keytab to get delegation tokens. You just login with `kinit`.

[GitHub] spark issue #19223: [SPARK-21513][SQL][FOLLOWUP] Allow UDF to_json support c...

2017-09-14 Thread goldmedal
Github user goldmedal commented on the issue: https://github.com/apache/spark/pull/19223 ok. I got it. Thanks :) --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19223: [SPARK-21513][SQL][FOLLOWUP] Allow UDF to_json support c...

2017-09-14 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19223 Yes, when there are some changes in: https://github.com/apache/spark/blob/828fab03567ecc245a65c4d295a677ce0ba26c19/appveyor.yml#L29-L35 It should run the R tests on Windows via

  1   2   3   4   5   >