Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19196#discussion_r139578010
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/IncrementalExecutionRulesSuite.scala
---
@@ -0,0 +1,123 @@
+/*
+ * Licensed to the
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19196#discussion_r139577945
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/IncrementalExecutionRulesSuite.scala
---
@@ -0,0 +1,123 @@
+/*
+ * Licensed to the
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19196#discussion_r139577898
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/IncrementalExecutionRulesSuite.scala
---
@@ -0,0 +1,123 @@
+/*
+ * Licensed to the
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/17819
@viirya Scala `with trait` is a complex mechanism and `trait` isn't
equivalent to java's `interface`. Scala compiler will precompile and generate
many other codes, so java-side code cannot
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19130#discussion_r139577257
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -385,4 +385,13 @@ package object config {
.checkValue(v =>
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19130#discussion_r139577191
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -367,6 +368,54 @@ object SparkSubmit extends CommandLineUtils with
Logging
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19256
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19256
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81898/
Test PASSed.
---
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19130#discussion_r139576893
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -367,6 +368,54 @@ object SparkSubmit extends CommandLineUtils with
Logging
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19256
**[Test build #81898 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81898/testReport)**
for PR 19256 at commit
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19130#discussion_r139576814
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -367,6 +368,54 @@ object SparkSubmit extends CommandLineUtils with
Logging
Github user guoxiaolongzte commented on the issue:
https://github.com/apache/spark/pull/19242
@srowen
Help to review the code, thanks.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/18704
@cloud-fan Could you please review this again?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19130#discussion_r139576228
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -385,4 +385,13 @@ package object config {
.checkValue(v =>
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19130#discussion_r139576095
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -367,6 +368,54 @@ object SparkSubmit extends CommandLineUtils with
Logging
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19130#discussion_r139575943
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -367,6 +368,54 @@ object SparkSubmit extends CommandLineUtils with
Logging
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19130#discussion_r139575421
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -367,6 +368,54 @@ object SparkSubmit extends CommandLineUtils with
Logging
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/16774
OK. I will separate a PR. Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19265
**[Test build #81902 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81902/testReport)**
for PR 19265 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19243
Sure, let me minimise the changes as you suggested for now and keep the
current change somewhere in my local just in case. That makes sense to me too.
---
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19265
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/19229
@viirya No, keep the dataframe version code. But I only want to confirm how
much performance gap between this and RDD version. (for possible improvements
in the future, because in similar test
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19265
**[Test build #81901 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81901/testReport)**
for PR 19265 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19265
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19265
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19265
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19265
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19265
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19272
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user ArtRand opened a pull request:
https://github.com/apache/spark/pull/19272
[Spark-21842] Support Kerberos ticket renewal and creation in Mesos
## What changes were proposed in this pull request?
Add a class, `MesosCredentialRenewer` that updates delegation tokens on a
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/17819
@WeichenXu123 According to
https://docs.oracle.com/javase/specs/jls/se7/html/jls-13.html#jls-13.4.4 and
https://wiki.eclipse.org/Evolving_Java-based_APIs_2#Evolving_API_Classes, I
think adding an
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19252
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81897/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19252
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19252
**[Test build #81897 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81897/testReport)**
for PR 19252 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19252
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81896/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19252
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19252
**[Test build #81896 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81896/testReport)**
for PR 19252 at commit
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19181#discussion_r139570073
--- Diff:
core/src/test/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorterSuite.java
---
@@ -503,6 +511,39 @@ public void
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19252#discussion_r139569908
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -377,6 +377,8 @@ class SessionCatalog(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19252#discussion_r139569666
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/StatisticsCollectionSuite.scala ---
@@ -261,6 +261,11 @@ class StatisticsCollectionSuite extends
GitHub user tdas opened a pull request:
https://github.com/apache/spark/pull/19271
[SPARK-22053][SS] Stream-stream inner join
## What changes were proposed in this pull request?
This PR implements stream-stream inner join using a two-way symmetric hash
join. At a high
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19271
**[Test build #81900 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81900/testReport)**
for PR 19271 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19211
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81895/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19211
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19211
**[Test build #81895 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81895/testReport)**
for PR 19211 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19229
@WeichenXu123 Thanks for verifying that.
Do you mean using ApproxQuantiles to compute mean and median? But I think
this change is not intended to improve this part.
---
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19256
LGTM pending Jenkins
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/16774
@WeichenXu123 , it would be great if you could separate out the bugfix. I
looked in #19208 but couldn't find what you were referring to.
---
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/18659
@ueshin , the tests are all passing now when using pyarrow 0.7 (just
released). This added better support for type coercion in `Array.from_pandas`
which makes handling null values a little
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/18659#discussion_r139562988
--- Diff: python/pyspark/serializers.py ---
@@ -199,6 +211,46 @@ def __repr__(self):
return "ArrowSerializer"
+class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19194
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81894/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19194
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19194
**[Test build #81894 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81894/testReport)**
for PR 19194 at commit
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/18659#discussion_r139562519
--- Diff: python/pyspark/sql/tests.py ---
@@ -3122,6 +3122,185 @@ def test_filtered_frame(self):
self.assertTrue(pdf.empty)
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19074
ping @jerryshao
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/18754#discussion_r139562172
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowWriter.scala
---
@@ -224,6 +226,25 @@ private[arrow] class
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18659
**[Test build #81899 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81899/testReport)**
for PR 18659 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19256
**[Test build #81898 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81898/testReport)**
for PR 19256 at commit
Github user ajbozarth commented on the issue:
https://github.com/apache/spark/pull/19270
I'll look at the html/js code tomorrow, but it looks like there still
unrelated code that adds new fields, is that code supposed to be there or is it
for another task?
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19250
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19250
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81892/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19250
**[Test build #81892 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81892/testReport)**
for PR 19250 at commit
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/19186
This has ended up being more complex than we envisioned. It would be
valuable to describe the design succinctly so that people can debate it on
JIRA. Could you please describe your solution on
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19252
**[Test build #81897 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81897/testReport)**
for PR 19252 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19252
**[Test build #81896 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81896/testReport)**
for PR 19252 at commit
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/19186
@zhengruifeng Can you please update the PR description so it describes the
actual functionality being added?
---
-
To
Github user kevinyu98 commented on the issue:
https://github.com/apache/spark/pull/12646
Hello Sean : Thank so much for the help on this PR, appreciated all the
help from you and all the reviewers.
---
-
To
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/19106
These are fair arguments. I guess it makes sense to throw an exception;
that's fine with me.
---
-
To unsubscribe, e-mail:
Github user ajbozarth commented on the issue:
https://github.com/apache/spark/pull/19270
Thanks, I'll try to review this by EOD tomorrow
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/16774
@WeichenXu123 Thanks for finding that bug! Can you please separate out
your bugfix? It's good to get fixes in, rather than attaching them to PRs
which may require discussion, so that we make
Github user pgandhi999 commented on the issue:
https://github.com/apache/spark/pull/19270
@ajbozarth Thank you for your comment on the previous PR. I have closed
that one. Apologies for the confusion caused in the previous PR!
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19270
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user pgandhi999 opened a pull request:
https://github.com/apache/spark/pull/19270
[SPARK-21809] : Change Stage Page to use datatables to support sorting
columns and searching
Support column sort and search for Stage Server using jQuery DataTable and
REST API. Before this
Github user pgandhi999 closed the pull request at:
https://github.com/apache/spark/pull/19207
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r139535041
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -503,69 +504,304 @@ case class
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r139535018
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -503,69 +504,304 @@ case class
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19222
**[Test build #81889 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81889/testReport)**
for PR 19222 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19222
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19222
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81889/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19211
**[Test build #81895 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81895/testReport)**
for PR 19211 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18924
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18924
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81893/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18924
**[Test build #81893 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81893/testReport)**
for PR 18924 at commit
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19211#discussion_r139529920
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/LiveListenerBus.scala ---
@@ -39,20 +41,13 @@ import org.apache.spark.util.Utils
* has
Github user danielfx90 commented on the issue:
https://github.com/apache/spark/pull/19238
Seems logical. Then, unless someone disagrees, feel free to close this PR
and we will create a new spark package with this feature in a new repository.
Thanks!
---
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/19211#discussion_r139524259
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/LiveListenerBus.scala ---
@@ -39,20 +41,13 @@ import org.apache.spark.util.Utils
* has
Github user dhruve commented on the issue:
https://github.com/apache/spark/pull/19194
@tgraves I have addressed the comments and tried to cover the possible
cases in the existing test for job groups and speculation. Kindly let me know
if we need to add or address more use cases.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19194
**[Test build #81894 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81894/testReport)**
for PR 19194 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19268
**[Test build #3926 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3926/testReport)**
for PR 19268 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18887
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18887
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81890/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18887
**[Test build #81890 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81890/testReport)**
for PR 18887 at commit
Github user ajbozarth commented on the issue:
https://github.com/apache/spark/pull/19207
It looks like you have a bunch of unrelated code in this PR, this seems to
be caused by how you're doing development. You've opened this PR from your
master branch and it includes work on 3 other
Github user akopich commented on the issue:
https://github.com/apache/spark/pull/18924
@WeichenXu123, thank you for your prompt reply!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18924
**[Test build #81893 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81893/testReport)**
for PR 18924 at commit
Github user akopich commented on a diff in the pull request:
https://github.com/apache/spark/pull/18924#discussion_r139514402
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
@@ -462,31 +462,44 @@ final class OnlineLDAOptimizer extends
Github user akopich commented on a diff in the pull request:
https://github.com/apache/spark/pull/18924#discussion_r139514301
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
@@ -462,31 +462,44 @@ final class OnlineLDAOptimizer extends
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12646
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/12646
Thanks! Merged to master.
Could you resolve the above comments in the follow-up PR? Thanks!
---
-
To unsubscribe,
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r139513283
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -503,69 +504,304 @@ case class
101 - 200 of 433 matches
Mail list logo
