Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/19122#discussion_r140375849
--- Diff: python/pyspark/ml/tests.py ---
@@ -986,6 +1007,25 @@ def test_save_load_simple_estimator(self):
loadedModel =
Github user maryannxue commented on the issue:
https://github.com/apache/spark/pull/19281
Thank you, @wzhfy, very much for the comments! I have made corresponding
changes in my latest commit.
---
-
To unsubscribe,
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/19281#discussion_r140381057
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala
---
@@ -96,6 +96,24 @@ object SortOrder {
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19281
**[Test build #82054 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82054/testReport)**
for PR 19281 at commit
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/16578
> Oh crap. I know what happened here. I've been updating some of the unit
tests locally, and I've been running changes against these modified tests. I'll
fix this and push a commit.
This
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/16578
>Test build #82051 has finished for PR 16578 at commit 00ab80c.
>
> * This patch fails Spark unit tests.
> * This patch merges cleanly.
> * This patch adds no public classes.
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19269#discussion_r140379971
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/DataSourceV2Writer.java
---
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache
Github user squito closed the pull request at:
https://github.com/apache/spark/pull/19313
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/19122#discussion_r140377904
--- Diff: python/pyspark/ml/tuning.py ---
@@ -255,18 +257,30 @@ def _fit(self, dataset):
randCol = self.uid + "_rand"
df =
Github user squito commented on the issue:
https://github.com/apache/spark/pull/19313
thanks @vanzin
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/19122#discussion_r140373348
--- Diff: python/pyspark/ml/tuning.py ---
@@ -14,15 +14,16 @@
# See the License for the specific language governing permissions and
#
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/19122#discussion_r140376994
--- Diff: python/pyspark/ml/tuning.py ---
@@ -255,18 +257,30 @@ def _fit(self, dataset):
randCol = self.uid + "_rand"
df =
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/19122#discussion_r140375935
--- Diff: python/pyspark/ml/tests.py ---
@@ -836,6 +836,27 @@ def test_save_load_simple_estimator(self):
loadedModel =
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19222
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19222
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82044/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19222
**[Test build #82044 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82044/testReport)**
for PR 19222 at commit
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19311#discussion_r140379012
--- Diff:
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
@@ -544,20 +544,39 @@ private[spark] class MemoryStore(
}
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16578
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16578
**[Test build #82051 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82051/testReport)**
for PR 16578 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16578
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82051/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17298
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82050/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17298
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17298
**[Test build #82050 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82050/testReport)**
for PR 17298 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/19313
(Please close the PR manually.)
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17359
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/19313
Merging to 2.1.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19313
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82049/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19313
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19313
**[Test build #82049 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82049/testReport)**
for PR 19313 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19271
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user tdas commented on the issue:
https://github.com/apache/spark/pull/19271
@brkyvz @zsxwing thank you for reviewing. I have merged it to master!
---
-
To unsubscribe, e-mail:
Github user tdas commented on the issue:
https://github.com/apache/spark/pull/19271
@brkyvz
1. we can add this test later.
2. as discussed offline, this method is only to generate the expression and
is not responsible for checking whether the expression has watermarks.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16578
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82047/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16578
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16578
**[Test build #82047 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82047/testReport)**
for PR 16578 at commit
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/19278#discussion_r140373060
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tuning/TrainValidationSplitSuite.scala
---
@@ -160,11 +160,13 @@ class TrainValidationSplitSuite
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/19278#discussion_r140373382
--- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala ---
@@ -396,17 +396,24 @@ private[ml] object DefaultParamsReader {
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/19278#discussion_r140373339
--- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala ---
@@ -396,17 +396,24 @@ private[ml] object DefaultParamsReader {
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/19278#discussion_r140374060
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -303,16 +302,17 @@ object CrossValidatorModel extends
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/19278#discussion_r140373098
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tuning/CrossValidatorSuite.scala ---
@@ -159,12 +159,15 @@ class CrossValidatorSuite
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19312
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82048/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19312
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19312
**[Test build #82048 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82048/testReport)**
for PR 19312 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19311
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19311
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82046/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19311
**[Test build #82046 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82046/testReport)**
for PR 19311 at commit
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/19269#discussion_r140371372
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/DataSourceV2Writer.java
---
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/19122
@BryanCutler Do you have more comments? I can check it out now but don't
want to review at the same time.
---
-
To
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/16578#discussion_r140368054
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/QueryPlanConstraints.scala
---
@@ -77,20 +77,21 @@ trait
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/16578#discussion_r140366890
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/AggregateFieldExtractionPushdown.scala
---
@@ -0,0 +1,77 @@
+/*
+ *
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16578
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16578
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82045/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18659
**[Test build #82053 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82053/testReport)**
for PR 18659 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16578
**[Test build #82045 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82045/testReport)**
for PR 16578 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18659
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18659
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82042/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18659
**[Test build #82042 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82042/testReport)**
for PR 18659 at commit
Github user sureshthalamati commented on the issue:
https://github.com/apache/spark/pull/18994
ping @gatorsmile @cloud-fan @rxin
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19194
**[Test build #82052 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82052/testReport)**
for PR 19194 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16578
**[Test build #82051 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82051/testReport)**
for PR 16578 at commit
Github user dhruve commented on a diff in the pull request:
https://github.com/apache/spark/pull/19194#discussion_r140361162
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -619,6 +625,47 @@ private[spark] class ExecutorAllocationManager(
Github user brkyvz commented on the issue:
https://github.com/apache/spark/pull/19271
LGTM: Would love to see the following things a bit more buttoned up in a
follow up PR:
1. Tests on join + aggregation and aggregation + join
2. A better, safer, more understandable
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/16578#discussion_r140358379
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetReadSupport.scala
---
@@ -63,9 +74,22 @@ private[parquet]
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18747
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18747
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82043/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18747
**[Test build #82043 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82043/testReport)**
for PR 18747 at commit
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/16578#discussion_r140357267
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/JoinFieldExtractionPushdown.scala
---
@@ -0,0 +1,66 @@
+/*
+ *
Github user ajbozarth commented on the issue:
https://github.com/apache/spark/pull/19270
---
Github user ajbozarth commented on the issue:
https://github.com/apache/spark/pull/19270
For me it's definitely the UI that doesn't work and the SHS that does, I''
see if I can recreate and screenshot the js error I'm getting for you
---
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19294
IMO it should be fine to not provide output directory if you are not using
absolute output paths, I also don't think we should always create absolute
output paths in
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19309
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82041/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19309
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19309
**[Test build #82041 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82041/testReport)**
for PR 19309 at commit
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/16578#discussion_r140351256
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetReadSupport.scala
---
@@ -63,9 +74,22 @@ private[parquet]
Github user mridulm commented on the issue:
https://github.com/apache/spark/pull/19294
@szhem Did you try this patch with sql ?
A cursory look at
`org.apache.spark.sql.execution.datasources.FileFormatWriter` and
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19313
**[Test build #82049 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82049/testReport)**
for PR 19313 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17298
**[Test build #82050 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82050/testReport)**
for PR 17298 at commit
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/11105
So if there is interest (cc @squito ) I'm open to update this and go with
the warning signs in the doc approach if there is reviewer interest. Otherwise
I'll kick the tires on this again when were
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/17298
Jenkins retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
GitHub user squito opened a pull request:
https://github.com/apache/spark/pull/19313
[SPARK-21928][CORE] Set classloader on SerializerManager's private kryo
## What changes were proposed in this pull request?
We have to make sure that SerializerManager's private instance of
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/9207
@MLNick: Do you have the bandwith to revisit this? I'm open to refactoring
to a more plug-gable approach if we've got the review bandwidth for it.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18994
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18994
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82039/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18994
**[Test build #82039 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82039/testReport)**
for PR 18994 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19312
**[Test build #82048 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82048/testReport)**
for PR 19312 at commit
GitHub user holdenk opened a pull request:
https://github.com/apache/spark/pull/19312
[SPARK-22072][SPARK-22071][BUILD]Improve release build scripts
## What changes were proposed in this pull request?
Check JDK version (with javac) and use SPARK_VERSION for publish-release
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/19312
cc @JoshRosen
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19294#discussion_r140342523
--- Diff:
core/src/main/scala/org/apache/spark/internal/io/HadoopMapReduceCommitProtocol.scala
---
@@ -57,6 +57,11 @@ class
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16578
**[Test build #82047 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82047/testReport)**
for PR 16578 at commit
Github user markhamstra commented on a diff in the pull request:
https://github.com/apache/spark/pull/19194#discussion_r140340018
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -619,6 +625,47 @@ private[spark] class ExecutorAllocationManager(
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/16578#discussion_r140338751
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/QueryPlanConstraints.scala
---
@@ -77,20 +77,21 @@ trait
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/16578#discussion_r140338601
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/QueryPlanConstraints.scala
---
@@ -77,20 +77,21 @@ trait
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/19194#discussion_r140337893
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -619,6 +625,47 @@ private[spark] class ExecutorAllocationManager(
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19308
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19308
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82038/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19308
**[Test build #82038 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82038/testReport)**
for PR 19308 at commit
Github user pgandhi999 commented on the issue:
https://github.com/apache/spark/pull/19270
I believe you mean the opposite of what you wrote. My changes are visible
in the web ui(while the app is running) and not in the SHS(once the job is
done). Yep I see that and am working on the
Github user tejasapatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/19222#discussion_r140336969
--- Diff:
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/expressions/HiveHasher.java
---
@@ -38,6 +39,10 @@ public static int hashLong(long
Github user tejasapatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/19222#discussion_r140336704
--- Diff:
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/expressions/HiveHasher.java
---
@@ -38,6 +39,10 @@ public static int hashLong(long
Github user tejasapatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/19222#discussion_r140336092
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/array/ByteArrayMethods.java
---
@@ -46,6 +47,42 @@ public static int
101 - 200 of 422 matches
Mail list logo
