Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19293
@LantaoJin Please add a test case.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19293
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19321
Could you document the change in the output type of `percentile_approx ` in
the following section?
https://spark.apache.org/docs/latest/sql-programming-guide.html#migration-guide
---
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19321#discussion_r140647928
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproximatePercentile.scala
---
@@ -123,7 +124,13 @@ case
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19321#discussion_r140647683
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproximatePercentile.scala
---
@@ -134,7 +141,18 @@ case
Github user ConeyLiu commented on the issue:
https://github.com/apache/spark/pull/19317
Does not `treeAggregate` will introduce another `Shuffle`?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19286
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19286
Thanks! Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19286
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user jinxing64 commented on the issue:
https://github.com/apache/spark/pull/19330
@hvanhovell
Thanks a lot for comment.
I got you point. I will refine soon.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18704
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18704
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82125/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18704
**[Test build #82125 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82125/testReport)**
for PR 18704 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19286
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19286
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82123/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19286
**[Test build #82123 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82123/testReport)**
for PR 19286 at commit
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/19286
@viirya No problem. The newer version you have looks clean as well.
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18704
**[Test build #82125 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82125/testReport)**
for PR 18704 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18704
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82124/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18704
**[Test build #82124 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82124/testReport)**
for PR 18704 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18704
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18704
**[Test build #82124 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82124/testReport)**
for PR 18704 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19286
**[Test build #82123 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82123/testReport)**
for PR 19286 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19286
@dilipbiswal Thanks for the suggestion. However, it looks more complicated,
IMO.
---
-
To unsubscribe, e-mail:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19286#discussion_r140644507
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/AggregatedDialect.scala ---
@@ -43,6 +43,17 @@ private class AggregatedDialect(dialects:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18704
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18704
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82122/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18704
**[Test build #82122 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82122/testReport)**
for PR 18704 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18704
**[Test build #82122 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82122/testReport)**
for PR 18704 at commit
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19290
oh, remember to remove WIP and update this line
https://github.com/apache/spark/pull/19290/files#diff-74ca2b618d236bbd6faa23e13bff1403R30
before merging in?
---
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19290#discussion_r140643692
--- Diff: R/pkg/R/DataFrame.R ---
@@ -2650,8 +2650,9 @@ setMethod("merge",
#' @param suffix a suffix for the column name
#' @return list of
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/19286
@viirya Hey simon, thanks for catching this. Will it be little easier to
follow if we wrote like this ?
```
override def isCascadingTruncateTable(): Option[Boolean] = {
def
Github user szhem commented on the issue:
https://github.com/apache/spark/pull/19294
@mridulm
> incorporating a test for the sql part will also help in this matter.
What should be the expected behaviour in case of sql?
I'm asking because [the sql part seems to fail
Github user HyukjinKwon closed the pull request at:
https://github.com/apache/spark/pull/19333
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18747
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82121/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18747
Build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18747
**[Test build #82121 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82121/testReport)**
for PR 18747 at commit
Github user jgoleary commented on the issue:
https://github.com/apache/spark/pull/19326
@HyukjinKwon looks like this does the same thing as `name()` is an alias
for `alias()`. Happy to close but suggest merging one of these to help future
noobs.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19290
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82120/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19290
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19290
**[Test build #82120 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82120/testReport)**
for PR 19290 at commit
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19321
That's a good point, thanks
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19222
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19222
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82118/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19222
**[Test build #82118 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82118/testReport)**
for PR 19222 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19295
I do not think we should do it. The extra pre-optimizer rules can easily
break our existing optimizer rules. Adding post optimizer rules should be
enough for 99% cases.
---
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19295#discussion_r140638641
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/ExperimentalMethods.scala ---
@@ -44,11 +44,14 @@ class ExperimentalMethods private[sql]() {
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18747
**[Test build #82121 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82121/testReport)**
for PR 18747 at commit
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/19333
@HyukjinKwon Could you close this PR?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/19333
Thanks! merging to branch-2.2.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19277
**[Test build #3933 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3933/testReport)**
for PR 19277 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19333
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19333
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82119/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19333
**[Test build #82119 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82119/testReport)**
for PR 19333 at commit
Github user tejasapatil commented on the issue:
https://github.com/apache/spark/pull/19330
@hvanhovell : based on [your comment over the
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19286#discussion_r140638171
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/AggregatedDialect.scala ---
@@ -43,6 +43,17 @@ private class AggregatedDialect(dialects:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19286#discussion_r140638141
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/AggregatedDialect.scala ---
@@ -43,6 +43,17 @@ private class AggregatedDialect(dialects:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19286#discussion_r140638128
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -749,6 +749,34 @@ class JDBCSuite extends SparkFunSuite
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19329
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19329
Thanks! Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19329
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user akopich commented on the issue:
https://github.com/apache/spark/pull/18924
@WeichenXu123, thanks for creating Jira. Yes, sure I will work on it.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19332
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82117/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19332
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19290
**[Test build #82120 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82120/testReport)**
for PR 19290 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19332
**[Test build #82117 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82117/testReport)**
for PR 19332 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19290
I also tried v1.0.1 against the master; however, it looks not detecting
many instances this PR fixes. It only detected 3 extra instances:
```
R/DataFrame.R:2615:22: style: Variable
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19290
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/17743
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/17743
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19290
> 5 min: this is mildly concerning, is it possible this is caused by new
checks in lintr? perhaps we could exclude them or something?
1.0.1 miss the linters below (vs master):
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/19310
It probably is. The feature only works on Linux, but thanks for working
towards fixing this.
---
-
To unsubscribe, e-mail:
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/19333
LGTM, pending Jenkins.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19333
**[Test build #82119 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82119/testReport)**
for PR 19333 at commit
GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/spark/pull/19333
[SPARK-22109][SQL][BRANCH-2.2] Resolves type conflicts between strings and
timestamps in partition column
## What changes were proposed in this pull request?
This PR backports
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19222
**[Test build #82118 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82118/testReport)**
for PR 19222 at commit
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/19222
Jenkins, retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19331
Definitely.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/19331
@HyukjinKwon Could you send a pr to backport this to branch-2.2 please?
---
-
To unsubscribe, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19331
Thank you @ueshin!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/19331
Thanks! merging to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19331
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/19331
LGTM.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17743
**[Test build #3934 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3934/testReport)**
for PR 17743 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19266
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19320
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17743
**[Test build #3934 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3934/testReport)**
for PR 17743 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19266
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19320
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19277
**[Test build #3933 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3933/testReport)**
for PR 19277 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19290
> anyway I mean if we use the git tag 9951084 it should match v1.0.1
release exactly.
the one you listed jimhester/lintr@5431140 is in master I think and perhaps
you are saying there are
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/19323
@ala can you close this one? The merge script does not do that for
backports.
---
-
To unsubscribe, e-mail:
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/19323
merging to 2.2/2.1. Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19332
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82114/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19332
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19332
**[Test build #82114 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82114/testReport)**
for PR 19332 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19222
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19222
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82116/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19222
**[Test build #82116 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82116/testReport)**
for PR 19222 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19322
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
1 - 100 of 171 matches
Mail list logo
