Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140933568
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationChecker.scala
---
@@ -233,16 +234,46 @@ object
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/18931
@maropu @kiszk Thanks for your comments. I've addressed them all. Thanks.
---
-
To unsubscribe, e-mail:
Github user joseph-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140933095
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -157,11 +164,20 @@ case class
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/18931
@cloud-fan I think the approach looks much clear now. Can you take a look
if you have time? Thanks. also cc @gatorsmile for review Thanks.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18931
**[Test build #82165 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82165/testReport)**
for PR 18931 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/18931
Thanks @juliuszsompolski. The merged #19324 simplified `continue` usage. I
can remove the part to deal with it now.
---
-
To
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18931
**[Test build #82164 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82164/testReport)**
for PR 18931 at commit
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/19325
LGTM, pending Jenkins.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19041
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19041
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82160/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19041
**[Test build #82160 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82160/testReport)**
for PR 19041 at commit
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140931385
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationChecker.scala
---
@@ -233,16 +234,46 @@ object
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r140931214
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExpandExec.scala ---
@@ -89,6 +89,8 @@ case class ExpandExec(
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/15769#discussion_r140930985
--- Diff:
core/src/main/scala/org/apache/spark/internal/io/SparkHadoopMapReduceWriter.scala
---
@@ -0,0 +1,249 @@
+/*
+ * Licensed to the
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19327
**[Test build #82163 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82163/testReport)**
for PR 19327 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19327
**[Test build #82162 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82162/testReport)**
for PR 19327 at commit
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140914684
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala
---
@@ -309,19 +396,24 @@ class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140912351
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala
---
@@ -87,70 +87,157 @@ class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140906369
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -324,17 +389,33 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140927997
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationsSuite.scala
---
@@ -416,32 +421,32 @@ class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140905683
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -216,22 +232,70 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140910541
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala
---
@@ -87,70 +87,157 @@ class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140903737
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -216,22 +232,70 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140900883
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -157,11 +164,20 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140910588
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala
---
@@ -87,70 +87,157 @@ class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140911830
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala
---
@@ -87,70 +87,157 @@ class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140913768
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala
---
@@ -87,70 +87,157 @@ class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140911442
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala
---
@@ -87,70 +87,157 @@ class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140904307
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -216,22 +232,70 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140913094
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala
---
@@ -87,70 +87,157 @@ class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140928059
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -146,7 +146,14 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140912029
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala
---
@@ -87,70 +87,157 @@ class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140911245
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala
---
@@ -87,70 +87,157 @@ class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140900266
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -157,11 +164,20 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140903616
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -216,22 +232,70 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140910781
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -324,17 +389,33 @@ case class
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/19342#discussion_r140920250
--- Diff: R/pkg/R/DataFrame.R ---
@@ -3250,6 +3250,7 @@ setMethod("attach",
function(what, pos = 2, name = deparse(substitute(what)),
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19325
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19325
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82159/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19325
**[Test build #82159 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82159/testReport)**
for PR 19325 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19325
**[Test build #82161 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82161/testReport)**
for PR 19325 at commit
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/19325#discussion_r140915736
--- Diff: python/pyspark/sql/functions.py ---
@@ -2183,14 +2183,29 @@ def pandas_udf(f=None, returnType=StringType()):
:param f: python
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19325#discussion_r140908666
--- Diff: python/pyspark/sql/functions.py ---
@@ -2183,14 +2183,29 @@ def pandas_udf(f=None, returnType=StringType()):
:param f: python
Github user falaki commented on the issue:
https://github.com/apache/spark/pull/19342
Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19341
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19341
Thanks! Merged to master/2.2
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19341
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19041
**[Test build #82160 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82160/testReport)**
for PR 19041 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/19309
/cc @gatorsmile @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19342
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/19041
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
GitHub user bdwyer2 opened a pull request:
https://github.com/apache/spark/pull/19342
[MINOR][SparkR] minor fixes for CRAN compliance
## What changes were proposed in this pull request?
Added `SystemRequirements` field to the `Description` file and added an
`on.exit()`
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19325
**[Test build #82159 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82159/testReport)**
for PR 19325 at commit
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/19325#discussion_r140891646
--- Diff: python/pyspark/sql/functions.py ---
@@ -2183,14 +2183,29 @@ def pandas_udf(f=None, returnType=StringType()):
:param f: python
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/19331#discussion_r140890429
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala
---
@@ -470,15 +471,15 @@ object PartitioningUtils {
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19327
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82158/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19327
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19327
**[Test build #82158 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82158/testReport)**
for PR 19327 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18887
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82155/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18887
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18887
**[Test build #82155 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82155/testReport)**
for PR 18887 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18887
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82154/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18887
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18887
**[Test build #82154 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82154/testReport)**
for PR 18887 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19324
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19324
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19341
**[Test build #3935 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3935/testReport)**
for PR 19341 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19327
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19327
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82157/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19327
**[Test build #82157 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82157/testReport)**
for PR 19327 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19327
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82156/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19327
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19327
**[Test build #82156 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82156/testReport)**
for PR 19327 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19324
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19324
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82153/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19324
**[Test build #82153 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82153/testReport)**
for PR 19324 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19338
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19338
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82152/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19338
**[Test build #82152 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82152/testReport)**
for PR 19338 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19020
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82151/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19020
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19020
**[Test build #82151 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82151/testReport)**
for PR 19020 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19311
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19311
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82150/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19311
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/19325#discussion_r140868188
--- Diff: python/pyspark/sql/functions.py ---
@@ -2183,14 +2183,29 @@ def pandas_udf(f=None, returnType=StringType()):
:param f: python
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19311
**[Test build #82150 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82150/testReport)**
for PR 19311 at commit
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/19325
Thanks @HyukjinKwon @viirya and @ueshin , all good ideas! I'll push an
update, but seems like we need to figure out what's going on with the Jenkins
doctests, so I'll try to get some help
Github user ajbozarth commented on the issue:
https://github.com/apache/spark/pull/18015
Still LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18853
Thanks for working on it!
I checked the related codes in HIve. Does the current fix resolve all the
differences between Hive-speicific type casting/coercion? Please list all the
Github user rezasafi commented on a diff in the pull request:
https://github.com/apache/spark/pull/15769#discussion_r140862939
--- Diff:
core/src/main/scala/org/apache/spark/internal/io/SparkHadoopMapReduceWriter.scala
---
@@ -0,0 +1,249 @@
+/*
+ * Licensed to the Apache
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19340#discussion_r140861746
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala ---
@@ -546,10 +574,88 @@ object KMeans {
.run(data)
}
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19340#discussion_r140861096
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala ---
@@ -546,10 +574,88 @@ object KMeans {
.run(data)
}
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19340#discussion_r140860281
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala ---
@@ -546,10 +574,88 @@ object KMeans {
.run(data)
}
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19340#discussion_r140859735
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -260,7 +269,8 @@ class KMeans @Since("1.5.0") (
maxIter -> 20,
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19340#discussion_r140859569
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -71,6 +71,15 @@ private[clustering] trait KMeansParams extends Params
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19327
**[Test build #82158 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82158/testReport)**
for PR 19327 at commit
Github user joseph-torres commented on the issue:
https://github.com/apache/spark/pull/19327
I believe I've addressed all comments. Some refactorings made some comments
obsolete, though.
I've also fixed 1 bug and 1 test issue causing the 2 unit test failures.
There's
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/19311
LGTM. Merging to master / 2.2 / 2.1.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/19311
(After tests are done, I mean.)
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
101 - 200 of 333 matches
Mail list logo
