Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19175
**[Test build #82145 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82145/testReport)**
for PR 19175 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19337
**[Test build #82144 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82144/testReport)**
for PR 19337 at commit
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/19175#discussion_r140731720
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1287,3 +1288,33 @@ object
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19336
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82143/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19336
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19336
**[Test build #82143 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82143/testReport)**
for PR 19336 at commit
Github user DonnyZone commented on a diff in the pull request:
https://github.com/apache/spark/pull/19175#discussion_r140729331
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1287,3 +1288,33 @@ object
Github user mpjlu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19337#discussion_r140727204
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
@@ -573,7 +584,8 @@ private[clustering] object OnlineLDAOptimizer {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19337#discussion_r140725930
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
@@ -573,7 +584,8 @@ private[clustering] object OnlineLDAOptimizer {
GitHub user mpjlu opened a pull request:
https://github.com/apache/spark/pull/19337
[SPARK-22114][ML][MLLIB]add epsilon for LDA
## What changes were proposed in this pull request?
The current convergence condition of OnlineLDAOptimizer is:
while(meanGammaChange > 1e-3)
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/19175
@DonnyZone The current heavy weight approach should be better in terms of
data being scanned and moved. The main problem is just that shuffles get too
bulky. However this is a no-trivial problem
Github user ala commented on the issue:
https://github.com/apache/spark/pull/19323
@hvanhovell Sure. Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/19175#discussion_r140719222
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -481,6 +481,13 @@ object SQLConf {
.booleanConf
Github user ala closed the pull request at:
https://github.com/apache/spark/pull/19323
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/19175#discussion_r140718061
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1287,3 +1288,33 @@ object
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/19175#discussion_r140717934
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1287,3 +1288,33 @@ object
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/19175#discussion_r140717827
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1287,3 +1288,33 @@ object
Github user DonnyZone commented on the issue:
https://github.com/apache/spark/pull/19175
@cloud-fan Do you have time to review this PR? We found it is useful in
high dimensional cube cases.
---
-
To unsubscribe,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19336
**[Test build #82143 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82143/testReport)**
for PR 19336 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19336
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19336
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19336
**[Test build #82142 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82142/testReport)**
for PR 19336 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19336
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82142/
Test FAILed.
---
Github user stanzhai commented on a diff in the pull request:
https://github.com/apache/spark/pull/19301#discussion_r140699522
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -72,11 +74,19 @@ object
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18887#discussion_r140691818
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -422,208 +457,101 @@ private[history] class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18887#discussion_r140689640
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -720,75 +634,218 @@ private[history] class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18887#discussion_r140689773
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -742,53 +703,150 @@ private[history] object
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18887#discussion_r140689420
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -720,75 +634,218 @@ private[history] class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18887#discussion_r140691501
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -422,208 +457,101 @@ private[history] class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18887#discussion_r140692278
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -720,75 +634,218 @@ private[history] class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18887#discussion_r140689830
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -422,208 +457,101 @@ private[history] class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18887#discussion_r140699378
--- Diff:
core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala
---
@@ -624,7 +639,9 @@ class FsHistoryProviderSuite extends
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19229
@gatorsmile Added the check for case sensitivity. Please take a look again.
Thanks.
---
-
To unsubscribe, e-mail:
301 - 333 of 333 matches
Mail list logo
