[GitHub] spark issue #19229: [SPARK-22001][ML][SQL] ImputerModel can do withColumn fo...

2017-09-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19229 **[Test build #82369 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82369/testReport)** for PR 19229 at commit

[GitHub] spark issue #19083: [SPARK-21871][SQL] Check actual bytecode size when compi...

2017-09-30 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19083 Y --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19229: [SPARK-22001][ML][SQL] ImputerModel can do withCo...

2017-09-30 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19229#discussion_r142021142 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -2083,22 +2083,57 @@ class Dataset[T] private[sql]( * @group untypedrel

[GitHub] spark pull request #19229: [SPARK-22001][ML][SQL] ImputerModel can do withCo...

2017-09-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19229#discussion_r142021120 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -2083,22 +2083,57 @@ class Dataset[T] private[sql]( * @group

[GitHub] spark issue #19406: [SPARK-22179] percentile_approx should choose the first ...

2017-09-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19406 **[Test build #82368 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82368/testReport)** for PR 19406 at commit

[GitHub] spark pull request #19229: [SPARK-22001][ML][SQL] ImputerModel can do withCo...

2017-09-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19229#discussion_r142021066 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -2083,22 +2083,57 @@ class Dataset[T] private[sql]( * @group

[GitHub] spark issue #19406: [SPARK-22179] percentile_approx should choose the first ...

2017-09-30 Thread wzhfy
Github user wzhfy commented on the issue: https://github.com/apache/spark/pull/19406 cc @thunterdb @cloud-fan @gatorsmile --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #19406: [SPARK-22179] percentile_approx should choose the...

2017-09-30 Thread wzhfy
GitHub user wzhfy opened a pull request: https://github.com/apache/spark/pull/19406 [SPARK-22179] percentile_approx should choose the first element for small percentage ## What changes were proposed in this pull request? percentile_approx should choose the first element

[GitHub] spark issue #19402: [SPARK-22167][R][BUILD] sparkr packaging issue allow zin...

2017-09-30 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/19402 Sounds good :) --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19083: [SPARK-21871][SQL] Check actual bytecode size when compi...

2017-09-30 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/19083 ok to remove the option in this pr? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #19402: [SPARK-22167][R][BUILD] sparkr packaging issue allow zin...

2017-09-30 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/19402 passed https://ci.appveyor.com/project/ApacheSoftwareFoundation/spark/build/1804-master --- - To unsubscribe, e-mail:

[GitHub] spark issue #19083: [SPARK-21871][SQL] Check actual bytecode size when compi...

2017-09-30 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19083 Yeah, please remove it. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19083: [SPARK-21871][SQL] Check actual bytecode size when compi...

2017-09-30 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/19083 IMHO we could drop the option safely. cc: @eatoncys --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark pull request #19083: [SPARK-21871][SQL] Check actual bytecode size whe...

2017-09-30 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/19083#discussion_r142020549 --- Diff: sql/core/src/test/resources/sql-tests/inputs/group-by.sql --- @@ -30,8 +30,15 @@ SELECT a + 2, COUNT(b) FROM testData GROUP BY a + 1; SELECT a

[GitHub] spark issue #19083: [SPARK-21871][SQL] Check actual bytecode size when compi...

2017-09-30 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19083 Do we still need `spark.sql.codegen.maxLinesPerFunction`? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark pull request #19083: [SPARK-21871][SQL] Check actual bytecode size whe...

2017-09-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19083#discussion_r142020459 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameTimeWindowingSuite.scala --- @@ -228,29 +241,35 @@ class DataFrameTimeWindowingSuite

[GitHub] spark pull request #19083: [SPARK-21871][SQL] Check actual bytecode size whe...

2017-09-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19083#discussion_r142020462 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -2102,25 +2102,31 @@ class SQLQuerySuite extends QueryTest with

[GitHub] spark pull request #19083: [SPARK-21871][SQL] Check actual bytecode size whe...

2017-09-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19083#discussion_r142020453 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameTimeWindowingSuite.scala --- @@ -95,50 +96,62 @@ class DataFrameTimeWindowingSuite

[GitHub] spark pull request #19083: [SPARK-21871][SQL] Check actual bytecode size whe...

2017-09-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19083#discussion_r142020457 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameTimeWindowingSuite.scala --- @@ -95,50 +96,62 @@ class DataFrameTimeWindowingSuite

[GitHub] spark pull request #19083: [SPARK-21871][SQL] Check actual bytecode size whe...

2017-09-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19083#discussion_r142020451 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala --- @@ -416,25 +416,31 @@ class DataFrameAggregateSuite extends

[GitHub] spark pull request #19083: [SPARK-21871][SQL] Check actual bytecode size whe...

2017-09-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19083#discussion_r142020435 --- Diff: sql/core/src/test/resources/sql-tests/inputs/group-by.sql --- @@ -30,8 +30,15 @@ SELECT a + 2, COUNT(b) FROM testData GROUP BY a + 1;

[GitHub] spark issue #19401: [SPARK-22176][SQL] Fix overflow issue in Dataset.show

2017-09-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19401 **[Test build #82366 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82366/testReport)** for PR 19401 at commit

[GitHub] spark issue #19083: [SPARK-21871][SQL] Check actual bytecode size when compi...

2017-09-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19083 **[Test build #82367 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82367/testReport)** for PR 19083 at commit

[GitHub] spark issue #19083: [SPARK-21871][SQL] Check actual bytecode size when compi...

2017-09-30 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/19083 retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19401: [SPARK-22176][SQL] Fix overflow issue in Dataset.show

2017-09-30 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/19401 It seems jenkins gets sleep --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19401: [SPARK-22176][SQL] Fix overflow issue in Dataset.show

2017-09-30 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/19401 retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19405: [SPARK-22178] [SQL] Refresh Persistent Views by REFRESH ...

2017-09-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19405 **[Test build #82365 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82365/testReport)** for PR 19405 at commit

[GitHub] spark pull request #19405: [SPARK-22178] [SQL] Refresh Persistent Views by R...

2017-09-30 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/19405 [SPARK-22178] [SQL] Refresh Persistent Views by REFRESH TABLE Command ## What changes were proposed in this pull request? The underlying tables of persistent views are not refreshed when

[GitHub] spark issue #19401: [SPARK-22176][SQL] Fix overflow issue in Dataset.show

2017-09-30 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19401 retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19401: [SPARK-22176][SQL] Fix overflow issue in Dataset.show

2017-09-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19401 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82363/ Test FAILed. ---

[GitHub] spark issue #19083: [SPARK-21871][SQL] Check actual bytecode size when compi...

2017-09-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19083 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82364/ Test FAILed. ---

[GitHub] spark issue #19401: [SPARK-22176][SQL] Fix overflow issue in Dataset.show

2017-09-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19401 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19083: [SPARK-21871][SQL] Check actual bytecode size when compi...

2017-09-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19083 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19404: [SPARK-21760] [Streaming] Fix for Structured streaming t...

2017-09-30 Thread rekhajoshm
Github user rekhajoshm commented on the issue: https://github.com/apache/spark/pull/19404 Seems to be apache spark git/jenkins issue.Please retest after a while.thanks --- - To unsubscribe, e-mail:

[GitHub] spark issue #19083: [SPARK-21871][SQL] Check actual bytecode size when compi...

2017-09-30 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/19083 retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19401: [SPARK-22176][SQL] Fix overflow issue in Dataset.show

2017-09-30 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/19401 retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #17702: [SPARK-20408][SQL] Get the glob path in parallel to redu...

2017-09-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17702 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19404: [SPARK-21760] [Streaming] Fix for Structured streaming t...

2017-09-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19404 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82359/ Test FAILed. ---

[GitHub] spark issue #19083: [SPARK-21871][SQL] Check actual bytecode size when compi...

2017-09-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19083 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82362/ Test FAILed. ---

[GitHub] spark issue #19401: [SPARK-22176][SQL] Fix overflow issue in Dataset.show

2017-09-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19401 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82361/ Test FAILed. ---

[GitHub] spark issue #17702: [SPARK-20408][SQL] Get the glob path in parallel to redu...

2017-09-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17702 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82360/ Test FAILed. ---

[GitHub] spark issue #19404: [SPARK-21760] [Streaming] Fix for Structured streaming t...

2017-09-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19404 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19401: [SPARK-22176][SQL] Fix overflow issue in Dataset.show

2017-09-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19401 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19083: [SPARK-21871][SQL] Check actual bytecode size when compi...

2017-09-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19083 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #17702: [SPARK-20408][SQL] Get the glob path in parallel to redu...

2017-09-30 Thread xuanyuanking
Github user xuanyuanking commented on the issue: https://github.com/apache/spark/pull/17702 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19083: [SPARK-21871][SQL] Check actual bytecode size whe...

2017-09-30 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/19083#discussion_r142018768 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -585,10 +586,22 @@ object SQLConf { .doc("The maximum

[GitHub] spark pull request #19083: [SPARK-21871][SQL] Check actual bytecode size whe...

2017-09-30 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/19083#discussion_r142018586 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -585,10 +586,22 @@ object SQLConf { .doc("The maximum

[GitHub] spark pull request #19401: [SPARK-22176][SQL] Fix overflow issue in Dataset....

2017-09-30 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/19401#discussion_r142018469 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -238,7 +238,7 @@ class Dataset[T] private[sql]( private[sql] def

[GitHub] spark pull request #19404: [SPARK-21760] [Streaming] Fix for Structured stre...

2017-09-30 Thread rekhajoshm
GitHub user rekhajoshm opened a pull request: https://github.com/apache/spark/pull/19404 [SPARK-21760] [Streaming] Fix for Structured streaming terminates with Exception ## What changes were proposed in this pull request? Updated serialize call for flush and FSDataOutputStream

[GitHub] spark issue #19402: [SPARK-22167][R][BUILD] sparkr packaging issue allow zin...

2017-09-30 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/19402 building your change here #19403 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19403: [R][BUILD][WIP] test

2017-09-30 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/19403 first build https://ci.appveyor.com/project/ApacheSoftwareFoundation/spark/build/1803-master second build https://ci.appveyor.com/project/ApacheSoftwareFoundation/spark/build/1804-master

[GitHub] spark issue #19403: [R][BUILD][WIP] test

2017-09-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19403 **[Test build #82358 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82358/testReport)** for PR 19403 at commit

[GitHub] spark issue #19403: [R][BUILD][WIP] test

2017-09-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19403 **[Test build #82357 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82357/testReport)** for PR 19403 at commit

[GitHub] spark issue #19403: [R][BUILD][WIP] test

2017-09-30 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/19403 hmm, it looks like it is working perhaps the github.com indicator is broken https://ci.appveyor.com/project/ApacheSoftwareFoundation/spark ---

[GitHub] spark pull request #19403: [R][BUILD][WIP] test

2017-09-30 Thread felixcheung
GitHub user felixcheung opened a pull request: https://github.com/apache/spark/pull/19403 [R][BUILD][WIP] test ## What changes were proposed in this pull request? test appveyor You can merge this pull request into a Git repository by running: $ git pull

[GitHub] spark issue #19402: [SPARK-22167][R][BUILD] sparkr packaging issue allow zin...

2017-09-30 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/19402 I'm not sure why appveyor is not triggered... but I thought this is more of a java/scala change. since jenkins passes and if you have verified release-build.sh works with this with zinc on

[GitHub] spark issue #19402: [SPARK-22167][R][BUILD] sparkr packaging issue allow zin...

2017-09-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19402 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19402: [SPARK-22167][R][BUILD] sparkr packaging issue allow zin...

2017-09-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19402 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82356/ Test PASSed. ---

[GitHub] spark issue #19402: [SPARK-22167][R][BUILD] sparkr packaging issue allow zin...

2017-09-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19402 **[Test build #82356 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82356/testReport)** for PR 19402 at commit

[GitHub] spark pull request #19083: [SPARK-21871][SQL] Check actual bytecode size whe...

2017-09-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19083#discussion_r142012782 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -585,10 +586,22 @@ object SQLConf { .doc("The maximum

[GitHub] spark issue #19402: [SPARK-22167][R][BUILD] sparkr packaging issue allow zin...

2017-09-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19402 **[Test build #82356 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82356/testReport)** for PR 19402 at commit

[GitHub] spark issue #19402: [SPARK-22167][R][BUILD] sparkr packaging issue allow zin...

2017-09-30 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/19402 @felixcheung can you trigger the R tests for this? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark pull request #19083: [SPARK-21871][SQL] Check actual bytecode size whe...

2017-09-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19083#discussion_r142012633 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -585,10 +586,22 @@ object SQLConf { .doc("The maximum

[GitHub] spark pull request #19401: [SPARK-22176][SQL] Fix overflow issue in Dataset....

2017-09-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19401#discussion_r142012580 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -238,7 +238,7 @@ class Dataset[T] private[sql]( private[sql] def

[GitHub] spark issue #19270: [SPARK-21809] : Change Stage Page to use datatables to s...

2017-09-30 Thread pgandhi999
Github user pgandhi999 commented on the issue: https://github.com/apache/spark/pull/19270 No problem, @ajbozarth , and thank you for your valuable feedback. I really appreciate it. --- - To unsubscribe, e-mail:

[GitHub] spark issue #19402: [SPARK-22167][R][BUILD] sparkr packaging issue allow zin...

2017-09-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19402 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82355/ Test PASSed. ---

[GitHub] spark issue #19402: [SPARK-22167][R][BUILD] sparkr packaging issue allow zin...

2017-09-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19402 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19402: [SPARK-22167][R][BUILD] sparkr packaging issue allow zin...

2017-09-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19402 **[Test build #82355 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82355/testReport)** for PR 19402 at commit

[GitHub] spark issue #19402: [SPARK-22167][R][BUILD] sparkr packaging issue allow zin...

2017-09-30 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/19402 That _should_ work more simply, thanks. I'll try that later on tonight. --- - To unsubscribe, e-mail:

[GitHub] spark issue #18732: [SPARK-20396][SQL][PySpark] groupby().apply() with panda...

2017-09-30 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/18732 What's the difference between this one and the transform function you also proposed? I'm trying to see if all the naming makes sense when considered together. ---

[GitHub] spark issue #19149: [SPARK-21652][SQL][FOLLOW-UP] Fix rule conflict between ...

2017-09-30 Thread adrian-ionescu
Github user adrian-ionescu commented on the issue: https://github.com/apache/spark/pull/19149 At least part of the issue was solved by #19201. Unless we have a repro case, let's not pursue this. --- - To

[GitHub] spark issue #19290: [SPARK-22063][R] Fixes lint check failures in R by lates...

2017-09-30 Thread shaneknapp
Github user shaneknapp commented on the issue: https://github.com/apache/spark/pull/19290 @felixcheung -- yes, this is the system default lintr, meaning all calls to lintr will be against this version. as for other branches, i think it could possibly break them.

[GitHub] spark pull request #19402: [SPARK-22167][R][BUILD] sparkr packaging issue al...

2017-09-30 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/19402#discussion_r142010483 --- Diff: core/pom.xml --- @@ -499,7 +499,7 @@ -

[GitHub] spark issue #19290: [SPARK-22063][R] Fixes lint check failures in R by lates...

2017-09-30 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/19290 btw, lintr once upgraded will run on all builds on all branches right? wouldn't the upgrade break other branches? --- - To

[GitHub] spark issue #19269: [SPARK-22026][SQL][WIP] data source v2 write path

2017-09-30 Thread steveloughran
Github user steveloughran commented on the issue: https://github.com/apache/spark/pull/19269 One other thing that would be good now and invaluable in future is for the `DataWriter.commit()` call to return a `Map[String,Long]` of statistics alongside the message sent to the committer.

[GitHub] spark issue #19401: [SPARK-22176][SQL] Fix overflow issue in Dataset.show

2017-09-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19401 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19401: [SPARK-22176][SQL] Fix overflow issue in Dataset.show

2017-09-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19401 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82354/ Test PASSed. ---

[GitHub] spark issue #19401: [SPARK-22176][SQL] Fix overflow issue in Dataset.show

2017-09-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19401 **[Test build #82354 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82354/testReport)** for PR 19401 at commit

[GitHub] spark issue #19083: [SPARK-21871][SQL] Check actual bytecode size when compi...

2017-09-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19083 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82353/ Test PASSed. ---

[GitHub] spark issue #19083: [SPARK-21871][SQL] Check actual bytecode size when compi...

2017-09-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19083 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19083: [SPARK-21871][SQL] Check actual bytecode size when compi...

2017-09-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19083 **[Test build #82353 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82353/testReport)** for PR 19083 at commit

[GitHub] spark issue #18732: [SPARK-20396][SQL][PySpark] groupby().apply() with panda...

2017-09-30 Thread icexelloss
Github user icexelloss commented on the issue: https://github.com/apache/spark/pull/18732 @rxin This is similar to flatMapGroups since the return value of the user function is a list of rows (pd.DataFrame) rather than a single row. ---

[GitHub] spark issue #19402: [SPARK-22167][R][BUILD] sparkr packaging issue allow zin...

2017-09-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19402 **[Test build #82355 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82355/testReport)** for PR 19402 at commit

[GitHub] spark issue #19402: [SPARK-22167][R][BUILD] sparkr packaging issue allow zin...

2017-09-30 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/19402 cc @felixcheung @vanzin --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19402: [SPARK-22167][R][BUILD] sparkr packaging issue allow zin...

2017-09-30 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/19402 Note: set -x is intentionally left in so that during the build it is clear which R source is being built. --- - To unsubscribe,

[GitHub] spark pull request #19402: [SPARK-22167][R][BUILD] sparkr packaging issue al...

2017-09-30 Thread holdenk
GitHub user holdenk opened a pull request: https://github.com/apache/spark/pull/19402 [SPARK-22167][R][BUILD] sparkr packaging issue allow zinc ## What changes were proposed in this pull request? When zinc is running the pwd might be in the root of the project. A quick

[GitHub] spark issue #19401: [SPARK-22176][SQL] Fix overflow issue in Dataset.show

2017-09-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19401 **[Test build #82354 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82354/testReport)** for PR 19401 at commit

[GitHub] spark pull request #19340: [SPARK-22119][ML] Add cosine distance to KMeans

2017-09-30 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/19340#discussion_r142006352 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala --- @@ -546,10 +574,88 @@ object KMeans { .run(data) }

[GitHub] spark pull request #19401: [SPARK-22176][SQL] Fix overflow issue in Dataset....

2017-09-30 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/19401#discussion_r142006295 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -238,9 +238,15 @@ class Dataset[T] private[sql]( private[sql] def

[GitHub] spark pull request #19401: [SPARK-22176][SQL] Fix overflow issue in Dataset....

2017-09-30 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19401#discussion_r142006251 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -238,9 +238,15 @@ class Dataset[T] private[sql]( private[sql] def

[GitHub] spark issue #19083: [SPARK-21871][SQL] Check actual bytecode size when compi...

2017-09-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19083 **[Test build #82353 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82353/testReport)** for PR 19083 at commit

[GitHub] spark pull request #19181: [SPARK-21907][CORE] oom during spill

2017-09-30 Thread eyalfa
Github user eyalfa commented on a diff in the pull request: https://github.com/apache/spark/pull/19181#discussion_r142005517 --- Diff: core/src/test/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorterSuite.java --- @@ -503,6 +511,39 @@ public void

[GitHub] spark issue #19401: [SPARK-22176][SQL] Fix overflow issue in Dataset.show

2017-09-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19401 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82352/ Test PASSed. ---

[GitHub] spark issue #19401: [SPARK-22176][SQL] Fix overflow issue in Dataset.show

2017-09-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19401 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19401: [SPARK-22176][SQL] Fix overflow issue in Dataset.show

2017-09-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19401 **[Test build #82352 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82352/testReport)** for PR 19401 at commit

[GitHub] spark pull request #19269: [SPARK-22026][SQL][WIP] data source v2 write path

2017-09-30 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/19269#discussion_r142005126 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2Command.scala --- @@ -0,0 +1,113 @@ +/* +

[GitHub] spark pull request #19269: [SPARK-22026][SQL][WIP] data source v2 write path

2017-09-30 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/19269#discussion_r142005072 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2Command.scala --- @@ -0,0 +1,113 @@ +/* +

[GitHub] spark pull request #19269: [SPARK-22026][SQL][WIP] data source v2 write path

2017-09-30 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/19269#discussion_r142004971 --- Diff: sql/core/src/test/java/test/org/apache/spark/sql/sources/v2/JavaSimpleWritableDataSource.java --- @@ -0,0 +1,297 @@ +/* + *

[GitHub] spark pull request #19269: [SPARK-22026][SQL][WIP] data source v2 write path

2017-09-30 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/19269#discussion_r142004889 --- Diff: sql/core/src/test/java/test/org/apache/spark/sql/sources/v2/JavaSimpleWritableDataSource.java --- @@ -0,0 +1,297 @@ +/* + *

[GitHub] spark pull request #19269: [SPARK-22026][SQL][WIP] data source v2 write path

2017-09-30 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/19269#discussion_r142004831 --- Diff: sql/core/src/test/java/test/org/apache/spark/sql/sources/v2/JavaSimpleWritableDataSource.java --- @@ -0,0 +1,297 @@ +/* + *

  1   2   >