Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19439
**[Test build #82481 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82481/testReport)**
for PR 19439 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19392
OK
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user shubhamchopra commented on the issue:
https://github.com/apache/spark/pull/17673
Thanks for your comments/suggestions @MLnick and @sethah . Working on
incorporating these.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19439
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19439
**[Test build #82480 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82480/testReport)**
for PR 19439 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19439
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82480/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19439
**[Test build #82480 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82480/testReport)**
for PR 19439 at commit
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19438#discussion_r143001025
--- Diff: R/pkg/tests/fulltests/test_sparkSQL.R ---
@@ -2538,7 +2538,7 @@ test_that("describe() and summary() on a DataFrame", {
stats2 <-
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19438#discussion_r143000567
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/ImputerSuite.scala ---
@@ -43,7 +43,7 @@ class ImputerSuite extends SparkFunSuite with
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19438#discussion_r142999631
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/ApproximatePercentileQuerySuite.scala
---
@@ -129,7 +144,7 @@ class ApproximatePercentileQuerySuite
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19438#discussion_r143000448
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -1038,8 +1038,8 @@ def summary(self, *statistics):
| mean| 3.5| null|
GitHub user imatiach-msft opened a pull request:
https://github.com/apache/spark/pull/19439
[SPARK-21866][ML][PySpark] Adding spark image reader
## What changes were proposed in this pull request?
Adding spark image reader, an implementation of schema for representing
images in
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19420#discussion_r142999706
--- Diff:
examples/src/main/java/org/apache/spark/examples/sql/hive/JavaSparkHiveExample.java
---
@@ -124,6 +124,13 @@ public static void
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19061
Could you review this `ConsoleProgressBar` PR again, @vanzin ?
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18732
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18732
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82477/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18732
**[Test build #82477 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82477/testReport)**
for PR 18732 at commit
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r142991123
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -171,20 +210,46 @@ final class Word2Vec @Since("1.4.0") (
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r142990145
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -171,20 +210,46 @@ final class Word2Vec @Since("1.4.0") (
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17357
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17357
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82476/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17357
**[Test build #82476 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82476/testReport)**
for PR 17357 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17774
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user wzhfy commented on the issue:
https://github.com/apache/spark/pull/19406
@HyukjinKwon thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user wzhfy closed the pull request at:
https://github.com/apache/spark/pull/19406
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/19438#discussion_r142981865
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/ApproximatePercentileQuerySuite.scala
---
@@ -129,7 +144,7 @@ class ApproximatePercentileQuerySuite
Github user wzhfy commented on the issue:
https://github.com/apache/spark/pull/19438
cc @srowen @jiangxb1987 @HyukjinKwon
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19406
Ah, that's fine :). It was just an option. I will follow discussion and
help sort it out in any event.
---
-
To
Github user wzhfy commented on the issue:
https://github.com/apache/spark/pull/19406
@HyukjinKwon These two JIRAs change percentile_approx in different ways, so
maybe it's better to use different JIRAs?
---
-
To
Github user wzhfy commented on the issue:
https://github.com/apache/spark/pull/19406
@HyukjinKwon uh...just saw this, already created a new [JIRA](url) and
[PR](https://github.com/apache/spark/pull/19438), is it also ok?
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19438
**[Test build #82479 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82479/testReport)**
for PR 19438 at commit
GitHub user wzhfy opened a pull request:
https://github.com/apache/spark/pull/19438
[SPARK-22208] [SQL] Improve percentile_approx by not rounding up
targetError and starting from index 0
## What changes were proposed in this pull request?
Currently percentile_approx never
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19406
Oh, optionally, we can just edit the JIRA I guess.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user wzhfy commented on the issue:
https://github.com/apache/spark/pull/19406
@srowen @jiangxb1987 OK, I'll close this JIRA and creating a new JIRA as
improvement instead of bugfix.
---
-
To unsubscribe,
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19090
@felixcheung, this one LGTM as I checked what I could all and quite
confident; however, will leave this open for few days more considering
importance. Let me please cc you here to double check
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19041
**[Test build #82478 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82478/testReport)**
for PR 19041 at commit
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/18732#discussion_r142961120
--- Diff: python/pyspark/worker.py ---
@@ -74,17 +74,35 @@ def wrap_udf(f, return_type):
def wrap_pandas_udf(f, return_type):
-
Github user icexelloss commented on the issue:
https://github.com/apache/spark/pull/18732
@HyukjinKwon Thanks for the summarry!
* https://github.com/apache/spark/pull/18732#discussion_r142735696
`ArrowPandasSerialzer`I will spend some time address this today.
*
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19369
**[Test build #3942 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3942/testReport)**
for PR 19369 at commit
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/19399#discussion_r142959826
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -850,6 +869,18 @@ private[history] class
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19436
Thanks @HyukjinKwon @felixcheung
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/18732#discussion_r142957552
--- Diff: python/pyspark/sql/functions.py ---
@@ -2058,7 +2058,7 @@ def __init__(self, func, returnType, name=None,
vectorized=False):
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19436
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19436
Merged to master, branch-2.2 and branch-2.1.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/18732#discussion_r142956597
--- Diff: python/pyspark/sql/group.py ---
@@ -194,6 +194,65 @@ def pivot(self, pivot_col, values=None):
jgd = self._jgd.pivot(pivot_col,
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18732#discussion_r142952213
--- Diff: python/pyspark/sql/group.py ---
@@ -192,7 +193,67 @@ def pivot(self, pivot_col, values=None):
jgd =
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18732
Ongoing discussions that (I think) might block this PR:
- https://github.com/apache/spark/pull/18732#discussion_r142735696 by
@BryanCutler: `ArrowPandasSerializer` able to serialize
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18732
**[Test build #82477 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82477/testReport)**
for PR 18732 at commit
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/18732#discussion_r142949557
--- Diff: python/pyspark/worker.py ---
@@ -74,17 +74,35 @@ def wrap_udf(f, return_type):
def wrap_pandas_udf(f, return_type):
-
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18732#discussion_r142949179
--- Diff: python/pyspark/worker.py ---
@@ -74,17 +74,35 @@ def wrap_udf(f, return_type):
def wrap_pandas_udf(f, return_type):
-
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/18732#discussion_r142948551
--- Diff: python/pyspark/sql/group.py ---
@@ -192,7 +193,67 @@ def pivot(self, pivot_col, values=None):
jgd = self._jgd.pivot(pivot_col)
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18732#discussion_r142948307
--- Diff: python/pyspark/worker.py ---
@@ -74,17 +74,35 @@ def wrap_udf(f, return_type):
def wrap_pandas_udf(f, return_type):
-
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18732#discussion_r142947514
--- Diff: python/pyspark/sql/group.py ---
@@ -192,7 +193,67 @@ def pivot(self, pivot_col, values=None):
jgd =
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18732#discussion_r142946504
--- Diff: python/pyspark/sql/group.py ---
@@ -192,7 +193,67 @@ def pivot(self, pivot_col, values=None):
jgd =
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18732#discussion_r142946430
--- Diff: python/pyspark/sql/group.py ---
@@ -192,7 +193,67 @@ def pivot(self, pivot_col, values=None):
jgd =
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/18732#discussion_r142945465
--- Diff: python/pyspark/sql/group.py ---
@@ -192,7 +193,67 @@ def pivot(self, pivot_col, values=None):
jgd = self._jgd.pivot(pivot_col)
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/18732#discussion_r142944123
--- Diff: python/pyspark/sql/group.py ---
@@ -192,7 +193,67 @@ def pivot(self, pivot_col, values=None):
jgd = self._jgd.pivot(pivot_col)
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19389
ping @gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19436
**[Test build #82474 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82474/testReport)**
for PR 19436 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19436
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19436
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82474/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17357
**[Test build #82476 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82476/testReport)**
for PR 17357 at commit
Github user susanxhuynh commented on the issue:
https://github.com/apache/spark/pull/19437
@ArtRand @skonto Please review. Tests passed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19437
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82475/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19437
**[Test build #82475 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82475/testReport)**
for PR 19437 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19437
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19437
**[Test build #82475 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82475/testReport)**
for PR 19437 at commit
GitHub user susanxhuynh opened a pull request:
https://github.com/apache/spark/pull/19437
[SPARK-22131][MESOS] Mesos driver secrets
## Background
In #18837 , @ArtRand added Mesos secrets support to the dispatcher. **This
PR is to add the same secrets support to the
Github user akopich commented on the issue:
https://github.com/apache/spark/pull/18924
Thank you, @hhbyyh.
I have augmented the example a bit: explicitly set random seed a nd chosen
online optimizer:
`val lda = new
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19369
**[Test build #3942 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3942/testReport)**
for PR 19369 at commit
Github user superbobry commented on the issue:
https://github.com/apache/spark/pull/19369
I've fixed the failing `DiskStoreSuite` and ensured the other two suites
also pass fine.
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19436
**[Test build #82474 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82474/testReport)**
for PR 19436 at commit
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19436#discussion_r142903183
--- Diff: R/pkg/tests/fulltests/test_sparkSQL.R ---
@@ -3075,6 +3075,11 @@ test_that("gapply() and gapplyCollect() on a
DataFrame", {
df1Collect <-
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19436#discussion_r142902434
--- Diff: R/pkg/tests/fulltests/test_sparkSQL.R ---
@@ -3075,6 +3075,11 @@ test_that("gapply() and gapplyCollect() on a
DataFrame", {
df1Collect <-
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19436#discussion_r142901810
--- Diff: R/pkg/tests/fulltests/test_sparkSQL.R ---
@@ -3075,6 +3075,11 @@ test_that("gapply() and gapplyCollect() on a
DataFrame", {
df1Collect
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19436
Let me install R environment to test it locally...
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/19374
@ArtRand @susanxhuynh gentle ping.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19369#discussion_r142896027
--- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala ---
@@ -67,7 +67,7 @@ private[spark] class DiskStore(
var threwException:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19436
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82473/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19436
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19436
**[Test build #82473 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82473/testReport)**
for PR 19436 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19369
**[Test build #3941 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3941/testReport)**
for PR 19369 at commit
Github user jomach commented on the issue:
https://github.com/apache/spark/pull/19429
@felixcheung Sorry for that. Should be there now. Can you test ? thanks
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19369
**[Test build #3941 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3941/testReport)**
for PR 19369 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19436
**[Test build #82473 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82473/testReport)**
for PR 19436 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19436
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19436
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19436
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82470/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19436
**[Test build #82470 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82470/testReport)**
for PR 19436 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19436
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19436
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82472/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19436
**[Test build #82472 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82472/testReport)**
for PR 19436 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18732
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18732
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82469/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18732
**[Test build #82469 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82469/testReport)**
for PR 18732 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19436
**[Test build #82472 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82472/testReport)**
for PR 19436 at commit
Github user squito commented on the issue:
https://github.com/apache/spark/pull/19287
lgtm, thanks @xuanyuanking
@jerryshao can you merge this? I will have very intermittent access for a
few weeks, I'd prefer not to merge in case there is any issue that needs an
urgent
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19337#discussion_r142854372
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
@@ -322,6 +326,13 @@ final class OnlineLDAOptimizer extends
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19337#discussion_r142853109
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -224,6 +224,20 @@ private[clustering] trait LDAParams extends Params
with
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19337#discussion_r142853643
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -224,6 +224,20 @@ private[clustering] trait LDAParams extends Params
with
201 - 300 of 305 matches
Mail list logo
