Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19424
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19424
**[Test build #82547 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82547/testReport)**
for PR 19424 at commit
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/19437
@susanxhuynh this a mesos 1.4 feature, shouldn't we document this for users?
https://issues.apache.org/jira/browse/MESOS-7418
---
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/19106
@srowen Any other comments? Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user krishna-pandey commented on a diff in the pull request:
https://github.com/apache/spark/pull/19419#discussion_r143427428
--- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala ---
@@ -89,6 +92,9 @@ private[spark] object JettyUtils extends Logging {
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/15770#discussion_r143426157
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/clustering/PowerIterationClustering.scala
---
@@ -0,0 +1,216 @@
+/*
+ * Licensed to the
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/19433
@smurching Does it still WIP ? If done remove "[WIP]", I will begin review,
thanks!
---
-
To unsubscribe, e-mail:
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19266#discussion_r143421894
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/BufferHolder.java
---
@@ -35,6 +35,11 @@
* if the fields of
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r143415419
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala
---
@@ -170,9 +174,122 @@
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r143413006
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/deploy/mesos/config.scala
---
@@ -21,6 +21,39 @@ import java.util.concurrent.TimeUnit
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r143411366
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala
---
@@ -170,9 +174,122 @@
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19363
**[Test build #82548 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82548/testReport)**
for PR 19363 at commit
Github user yaooqinn commented on the issue:
https://github.com/apache/spark/pull/19363
Okï¼i will add a jira tgt and fix RelationalGroupedDataset
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/18748
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19082
Yes no need for a back-and-forth. @gatorsmile I think it's reasonable to
ask for a little more detail on your comment.
---
-
To
Github user ScrapCodes commented on a diff in the pull request:
https://github.com/apache/spark/pull/17357#discussion_r143407147
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/DriverWrapper.scala ---
@@ -23,14 +23,15 @@ import org.apache.commons.lang3.StringUtils
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19438#discussion_r143406940
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameStatSuite.scala ---
@@ -157,21 +157,21 @@ class DataFrameStatSuite extends QueryTest with
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19438#discussion_r143406835
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/QuantileSummariesSuite.scala
---
@@ -58,7 +58,7 @@ class QuantileSummariesSuite
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19424
**[Test build #82547 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82547/testReport)**
for PR 19424 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19424
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19082
@gatorsmile If my words make you upset, I'm sorry. It's you right to raise
suspicion against any PRs. I do respect this right.
Maybe I'm wrong and there actually is a possible regression.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19363
shall we fix RelationalGroupedDataset too?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user smurching commented on a diff in the pull request:
https://github.com/apache/spark/pull/19433#discussion_r143398990
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/LocalDecisionTreeUtils.scala
---
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19082
OK. Based on your attitudes, I do not care it.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user crlalam commented on a diff in the pull request:
https://github.com/apache/spark/pull/19420#discussion_r143118902
--- Diff:
examples/src/main/java/org/apache/spark/examples/sql/hive/JavaSparkHiveExample.java
---
@@ -124,6 +124,13 @@ public static void main(String[]
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19082
If you really can't or don't willing to explain, we can wait for @kiszk or
@rednaxelafx to explain it.
---
-
To unsubscribe,
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19082
@gatorsmile You can't just drop few words without explanation and simply
say that others works don't work. I do respect your work/comments and you
should respect my works too.
---
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19082
Just try to help you understand it. If you don't want it, I can keep quiet.
---
-
To unsubscribe, e-mail:
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19082
No. I think you should explain it because this is your concern. You just
need to point out, where is the single blocking loop for the two operators?
---
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19082
Sorry, it is really hard to explain it to you. Maybe you can first think
about why the whole-stage codegen works better the previous solution?
---
Github user klion26 commented on the issue:
https://github.com/apache/spark/pull/19145
sorry for the late response, IIUC, in MR, this case handled by below
1. AM received the container failed message
2. AM will check whether there are any attempts of the same task is RUNNING
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19082
> After horizontal/ring cutting, each operator will be in a single blocking
loop. That means, whole-stage codegen is off.
And do we have anything to cut the operators to individual single
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19082
Yeah, once we exceed `hugeMethodLimit`, wholestage codegen is disabled. Can
you tell me how `hugeMethodLimit` makes each operator to a single blocking
loop? We didn't run codegen now.
---
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/19287
Thanks all reviewers!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19082
The relation is very clear. Let me copy what I said above
> Just imagine we have two nodes, we want to do a horizontal/ring cut.
Basically, in this scenario, horizontal/ring cutting
Github user guoxiaolongzte commented on the issue:
https://github.com/apache/spark/pull/19399
Nice, I think it should be merged.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19444#discussion_r143390226
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -405,6 +405,11 @@ object CatalogTypes {
*
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19287
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19287
LGTM, merging to master. Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19082
Ok. Any comments from @kiszk and @rednaxelafx on this topic? :)
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19287
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19287
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82546/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19287
**[Test build #82546 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82546/testReport)**
for PR 19287 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19082
Nope. You can wait for the answers from the JVM experts. : )
---
-
To unsubscribe, e-mail:
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19082
@gatorsmile Are you talking about this:
https://en.wikipedia.org/wiki/Loop_nest_optimization?
---
-
To unsubscribe,
301 - 345 of 345 matches
Mail list logo
