Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19471
**[Test build #82633 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82633/testReport)**
for PR 19471 at commit
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/19468
+ @susanxhuynh @ArtRand (Mesosphere).
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18664
That's a great explanation. I think you are right. Using
`SQLConf.SESSION_LOCAL_TIMEZONE` makes much more sense to me now.
---
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/19390
Glad to hear that @tawfiqul-islam, thank you for the feedback.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/19374#discussion_r143969946
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -804,45 +814,52 @@
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/19374#discussion_r143969875
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -374,6 +375,15 @@
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/19374#discussion_r143969837
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -276,8 +276,8 @@
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/19374
@susanxhuynh good catch I dont know about the time issue. Seems weird,
maybe another bug?
This is the section of the not completed apps by the way since this is a
streaming app.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19472
**[Test build #82634 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82634/testReport)**
for PR 19472 at commit
GitHub user kiszk opened a pull request:
https://github.com/apache/spark/pull/19472
Use MemoryBlock in UnsafeRow, UnsafeArrayData, and UnsafeMapData
## What changes were proposed in this pull request?
Waiting for merging #19222
This PR tries to use `MemoryBlock` in
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18931
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82627/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18931
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18931
**[Test build #82627 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82627/testReport)**
for PR 18931 at commit
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/18664
I disagree with using `DateTimeUtils.defaultTimeZone()` for the timezone.
If `DateTimeUtils.defaultTimeZone()` is different from system timezone in
Python, the return values are different between
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/19437
LGTM.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19471
cc @rxin @brkyvz @liancheng @gatorsmile @maropu
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19471
**[Test build #82633 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82633/testReport)**
for PR 19471 at commit
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/19471
[SPARK-22245][SQL] partitioned data set should always put partition columns
at the end
## Background
In Spark SQL, partition columns always appear at the end of the schema,
even with
Github user yssharma commented on the issue:
https://github.com/apache/spark/pull/18029
Thanks @brkyvz . Appreciate the review comments.
I am facing some issues with the scala packaging. I will keep working on it
and update the patch soon.
---
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/17819
@MLnick Thanks for leaving the comments. I think I've addressed all of
them. Please take a look if you are free. Thanks.
---
-
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17819#discussion_r143947510
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/BucketizerSuite.scala ---
@@ -187,6 +188,196 @@ class BucketizerSuite extends SparkFunSuite with
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17819#discussion_r143947158
--- Diff:
examples/src/main/java/org/apache/spark/examples/ml/JavaBucketizerExample.java
---
@@ -33,6 +33,13 @@
import
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17819
**[Test build #82632 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82632/testReport)**
for PR 17819 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19429
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82630/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19429
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19429
**[Test build #82630 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82630/testReport)**
for PR 19429 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18029
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82631/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18029
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18029
**[Test build #82631 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82631/testReport)**
for PR 18029 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19429
I wasn't even quite sure when I opened the JIRA. That's why I asked it to
one of PMCs who might have a better insight. I am okay with going ahead as a
small improvement in the docs if any
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19429
I intended to explain `multiLine`, `inferSchema` and `header` which are
quite arguably commonly used rather than just show up the examples. JSON one
explains `multiLine` and each line of the
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18029
**[Test build #82631 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82631/testReport)**
for PR 18029 at commit
Github user jomach commented on the issue:
https://github.com/apache/spark/pull/19429
@gatorsmile pr comments fixed. The problem with the actual docs is that
people wen start with spark usually don't start with JSON files but with CSV
files to "see" something
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19429
**[Test build #82630 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82630/testReport)**
for PR 19429 at commit
Github user liutang123 commented on the issue:
https://github.com/apache/spark/pull/19464
@kiszk Any other suggestions an can ti PR be merged?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19429
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19429
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82628/
Test PASSed.
---
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19429#discussion_r143935085
--- Diff: docs/sql-programming-guide.md ---
@@ -479,6 +481,25 @@ source type can be converted into other types using
this syntax.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19429
**[Test build #82628 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82628/testReport)**
for PR 19429 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19429
When I opened a JIRA, I thought a chapter such as
https://spark.apache.org/docs/latest/sql-programming-guide.html#json-datasets.
This chapter, `Manually Specifying Options`, looks describing
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19429#discussion_r143933800
--- Diff:
examples/src/main/java/org/apache/spark/examples/sql/JavaSQLDataSourceExample.java
---
@@ -116,6 +116,13 @@ private static void
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19429#discussion_r143932389
--- Diff: docs/sql-programming-guide.md ---
@@ -479,6 +481,25 @@ source type can be converted into other types using
this syntax.
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19429#discussion_r143932676
--- Diff: docs/sql-programming-guide.md ---
@@ -461,6 +461,8 @@ name (i.e., `org.apache.spark.sql.parquet`), but for
built-in sources you can al
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19429#discussion_r143933737
--- Diff:
examples/src/main/scala/org/apache/spark/examples/sql/SQLDataSourceExample.scala
---
@@ -49,6 +49,14 @@ object SQLDataSourceExample {
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19429#discussion_r143933594
--- Diff: examples/src/main/r/RSparkSQLExample.R ---
@@ -112,6 +112,11 @@ namesAndAges <- select(df, "name", "age")
write.df(namesAndAges,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19429
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82629/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19429
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19429
**[Test build #82629 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82629/testReport)**
for PR 19429 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19429
**[Test build #82629 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82629/testReport)**
for PR 19429 at commit
Github user jomach commented on the issue:
https://github.com/apache/spark/pull/19429
@gatorsmile pr comments fixed. Sorry but is my first time.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17819#discussion_r143930542
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Bucketizer.scala
---
@@ -96,9 +99,71 @@ final class Bucketizer @Since("1.4.0") (@Since("1.4.0")
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19429
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19429#discussion_r143929178
--- Diff:
examples/src/main/scala/org/apache/spark/examples/sql/SQLDataSourceExample.scala
---
@@ -49,6 +49,14 @@ object SQLDataSourceExample {
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19429
**[Test build #82628 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82628/testReport)**
for PR 19429 at commit
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17819#discussion_r143929154
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Bucketizer.scala
---
@@ -96,9 +99,71 @@ final class Bucketizer @Since("1.4.0") (@Since("1.4.0")
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19429#discussion_r143929114
--- Diff:
examples/src/main/java/org/apache/spark/examples/sql/JavaSQLDataSourceExample.java
---
@@ -116,6 +116,13 @@ private static void
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19438
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19438
Thanks!
This changes the query result. I think this is not a regression bug. I only
merge it to master. If anybody else has a concern, we still can address it in
the follow-up PRs.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18931
**[Test build #82627 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82627/testReport)**
for PR 18931 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/18931
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18931
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18931
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82622/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18931
**[Test build #82622 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82622/testReport)**
for PR 18931 at commit
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17819#discussion_r143926137
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Bucketizer.scala
---
@@ -24,20 +24,23 @@ import org.apache.spark.annotation.Since
import
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19439#discussion_r143924856
--- Diff: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala
---
@@ -0,0 +1,229 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19439#discussion_r143925711
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/image/ImageSchemaSuite.scala ---
@@ -0,0 +1,124 @@
+/*
+ * Licensed to the Apache Software
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19439#discussion_r143925461
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/image/ImageSchemaSuite.scala ---
@@ -0,0 +1,124 @@
+/*
+ * Licensed to the Apache Software
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19439#discussion_r143925260
--- Diff: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala
---
@@ -0,0 +1,229 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19439#discussion_r143925390
--- Diff: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala
---
@@ -0,0 +1,229 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19439#discussion_r143925351
--- Diff: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala
---
@@ -0,0 +1,229 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19439#discussion_r143925576
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/image/ImageSchemaSuite.scala ---
@@ -0,0 +1,124 @@
+/*
+ * Licensed to the Apache Software
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19439#discussion_r143925040
--- Diff: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala
---
@@ -0,0 +1,229 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19439#discussion_r143925532
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/image/ImageSchemaSuite.scala ---
@@ -0,0 +1,124 @@
+/*
+ * Licensed to the Apache Software
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19439#discussion_r143925497
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/image/ImageSchemaSuite.scala ---
@@ -0,0 +1,124 @@
+/*
+ * Licensed to the Apache Software
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19439#discussion_r143924715
--- Diff: mllib/src/main/scala/org/apache/spark/ml/image/HadoopUtils.scala
---
@@ -0,0 +1,122 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19439#discussion_r143925678
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/image/ImageSchemaSuite.scala ---
@@ -0,0 +1,124 @@
+/*
+ * Licensed to the Apache Software
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19439#discussion_r143924657
--- Diff: mllib/src/main/scala/org/apache/spark/ml/image/HadoopUtils.scala
---
@@ -0,0 +1,122 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19439#discussion_r143924621
--- Diff: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala
---
@@ -0,0 +1,229 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19439#discussion_r143925142
--- Diff: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala
---
@@ -0,0 +1,229 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19439#discussion_r143924912
--- Diff: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala
---
@@ -0,0 +1,229 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19363
Please replace `[Minor]` with `[SQL]`.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18979
Will review it tomorrow
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user fjh100456 commented on the issue:
https://github.com/apache/spark/pull/6751
With `/*+ broadcast(table) */`, it works well, thank you very much.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18029
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82626/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18029
**[Test build #82626 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82626/testReport)**
for PR 18029 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18029
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18029
**[Test build #82626 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82626/testReport)**
for PR 18029 at commit
Github user sitalkedia commented on the issue:
https://github.com/apache/spark/pull/18805
Yes, the binary distribution is included in the zstd-jni jar file.
---
-
To unsubscribe, e-mail:
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/18805
Does the package include a binary distribution for Linux?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user sitalkedia commented on the issue:
https://github.com/apache/spark/pull/18805
@vanzin - May be the test time outs are related to one test failure
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19363
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82619/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19363
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19363
**[Test build #82619 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82619/testReport)**
for PR 19363 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19470
Hi, @gatorsmile and @cloud-fan .
Could you review this PR?
---
-
To unsubscribe, e-mail:
301 - 394 of 394 matches
Mail list logo
