Github user rberenguel commented on a diff in the pull request:
https://github.com/apache/spark/pull/17100#discussion_r146234832
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -270,12 +270,27 @@ trait CheckAnalysis extends
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/19555
@susanxhuynh could you pls review this?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user rberenguel commented on a diff in the pull request:
https://github.com/apache/spark/pull/17100#discussion_r146234085
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -270,12 +270,27 @@ trait CheckAnalysis extends
Github user rberenguel commented on a diff in the pull request:
https://github.com/apache/spark/pull/17100#discussion_r146233808
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -270,12 +270,27 @@ trait CheckAnalysis extends
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/17100#discussion_r146230295
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -270,12 +270,27 @@ trait CheckAnalysis extends
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/17100#discussion_r146230050
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -270,12 +270,27 @@ trait CheckAnalysis extends
GitHub user WeichenXu123 opened a pull request:
https://github.com/apache/spark/pull/19558
[SPARK-22332][ML][TEST] Fix NaiveBayes unit test occasionly fail (cause by
test dataset not deterministic)
## What changes were proposed in this pull request?
Fix NaiveBayes unit
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/17100#discussion_r146229748
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -270,12 +270,27 @@ trait CheckAnalysis extends
Github user maver1ck commented on the issue:
https://github.com/apache/spark/pull/19255
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19556
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19556
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82971/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19556
**[Test build #82971 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82971/testReport)**
for PR 19556 at commit
Github user superbobry commented on a diff in the pull request:
https://github.com/apache/spark/pull/19458#discussion_r146213702
--- Diff:
core/src/main/scala/org/apache/spark/storage/DiskBlockManager.scala ---
@@ -100,7 +100,16 @@ private[spark] class DiskBlockManager(conf:
Github user rberenguel commented on a diff in the pull request:
https://github.com/apache/spark/pull/17100#discussion_r146211895
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -270,12 +270,27 @@ trait CheckAnalysis extends
Github user rberenguel commented on a diff in the pull request:
https://github.com/apache/spark/pull/17100#discussion_r146211291
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -270,12 +271,25 @@ trait CheckAnalysis extends
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/17100#discussion_r146211140
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -270,12 +270,27 @@ trait CheckAnalysis extends
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/19439
@hhbyyh Thanks for your comments!
> Another option is that to support all bytes[], short[], int[], float[]
and double[] as data storage type candidates, and switch among them according
Github user wzhfy commented on the issue:
https://github.com/apache/spark/pull/17100
@rberenguel Could you fix [this
comment](https://github.com/apache/spark/pull/17100#pullrequestreview-71023434)?
---
-
To
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/17100#discussion_r146208370
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -270,12 +271,25 @@ trait CheckAnalysis extends
Github user rberenguel commented on a diff in the pull request:
https://github.com/apache/spark/pull/17100#discussion_r146208143
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisErrorSuite.scala
---
@@ -408,16 +408,28 @@ class
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/17100#discussion_r146207532
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisErrorSuite.scala
---
@@ -408,16 +408,28 @@ class AnalysisErrorSuite
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/17100#discussion_r146205865
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -270,12 +271,25 @@ trait CheckAnalysis extends
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17100
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17100
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82970/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17100
**[Test build #82970 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82970/testReport)**
for PR 17100 at commit
Github user maver1ck commented on the issue:
https://github.com/apache/spark/pull/18685
I realized that changes here was added also in SPARK-21070.
https://github.com/apache/spark/commit/751f513367ae776c6d6815e1ce138078924872eb
So we can close this PR.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19556
**[Test build #82973 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82973/testReport)**
for PR 19556 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19557
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19557
**[Test build #82972 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82972/testReport)**
for PR 19557 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19557
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82972/
Test PASSed.
---
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/18492#discussion_r146190420
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -373,8 +373,14 @@ private[spark] class ExecutorAllocationManager(
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19529#discussion_r146186223
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/SharedSparkSession.scala ---
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19529#discussion_r146185400
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/GenericFlatSpecSuite.scala ---
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19529#discussion_r146185476
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/SQLTestUtils.scala ---
@@ -52,249 +36,23 @@ import org.apache.spark.util.{UninterruptibleThread,
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19529#discussion_r146185226
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/plans/PlanTest.scala
---
@@ -18,158 +18,9 @@
package
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19557#discussion_r146182283
--- Diff: R/pkg/R/DataFrame.R ---
@@ -3247,12 +3247,23 @@ setMethod("as.data.frame",
#' }
#' @seealso \link{detach}
#' @note attach since
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19557
**[Test build #82972 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82972/testReport)**
for PR 19557 at commit
GitHub user felixcheung opened a pull request:
https://github.com/apache/spark/pull/19557
[SPARK-22281][SPARKR] Handle R method breaking signature changes
## What changes were proposed in this pull request?
This is to fix the code for the latest R changes in R-devel
```
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19556
**[Test build #82971 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82971/testReport)**
for PR 19556 at commit
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/19556
[SPARK-22328][Core] ClosureCleaner should not miss referenced superclass
fields
## What changes were proposed in this pull request?
When the given closure uses some fields defined in super
Github user windkit commented on a diff in the pull request:
https://github.com/apache/spark/pull/19510#discussion_r146180171
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -64,6 +64,7 @@
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17100
**[Test build #82970 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82970/testReport)**
for PR 17100 at commit
GitHub user windkit opened a pull request:
https://github.com/apache/spark/pull/19555
[SPARK-22133][DOCS] Documentation for Mesos Reject Offer Configurations
## What changes were proposed in this pull request?
Documentation about Mesos Reject Offer Configurations
##
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19555
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19529
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82969/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19529
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19529
**[Test build #82969 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82969/testReport)**
for PR 19529 at commit
Github user jsnowacki commented on the issue:
https://github.com/apache/spark/pull/19370
@HyukjinKwon I've updated the PR description. Let me know if this is
sufficient.
---
-
To unsubscribe, e-mail:
Github user rberenguel commented on a diff in the pull request:
https://github.com/apache/spark/pull/17100#discussion_r146177319
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -270,12 +271,25 @@ trait CheckAnalysis extends
Github user rberenguel commented on a diff in the pull request:
https://github.com/apache/spark/pull/17100#discussion_r146177284
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -24,6 +24,7 @@ import
Github user rberenguel commented on a diff in the pull request:
https://github.com/apache/spark/pull/17100#discussion_r146177263
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -270,12 +271,25 @@ trait CheckAnalysis extends
Github user rberenguel commented on a diff in the pull request:
https://github.com/apache/spark/pull/17100#discussion_r146177196
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -270,12 +271,25 @@ trait CheckAnalysis extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17100#discussion_r146177053
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -270,12 +271,25 @@ trait CheckAnalysis extends
Github user rberenguel commented on a diff in the pull request:
https://github.com/apache/spark/pull/17100#discussion_r146176760
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -270,12 +271,25 @@ trait CheckAnalysis extends
Github user rberenguel commented on a diff in the pull request:
https://github.com/apache/spark/pull/17100#discussion_r146176626
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -24,6 +24,7 @@ import
Github user rberenguel commented on a diff in the pull request:
https://github.com/apache/spark/pull/17100#discussion_r146176609
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -270,12 +271,25 @@ trait CheckAnalysis extends
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19548
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19548
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82968/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19548
**[Test build #82968 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82968/testReport)**
for PR 19548 at commit
Github user sjrand closed the pull request at:
https://github.com/apache/spark/pull/19554
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user sjrand commented on the issue:
https://github.com/apache/spark/pull/19554
Thanks @jerryshao.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19554
@sjrand would you please close this PR, it is already merged to branch 2.2.
---
-
To unsubscribe, e-mail:
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19554
Thanks, merging to branch 2.2.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
301 - 363 of 363 matches
Mail list logo
