[GitHub] spark pull request #19222: [SPARK-10399][CORE][SQL] Introduce multiple Memor...

2017-10-28 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/19222#discussion_r147571183 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/memory/MemoryBlock.java --- @@ -17,47 +17,168 @@ package

[GitHub] spark issue #19596: [SPARK-22369][PYTHON][DOCS] Exposes catalog API document...

2017-10-28 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/19596 Yea definitely. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #18544: [SPARK-21318][SQL]Improve exception message thrown by `l...

2017-10-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18544 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83178/ Test PASSed. ---

[GitHub] spark issue #18544: [SPARK-21318][SQL]Improve exception message thrown by `l...

2017-10-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18544 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #18544: [SPARK-21318][SQL]Improve exception message thrown by `l...

2017-10-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18544 **[Test build #83178 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83178/testReport)** for PR 18544 at commit

[GitHub] spark issue #18251: [SPARK-17788][SPARK-21033][SQL] fix the potential OOM in...

2017-10-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18251 **[Test build #83180 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83180/testReport)** for PR 18251 at commit

[GitHub] spark pull request #19383: [SPARK-20643][core] Add listener implementation t...

2017-10-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19383#discussion_r147570235 --- Diff: project/MimaExcludes.scala --- @@ -36,6 +36,8 @@ object MimaExcludes { // Exclude rules for 2.3.x lazy val v23excludes =

[GitHub] spark issue #19567: [SPARK-22291][SQL] Conversion error when transforming ar...

2017-10-28 Thread jmchung
Github user jmchung commented on the issue: https://github.com/apache/spark/pull/19567 Thanks @viirya, the title has been changed. Please correct me if the modified title is still inappropriate. --- - To

[GitHub] spark issue #19596: [SPARK-22369][PYTHON][DOCS] Exposes catalog API document...

2017-10-28 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19596 cc @rxin, do you think it's okay to expose PySpark's Catalog class API doc? --- - To unsubscribe, e-mail:

[GitHub] spark issue #19601: [SPARK-22383][SQL] Generate code to directly get value o...

2017-10-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19601 **[Test build #83179 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83179/testReport)** for PR 19601 at commit

[GitHub] spark pull request #19601: [SPARK-22383][SQL] Generate code to directly get ...

2017-10-28 Thread kiszk
GitHub user kiszk opened a pull request: https://github.com/apache/spark/pull/19601 [SPARK-22383][SQL] Generate code to directly get value of primitive type array from ColumnVector for table cache ## What changes were proposed in this pull request? This PR generates the

[GitHub] spark issue #19598: [SPARK-22378][SQL] Eliminate redundant null check in gen...

2017-10-28 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/19598 @gatorsmile could you please review this? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #19567: [SPARK-22291][SQL] PostgreSQL UUID[] to StringTyp...

2017-10-28 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19567#discussion_r147569347 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala --- @@ -456,8 +456,17 @@ object JdbcUtils extends Logging

[GitHub] spark issue #19567: [SPARK-22291][SQL] PostgreSQL UUID[] to StringType: Conv...

2017-10-28 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/19567 This is not just for UUID[] for now. We should update the PR title. --- - To unsubscribe, e-mail:

[GitHub] spark pull request #19383: [SPARK-20643][core] Add listener implementation t...

2017-10-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19383#discussion_r147569230 --- Diff: core/src/main/scala/org/apache/spark/status/AppStatusListener.scala --- @@ -0,0 +1,531 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #19383: [SPARK-20643][core] Add listener implementation t...

2017-10-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19383#discussion_r147569232 --- Diff: project/MimaExcludes.scala --- @@ -36,6 +36,8 @@ object MimaExcludes { // Exclude rules for 2.3.x lazy val v23excludes =

[GitHub] spark pull request #19383: [SPARK-20643][core] Add listener implementation t...

2017-10-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19383#discussion_r147569226 --- Diff: core/src/main/scala/org/apache/spark/status/api/v1/api.scala --- @@ -129,9 +129,13 @@ class RDDDataDistribution private[spark]( val

[GitHub] spark issue #18544: [SPARK-21318][SQL]Improve exception message thrown by `l...

2017-10-28 Thread stanzhai
Github user stanzhai commented on the issue: https://github.com/apache/spark/pull/18544 fixed @gatorsmile . retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #18544: [SPARK-21318][SQL]Improve exception message thrown by `l...

2017-10-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18544 **[Test build #83178 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83178/testReport)** for PR 18544 at commit

[GitHub] spark pull request #19576: [SPARK-19727][SQL][followup] Fix for round functi...

2017-10-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19576 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19600: Added more information to Imputer

2017-10-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19600 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19576: [SPARK-19727][SQL][followup] Fix for round function that...

2017-10-28 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19576 Thanks! Merged to master/2.2 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #19600: Added more information to Imputer

2017-10-28 Thread tengpeng
GitHub user tengpeng opened a pull request: https://github.com/apache/spark/pull/19600 Added more information to Imputer Often times we want to impute custom values other than 'NaN'. My addition helps people locate this function without reading the API. ## What changes

[GitHub] spark issue #19576: [SPARK-19727][SQL][followup] Fix for round function that...

2017-10-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19576 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19576: [SPARK-19727][SQL][followup] Fix for round function that...

2017-10-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19576 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83176/ Test PASSed. ---

[GitHub] spark issue #19576: [SPARK-19727][SQL][followup] Fix for round function that...

2017-10-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19576 **[Test build #83176 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83176/testReport)** for PR 19576 at commit

[GitHub] spark pull request #18937: [MINOR] Remove false comment from planStreamingAg...

2017-10-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18937 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #18937: [MINOR] Remove false comment from planStreamingAggregati...

2017-10-28 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18937 Thanks! Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #18937: [MINOR] Remove false comment from planStreamingAggregati...

2017-10-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18937 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #18937: [MINOR] Remove false comment from planStreamingAggregati...

2017-10-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18937 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83175/ Test PASSed. ---

[GitHub] spark issue #18937: [MINOR] Remove false comment from planStreamingAggregati...

2017-10-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18937 **[Test build #83175 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83175/testReport)** for PR 18937 at commit

[GitHub] spark issue #19589: [SPARKR][SPARK-22344] Set java.io.tmpdir for SparkR test...

2017-10-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19589 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83177/ Test PASSed. ---

[GitHub] spark issue #19589: [SPARKR][SPARK-22344] Set java.io.tmpdir for SparkR test...

2017-10-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19589 **[Test build #83177 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83177/testReport)** for PR 19589 at commit

[GitHub] spark issue #19589: [SPARKR][SPARK-22344] Set java.io.tmpdir for SparkR test...

2017-10-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19589 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #16812: [SPARK-19465][SQL] Added options for custom boolean valu...

2017-10-28 Thread dhunziker
Github user dhunziker commented on the issue: https://github.com/apache/spark/pull/16812 Oracle doesn't have boolean so it's usually modelled as char(1) with Y/N, Sybase doesn't have boolean either but bit which is 1/0. PosgreSQL supports a range of values

[GitHub] spark pull request #19383: [SPARK-20643][core] Add listener implementation t...

2017-10-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19383#discussion_r147566861 --- Diff: project/MimaExcludes.scala --- @@ -36,6 +36,8 @@ object MimaExcludes { // Exclude rules for 2.3.x lazy val v23excludes =

[GitHub] spark pull request #19383: [SPARK-20643][core] Add listener implementation t...

2017-10-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19383#discussion_r147566819 --- Diff: core/src/main/scala/org/apache/spark/status/AppStatusListener.scala --- @@ -0,0 +1,531 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #19383: [SPARK-20643][core] Add listener implementation t...

2017-10-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19383#discussion_r147566828 --- Diff: core/src/main/scala/org/apache/spark/status/api/v1/api.scala --- @@ -129,9 +129,13 @@ class RDDDataDistribution private[spark]( val

[GitHub] spark issue #19589: [SPARKR][SPARK-22344] Set java.io.tmpdir for SparkR test...

2017-10-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19589 **[Test build #83177 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83177/testReport)** for PR 19589 at commit

[GitHub] spark issue #19571: [SPARK-15474][SQL] Write and read back non-emtpy schema ...

2017-10-28 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19571 Sorry I miss-understood the problem at the beginning. I thought the new orc version just changes the existing APIs a little, but it turns out the new orc version has a new set of read/write APIs.

[GitHub] spark pull request #19222: [SPARK-10399][CORE][SQL] Introduce multiple Memor...

2017-10-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19222#discussion_r147566301 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/array/LongArray.java --- @@ -33,15 +32,13 @@ private static final long WIDTH = 8;

[GitHub] spark pull request #19222: [SPARK-10399][CORE][SQL] Introduce multiple Memor...

2017-10-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19222#discussion_r147566248 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeRow.java --- @@ -418,7 +419,10 @@ public UTF8String

[GitHub] spark pull request #19222: [SPARK-10399][CORE][SQL] Introduce multiple Memor...

2017-10-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19222#discussion_r147566242 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java --- @@ -230,7 +233,10 @@ public UTF8String

[GitHub] spark pull request #19222: [SPARK-10399][CORE][SQL] Introduce multiple Memor...

2017-10-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19222#discussion_r147566212 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -50,11 +52,11 @@ // These are only updated by

[GitHub] spark pull request #19222: [SPARK-10399][CORE][SQL] Introduce multiple Memor...

2017-10-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19222#discussion_r147566203 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/memory/MemoryBlock.java --- @@ -17,47 +17,168 @@ package

[GitHub] spark pull request #19222: [SPARK-10399][CORE][SQL] Introduce multiple Memor...

2017-10-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19222#discussion_r147566177 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/memory/MemoryBlock.java --- @@ -17,47 +17,168 @@ package

[GitHub] spark pull request #19222: [SPARK-10399][CORE][SQL] Introduce multiple Memor...

2017-10-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19222#discussion_r147566155 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/memory/UnsafeMemoryAllocator.java --- @@ -19,28 +19,48 @@ import

[GitHub] spark pull request #19222: [SPARK-10399][CORE][SQL] Introduce multiple Memor...

2017-10-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19222#discussion_r147566118 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/memory/OffHeapMemoryBlock.java --- @@ -0,0 +1,103 @@ +/* + * Licensed to the

[GitHub] spark pull request #19222: [SPARK-10399][CORE][SQL] Introduce multiple Memor...

2017-10-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19222#discussion_r147566106 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/memory/OffHeapMemoryBlock.java --- @@ -0,0 +1,103 @@ +/* + * Licensed to the

[GitHub] spark pull request #19222: [SPARK-10399][CORE][SQL] Introduce multiple Memor...

2017-10-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19222#discussion_r147566098 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/memory/OffHeapMemoryBlock.java --- @@ -0,0 +1,103 @@ +/* + * Licensed to the

[GitHub] spark pull request #19222: [SPARK-10399][CORE][SQL] Introduce multiple Memor...

2017-10-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19222#discussion_r147566082 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/memory/MemoryBlock.java --- @@ -17,47 +17,168 @@ package

[GitHub] spark pull request #19222: [SPARK-10399][CORE][SQL] Introduce multiple Memor...

2017-10-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19222#discussion_r147566059 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/memory/HeapMemoryAllocator.java --- @@ -73,6 +73,12 @@ public MemoryBlock allocate(long

[GitHub] spark pull request #19222: [SPARK-10399][CORE][SQL] Introduce multiple Memor...

2017-10-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19222#discussion_r147565964 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/memory/MemoryBlock.java --- @@ -17,47 +17,168 @@ package

[GitHub] spark pull request #19222: [SPARK-10399][CORE][SQL] Introduce multiple Memor...

2017-10-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19222#discussion_r147565937 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/memory/MemoryBlock.java --- @@ -17,47 +17,168 @@ package

[GitHub] spark pull request #19222: [SPARK-10399][CORE][SQL] Introduce multiple Memor...

2017-10-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19222#discussion_r147565897 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/memory/MemoryBlock.java --- @@ -17,47 +17,168 @@ package

[GitHub] spark pull request #19222: [SPARK-10399][CORE][SQL] Introduce multiple Memor...

2017-10-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19222#discussion_r147565847 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/memory/MemoryBlock.java --- @@ -17,47 +17,168 @@ package

[GitHub] spark pull request #19222: [SPARK-10399][CORE][SQL] Introduce multiple Memor...

2017-10-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19222#discussion_r147565833 --- Diff: common/unsafe/src/main/java/org/apache/spark/sql/catalyst/expressions/HiveHasher.java --- @@ -38,6 +39,10 @@ public static int hashLong(long

[GitHub] spark issue #19586: [SPARK-22367][CORE] Separate the serialization of class ...

2017-10-28 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19586 looking at the `SerializationStream` interface, I think it's designed for read/write objects of different classes, so your optimization should not be applied there. Instead, I think we

[GitHub] spark pull request #19586: [SPARK-22367][CORE] Separate the serialization of...

2017-10-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19586#discussion_r147565429 --- Diff: core/src/main/scala/org/apache/spark/serializer/KryoSerializer.scala --- @@ -205,11 +205,45 @@ class KryoSerializationStream(

[GitHub] spark pull request #19586: [SPARK-22367][CORE] Separate the serialization of...

2017-10-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19586#discussion_r147565331 --- Diff: pom.xml --- @@ -133,7 +133,7 @@ 1.6.0 9.3.20.v20170531 3.1.0 -0.8.4 +0.9.2 --- End diff --

[GitHub] spark pull request #19586: [SPARK-22367][CORE] Separate the serialization of...

2017-10-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19586#discussion_r147565323 --- Diff: pom.xml --- @@ -133,7 +133,7 @@ 1.6.0 9.3.20.v20170531 3.1.0 -0.8.4 +0.9.2 --- End diff --

[GitHub] spark pull request #19576: [SPARK-19727][SQL][followup] Fix for round functi...

2017-10-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19576#discussion_r147565256 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/MathFunctionsSuite.scala --- @@ -258,6 +258,18 @@ class MathFunctionsSuite extends QueryTest with

[GitHub] spark issue #19576: [SPARK-19727][SQL][followup] Fix for round function that...

2017-10-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19576 **[Test build #83176 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83176/testReport)** for PR 19576 at commit

[GitHub] spark issue #18937: [MINOR] Remove false comment from planStreamingAggregati...

2017-10-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18937 **[Test build #83175 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83175/testReport)** for PR 18937 at commit

[GitHub] spark issue #18937: [MINOR] Remove false comment from planStreamingAggregati...

2017-10-28 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18937 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19597: [SPARK-22375][TEST] Test script can fail if eggs are ins...

2017-10-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19597 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83172/ Test PASSed. ---

[GitHub] spark issue #19597: [SPARK-22375][TEST] Test script can fail if eggs are ins...

2017-10-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19597 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19597: [SPARK-22375][TEST] Test script can fail if eggs are ins...

2017-10-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19597 **[Test build #83172 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83172/testReport)** for PR 19597 at commit

[GitHub] spark pull request #19599: [SPARK-22381] [ML] Add StringParam that supports ...

2017-10-28 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/19599#discussion_r147562600 --- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala --- @@ -440,6 +440,43 @@ class BooleanParam(parent: String, name: String, doc: String)

[GitHub] spark pull request #19599: [SPARK-22381] [ML] Add StringParam that supports ...

2017-10-28 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/19599#discussion_r147562823 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/NaiveBayes.scala --- @@ -133,7 +134,7 @@ class NaiveBayes @Since("1.5.0") (

[GitHub] spark pull request #19599: [SPARK-22381] [ML] Add StringParam that supports ...

2017-10-28 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/19599#discussion_r147562645 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala --- @@ -224,8 +222,8 @@ class LinearRegression @Since("1.3.0")

[GitHub] spark pull request #19599: [SPARK-22381] [ML] Add StringParam that supports ...

2017-10-28 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/19599#discussion_r147562530 --- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala --- @@ -440,6 +440,43 @@ class BooleanParam(parent: String, name: String, doc: String)

[GitHub] spark issue #19597: [SPARK-22375][TEST] Test script can fail if eggs are ins...

2017-10-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19597 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83171/ Test PASSed. ---

[GitHub] spark issue #19597: [SPARK-22375][TEST] Test script can fail if eggs are ins...

2017-10-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19597 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19597: [SPARK-22375][TEST] Test script can fail if eggs are ins...

2017-10-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19597 **[Test build #83171 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83171/testReport)** for PR 19597 at commit

[GitHub] spark issue #19598: [SPARK-22378][SQL] Eliminate redundant null check in gen...

2017-10-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19598 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83173/ Test PASSed. ---

[GitHub] spark issue #19598: [SPARK-22378][SQL] Eliminate redundant null check in gen...

2017-10-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19598 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19598: [SPARK-22378][SQL] Eliminate redundant null check in gen...

2017-10-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19598 **[Test build #83173 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83173/testReport)** for PR 19598 at commit

[GitHub] spark issue #18747: [SPARK-20822][SQL] Generate code to directly get value f...

2017-10-28 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/18747 @cloud-fan I updated benchmark result (2.9x) in the description. --- - To unsubscribe, e-mail:

[GitHub] spark issue #19599: [SPARK-22381] [ML] Add StringParam that supports valid o...

2017-10-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19599 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83174/ Test FAILed. ---

[GitHub] spark issue #19599: [SPARK-22381] [ML] Add StringParam that supports valid o...

2017-10-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19599 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19599: [SPARK-22381] [ML] Add StringParam that supports valid o...

2017-10-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19599 **[Test build #83174 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83174/testReport)** for PR 19599 at commit

[GitHub] spark issue #19599: [SPARK-22381] [ML] Add StringParam that supports valid o...

2017-10-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19599 **[Test build #83174 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83174/testReport)** for PR 19599 at commit

[GitHub] spark pull request #19599: [SPARK-22381] [ML] Add StringParam that supports ...

2017-10-28 Thread hhbyyh
GitHub user hhbyyh opened a pull request: https://github.com/apache/spark/pull/19599 [SPARK-22381] [ML] Add StringParam that supports valid options ## What changes were proposed in this pull request? jira: https://issues.apache.org/jira/browse/SPARK-22381 During

[GitHub] spark issue #19567: [SPARK-22291][SQL] PostgreSQL UUID[] to StringType: Conv...

2017-10-28 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19567 LGTM except one comment, good catch! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #19567: [SPARK-22291][SQL] PostgreSQL UUID[] to StringTyp...

2017-10-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19567#discussion_r147560424 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala --- @@ -456,8 +456,17 @@ object JdbcUtils extends

[GitHub] spark pull request #18113: [SPARK-20890][SQL] Added min and max typed aggreg...

2017-10-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18113#discussion_r147559942 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/typedaggregators.scala --- @@ -26,43 +26,64 @@ import

[GitHub] spark pull request #19587: [SPARK-22370][SQL][PYSPARK] Config values should ...

2017-10-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19587 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19587: [SPARK-22370][SQL][PYSPARK] Config values should be capt...

2017-10-28 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19587 LGTM, merging to master! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19598: [SPARK-22378][SQL] Eliminate redundant null check in gen...

2017-10-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19598 **[Test build #83173 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83173/testReport)** for PR 19598 at commit

[GitHub] spark pull request #19598: [SPARK-22378]

2017-10-28 Thread kiszk
GitHub user kiszk opened a pull request: https://github.com/apache/spark/pull/19598 [SPARK-22378] ## What changes were proposed in this pull request? This PR eliminates redundant null check in generated code for extracting an element from complex types. Since these code

[GitHub] spark issue #19597: [SPARK-22375][TEST] Test script can fail if eggs are ins...

2017-10-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19597 **[Test build #83172 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83172/testReport)** for PR 19597 at commit

[GitHub] spark issue #19597: [SPARK-22375][TEST] Test script can fail if eggs are ins...

2017-10-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19597 **[Test build #83171 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83171/testReport)** for PR 19597 at commit

[GitHub] spark issue #19597: [SPARK-22375][TEST] Test script can fail if eggs are ins...

2017-10-28 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19597 I think you can add it here instead https://github.com/apache/spark/blob/0e31e28d483918c1de26f78068e78c2ca3cf7f3c/dev/tox.ini#L19 ---

[GitHub] spark issue #19597: [SPARK-22375][TEST] Test script can fail if eggs are ins...

2017-10-28 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19597 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19597: [SPARK-22375][TEST] Test script can fail if eggs are ins...

2017-10-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19597 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #19597: [SPARK-22375][TEST] Test script can fail if eggs ...

2017-10-28 Thread xynny
GitHub user xynny opened a pull request: https://github.com/apache/spark/pull/19597 [SPARK-22375][TEST] Test script can fail if eggs are installed by set… …up.py during test process ## What changes were proposed in this pull request? Ignore the python/.eggs

[GitHub] spark issue #19596: [SPARK-22369][PYTHON][DOCS] Exposes catalog API document...

2017-10-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19596 **[Test build #83170 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83170/testReport)** for PR 19596 at commit

[GitHub] spark issue #19596: [SPARK-22369][PYTHON][DOCS] Exposes catalog API document...

2017-10-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19596 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83170/ Test PASSed. ---

[GitHub] spark issue #19596: [SPARK-22369][PYTHON][DOCS] Exposes catalog API document...

2017-10-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19596 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

  1   2   3   >