[GitHub] spark issue #19389: [SPARK-22165][SQL] Resolve type conflicts between decima...

2017-11-11 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19389 Maybe, what do you think about opening a discussion in the mailing list? If I understood correctly, committers have a different opinion on this (did I understand correctly?). That should

[GitHub] spark issue #19724: [SPARK-22464][BACKPORT-2.2][SQL] No pushdown for Hive me...

2017-11-11 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19724 cc @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19723: [BACKPORT-2.2] [SPARK-22488][SQL] Fix the view resolutio...

2017-11-11 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19723 cc @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19719: [SPARK-22487][SQL][followup] still keep spark.sql.hive.v...

2017-11-11 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19719 LGTM except a few comments --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #19719: [SPARK-22487][SQL][followup] still keep spark.sql.hive.v...

2017-11-11 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19719 Do something like the other deprecated conf `MAPRED_REDUCE_TASKS `?

[GitHub] spark pull request #19719: [SPARK-22487][SQL][followup] still keep spark.sql...

2017-11-11 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19719#discussion_r150402144 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala --- @@ -66,6 +66,14 @@ private[spark] object HiveUtils extends Logging {

[GitHub] spark pull request #19719: [SPARK-22487][SQL][followup] still keep spark.sql...

2017-11-11 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19719#discussion_r150402135 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala --- @@ -66,6 +66,14 @@ private[spark] object HiveUtils extends Logging {

[GitHub] spark issue #19389: [SPARK-22165][SQL] Resolve type conflicts between decima...

2017-11-11 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19389 Generally, the current type inference/coercion rules are messy and random. We have to seriously revisit our type coercion. After thinking it more, I think this change in this PR is

[GitHub] spark issue #19389: [SPARK-22165][SQL] Resolve type conflicts between decima...

2017-11-11 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19389 Also cc @rxin @cloud-fan @sameeragarwal --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #15049: [SPARK-17310][SQL] Add an option to disable recor...

2017-11-11 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/15049#discussion_r150401715 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala --- @@ -370,13 +372,11 @@ class

[GitHub] spark pull request #15049: [SPARK-17310][SQL] Add an option to disable recor...

2017-11-11 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/15049#discussion_r150401639 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala --- @@ -370,13 +372,11 @@ class

[GitHub] spark pull request #15049: [SPARK-17310][SQL] Add an option to disable recor...

2017-11-11 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/15049#discussion_r150401147 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala --- @@ -370,13 +372,11 @@ class

[GitHub] spark issue #19479: [SPARK-17074] [SQL] Generate equi-height histogram in co...

2017-11-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19479 **[Test build #83735 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83735/testReport)** for PR 19479 at commit

[GitHub] spark issue #15049: [SPARK-17310][SQL] Add an option to disable record-level...

2017-11-11 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15049 cc @cloud-fan too. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #18581: [SPARK-21289][SQL][ML] Supports custom line separator fo...

2017-11-11 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18581 gentle ping @gatorsmile --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19389: [SPARK-22165][SQL] Resolve type conflicts between decima...

2017-11-11 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19389 Hi @gatorsmile, could you please review this when you have some time? --- - To unsubscribe, e-mail:

[GitHub] spark issue #19695: [SPARK-22377][BUILD] Use /usr/sbin/lsof if lsof does not...

2017-11-11 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19695 Let's go ahead with this first and make a followup if there is another problem can be found, if you guys here wouldn't mind. ---

[GitHub] spark issue #19725: [DO NOT REVIEW][SPARK-22042] [SQL] Insert shuffle nodes ...

2017-11-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19725 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83734/ Test FAILed. ---

[GitHub] spark issue #19725: [DO NOT REVIEW][SPARK-22042] [SQL] Insert shuffle nodes ...

2017-11-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19725 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19725: [DO NOT REVIEW][SPARK-22042] [SQL] Insert shuffle nodes ...

2017-11-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19725 **[Test build #83734 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83734/testReport)** for PR 19725 at commit

[GitHub] spark issue #19719: [SPARK-22487][SQL][followup] still keep spark.sql.hive.v...

2017-11-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19719 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83733/ Test PASSed. ---

[GitHub] spark issue #19719: [SPARK-22487][SQL][followup] still keep spark.sql.hive.v...

2017-11-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19719 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19719: [SPARK-22487][SQL][followup] still keep spark.sql.hive.v...

2017-11-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19719 **[Test build #83733 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83733/testReport)** for PR 19719 at commit

[GitHub] spark issue #19543: [SPARK-19606][MESOS] Support constraints in spark-dispat...

2017-11-11 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/19543 @susanxhuynh, @ttashi-rms, @ArtRand please take a look --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #19725: [DO NOT REVIEW][SPARK-22042] [SQL] Insert shuffle nodes ...

2017-11-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19725 **[Test build #83734 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83734/testReport)** for PR 19725 at commit

[GitHub] spark pull request #19725: [DO NOT REVIEW][SPARK-22042] [SQL] Insert shuffle...

2017-11-11 Thread tejasapatil
GitHub user tejasapatil opened a pull request: https://github.com/apache/spark/pull/19725 [DO NOT REVIEW][SPARK-22042] [SQL] Insert shuffle nodes in entire tree before applying `ReorderJoinPredicates` trying out suggestion in

[GitHub] spark pull request #19651: [SPARK-20682][SPARK-15474][SPARK-21791] Add new O...

2017-11-11 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19651#discussion_r150396893 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcSerializer.scala --- @@ -0,0 +1,163 @@ +/* + * Licensed

[GitHub] spark pull request #19651: [SPARK-20682][SPARK-15474][SPARK-21791] Add new O...

2017-11-11 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19651#discussion_r150396880 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcSerializer.scala --- @@ -0,0 +1,163 @@ +/* + * Licensed

[GitHub] spark pull request #19651: [SPARK-20682][SPARK-15474][SPARK-21791] Add new O...

2017-11-11 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19651#discussion_r150396839 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcSerializer.scala --- @@ -0,0 +1,163 @@ +/* + * Licensed

[GitHub] spark issue #19719: [SPARK-22487][SQL][followup] still keep spark.sql.hive.v...

2017-11-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19719 **[Test build #83733 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83733/testReport)** for PR 19719 at commit

[GitHub] spark pull request #19651: [SPARK-20682][SPARK-15474][SPARK-21791] Add new O...

2017-11-11 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19651#discussion_r150395563 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcUtils.scala --- @@ -0,0 +1,131 @@ +/* + * Licensed to

[GitHub] spark issue #19702: [SPARK-10365][SQL] Support Parquet logical type TIMESTAM...

2017-11-11 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19702 thanks, merging to master! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19702: [SPARK-10365][SQL] Support Parquet logical type T...

2017-11-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19702 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19638: [SPARK-22422][ML] Add Adjusted R2 to RegressionMe...

2017-11-11 Thread tengpeng
Github user tengpeng commented on a diff in the pull request: https://github.com/apache/spark/pull/19638#discussion_r150394001 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala --- @@ -764,13 +764,17 @@ class LinearRegressionSuite

[GitHub] spark pull request #19638: [SPARK-22422][ML] Add Adjusted R2 to RegressionMe...

2017-11-11 Thread tengpeng
Github user tengpeng commented on a diff in the pull request: https://github.com/apache/spark/pull/19638#discussion_r150393944 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala --- @@ -764,13 +764,17 @@ class LinearRegressionSuite

[GitHub] spark issue #19724: [SPARK-22464][BACKPORT-2.2][SQL] No pushdown for Hive me...

2017-11-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19724 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83731/ Test PASSed. ---

[GitHub] spark issue #19724: [SPARK-22464][BACKPORT-2.2][SQL] No pushdown for Hive me...

2017-11-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19724 **[Test build #83731 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83731/testReport)** for PR 19724 at commit

[GitHub] spark issue #19724: [SPARK-22464][BACKPORT-2.2][SQL] No pushdown for Hive me...

2017-11-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19724 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19723: [BACKPORT-2.2] [SPARK-22488][SQL] Fix the view resolutio...

2017-11-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19723 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83730/ Test PASSed. ---

[GitHub] spark issue #19723: [BACKPORT-2.2] [SPARK-22488][SQL] Fix the view resolutio...

2017-11-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19723 **[Test build #83730 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83730/testReport)** for PR 19723 at commit

[GitHub] spark issue #19723: [BACKPORT-2.2] [SPARK-22488][SQL] Fix the view resolutio...

2017-11-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19723 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19702: [SPARK-10365][SQL] Support Parquet logical type TIMESTAM...

2017-11-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19702 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83728/ Test PASSed. ---

[GitHub] spark issue #19702: [SPARK-10365][SQL] Support Parquet logical type TIMESTAM...

2017-11-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19702 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19702: [SPARK-10365][SQL] Support Parquet logical type TIMESTAM...

2017-11-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19702 **[Test build #83728 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83728/testReport)** for PR 19702 at commit

[GitHub] spark pull request #18113: [SPARK-20890][SQL] Added min and max typed aggreg...

2017-11-11 Thread setjet
Github user setjet commented on a diff in the pull request: https://github.com/apache/spark/pull/18113#discussion_r150392495 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/typedaggregators.scala --- @@ -76,26 +76,126 @@ class TypedCount[IN](val f: IN

[GitHub] spark issue #19719: [SPARK-22487][SQL][followup] still keep spark.sql.hive.v...

2017-11-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19719 **[Test build #83732 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83732/testReport)** for PR 19719 at commit

[GitHub] spark issue #19719: [SPARK-22487][SQL][followup] still keep spark.sql.hive.v...

2017-11-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19719 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83732/ Test FAILed. ---

[GitHub] spark issue #19719: [SPARK-22487][SQL][followup] still keep spark.sql.hive.v...

2017-11-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19719 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #18113: [SPARK-20890][SQL] Added min and max typed aggreg...

2017-11-11 Thread setjet
Github user setjet commented on a diff in the pull request: https://github.com/apache/spark/pull/18113#discussion_r150392424 --- Diff: sql/core/src/main/java/org/apache/spark/sql/expressions/javalang/typed.java --- @@ -74,4 +71,40 @@ public static TypedColumn

[GitHub] spark issue #19719: [SPARK-22487][SQL][followup] still keep spark.sql.hive.v...

2017-11-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19719 **[Test build #83732 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83732/testReport)** for PR 19719 at commit

[GitHub] spark pull request #17631: [SPARK-20319][SQL] Already quoted identifiers are...

2017-11-11 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17631#discussion_r150391984 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala --- @@ -121,7 +121,8 @@ object JdbcUtils extends

[GitHub] spark issue #19724: [SPARK-22464][BACKPORT-2.2][SQL] No pushdown for Hive me...

2017-11-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19724 **[Test build #83731 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83731/testReport)** for PR 19724 at commit

[GitHub] spark pull request #19724: [SPARK-22464][BACKPORT-2.2][SQL] No pushdown for ...

2017-11-11 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/19724 [SPARK-22464][BACKPORT-2.2][SQL] No pushdown for Hive metastore partition predicates containing null-safe equality ## What changes were proposed in this pull request? `<=>` is not supported

[GitHub] spark issue #19715: [SPARK-22397][ML]add multiple columns support to Quantil...

2017-11-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19715 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19479: [SPARK-17074] [SQL] Generate equi-height histogram in co...

2017-11-11 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19479 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19715: [SPARK-22397][ML]add multiple columns support to Quantil...

2017-11-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19715 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83729/ Test PASSed. ---

[GitHub] spark issue #19715: [SPARK-22397][ML]add multiple columns support to Quantil...

2017-11-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19715 **[Test build #83729 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83729/testReport)** for PR 19715 at commit

[GitHub] spark pull request #19479: [SPARK-17074] [SQL] Generate equi-height histogra...

2017-11-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19479#discussion_r150391475 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala --- @@ -275,6 +313,127 @@ object ColumnStat extends

[GitHub] spark pull request #19479: [SPARK-17074] [SQL] Generate equi-height histogra...

2017-11-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19479#discussion_r150391245 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala --- @@ -275,6 +313,127 @@ object ColumnStat extends

[GitHub] spark pull request #19479: [SPARK-17074] [SQL] Generate equi-height histogra...

2017-11-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19479#discussion_r150391234 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala --- @@ -275,6 +313,127 @@ object ColumnStat extends

[GitHub] spark pull request #18113: [SPARK-20890][SQL] Added min and max typed aggreg...

2017-11-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18113#discussion_r150391130 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/typedaggregators.scala --- @@ -76,26 +76,126 @@ class TypedCount[IN](val f:

[GitHub] spark pull request #18113: [SPARK-20890][SQL] Added min and max typed aggreg...

2017-11-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18113#discussion_r150391109 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/typedaggregators.scala --- @@ -76,26 +76,126 @@ class TypedCount[IN](val f:

[GitHub] spark pull request #18113: [SPARK-20890][SQL] Added min and max typed aggreg...

2017-11-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18113#discussion_r150391105 --- Diff: sql/core/src/main/java/org/apache/spark/sql/expressions/javalang/typed.java --- @@ -74,4 +71,40 @@ public static TypedColumn

[GitHub] spark pull request #18113: [SPARK-20890][SQL] Added min and max typed aggreg...

2017-11-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18113#discussion_r150391079 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/typedaggregators.scala --- @@ -76,26 +76,126 @@ class TypedCount[IN](val f:

[GitHub] spark pull request #18113: [SPARK-20890][SQL] Added min and max typed aggreg...

2017-11-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18113#discussion_r150391065 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/typedaggregators.scala --- @@ -76,26 +76,126 @@ class TypedCount[IN](val f:

[GitHub] spark pull request #18113: [SPARK-20890][SQL] Added min and max typed aggreg...

2017-11-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18113#discussion_r150391063 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/typedaggregators.scala --- @@ -44,8 +44,9 @@ class TypedSumDouble[IN](val f:

[GitHub] spark pull request #18113: [SPARK-20890][SQL] Added min and max typed aggreg...

2017-11-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18113#discussion_r150391077 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/typedaggregators.scala --- @@ -76,26 +76,126 @@ class TypedCount[IN](val f:

[GitHub] spark pull request #18113: [SPARK-20890][SQL] Added min and max typed aggreg...

2017-11-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18113#discussion_r150391056 --- Diff: sql/core/src/main/java/org/apache/spark/sql/expressions/javalang/typed.java --- @@ -74,4 +71,40 @@ public static TypedColumn

[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Converter Started, Completed and L...

2017-11-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19640 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83727/ Test PASSed. ---

[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Converter Started, Completed and L...

2017-11-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19640 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Converter Started, Completed and L...

2017-11-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19640 **[Test build #83727 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83727/testReport)** for PR 19640 at commit

[GitHub] spark issue #19723: [BACKPORT-2.2] [SPARK-22488][SQL] Fix the view resolutio...

2017-11-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19723 **[Test build #83730 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83730/testReport)** for PR 19723 at commit

[GitHub] spark pull request #19723: [BACKPORT-2.2] [SPARK-22488][SQL] Fix the view re...

2017-11-11 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/19723 [BACKPORT-2.2] [SPARK-22488][SQL] Fix the view resolution issue in the SparkSession internal table() API ## What changes were proposed in this pull request? The current internal

[GitHub] spark issue #19695: [SPARK-22377][BUILD] Use /usr/sbin/lsof if lsof does not...

2017-11-11 Thread xynny
Github user xynny commented on the issue: https://github.com/apache/spark/pull/19695 The script looks fine to me, but I think it's just still a problem that all the jenkins slaves are actually running different OSes. It's just inconsistent. ---

[GitHub] spark issue #19715: [SPARK-22397][ML]add multiple columns support to Quantil...

2017-11-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19715 **[Test build #83729 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83729/testReport)** for PR 19715 at commit

[GitHub] spark issue #19713: [SPARK-22488] [SQL] Fix the view resolution issue in the...

2017-11-11 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/19713 Sounds like we should have for 2.2.1 I’m looking at cutting 2.2.1 ASAP, could someone backport this and tag me? ---

[GitHub] spark issue #19722: [SPARK-21693][R][ML] Reduce max iterations in Linear SVM...

2017-11-11 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/19722 LGTM cool stuff, if we get the same result in less iterations Let’s get this into 2.2 as well --- - To

[GitHub] spark issue #19479: [SPARK-17074] [SQL] Generate equi-height histogram in co...

2017-11-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19479 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19479: [SPARK-17074] [SQL] Generate equi-height histogram in co...

2017-11-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19479 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83726/ Test PASSed. ---

[GitHub] spark issue #19479: [SPARK-17074] [SQL] Generate equi-height histogram in co...

2017-11-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19479 **[Test build #83726 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83726/testReport)** for PR 19479 at commit

[GitHub] spark pull request #19468: [SPARK-18278] [Scheduler] Spark on Kubernetes - B...

2017-11-11 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19468#discussion_r150389436 --- Diff: resource-managers/kubernetes/core/pom.xml --- @@ -0,0 +1,102 @@ + + +http://maven.apache.org/POM/4.0.0;

[GitHub] spark issue #19702: [SPARK-10365][SQL] Support Parquet logical type TIMESTAM...

2017-11-11 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19702 LGTM pending Jenkins --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19702: [SPARK-10365][SQL] Support Parquet logical type TIMESTAM...

2017-11-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19702 **[Test build #83728 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83728/testReport)** for PR 19702 at commit

[GitHub] spark issue #19702: [SPARK-10365][SQL] Support Parquet logical type TIMESTAM...

2017-11-11 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19702 The only failed test is SQLConfSuite which test the default value of the new config. --- - To unsubscribe, e-mail:

[GitHub] spark issue #19713: [SPARK-22488] [SQL] Fix the view resolution issue in the...

2017-11-11 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19713 thanks, merging to master! can you send a new PR for 2.2? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark pull request #19713: [SPARK-22488] [SQL] Fix the view resolution issue...

2017-11-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19713 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18113: [SPARK-20890][SQL] Added min and max typed aggreg...

2017-11-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18113#discussion_r150388551 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/typedaggregators.scala --- @@ -76,26 +77,130 @@ class TypedCount[IN](val f:

[GitHub] spark pull request #18113: [SPARK-20890][SQL] Added min and max typed aggreg...

2017-11-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18113#discussion_r150388516 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/typedaggregators.scala --- @@ -76,26 +77,130 @@ class TypedCount[IN](val f:

[GitHub] spark pull request #18113: [SPARK-20890][SQL] Added min and max typed aggreg...

2017-11-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18113#discussion_r150388500 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/typedaggregators.scala --- @@ -26,8 +26,9 @@ import

[GitHub] spark pull request #18113: [SPARK-20890][SQL] Added min and max typed aggreg...

2017-11-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18113#discussion_r150388484 --- Diff: sql/core/src/main/java/org/apache/spark/sql/expressions/javalang/typed.java --- @@ -74,4 +71,40 @@ public static TypedColumn

[GitHub] spark issue #19640: [SPARK-16986][CORE][WEB-UI] Support configure history se...

2017-11-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19640 **[Test build #83727 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83727/testReport)** for PR 19640 at commit

[GitHub] spark issue #19479: [SPARK-17074] [SQL] Generate equi-height histogram in co...

2017-11-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19479 **[Test build #83726 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83726/testReport)** for PR 19479 at commit

[GitHub] spark issue #19722: [SPARK-21693][R][ML] Reduce max iterations in Linear SVM...

2017-11-11 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19722 cc @felixcheung and @shivaram too. This one finally reduces the time! --- - To unsubscribe, e-mail:

[GitHub] spark issue #19722: [SPARK-21693][R][ML] Reduce max iterations in Linear SVM...

2017-11-11 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19722 Yea, the first build speeded up roughly about 30 minutes - https://ci.appveyor.com/project/ApacheSoftwareFoundation/spark/build/1909-master. I triggered more builds here for sure with my

[GitHub] spark issue #19722: [WIP][SPARK-21693][R][ML] Reduce max iterations in Linea...

2017-11-11 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19722 I checked it speeded up in https://ci.appveyor.com/project/ApacheSoftwareFoundation/spark/build/1909-master but the test seems hanging in `SparkSQL functions`, which seems unrelated. I

[GitHub] spark issue #19722: [WIP][SPARK-21693][R][ML] Reduce max iterations in Linea...

2017-11-11 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19722 Build started: [SparkR] `ALL`

[GitHub] spark issue #19722: [WIP][SPARK-21693][R][ML] Reduce max iterations in Linea...

2017-11-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19722 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19722: [WIP][SPARK-21693][R][ML] Reduce max iterations in Linea...

2017-11-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19722 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83725/ Test PASSed. ---

[GitHub] spark issue #19722: [WIP][SPARK-21693][R][ML] Reduce max iterations in Linea...

2017-11-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19722 **[Test build #83725 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83725/testReport)** for PR 19722 at commit

[GitHub] spark pull request #19713: [SPARK-22488] [SQL] Fix the view resolution issue...

2017-11-11 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/19713#discussion_r150384871 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala --- @@ -825,10 +825,11 @@ abstract class DDLSuite extends

  1   2   >