Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19747
**[Test build #83969 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83969/testReport)**
for PR 19747 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19772
LGTM, merging to master/2.2
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19772#discussion_r151732579
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/SQLTransformer.scala ---
@@ -70,7 +70,8 @@ class SQLTransformer @Since("1.6.0")
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19747
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19747
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83968/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19747
**[Test build #83968 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83968/testReport)**
for PR 19747 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19390
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19390
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83967/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19390
**[Test build #83967 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83967/testReport)**
for PR 19390 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19720
I don't have a strong preference, but there were many 64kb compile error
fixes for 2.2 or prior(e.g. `CreateStruct`, `CreateArray`, `Invoke`,
`CreateExternalRow`, erc.). They all add more global
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19730#discussion_r151725673
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -1039,13 +1039,19 @@ case class Cast(child:
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r151725539
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/VectorizedHashMapGenerator.scala
---
@@ -75,9 +77,14 @@ class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19730#discussion_r151723565
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
---
@@ -827,4 +827,34 @@ class CastSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19730#discussion_r151723430
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
---
@@ -827,4 +827,34 @@ class CastSuite extends
Github user squito commented on the issue:
https://github.com/apache/spark/pull/19769
cc @henryr @zivanfi
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19630
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19630
thanks, merging to master, cheers!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19257
After some more thoughts, I think the best choice is to do planning bottom
up. That requires a lot of refactoring and I'm fine to merge this workaround
first.
LGTM except one minor
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19257#discussion_r151714611
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/BucketedReadSuite.scala ---
@@ -602,6 +602,28 @@ abstract class BucketedReadSuite extends
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19774
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83966/
Test PASSed.
---
Github user icexelloss commented on the issue:
https://github.com/apache/spark/pull/19630
Everyone, I don't have more changes to the PR. I think all comments are
addressed at this point. Please let me know if I missed anything or there are
more comments. Thank you!
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19774
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19774
**[Test build #83966 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83966/testReport)**
for PR 19774 at commit
Github user icexelloss commented on the issue:
https://github.com/apache/spark/pull/19630
@HyukjinKwon Thanks for the reply on coverage. It'd be great to have an
easy way to run coverage :)
---
-
To unsubscribe,
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/19752
@kiszk may I kindly ask you to review this please? Thanks.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19774
**[Test build #83972 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83972/testReport)**
for PR 19774 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19630
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19630
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83962/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19630
**[Test build #83962 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83962/testReport)**
for PR 19630 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19630
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19630
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83965/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19630
**[Test build #83965 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83965/testReport)**
for PR 19630 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19767
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83963/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19767
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19769
**[Test build #83971 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83971/testReport)**
for PR 19769 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19767
**[Test build #83963 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83963/testReport)**
for PR 19767 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19730
**[Test build #83970 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83970/testReport)**
for PR 19730 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19760
I'm ok to move the deprecated config keys of
`MAX_REMOTE_BLOCK_SIZE_FETCH_TO_MEM` and `LISTENER_BUS_EVENT_QUEUE_CAPACITY` to
`SparkConf` if the deprecation message really matters. But I'd like to
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/19774#discussion_r151693461
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -689,6 +689,11 @@ case class DescribeColumnCommand(
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/19774#discussion_r151693478
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/describe-table-column.sql ---
@@ -24,6 +24,18 @@ DESC EXTENDED desc_col_table key;
DESC
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/19774#discussion_r151689883
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/describe-table-column.sql ---
@@ -24,6 +24,18 @@ DESC EXTENDED desc_col_table key;
DESC
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19747
**[Test build #83969 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83969/testReport)**
for PR 19747 at commit
Github user mpetruska commented on the issue:
https://github.com/apache/spark/pull/19671
@jiangxb1987 : Well, I ran the `BlockManagerSuite` with `testOnly` and did
not encounter any failures, passed 10 out of 10. Then, as a benchmark, I
checked out the version without my changes and
Github user skambha commented on the issue:
https://github.com/apache/spark/pull/19747
I have taken care of adding the check in the new
HiveClientImpl.alterTableDataSchema as well and have added some new tests.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19747
**[Test build #83968 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83968/testReport)**
for PR 19747 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19765
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19765
Merged to master/2.2
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user skambha commented on a diff in the pull request:
https://github.com/apache/spark/pull/19747#discussion_r151689272
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -40,6 +40,22 @@ class SQLQuerySuite extends QueryTest with
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19775
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user matyix opened a pull request:
https://github.com/apache/spark/pull/19775
Add support for publishing Spark metrics into Prometheus
## What changes were proposed in this pull request?
_Originally this PR was submitted to the Spark on K8S fork
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19739
In any event, you can always produce your a build without any POM changes
that does exactly this with `-Dhadoop.version=2.8.2` if you wanted to. You can
close this.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19390
**[Test build #83967 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83967/testReport)**
for PR 19390 at commit
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r151679164
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -451,15 +468,22 @@ trait
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19630#discussion_r151677913
--- Diff: python/pyspark/sql/functions.py ---
@@ -2049,132 +2050,12 @@ def map_values(col):
# User Defined
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19774
**[Test build #83966 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83966/testReport)**
for PR 19774 at commit
GitHub user mgaido91 opened a pull request:
https://github.com/apache/spark/pull/19774
[SPARK-22475][SQL] show histogram in DESC COLUMN command
## What changes were proposed in this pull request?
Added the histogram representation to the output of the `DESCRIBE EXTENDED
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19630#discussion_r151676061
--- Diff: python/pyspark/sql/functions.py ---
@@ -2049,132 +2050,12 @@ def map_values(col):
# User Defined Function
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19257
@felixcheung Don't worry, the bug only exists in the master branch, so it
won't block the 2.2.1 release. I have corrected the JIRA ticket's affected
version to 2.3 . Also I'm looking into this
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r151674490
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -451,15 +468,22 @@ trait
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r151674372
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -228,24 +254,15 @@ trait
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19630
**[Test build #83965 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83965/testReport)**
for PR 19630 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19630
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19773
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19773
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83964/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19773
**[Test build #83964 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83964/testReport)**
for PR 19773 at commit
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r151673131
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -451,15 +468,22 @@ trait
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r151673115
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -349,13 +349,22
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r151672855
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -427,10 +444,10 @@ trait
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19773
**[Test build #83964 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83964/testReport)**
for PR 19773 at commit
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r151672564
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -175,17 +176,39 @@ trait
GitHub user xuanyuanking opened a pull request:
https://github.com/apache/spark/pull/19773
Supporting for changing column dataType
## What changes were proposed in this pull request?
Support user to change column dataType in hive table and datasource table,
here also want
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19630
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83959/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19630
**[Test build #83959 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83959/testReport)**
for PR 19630 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19630
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19767
**[Test build #83963 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83963/testReport)**
for PR 19767 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19630
**[Test build #83962 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83962/testReport)**
for PR 19630 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19769
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83960/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19769
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19769
**[Test build #83960 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83960/testReport)**
for PR 19769 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19630
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19630
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83961/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19630
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19518
ping @bdrillard
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19767#discussion_r151644789
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -105,6 +105,41 @@ abstract class Expression extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19767#discussion_r151637511
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -105,6 +105,41 @@ abstract class Expression
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19767#discussion_r151636953
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -105,6 +105,41 @@ abstract class Expression
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19769#discussion_r151635947
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetInteroperabilitySuite.scala
---
@@ -87,4 +96,113 @@ class
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19763
cc @zsxwing
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19769
LGTM except a few minor comment
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19769#discussion_r151634925
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetInteroperabilitySuite.scala
---
@@ -87,4 +95,107 @@ class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19769#discussion_r151634730
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetInteroperabilitySuite.scala
---
@@ -87,4 +95,107 @@ class
Github user ferdonline commented on the issue:
https://github.com/apache/spark/pull/9428
That's the reason why I want to checkpoint when they are first calculated.
Further transformations use these results several times. Of course it's not a
problem per se to calculate twice for the
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19769#discussion_r151633919
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetInteroperabilitySuite.scala
---
@@ -87,4 +95,107 @@ class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19769#discussion_r151633640
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRowConverter.scala
---
@@ -151,6 +154,8 @@ private[parquet]
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19769
**[Test build #83960 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83960/testReport)**
for PR 19769 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19769
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19767#discussion_r151631456
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -105,6 +105,41 @@ abstract class Expression extends
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/19767
Looks good direction if we do not see performance degradation.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19767
@maropu it partially covers #18641 . One problem is that, for an
expression, if its child generates code less than 1024, and it has many
children, then we still have an issue. `CaseWhen` is a
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19767#discussion_r151624776
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -105,6 +105,41 @@ abstract class Expression
101 - 200 of 212 matches
Mail list logo
