Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19767#discussion_r152489116
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -105,6 +105,36 @@ abstract class Expression
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19779
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84094/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19779
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19779
**[Test build #84094 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84094/testReport)**
for PR 19779 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19082
ya, enjoy!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19082
Will review it carefully after I finish my vacation. Thanks!
---
-
To unsubscribe, e-mail:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19257#discussion_r152484490
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala
---
@@ -265,6 +268,7 @@ case class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19257#discussion_r152484440
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala
---
@@ -265,6 +268,7 @@ case class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19257#discussion_r152484350
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala
---
@@ -31,6 +32,8 @@ import
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19651#discussion_r152482492
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcDeserializer.scala
---
@@ -0,0 +1,216 @@
+/*
+ *
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19752#discussion_r152482401
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala
---
@@ -211,111 +231,61 @@ abstract class
Github user vinodkc commented on the issue:
https://github.com/apache/spark/pull/19779
@gatorsmile , @cloud-fan and @dongjoon-hyun
Thanks for the review comments and guidence
Sure, I'll submit a separate PR for backporting it to 2.2
---
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19651#discussion_r152480591
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcDeserializer.scala
---
@@ -0,0 +1,216 @@
+/*
+ *
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19792
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19792
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84095/
Test PASSed.
---
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/19792
What if `ArrayType` or `MapType`, or deeply nested `StructType`?
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19792
**[Test build #84095 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84095/testReport)**
for PR 19792 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19773#discussion_r152480007
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -318,16 +318,26 @@ case class AlterTableChangeColumnCommand(
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19651#discussion_r152479902
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcDeserializer.scala
---
@@ -0,0 +1,216 @@
+/*
+ *
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19651
**[Test build #84097 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84097/testReport)**
for PR 19651 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19779
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19468
**[Test build #84096 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84096/testReport)**
for PR 19468 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19779
Thanks! Merged to master.
@vinodkc Could you submit a separate PR for backporting it to 2.2?
---
-
To unsubscribe,
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19792#discussion_r152478594
--- Diff: python/pyspark/sql/types.py ---
@@ -1108,19 +1109,22 @@ def _has_nulltype(dt):
return isinstance(dt, NullType)
-def
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19767
LGTM except the above comments.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19767#discussion_r152476972
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -105,6 +105,36 @@ abstract class Expression
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19767#discussion_r152470168
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -105,6 +105,36 @@ abstract class Expression
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19767#discussion_r152477535
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -105,6 +105,36 @@ abstract class Expression
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19792
**[Test build #84095 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84095/testReport)**
for PR 19792 at commit
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/19792
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19779
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19779
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84092/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19779
**[Test build #84092 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84092/testReport)**
for PR 19779 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19779
**[Test build #84094 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84094/testReport)**
for PR 19779 at commit
Github user vinodkc commented on a diff in the pull request:
https://github.com/apache/spark/pull/19779#discussion_r152474528
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala ---
@@ -841,6 +841,76 @@ class VersionsSuite extends SparkFunSuite
Github user vinodkc commented on a diff in the pull request:
https://github.com/apache/spark/pull/19779#discussion_r152473900
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala ---
@@ -841,6 +841,76 @@ class VersionsSuite extends SparkFunSuite
Github user vinodkc commented on a diff in the pull request:
https://github.com/apache/spark/pull/19779#discussion_r152473845
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala ---
@@ -841,6 +841,76 @@ class VersionsSuite extends SparkFunSuite
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19781
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19781
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84091/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19781
**[Test build #84091 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84091/testReport)**
for PR 19781 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19756
ping @cloud-fan Please take a look. Thanks.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19621
**[Test build #84093 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84093/testReport)**
for PR 19621 at commit
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/19518
@cloud-fan Is it better to use this PR? Or, create a new PR?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19779
cc @felixcheung This sounds critical for Spark 2.2 too.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19779
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19779#discussion_r152465384
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala ---
@@ -841,6 +841,76 @@ class VersionsSuite extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19779#discussion_r152465374
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala ---
@@ -841,6 +841,76 @@ class VersionsSuite extends
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19791#discussion_r152464410
--- Diff: repl/src/test/scala/org/apache/spark/repl/ReplSuite.scala ---
@@ -217,4 +218,13 @@ class ReplSuite extends SparkFunSuite {
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19779
**[Test build #84092 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84092/testReport)**
for PR 19779 at commit
Github user vinodkc commented on a diff in the pull request:
https://github.com/apache/spark/pull/19779#discussion_r152464029
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala ---
@@ -841,6 +841,75 @@ class VersionsSuite extends SparkFunSuite
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19468
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84088/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19468
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19468
**[Test build #84088 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84088/testReport)**
for PR 19468 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19779
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84090/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19776
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84087/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19776
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19779
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19776
**[Test build #84087 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84087/testReport)**
for PR 19776 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19779
**[Test build #84090 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84090/testReport)**
for PR 19779 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19746
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19746
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84089/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19746
**[Test build #84089 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84089/testReport)**
for PR 19746 at commit
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r152458539
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodFactory.scala
---
@@ -0,0 +1,229 @@
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r152458560
--- Diff:
resource-managers/kubernetes/core/src/test/resources/log4j.properties ---
@@ -0,0 +1,31 @@
+#
+# Licensed to the Apache Software
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r152458551
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/ConfigurationUtils.scala
---
@@ -0,0 +1,43 @@
+/*
+ *
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19781#discussion_r152455868
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala ---
@@ -857,4 +857,29 @@ class JoinSuite extends QueryTest with
SharedSQLContext {
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19781
**[Test build #84091 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84091/testReport)**
for PR 19781 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19767
will review it tonight.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19588#discussion_r152454669
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/VectorIndexer.scala ---
@@ -311,22 +342,39 @@ class VectorIndexerModel private[ml] (
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/19786
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user jliwork commented on the issue:
https://github.com/apache/spark/pull/19776
@gatorsmile @cloud-fan @viirya @HyukjinKwon Thanks a lot! =)
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r152450525
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodFactory.scala
---
@@ -0,0 +1,229 @@
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19370
In `if not exist "%FIND_SPARK_HOME_PYTHON_SCRIPT%" (`, I switched the
condition to be matched with
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19370
I suggest this:
```cmd
rem Path to Python script finding SPARK_HOME
set FIND_SPARK_HOME_PYTHON_SCRIPT=%~dp0find_spark_home.py
rem Default to standard python interpreter
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19370#discussion_r152449365
--- Diff: bin/find-spark-home.cmd ---
@@ -0,0 +1,56 @@
+@echo off
+
+rem
+rem Licensed to the Apache Software Foundation (ASF) under one
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r152449333
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodFactory.scala
---
@@ -0,0 +1,229 @@
+/*
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19767#discussion_r152449180
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -105,6 +105,41 @@ abstract class Expression extends
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19776
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19779#discussion_r152448746
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala ---
@@ -841,6 +841,75 @@ class VersionsSuite extends SparkFunSuite
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19776
Thanks! Merged to master/2.2/2.1
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r152448480
--- Diff:
resource-managers/kubernetes/core/src/test/resources/log4j.properties ---
@@ -0,0 +1,31 @@
+#
+# Licensed to the Apache Software
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19776
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19781
I finally found the failure case by a simple query. I'll update soon.
---
-
To unsubscribe, e-mail:
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19518
yea, ok @kiszk I'll review your work.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/19601
@cloud-fan could you please review this?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19776
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19776
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84086/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19776
**[Test build #84086 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84086/testReport)**
for PR 19776 at commit
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/19518
@cloud-fan I want to take this over if possible
cc @maropu
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user vinodkc commented on a diff in the pull request:
https://github.com/apache/spark/pull/19779#discussion_r152446382
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala ---
@@ -841,6 +841,75 @@ class VersionsSuite extends SparkFunSuite
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19779
**[Test build #84090 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84090/testReport)**
for PR 19779 at commit
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r152446177
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodFactory.scala
---
@@ -0,0 +1,229 @@
+/*
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r152445984
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodFactory.scala
---
@@ -0,0 +1,229 @@
+/*
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r152445535
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodFactory.scala
---
@@ -0,0 +1,229 @@
+/*
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r152444685
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodFactory.scala
---
@@ -0,0 +1,229 @@
+/*
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r152443965
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/ConfigurationUtils.scala
---
@@ -0,0 +1,43 @@
+/*
+ *
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19767
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19767
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84085/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19767
**[Test build #84085 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84085/testReport)**
for PR 19767 at commit
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r152443488
--- Diff: pom.xml ---
@@ -2648,6 +2648,13 @@
+
+ kubernetes
+
+
1 - 100 of 393 matches
Mail list logo
