Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19858
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19813#discussion_r154576646
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/ExpressionCodegen.scala
---
@@ -0,0 +1,237 @@
+/*
+ *
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19869#discussion_r154576368
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -573,94 +574,84 @@ case class HashAggregateExec(
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19858
Thanks! Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19858
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19813#discussion_r154575849
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/ExpressionCodegen.scala
---
@@ -0,0 +1,237 @@
+/*
+ *
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19841#discussion_r154575693
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveTable.scala
---
@@ -104,14 +105,61 @@ case class
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19874
**[Test build #84418 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84418/testReport)**
for PR 19874 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19813#discussion_r154575588
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ColumnarBatchScan.scala
---
@@ -108,7 +108,10 @@ private[sql] trait ColumnarBatchScan
Github user barrenlake commented on a diff in the pull request:
https://github.com/apache/spark/pull/17176#discussion_r154575331
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala ---
@@ -159,36 +159,11 @@ class HadoopTableReader(
def
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/19874
[SPARK-22675] [SQL] Refactoring PropagateTypes in TypeCoercion
## What changes were proposed in this pull request?
PropagateTypes are called twice in TypeCoercion. We do not need to call it
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19869
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19869
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84416/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19869
**[Test build #84416 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84416/testReport)**
for PR 19869 at commit
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19813#discussion_r154574087
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/ExpressionCodegen.scala
---
@@ -0,0 +1,237 @@
+/*
+ *
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19813#discussion_r154573755
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1001,16 +1017,25 @@ class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19717#discussion_r154572754
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/steps/DriverServiceBootstrapStep.scala
---
@@ -0,0 +1,103 @@
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19873
cc @cloud-fan @hvanhovell Basically this is the same changes in #17770.
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19873
**[Test build #84417 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84417/testReport)**
for PR 19873 at commit
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/19873
[SPARK-20392][SQL] Set barrier to prevent re-entering a tree
## What changes were proposed in this pull request?
It is reported that there is performance downgrade when applying ML
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19813#discussion_r154571348
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -115,9 +120,35 @@ abstract class Expression
Github user zuotingbing commented on the issue:
https://github.com/apache/spark/pull/19841
I extract a separate function but it has too many parameters. Could i
extract several separate functions?
---
-
To
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19869
**[Test build #84416 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84416/testReport)**
for PR 19869 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19869
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84410/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19869
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19869
**[Test build #84410 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84410/testReport)**
for PR 19869 at commit
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19872#discussion_r154569899
--- Diff: python/pyspark/sql/group.py ---
@@ -89,8 +89,15 @@ def agg(self, *exprs):
else:
# Columns
assert
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19872#discussion_r154569953
--- Diff: python/pyspark/sql/group.py ---
@@ -89,8 +89,15 @@ def agg(self, *exprs):
else:
# Columns
assert
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19872#discussion_r154569884
--- Diff: python/pyspark/sql/group.py ---
@@ -89,8 +89,15 @@ def agg(self, *exprs):
else:
# Columns
assert
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19869#discussion_r154569858
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -768,12 +762,8 @@ case class HashAggregateExec(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19869#discussion_r154569741
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -768,12 +762,8 @@ case class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19872
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84415/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19872
**[Test build #84415 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84415/testReport)**
for PR 19872 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19872
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19872
**[Test build #84415 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84415/testReport)**
for PR 19872 at commit
Github user yaooqinn commented on the issue:
https://github.com/apache/spark/pull/19840
@ueshin case 8 should be client deploy mode, excuse me for copy mistake,
fixed
---
-
To unsubscribe, e-mail:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19872#discussion_r154569177
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/python/ExtractPythonUDFs.scala
---
@@ -113,6 +113,7 @@ object ExtractPythonUDFs extends
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19717#discussion_r154569020
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark-base/entrypoint.sh
---
@@ -0,0 +1,37 @@
+#!/bin/bash
+#
+#
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19717#discussion_r154568773
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -590,6 +604,11 @@ private[deploy] class
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/19840
@yaooqinn What's the difference between case 7 and 8? Looks like the same
configuration but the different result?
---
-
To
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19862#discussion_r154568554
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/execution/UnsafeExternalRowSorter.java
---
@@ -159,6 +154,12 @@ public boolean hasNext() {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19862#discussion_r154568281
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/execution/UnsafeExternalRowSorter.java
---
@@ -159,6 +154,12 @@ public boolean hasNext() {
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19872
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19872
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84414/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19872
**[Test build #84414 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84414/testReport)**
for PR 19872 at commit
Github user icexelloss commented on the issue:
https://github.com/apache/spark/pull/19872
cc @HyukjinKwon @holdenk @ueshin
Passing some basic tests. I will work on this more next week to clean up
and add more testing.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19872
**[Test build #84414 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84414/testReport)**
for PR 19872 at commit
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19717#discussion_r154567885
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -590,6 +600,11 @@ private[deploy] class
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/18995
BTW, @cloud-fan . Do you mean literally `move`? I'm wondering if I'm
thinking in a different way.
---
-
To unsubscribe,
GitHub user icexelloss opened a pull request:
https://github.com/apache/spark/pull/19872
WIP: [SPARK-22274][PySpark] User-defined aggregation functions with pandas
udf
## What changes were proposed in this pull request?
Add support for pandas_udf in groupby().agg()
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19862#discussion_r154567693
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -750,6 +756,8 @@ private[joins] class
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19871
**[Test build #84413 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84413/testReport)**
for PR 19871 at commit
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19862#discussion_r154567585
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/execution/UnsafeExternalRowSorter.java
---
@@ -182,18 +183,14 @@ public UnsafeRow next() {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19862#discussion_r154567319
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -674,8 +674,9 @@ private[joins] class
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154567195
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/DDLSourceLoadSuite.scala
---
@@ -54,11 +55,17 @@ class DDLSourceLoadSuite extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19862#discussion_r154567168
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -699,39 +700,44 @@ private[joins] class
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19717#discussion_r154567054
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/driver/Dockerfile ---
@@ -0,0 +1,31 @@
+#
+# Licensed to the Apache Software
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/18995
@cloud-fan .
For the other part, I'm restructuring to remove redundancy in the same
manner of `InMemoryCatalogedDDLSuite`, `HiveCatalogedDDLSuite`, and `DDLSuite`.
This one
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19871
**[Test build #84412 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84412/testReport)**
for PR 19871 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19869
LGTM for super minor comments...
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19862#discussion_r154566562
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -699,39 +700,44 @@ private[joins] class
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19717#discussion_r154566501
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -119,5 +139,60 @@ private[spark] object
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19869#discussion_r154566445
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -882,45 +851,65 @@ case class HashAggregateExec(
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19869#discussion_r154565659
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -768,12 +762,8 @@ case class HashAggregateExec(
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19869#discussion_r154561232
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -621,34 +622,30 @@ case class HashAggregateExec(
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19869#discussion_r154562413
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -672,48 +668,56 @@ case class HashAggregateExec(
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19862#discussion_r154566463
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -700,38 +701,43 @@ private[joins] class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19862#discussion_r154566374
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -699,39 +700,44 @@ private[joins] class
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19717#discussion_r154566357
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/Client.scala
---
@@ -0,0 +1,234 @@
+/*
+ *
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19717#discussion_r154566070
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/executor/Dockerfile ---
@@ -0,0 +1,31 @@
+#
+# Licensed to the Apache
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19717#discussion_r154566094
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/steps/DriverServiceBootstrapStep.scala
---
@@ -0,0 +1,103
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154565988
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -568,8 +571,12 @@ object DataSource extends
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19871
Thank you for review, @cloud-fan and @jiangxb1987 .
The PR is updated.
---
-
To unsubscribe, e-mail:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154565883
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/DDLSourceLoadSuite.scala
---
@@ -54,11 +55,17 @@ class DDLSourceLoadSuite extends
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19871
**[Test build #84411 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84411/testReport)**
for PR 19871 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154565755
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -568,8 +571,12 @@ object DataSource extends Logging
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19717#discussion_r154565597
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -296,6 +298,12 @@ object SparkSubmit extends CommandLineUtils with
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154565348
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -568,8 +570,13 @@ object DataSource extends
Github user liu-zhaokun closed the pull request at:
https://github.com/apache/spark/pull/19856
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19871
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84409/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19871
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19871
**[Test build #84409 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84409/testReport)**
for PR 19871 at commit
Github user gczsjdy commented on a diff in the pull request:
https://github.com/apache/spark/pull/19862#discussion_r154563897
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -674,8 +674,9 @@ private[joins] class
Github user gczsjdy commented on a diff in the pull request:
https://github.com/apache/spark/pull/19862#discussion_r154564327
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -699,39 +700,44 @@ private[joins] class
Github user gczsjdy commented on a diff in the pull request:
https://github.com/apache/spark/pull/19862#discussion_r154564488
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -699,39 +700,44 @@ private[joins] class
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19717#discussion_r154564066
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -251,6 +252,7 @@ object SparkSubmit extends CommandLineUtils with
Logging
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154563993
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -363,6 +363,11 @@ object SQLConf {
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154563902
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/DDLSourceLoadSuite.scala
---
@@ -54,11 +55,17 @@ class DDLSourceLoadSuite extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154563532
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -568,8 +570,13 @@ object DataSource extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154563501
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -568,8 +570,13 @@ object DataSource extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154563142
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -363,6 +363,11 @@ object SQLConf {
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19855
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19855
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84407/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19855
**[Test build #84407 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84407/testReport)**
for PR 19855 at commit
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19862#discussion_r154556774
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/execution/UnsafeExternalRowSorter.java
---
@@ -159,6 +159,12 @@ public boolean hasNext() {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19862#discussion_r154558106
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -699,39 +700,44 @@ private[joins] class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19862#discussion_r154560155
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -699,39 +700,44 @@ private[joins] class
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/17770
yea, a new PR sounds good, thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19862#discussion_r154560524
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -674,8 +674,9 @@ private[joins] class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19862#discussion_r154560474
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -750,6 +756,8 @@ private[joins] class
1 - 100 of 207 matches
Mail list logo
