Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154638371
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -363,6 +363,14 @@ object SQLConf {
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154638156
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -85,7 +87,8 @@ case class DataSource(
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19876
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19876
**[Test build #84426 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84426/testReport)**
for PR 19876 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19876
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84426/
Test FAILed.
---
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19870#discussion_r154542257
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -838,6 +838,8 @@ case class
Github user carsonwang commented on the issue:
https://github.com/apache/spark/pull/19877
cc @vanzin
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19875
**[Test build #84425 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84425/testReport)**
for PR 19875 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19874
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84424/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19876
**[Test build #84426 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84426/testReport)**
for PR 19876 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19874
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19877
**[Test build #84427 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84427/testReport)**
for PR 19877 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19874
**[Test build #84424 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84424/testReport)**
for PR 19874 at commit
Github user gczsjdy commented on a diff in the pull request:
https://github.com/apache/spark/pull/19862#discussion_r154635850
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -699,39 +700,44 @@ private[joins] class
GitHub user carsonwang opened a pull request:
https://github.com/apache/spark/pull/19877
[SPARK-22681]Accumulator should only updated once for each task in result
stage
## What changes were proposed in this pull request?
As the doc says "For accumulator updates performed inside
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19792#discussion_r154630463
--- Diff: python/pyspark/sql/session.py ---
@@ -337,7 +338,7 @@ def _inferSchemaFromList(self, data):
if type(first) is dict:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19813
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19813
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84422/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19813
**[Test build #84422 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84422/testReport)**
for PR 19813 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19871
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84421/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19871
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19871
**[Test build #84421 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84421/testReport)**
for PR 19871 at commit
GitHub user holdenk opened a pull request:
https://github.com/apache/spark/pull/19876
[WIP][ML][SPARK-11171] spark 11237 Add PMML export to Spark ML pipelines
## What changes were proposed in this pull request?
Adds PMML export support to Spark ML pipelines in the style of
GitHub user mgaido91 opened a pull request:
https://github.com/apache/spark/pull/19875
[SPARK-22473][FOLLOWUP][TEST] Remove deprecated Date functions
## What changes were proposed in this pull request?
#19696 replaced the deprecated usages for `Date` and `Waiter`, but a few
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19841
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19841
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84423/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19841
**[Test build #84423 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84423/testReport)**
for PR 19841 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19792
Oh, will double check too for sure shortly.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19872#discussion_r154616454
--- Diff: python/pyspark/sql/functions.py ---
@@ -2070,6 +2070,8 @@ class PandasUDFType(object):
GROUP_MAP =
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19872#discussion_r154615728
--- Diff: python/pyspark/sql/udf.py ---
@@ -56,6 +56,10 @@ def _create_udf(f, returnType, evalType):
return udf_obj._wrapped()
Github user gberger commented on the issue:
https://github.com/apache/spark/pull/19792
Friendly ping -- I've fixed that @ueshin.
Is there anything else I should look at to get this to be merged?
/cc @HyukjinKwon
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19873
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84420/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19873
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19873
**[Test build #84420 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84420/testReport)**
for PR 19873 at commit
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18581#discussion_r154606499
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/source/libsvm/LibSVMRelationSuite.scala
---
@@ -184,4 +184,54 @@ class LibSVMRelationSuite extends
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18581#discussion_r154606263
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/source/libsvm/LibSVMRelationSuite.scala
---
@@ -184,4 +184,54 @@ class LibSVMRelationSuite extends
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18581#discussion_r154605874
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/source/libsvm/LibSVMRelationSuite.scala
---
@@ -184,4 +184,54 @@ class LibSVMRelationSuite extends
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/19840
@yaooqinn It is used for executors.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18581#discussion_r154594735
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/source/libsvm/LibSVMRelationSuite.scala
---
@@ -184,4 +184,54 @@ class LibSVMRelationSuite extends
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18581#discussion_r154594381
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/source/libsvm/LibSVMRelationSuite.scala
---
@@ -184,4 +184,54 @@ class LibSVMRelationSuite extends
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18581#discussion_r154598540
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/source/libsvm/LibSVMRelationSuite.scala
---
@@ -184,4 +184,54 @@ class LibSVMRelationSuite extends
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19874
**[Test build #84424 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84424/testReport)**
for PR 19874 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19874
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user yaooqinn commented on the issue:
https://github.com/apache/spark/pull/19840
@ueshin
[context.py#L191](https://github.com/yaooqinn/spark/blob/8ff5663fe9a32eae79c8ee6bc310409170a8da64/python/pyspark/context.py#L191)
set for both driver and executor?
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19841
**[Test build #84423 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84423/testReport)**
for PR 19841 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19841
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19813
**[Test build #84422 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84422/testReport)**
for PR 19813 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19860
Thanks for your work! A late LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19813#discussion_r154588045
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ColumnarBatchScan.scala
---
@@ -108,7 +108,10 @@ private[sql] trait ColumnarBatchScan
Github user zuotingbing commented on the issue:
https://github.com/apache/spark/pull/19841
please review it again, thanks all.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user yaooqinn commented on the issue:
https://github.com/apache/spark/pull/19840
@ueshin i see.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19869
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19869
**[Test build #84419 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84419/testReport)**
for PR 19869 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19869
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84419/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19871
**[Test build #84421 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84421/testReport)**
for PR 19871 at commit
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154583136
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveStrategies.scala ---
@@ -195,8 +195,18 @@ case class RelationConversions(
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154582712
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
---
@@ -2153,4 +2153,21 @@ class SQLQuerySuite extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154582670
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -568,8 +571,11 @@ object DataSource extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19813#discussion_r154582497
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/ExpressionCodegen.scala
---
@@ -0,0 +1,237 @@
+/*
+ *
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19813#discussion_r154582383
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/ExpressionCodegen.scala
---
@@ -0,0 +1,237 @@
+/*
+ *
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/19840
@yaooqinn I meant it is not used for `pythonExec`.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19813#discussion_r154581864
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/ExpressionCodegen.scala
---
@@ -0,0 +1,237 @@
+/*
+ *
Github user gczsjdy commented on a diff in the pull request:
https://github.com/apache/spark/pull/19862#discussion_r154581844
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/execution/UnsafeExternalRowSorter.java
---
@@ -159,6 +154,12 @@ public boolean hasNext() {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19813#discussion_r154581731
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -115,9 +120,35 @@ abstract class Expression extends
Github user yaooqinn commented on the issue:
https://github.com/apache/spark/pull/19840
I can `spark.executorEnv.PYSPARK_PYTHON` in `sparkConf` at executor side ,
because it is set at
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154580498
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveStrategies.scala ---
@@ -195,8 +195,18 @@ case class RelationConversions(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154580323
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
---
@@ -2153,4 +2153,21 @@ class SQLQuerySuite extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19869#discussion_r154580311
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -596,7 +596,7 @@ case class HashAggregateExec(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154580007
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -568,8 +571,11 @@ object DataSource extends
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19869
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/19840
@yaooqinn OK, I see the situation.
In client mode, I think we can't use `spark.yarn.appMasterEnv.XXX` which is
for cluster mode. So we should use environment variable `PYSPARK_PYTHON` or
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19873
**[Test build #84420 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84420/testReport)**
for PR 19873 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19873
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19873
**[Test build #84417 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84417/testReport)**
for PR 19873 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19871
**[Test build #84412 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84412/testReport)**
for PR 19871 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19871
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84413/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19874
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19874
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84418/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19873
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19871
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19871
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19873
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84417/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19871
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19871
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84411/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19871
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84412/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19871
**[Test build #84411 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84411/testReport)**
for PR 19871 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19874
**[Test build #84418 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84418/testReport)**
for PR 19874 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19871
**[Test build #84413 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84413/testReport)**
for PR 19871 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19869
**[Test build #84419 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84419/testReport)**
for PR 19869 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154577760
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -568,8 +571,11 @@ object DataSource extends
401 - 490 of 490 matches
Mail list logo
