[GitHub] spark issue #20141: [SPARK-22945][SQL] add java UDF APIs in the functions ob...

2018-01-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20141 **[Test build #85658 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85658/testReport)** for PR 20141 at commit

[GitHub] spark issue #20148: [SPARK-22953][K8S] Avoids adding duplicated secret volum...

2018-01-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20148 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20148: [SPARK-22953][K8S] Avoids adding duplicated secret volum...

2018-01-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20148 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85669/ Test PASSed. ---

[GitHub] spark issue #20148: [SPARK-22953][K8S] Avoids adding duplicated secret volum...

2018-01-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20148 **[Test build #85669 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85669/testReport)** for PR 20148 at commit

[GitHub] spark issue #20146: [SPARK-11215][ML] Add multiple columns support to String...

2018-01-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20146 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85656/ Test FAILed. ---

[GitHub] spark issue #20146: [SPARK-11215][ML] Add multiple columns support to String...

2018-01-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20146 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20146: [SPARK-11215][ML] Add multiple columns support to String...

2018-01-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20146 **[Test build #85656 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85656/testReport)** for PR 20146 at commit

[GitHub] spark issue #20148: [SPARK-22953][K8S] Avoids adding duplicated secret volum...

2018-01-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20148 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85668/ Test PASSed. ---

[GitHub] spark issue #20148: [SPARK-22953][K8S] Avoids adding duplicated secret volum...

2018-01-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20148 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20148: [SPARK-22953][K8S] Avoids adding duplicated secret volum...

2018-01-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20148 **[Test build #85668 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85668/testReport)** for PR 20148 at commit

[GitHub] spark issue #20148: [SPARK-22953][K8S] Avoids adding duplicated secret volum...

2018-01-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20148 **[Test build #85669 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85669/testReport)** for PR 20148 at commit

[GitHub] spark issue #20148: [SPARK-22953][K8S] Avoids adding duplicated secret volum...

2018-01-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20148 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85667/ Test PASSed. ---

[GitHub] spark pull request #20148: [SPARK-22953][K8S] Avoids adding duplicated secre...

2018-01-03 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/20148#discussion_r159592335 --- Diff: resource-managers/kubernetes/core/src/test/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodFactorySuite.scala --- @@ -172,10 +172,8

[GitHub] spark issue #20148: [SPARK-22953][K8S] Avoids adding duplicated secret volum...

2018-01-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20148 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20148: [SPARK-22953][K8S] Avoids adding duplicated secret volum...

2018-01-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20148 **[Test build #85667 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85667/testReport)** for PR 20148 at commit

[GitHub] spark pull request #20148: [SPARK-22953][K8S] Avoids adding duplicated secre...

2018-01-03 Thread hex108
Github user hex108 commented on a diff in the pull request: https://github.com/apache/spark/pull/20148#discussion_r159591760 --- Diff: resource-managers/kubernetes/core/src/test/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodFactorySuite.scala --- @@ -172,10 +172,8 @@

[GitHub] spark issue #20148: [SPARK-22953][K8S] Avoids adding duplicated secret volum...

2018-01-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20148 **[Test build #85668 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85668/testReport)** for PR 20148 at commit

[GitHub] spark pull request #20148: [SPARK-22953][K8S] Avoids adding duplicated secre...

2018-01-03 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/20148#discussion_r159590877 --- Diff: resource-managers/kubernetes/core/src/test/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodFactorySuite.scala --- @@ -172,10 +172,8

[GitHub] spark pull request #20024: [SPARK-22825][SQL] Fix incorrect results of Casti...

2018-01-03 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20024#discussion_r159590636 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala --- @@ -203,9 +203,26 @@ case class Cast(child: Expression,

[GitHub] spark issue #20148: [SPARK-22953][K8S] Avoids adding duplicated secret volum...

2018-01-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20148 **[Test build #85667 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85667/testReport)** for PR 20148 at commit

[GitHub] spark pull request #20148: [SPARK-22953][K8S] Avoids adding duplicated secre...

2018-01-03 Thread hex108
Github user hex108 commented on a diff in the pull request: https://github.com/apache/spark/pull/20148#discussion_r159590343 --- Diff: resource-managers/kubernetes/core/src/test/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodFactorySuite.scala --- @@ -172,10 +172,8 @@

[GitHub] spark pull request #20024: [SPARK-22825][SQL] Fix incorrect results of Casti...

2018-01-03 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20024#discussion_r159590247 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala --- @@ -608,6 +667,20 @@ case class Cast(child: Expression,

[GitHub] spark pull request #20148: [SPARK-22953][K8S] Avoids adding duplicated secre...

2018-01-03 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/20148#discussion_r159590150 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/MountSecretsBootstrap.scala --- @@ -28,20 +28,26 @@

[GitHub] spark issue #20147: [SPARK-22940][SQL] HiveExternalCatalogVersionsSuite shou...

2018-01-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20147 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20147: [SPARK-22940][SQL] HiveExternalCatalogVersionsSuite shou...

2018-01-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20147 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85659/ Test PASSed. ---

[GitHub] spark issue #20145: [SPARK-22950][SQL]Handle ChildFirstURLClassLoader's pare...

2018-01-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20145 **[Test build #85666 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85666/testReport)** for PR 20145 at commit

[GitHub] spark issue #20147: [SPARK-22940][SQL] HiveExternalCatalogVersionsSuite shou...

2018-01-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20147 **[Test build #85659 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85659/testReport)** for PR 20147 at commit

[GitHub] spark pull request #20024: [SPARK-22825][SQL] Fix incorrect results of Casti...

2018-01-03 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20024#discussion_r159589454 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala --- @@ -608,6 +667,20 @@ case class Cast(child: Expression,

[GitHub] spark pull request #20145: [SPARK-22950][SQL]Handle ChildFirstURLClassLoader...

2018-01-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20145#discussion_r159589347 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveUtilsSuite.scala --- @@ -42,4 +47,41 @@ class HiveUtilsSuite extends QueryTest with

[GitHub] spark pull request #20024: [SPARK-22825][SQL] Fix incorrect results of Casti...

2018-01-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20024#discussion_r159589202 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala --- @@ -203,9 +203,26 @@ case class Cast(child: Expression,

[GitHub] spark pull request #20024: [SPARK-22825][SQL] Fix incorrect results of Casti...

2018-01-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20024#discussion_r159589126 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala --- @@ -203,9 +203,26 @@ case class Cast(child: Expression,

[GitHub] spark pull request #20148: [SPARK-22953][K8S] Avoids adding duplicated secre...

2018-01-03 Thread foxish
Github user foxish commented on a diff in the pull request: https://github.com/apache/spark/pull/20148#discussion_r159588871 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/MountSecretsBootstrap.scala --- @@ -28,20 +28,26 @@ private[spark]

[GitHub] spark issue #20148: [SPARK-22953][K8S] Avoids adding duplicated secret volum...

2018-01-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20148 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20148: [SPARK-22953][K8S] Avoids adding duplicated secret volum...

2018-01-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20148 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85664/ Test PASSed. ---

[GitHub] spark issue #20148: [SPARK-22953][K8S] Avoids adding duplicated secret volum...

2018-01-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20148 **[Test build #85664 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85664/testReport)** for PR 20148 at commit

[GitHub] spark issue #20149: [SPARK-22771][SQL] Add a missing return statement in Con...

2018-01-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20149 **[Test build #85665 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85665/testReport)** for PR 20149 at commit

[GitHub] spark pull request #20148: [SPARK-22953][K8S] Avoids adding duplicated secre...

2018-01-03 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/20148#discussion_r159588468 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/MountSecretsBootstrap.scala --- @@ -28,20 +28,26 @@

[GitHub] spark pull request #20024: [SPARK-22825][SQL] Fix incorrect results of Casti...

2018-01-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20024#discussion_r159588521 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala --- @@ -608,6 +667,20 @@ case class Cast(child: Expression,

[GitHub] spark pull request #20024: [SPARK-22825][SQL] Fix incorrect results of Casti...

2018-01-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20024#discussion_r159588472 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala --- @@ -608,6 +667,20 @@ case class Cast(child: Expression,

[GitHub] spark issue #20149: [SPARK-22771][SQL] Add a missing return statement in Con...

2018-01-03 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20149 cc: @gatorsmile --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20149: [SPARK-22771][SQL] Add a missing return statement...

2018-01-03 Thread maropu
GitHub user maropu opened a pull request: https://github.com/apache/spark/pull/20149 [SPARK-22771][SQL] Add a missing return statement in Concat.checkInputDataTypes ## What changes were proposed in this pull request? This pr is a follow-up to fix a bug left in #19977.

[GitHub] spark pull request #20148: [SPARK-22953][K8S] Avoids adding duplicated secre...

2018-01-03 Thread foxish
Github user foxish commented on a diff in the pull request: https://github.com/apache/spark/pull/20148#discussion_r159588348 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/MountSecretsBootstrap.scala --- @@ -28,20 +28,26 @@ private[spark]

[GitHub] spark issue #20078: [SPARK-22900] [Spark-Streaming] Remove unnecessary restr...

2018-01-03 Thread sharkdtu
Github user sharkdtu commented on the issue: https://github.com/apache/spark/pull/20078 @felixcheung Have you ever thought about initial num-executors? Actually, it is default 2 executors when you run spark on yarn. How can you make sure that this 2 executors have enougth cores

[GitHub] spark pull request #20024: [SPARK-22825][SQL] Fix incorrect results of Casti...

2018-01-03 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20024#discussion_r159588015 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala --- @@ -203,9 +203,26 @@ case class Cast(child: Expression,

[GitHub] spark pull request #20024: [SPARK-22825][SQL] Fix incorrect results of Casti...

2018-01-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20024#discussion_r159587926 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala --- @@ -203,9 +203,26 @@ case class Cast(child: Expression,

[GitHub] spark issue #20148: [SPARK-22953][K8S] Avoids adding duplicated secret volum...

2018-01-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20148 **[Test build #85664 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85664/testReport)** for PR 20148 at commit

[GitHub] spark pull request #20145: [SPARK-22950][SQL]Handle ChildFirstURLClassLoader...

2018-01-03 Thread yaooqinn
Github user yaooqinn commented on a diff in the pull request: https://github.com/apache/spark/pull/20145#discussion_r159587396 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveUtilsSuite.scala --- @@ -42,4 +47,41 @@ class HiveUtilsSuite extends QueryTest with

[GitHub] spark pull request #20148: [SPARK-22953][K8S] Avoids adding duplicated secre...

2018-01-03 Thread liyinan926
GitHub user liyinan926 opened a pull request: https://github.com/apache/spark/pull/20148 [SPARK-22953][K8S] Avoids adding duplicated secret volumes when init-container is used ## What changes were proposed in this pull request? User-specified secrets are mounted into both

[GitHub] spark issue #20145: [SPARK-22950][SQL]Handle ChildFirstURLClassLoader's pare...

2018-01-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20145 **[Test build #85663 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85663/testReport)** for PR 20145 at commit

[GitHub] spark pull request #20145: [SPARK-22950][SQL]Handle ChildFirstURLClassLoader...

2018-01-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20145#discussion_r159586966 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveUtilsSuite.scala --- @@ -42,4 +47,41 @@ class HiveUtilsSuite extends QueryTest with

[GitHub] spark issue #20078: [SPARK-22900] [Spark-Streaming] Remove unnecessary restr...

2018-01-03 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20078 hmm, I didn't know that was changed actually (SPARK-13723) But it seems to me `spark.streaming.dynamicAllocation.minExecutors` is still a valid approach. To match the non-streaming behavior

[GitHub] spark pull request #20145: [SPARK-22950][SQL]Handle ChildFirstURLClassLoader...

2018-01-03 Thread yaooqinn
Github user yaooqinn commented on a diff in the pull request: https://github.com/apache/spark/pull/20145#discussion_r159585279 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveUtilsSuite.scala --- @@ -42,4 +47,29 @@ class HiveUtilsSuite extends QueryTest with

[GitHub] spark pull request #20145: [SPARK-22950][SQL]Handle ChildFirstURLClassLoader...

2018-01-03 Thread yaooqinn
Github user yaooqinn commented on a diff in the pull request: https://github.com/apache/spark/pull/20145#discussion_r159585110 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveUtilsSuite.scala --- @@ -42,4 +47,29 @@ class HiveUtilsSuite extends QueryTest with

[GitHub] spark issue #20135: [SPARK-22937][SQL] SQL elt output binary for binary inpu...

2018-01-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20135 **[Test build #85661 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85661/testReport)** for PR 20135 at commit

[GitHub] spark issue #16578: [SPARK-4502][SQL] Parquet nested column pruning

2018-01-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16578 **[Test build #85662 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85662/testReport)** for PR 16578 at commit

[GitHub] spark issue #20078: [SPARK-22900] [Spark-Streaming] Remove unnecessary restr...

2018-01-03 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/20078 Originally in Spark dynamic allocation, "spark.executor.instances" and dynamic allocation conf cannot be co-existed, if "spark.executor.instances" is set, dynamic allocation will not be enabled.

[GitHub] spark issue #20078: [SPARK-22900] [Spark-Streaming] Remove unnecessary restr...

2018-01-03 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20078 not saying about this change, but I've use streaming dynamic allocation quite a bit back in the day. but in this case I think simply is to set

[GitHub] spark issue #20024: [SPARK-22825][SQL] Fix incorrect results of Casting Arra...

2018-01-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20024 **[Test build #85660 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85660/testReport)** for PR 20024 at commit

[GitHub] spark issue #20024: [SPARK-22825][SQL] Fix incorrect results of Casting Arra...

2018-01-03 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20024 ok, all the comments addressed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #20024: [SPARK-22825][SQL] Fix incorrect results of Casti...

2018-01-03 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20024#discussion_r159584638 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala --- @@ -608,6 +723,22 @@ case class Cast(child: Expression,

[GitHub] spark pull request #20024: [SPARK-22825][SQL] Fix incorrect results of Casti...

2018-01-03 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20024#discussion_r159584656 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala --- @@ -597,7 +605,114 @@ case class Cast(child: Expression,

[GitHub] spark issue #20144: [SPARK-21475][CORE][2nd attempt] Change to use NIO's Fil...

2018-01-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20144 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20144: [SPARK-21475][CORE][2nd attempt] Change to use NIO's Fil...

2018-01-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20144 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85651/ Test PASSed. ---

[GitHub] spark pull request #20146: [SPARK-11215][ML] Add multiple columns support to...

2018-01-03 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/20146#discussion_r159584417 --- Diff: R/pkg/tests/fulltests/test_mllib_classification.R --- @@ -348,12 +348,12 @@ test_that("spark.mlp", { # Test random seed #

[GitHub] spark issue #20144: [SPARK-21475][CORE][2nd attempt] Change to use NIO's Fil...

2018-01-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20144 **[Test build #85651 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85651/testReport)** for PR 20144 at commit

[GitHub] spark pull request #20129: [SPARK-22933][SPARKR] R Structured Streaming API ...

2018-01-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20129 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20129: [SPARK-22933][SPARKR] R Structured Streaming API for wit...

2018-01-03 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20129 merged to master/2.3 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20024: [SPARK-22825][SQL] Fix incorrect results of Casting Arra...

2018-01-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20024 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20024: [SPARK-22825][SQL] Fix incorrect results of Casting Arra...

2018-01-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20024 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85652/ Test PASSed. ---

[GitHub] spark issue #20024: [SPARK-22825][SQL] Fix incorrect results of Casting Arra...

2018-01-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20024 **[Test build #85652 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85652/testReport)** for PR 20024 at commit

[GitHub] spark pull request #20137: [SPARK-22939] [PySpark] Support Spark UDF in regi...

2018-01-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20137#discussion_r159582683 --- Diff: python/pyspark/sql/catalog.py --- @@ -255,9 +255,26 @@ def registerFunction(self, name, f, returnType=StringType()): >>> _ =

[GitHub] spark pull request #20137: [SPARK-22939] [PySpark] Support Spark UDF in regi...

2018-01-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20137#discussion_r159582570 --- Diff: python/pyspark/sql/catalog.py --- @@ -255,9 +255,26 @@ def registerFunction(self, name, f, returnType=StringType()): >>> _ =

[GitHub] spark issue #20137: [SPARK-22939] [PySpark] Support Spark UDF in registerFun...

2018-01-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20137 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85657/ Test PASSed. ---

[GitHub] spark issue #20137: [SPARK-22939] [PySpark] Support Spark UDF in registerFun...

2018-01-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20137 **[Test build #85657 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85657/testReport)** for PR 20137 at commit

[GitHub] spark issue #20137: [SPARK-22939] [PySpark] Support Spark UDF in registerFun...

2018-01-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20137 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20139: [SPARK-22944][SQL] improve FoldablePropagation

2018-01-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20139 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20147: [SPARK-22940][SQL] HiveExternalCatalogVersionsSui...

2018-01-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20147#discussion_r159582192 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala --- @@ -85,6 +90,43 @@ class

[GitHub] spark issue #20139: [SPARK-22944][SQL] improve FoldablePropagation

2018-01-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20139 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85648/ Test PASSed. ---

[GitHub] spark issue #20139: [SPARK-22944][SQL] improve FoldablePropagation

2018-01-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20139 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20139: [SPARK-22944][SQL] improve FoldablePropagation

2018-01-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20139 **[Test build #85648 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85648/testReport)** for PR 20139 at commit

[GitHub] spark issue #20139: [SPARK-22944][SQL] improve FoldablePropagation

2018-01-03 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20139 Thanks! Merged to master/2.3 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20147: [SPARK-22940][SQL] HiveExternalCatalogVersionsSuite shou...

2018-01-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20147 **[Test build #85659 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85659/testReport)** for PR 20147 at commit

[GitHub] spark issue #20147: [SPARK-22940][SQL] HiveExternalCatalogVersionsSuite shou...

2018-01-03 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20147 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #16578: [SPARK-4502][SQL] Parquet nested column pruning

2018-01-03 Thread VigneshMohan1
Github user VigneshMohan1 commented on the issue: https://github.com/apache/spark/pull/16578 @JoshRosen Can we make this pr to 2.3.0? A lot of people are interested in this and this will boost performance in reading parquet nested fields. ---

[GitHub] spark issue #20139: [SPARK-22944][SQL] improve FoldablePropagation

2018-01-03 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20139 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20141: [SPARK-22945][SQL] add java UDF APIs in the functions ob...

2018-01-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20141 **[Test build #85658 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85658/testReport)** for PR 20141 at commit

[GitHub] spark issue #20147: [SPARK-22940][SQL] HiveExternalCatalogVersionsSuite shou...

2018-01-03 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20147 OK to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20147: [SPARK-22940][SQL] HiveExternalCatalogVersionsSuite shou...

2018-01-03 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20147 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #16578: [SPARK-4502][SQL] Parquet nested column pruning

2018-01-03 Thread Gauravshah
Github user Gauravshah commented on the issue: https://github.com/apache/spark/pull/16578 @marmbrus can we start the review process ? so that it can make it for the next release ? --- - To unsubscribe, e-mail:

[GitHub] spark issue #20147: [SPARK-22940][SQL] HiveExternalCatalogVersionsSuite shou...

2018-01-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20147 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20147: [SPARK-22940][SQL] HiveExternalCatalogVersionsSui...

2018-01-03 Thread bersprockets
GitHub user bersprockets opened a pull request: https://github.com/apache/spark/pull/20147 [SPARK-22940][SQL] HiveExternalCatalogVersionsSuite should succeed on platforms that don't have wget ## What changes were proposed in this pull request? Modified

[GitHub] spark issue #20137: [SPARK-22939] [PySpark] Support Spark UDF in registerFun...

2018-01-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20137 **[Test build #85657 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85657/testReport)** for PR 20137 at commit

[GitHub] spark pull request #20146: [SPARK-11215][ML] Add multiple columns support to...

2018-01-03 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20146#discussion_r159580805 --- Diff: R/pkg/tests/fulltests/test_mllib_classification.R --- @@ -313,7 +313,7 @@ test_that("spark.mlp", { # Test predict method --- End diff --

[GitHub] spark issue #16578: [SPARK-4502][SQL] Parquet nested column pruning

2018-01-03 Thread mallman
Github user mallman commented on the issue: https://github.com/apache/spark/pull/16578 > However, I am -1 on merging a change this large after branch cut. It's disappointing, but I agree we can't merge a change this large into a branch cut. It will have to wait for 2.3.1 at

[GitHub] spark issue #20141: [SPARK-22945][SQL] add java UDF APIs in the functions ob...

2018-01-03 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20141 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20137: [SPARK-22939] [PySpark] Support Spark UDF in registerFun...

2018-01-03 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20137 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20137: [SPARK-22939] [PySpark] Support Spark UDF in regi...

2018-01-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20137#discussion_r159580038 --- Diff: python/pyspark/sql/catalog.py --- @@ -227,15 +227,15 @@ def dropGlobalTempView(self, viewName): @ignore_unicode_prefix

[GitHub] spark pull request #20137: [SPARK-22939] [PySpark] Support Spark UDF in regi...

2018-01-03 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20137#discussion_r159579886 --- Diff: python/pyspark/sql/catalog.py --- @@ -227,15 +227,15 @@ def dropGlobalTempView(self, viewName): @ignore_unicode_prefix

[GitHub] spark pull request #20141: [SPARK-22945][SQL] add java UDF APIs in the funct...

2018-01-03 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20141#discussion_r159579701 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -3461,13 +3485,172 @@ object functions { if (nullable) udf else

[GitHub] spark pull request #20137: [SPARK-22939] [PySpark] Support Spark UDF in regi...

2018-01-03 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20137#discussion_r159579617 --- Diff: python/pyspark/sql/catalog.py --- @@ -227,15 +227,15 @@ def dropGlobalTempView(self, viewName): @ignore_unicode_prefix

  1   2   3   4   5   >