Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/20167
is putting secrets as plain text files a good practice..?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/20154
that's good, I think we should still address the finer point of
https://github.com/apache/spark/pull/20154#pullrequestreview-86833216
- if docker hub can't build spark-base then pretty much
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19690
Under most conditions the users shouldn't ignore the printed error/warning
messages, have you observed much redundant buzz texts?
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20076
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85740/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20076
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20076
**[Test build #85740 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85740/testReport)**
for PR 20076 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20076
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85739/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20076
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20076
**[Test build #85739 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85739/testReport)**
for PR 20076 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19943
**[Test build #85744 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85744/testReport)**
for PR 19943 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19943
**[Test build #85743 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85743/testReport)**
for PR 19943 at commit
Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/19080#discussion_r160017940
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala
---
@@ -73,46 +127,31 @@ case class
Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/19080#discussion_r160017879
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala
---
@@ -51,12 +76,41 @@ case object AllTuples
Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/19080#discussion_r160018028
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala
---
@@ -73,46 +127,31 @@ case class
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/20013#discussion_r160017934
--- Diff: core/src/main/scala/org/apache/spark/status/LiveEntity.scala ---
@@ -119,118 +121,115 @@ private class LiveTask(
import
Github user squito commented on the issue:
https://github.com/apache/spark/pull/20013
lgtm
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/20013#discussion_r160017859
--- Diff: core/src/main/scala/org/apache/spark/status/LiveEntity.scala ---
@@ -119,118 +121,115 @@ private class LiveTask(
import
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20013
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20013
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85737/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20013
**[Test build #85737 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85737/testReport)**
for PR 20013 at commit
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20163#discussion_r160017637
--- Diff: python/pyspark/sql/udf.py ---
@@ -26,6 +26,28 @@
def _wrap_function(sc, func, returnType):
+def coerce_to_str(v):
+
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20163#discussion_r160017370
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -193,6 +193,24 @@ object DateTimeUtils {
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r160017579
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.scala
---
@@ -0,0 +1,493 @@
+/*
+ *
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19943
I answered at the comment~
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r160017549
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.scala
---
@@ -0,0 +1,432 @@
+/*
+ *
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r160017493
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcReadBenchmark.scala ---
@@ -0,0 +1,435 @@
+/*
+ * Licensed to the Apache
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r160017477
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcUtils.scala
---
@@ -110,4 +107,23 @@ object OrcUtils extends
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20168
Let's fix the PR title to `[SPARK-22730][ML] ...` BTW.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r160017338
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFileFormat.scala
---
@@ -139,15 +146,25 @@ class OrcFileFormat
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r160017293
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.scala
---
@@ -0,0 +1,493 @@
+/*
+ *
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20168
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20142
LGTM with minor comments regarding naming.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20168
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85742/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20168
**[Test build #85742 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85742/testReport)**
for PR 20168 at commit
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20142#discussion_r160017182
--- Diff: python/pyspark/sql/tests.py ---
@@ -3950,6 +3975,33 @@ def
test_vectorized_udf_timestamps_respect_session_timezone(self):
finally:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20142#discussion_r160017215
--- Diff: python/pyspark/sql/tests.py ---
@@ -3567,6 +3580,18 @@ def tearDownClass(cls):
time.tzset()
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20142#discussion_r160017176
--- Diff: python/pyspark/sql/tests.py ---
@@ -3950,6 +3975,33 @@ def
test_vectorized_udf_timestamps_respect_session_timezone(self):
finally:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20142
LGTM except for the one minor comment
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r160017124
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.scala
---
@@ -0,0 +1,493 @@
+/*
+ *
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r160017101
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.scala
---
@@ -0,0 +1,493 @@
+/*
+ *
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20142#discussion_r160017026
--- Diff: python/pyspark/sql/tests.py ---
@@ -3567,6 +3580,18 @@ def tearDownClass(cls):
time.tzset()
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r160016767
--- Diff: python/pyspark/ml/image.py ---
@@ -71,9 +88,30 @@ def ocvTypes(self):
"""
if self._ocvTypes is None:
-
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r160016719
--- Diff: python/pyspark/ml/image.py ---
@@ -71,9 +88,30 @@ def ocvTypes(self):
"""
if self._ocvTypes is None:
-
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r160016683
--- Diff: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala
---
@@ -37,20 +37,51 @@ import org.apache.spark.sql.types._
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20168
**[Test build #85742 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85742/testReport)**
for PR 20168 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20168
cc @jkbradley, @imatiach-msft, @MrBago and @thunterdb.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20168
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20163
@ueshin @icexelloss @cloud-fan @rednaxelafx, which one would you prefer?
To me, I like 1 at most. If the perf diff is trivial, 2. is also fine. If
3. works fine, I think I am also fine
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19943
overall looks good, my major concern is
https://github.com/apache/spark/pull/19943/files#r159221758 , do you have an
answer? This may be a big drawback compared to the wrapper solution.
---
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r160016468
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcReadBenchmark.scala ---
@@ -0,0 +1,435 @@
+/*
+ * Licensed to the Apache
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r160016446
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcUtils.scala
---
@@ -110,4 +107,23 @@ object OrcUtils extends Logging
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r160016431
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.scala
---
@@ -0,0 +1,493 @@
+/*
+ *
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r160016423
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.scala
---
@@ -0,0 +1,493 @@
+/*
+ *
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20076
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20076
**[Test build #85741 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85741/testReport)**
for PR 20076 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20076
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85741/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20076
**[Test build #85741 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85741/testReport)**
for PR 20076 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r160016334
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.scala
---
@@ -0,0 +1,493 @@
+/*
+ *
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r160016341
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.scala
---
@@ -0,0 +1,493 @@
+/*
+ *
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20076
**[Test build #85740 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85740/testReport)**
for PR 20076 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20029
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85736/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20076
**[Test build #85739 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85739/testReport)**
for PR 20076 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20029
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20029
**[Test build #85736 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85736/testReport)**
for PR 20029 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20166
LGTM except one minor comment
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20166#discussion_r160016007
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -228,6 +228,35 @@ case class Cast(child: Expression,
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20029
> The hiveClient created for the resourceLoader is only used to addJar,
which is, in turn, to add Jar to the shared IsolatedClientLoader. Then we can
just use the shared hive client for this
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20163
Hey @rednaxelafx that's fine. We all make mistake and I usually think it's
always better then not trying. I also made a mistake at the first time. It was
easier to debug this with your comments
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20010
Overall, it is reasonable. What is the current behavior in Hive?
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20170
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20170
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85734/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20170
**[Test build #85734 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85734/testReport)**
for PR 20170 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17968
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17968
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85738/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17968
**[Test build #85738 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85738/testReport)**
for PR 17968 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17968
**[Test build #85738 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85738/testReport)**
for PR 17968 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17968
cc @WeichenXu123 @yanboliang
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17968
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20170
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20170
Tests are taking to long...
Merging to master / 2.3.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20098
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20135
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20135#discussion_r160012524
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -271,33 +271,45 @@ case class
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20135
Thanks! Merged to master/2.3
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20135
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20098
Merging to master / 2.3.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20013
**[Test build #85737 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85737/testReport)**
for PR 20013 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20029
**[Test build #85736 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85736/testReport)**
for PR 20029 at commit
Github user liufengdb commented on the issue:
https://github.com/apache/spark/pull/20029
lgtm!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20029
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20097
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20097
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85730/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20097
**[Test build #85730 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85730/testReport)**
for PR 20097 at commit
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20096#discussion_r160009573
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceOffset.scala
---
@@ -19,7 +19,8 @@ package
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20169
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20169
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85733/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20169
**[Test build #85733 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85733/testReport)**
for PR 20169 at commit
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20096#discussion_r160004815
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaContinuousReader.scala
---
@@ -0,0 +1,224 @@
+/*
+ * Licensed to
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20096#discussion_r160007884
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -418,11 +418,16 @@ abstract class StreamExecution(
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20096#discussion_r160006676
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaContinuousWriter.scala
---
@@ -0,0 +1,113 @@
+/*
+ * Licensed to
1 - 100 of 248 matches
Mail list logo
