[GitHub] spark pull request #20138: [SPARK-20664][core] Delete stale application data...

2018-01-14 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/20138#discussion_r161443974 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala --- @@ -405,49 +404,70 @@ private[history] class

[GitHub] spark issue #20216: [SPARK-23024][WEB-UI]Spark ui about the contents of the ...

2018-01-14 Thread guoxiaolongzte
Github user guoxiaolongzte commented on the issue: https://github.com/apache/spark/pull/20216 @ajbozarth The first suggestion, I have already fixed it. ![3](https://user-images.githubusercontent.com/26266482/34931312-27b9e74a-fa09-11e7-89e5-8b7c0f5ad59b.png) ---

[GitHub] spark issue #20190: [SPARK-22976][Core]: Cluster mode driver directories can...

2018-01-14 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/20190 @RussellSpitzer , can you please submit PR against master branch. --- - To unsubscribe, e-mail:

[GitHub] spark pull request #20267: [SPARK-23068][BUILD][RELEASE] doc build error fro...

2018-01-14 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/20267#discussion_r161444163 --- Diff: dev/create-release/release-build.sh --- @@ -290,6 +290,8 @@ if [[ "$1" == "docs" ]]; then cd docs # TODO: Make configurable to

[GitHub] spark issue #20150: [SPARK-22956][SS] Bug fix for 2 streams union failover s...

2018-01-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20150 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86128/ Test PASSed. ---

[GitHub] spark issue #20150: [SPARK-22956][SS] Bug fix for 2 streams union failover s...

2018-01-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20150 **[Test build #86128 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86128/testReport)** for PR 20150 at commit

[GitHub] spark issue #20150: [SPARK-22956][SS] Bug fix for 2 streams union failover s...

2018-01-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20150 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20214: [SPARK-23023][SQL] Cast field data to strings in showStr...

2018-01-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20214 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86127/ Test PASSed. ---

[GitHub] spark issue #20214: [SPARK-23023][SQL] Cast field data to strings in showStr...

2018-01-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20214 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20214: [SPARK-23023][SQL] Cast field data to strings in showStr...

2018-01-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20214 **[Test build #86127 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86127/testReport)** for PR 20214 at commit

[GitHub] spark issue #19247: [Spark-21996][SQL] read files with space in name for str...

2018-01-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19247 **[Test build #86130 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86130/testReport)** for PR 19247 at commit

[GitHub] spark issue #19247: [Spark-21996][SQL] read files with space in name for str...

2018-01-14 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19247 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20259: [SPARK-23066][WEB-UI] Master Page increase master start-...

2018-01-14 Thread guoxiaolongzte
Github user guoxiaolongzte commented on the issue: https://github.com/apache/spark/pull/20259 1. Concerned about the start-up time is to see if the system is stable. 2. Our system has 50,000 + app running every day, maser will generate a lot of app registration, management

[GitHub] spark issue #20268: [SPARK-19550][BUILD][FOLLOW-UP] Remove MaxPermSize for s...

2018-01-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20268 **[Test build #86129 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86129/testReport)** for PR 20268 at commit

[GitHub] spark pull request #20268: [SPARK-19550][BUILD][FOLLOW-UP] Remove MaxPermSiz...

2018-01-14 Thread wangyum
GitHub user wangyum opened a pull request: https://github.com/apache/spark/pull/20268 [SPARK-19550][BUILD][FOLLOW-UP] Remove MaxPermSize for sql module ## What changes were proposed in this pull request? Remove `MaxPermSize` for `sql` module ## How was this patch

[GitHub] spark issue #19247: [Spark-21996][SQL] read files with space in name for str...

2018-01-14 Thread xysun
Github user xysun commented on the issue: https://github.com/apache/spark/pull/19247 hi @HyukjinKwon @zsxwing @mgaido91 i have updated code according to the comments, also merged with latest master. Please review. Thanks. ---

[GitHub] spark pull request #20265: [SPARK-21783][SQL] Turn on ORC filter push-down b...

2018-01-14 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20265#discussion_r161431971 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcReadBenchmark.scala --- @@ -483,6 +484,64 @@ object OrcReadBenchmark { }

[GitHub] spark pull request #19247: [Spark-21996][SQL] read files with space in name ...

2018-01-14 Thread xysun
Github user xysun commented on a diff in the pull request: https://github.com/apache/spark/pull/19247#discussion_r161430294 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamSource.scala --- @@ -233,7 +233,7 @@ class FileStreamSource( }

[GitHub] spark issue #20240: [SPARK-23049][SQL] `spark.sql.files.ignoreCorruptFiles` ...

2018-01-14 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/20240 Thank you so much for considering this at the last minute! @cloud-fan , @HyukjinKwon , and @gatorsmile . --- - To

[GitHub] spark issue #19872: [SPARK-22274][PYTHON][SQL] User-defined aggregation func...

2018-01-14 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19872 I don't have any concerns for merging it as is for now. Will double check tonight for sure. Was wondering if it generally looks good to you. ---

[GitHub] spark pull request #20240: [SPARK-23049][SQL] `spark.sql.files.ignoreCorrupt...

2018-01-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20240 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20240: [SPARK-23049][SQL] `spark.sql.files.ignoreCorruptFiles` ...

2018-01-14 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20240 thanks, merging to master/2.3! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #19872: [SPARK-22274][PYTHON][SQL] User-defined aggregation func...

2018-01-14 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/19872 LGTM. @HyukjinKwon Do you have any concerns about this? I'd also cc @cloud-fan for another look. --- - To unsubscribe,

[GitHub] spark issue #20259: [SPARK-23066][WEB-UI] Master Page increase master start-...

2018-01-14 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/20259 I still don't understand why a user would care how long startup took. What would they do with that? Admins and devs might. They should have access to logs. The initial logs are available at startup

[GitHub] spark issue #20150: [SPARK-22956][SS] Bug fix for 2 streams union failover s...

2018-01-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20150 **[Test build #86128 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86128/testReport)** for PR 20150 at commit

[GitHub] spark issue #20204: [SPARK-7721][PYTHON][TESTS] Adds PySpark coverage genera...

2018-01-14 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20204 Hi @rxin, @felixcheung, @ueshin, @holdenk and @JoshRosen. Could you take another look please when you guys have some time? @yhuai, I believe this is nice to have to prevent the previous

[GitHub] spark pull request #20150: [SPARK-22956][SS] Bug fix for 2 streams union fai...

2018-01-14 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/20150#discussion_r161426641 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/memory.scala --- @@ -122,6 +122,11 @@ case class MemoryStream[A :

[GitHub] spark pull request #20150: [SPARK-22956][SS] Bug fix for 2 streams union fai...

2018-01-14 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/20150#discussion_r161426622 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSourceSuite.scala --- @@ -318,6 +318,84 @@ class KafkaSourceSuite

[GitHub] spark pull request #20150: [SPARK-22956][SS] Bug fix for 2 streams union fai...

2018-01-14 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/20150#discussion_r161426632 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSourceSuite.scala --- @@ -318,6 +318,84 @@ class KafkaSourceSuite

[GitHub] spark pull request #20265: [SPARK-21783][SQL] Turn on ORC filter push-down b...

2018-01-14 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20265#discussion_r161426568 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcReadBenchmark.scala --- @@ -483,6 +484,64 @@ object OrcReadBenchmark { }

[GitHub] spark pull request #20265: [SPARK-21783][SQL] Turn on ORC filter push-down b...

2018-01-14 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20265#discussion_r161425712 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcReadBenchmark.scala --- @@ -483,6 +484,64 @@ object OrcReadBenchmark { }

[GitHub] spark issue #20259: [SPARK-23066][WEB-UI] Master Page increase master start-...

2018-01-14 Thread guoxiaolongzte
Github user guoxiaolongzte commented on the issue: https://github.com/apache/spark/pull/20259 Sir, I stick to my point for the following reasons: 1.When the spark system is running for some time, the log has been rolled back, because we use log4j, simply do not see the

[GitHub] spark issue #20214: [SPARK-23023][SQL] Cast field data to strings in showStr...

2018-01-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20214 **[Test build #86127 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86127/testReport)** for PR 20214 at commit

[GitHub] spark issue #20214: [SPARK-23023][SQL] Cast field data to strings in showStr...

2018-01-14 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20214 retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20246: [SPARK-23054][SQL] Fix incorrect results of casti...

2018-01-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20246 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20246: [SPARK-23054][SQL] Fix incorrect results of casting User...

2018-01-14 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20246 thanks, merging to master/2.3 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #20246: [SPARK-23054][SQL] Fix incorrect results of casti...

2018-01-14 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20246#discussion_r161422213 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala --- @@ -282,6 +282,8 @@ case class Cast(child: Expression,

[GitHub] spark pull request #20265: [SPARK-21783][SQL] Turn on ORC filter push-down b...

2018-01-14 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20265#discussion_r161421828 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcReadBenchmark.scala --- @@ -483,6 +484,64 @@ object OrcReadBenchmark { }

[GitHub] spark pull request #20265: [SPARK-21783][SQL] Turn on ORC filter push-down b...

2018-01-14 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20265#discussion_r161421703 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcReadBenchmark.scala --- @@ -483,6 +484,64 @@ object OrcReadBenchmark { }

[GitHub] spark issue #20250: [SPARK-23059][SQL][TEST] Correct some improper with view...

2018-01-14 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/spark/pull/20250 @dongjoon-hyun @gatorsmile Please review it. thanks --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #20227: [SPARK-23035][SQL] Fix improper information of TempTable...

2018-01-14 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/spark/pull/20227 @dongjoon-hyun ok ,done. Jira webpage shows "Maintenance in progress" --- - To unsubscribe, e-mail:

[GitHub] spark pull request #20264: [SPARK-23070] Bump previousSparkVersion in MimaBu...

2018-01-14 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/20264#discussion_r161418395 --- Diff: project/MimaBuild.scala --- @@ -88,7 +88,7 @@ object MimaBuild { def mimaSettings(sparkHome: File, projectRef: ProjectRef) = {

[GitHub] spark pull request #20267: [SPARK-23068][BUILD][RELEASE] doc build error fro...

2018-01-14 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20267#discussion_r161417524 --- Diff: dev/create-release/release-build.sh --- @@ -290,6 +290,8 @@ if [[ "$1" == "docs" ]]; then cd docs # TODO: Make configurable to

[GitHub] spark pull request #20171: [SPARK-22978] [PySpark] Register Vectorized UDFs ...

2018-01-14 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20171#discussion_r161414603 --- Diff: python/pyspark/sql/context.py --- @@ -204,15 +206,31 @@ def registerFunction(self, name, f, returnType=StringType()): >>>

[GitHub] spark pull request #20171: [SPARK-22978] [PySpark] Register Vectorized UDFs ...

2018-01-14 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20171#discussion_r161414948 --- Diff: python/pyspark/sql/catalog.py --- @@ -256,27 +258,58 @@ def registerFunction(self, name, f, returnType=StringType()): >>>

[GitHub] spark pull request #20171: [SPARK-22978] [PySpark] Register Vectorized UDFs ...

2018-01-14 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20171#discussion_r161414648 --- Diff: python/pyspark/sql/context.py --- @@ -204,15 +206,31 @@ def registerFunction(self, name, f, returnType=StringType()): >>>

[GitHub] spark pull request #20171: [SPARK-22978] [PySpark] Register Vectorized UDFs ...

2018-01-14 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20171#discussion_r161415247 --- Diff: python/pyspark/sql/context.py --- @@ -204,15 +206,31 @@ def registerFunction(self, name, f, returnType=StringType()): >>>

[GitHub] spark issue #20246: [SPARK-23054][SQL] Fix incorrect results of casting User...

2018-01-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20246 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86126/ Test PASSed. ---

[GitHub] spark issue #20246: [SPARK-23054][SQL] Fix incorrect results of casting User...

2018-01-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20246 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20246: [SPARK-23054][SQL] Fix incorrect results of casting User...

2018-01-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20246 **[Test build #86126 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86126/testReport)** for PR 20246 at commit

[GitHub] spark issue #20267: [SPARK-23068][BUILD][RELEASE] doc build error from jekyl...

2018-01-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20267 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86125/ Test PASSed. ---

[GitHub] spark issue #20267: [SPARK-23068][BUILD][RELEASE] doc build error from jekyl...

2018-01-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20267 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20267: [SPARK-23068][BUILD][RELEASE] doc build error from jekyl...

2018-01-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20267 **[Test build #86125 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86125/testReport)** for PR 20267 at commit

[GitHub] spark issue #20267: [SPARK-23068][BUILD][RELEASE] doc build error from jekyl...

2018-01-14 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20267 @sameeragarwal FYI. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20264: [SPARK-23070] Bump previousSparkVersion in MimaBu...

2018-01-14 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20264#discussion_r161412925 --- Diff: project/MimaBuild.scala --- @@ -88,7 +88,7 @@ object MimaBuild { def mimaSettings(sparkHome: File, projectRef: ProjectRef) = {

[GitHub] spark issue #19224: [SPARK-20990][SQL] Read all JSON documents in files when...

2018-01-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19224 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86124/ Test PASSed. ---

[GitHub] spark issue #19224: [SPARK-20990][SQL] Read all JSON documents in files when...

2018-01-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19224 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19224: [SPARK-20990][SQL] Read all JSON documents in files when...

2018-01-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19224 **[Test build #86124 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86124/testReport)** for PR 19224 at commit

[GitHub] spark issue #20227: [SPARK-23035][SQL] Fix warning: TEMPORARY TABLE ... USIN...

2018-01-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20227 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86123/ Test PASSed. ---

[GitHub] spark issue #20227: [SPARK-23035][SQL] Fix warning: TEMPORARY TABLE ... USIN...

2018-01-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20227 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20227: [SPARK-23035][SQL] Fix warning: TEMPORARY TABLE ... USIN...

2018-01-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20227 **[Test build #86123 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86123/testReport)** for PR 20227 at commit

[GitHub] spark issue #20085: [SPARK-22739][Catalyst][WIP] Additional Expression Suppo...

2018-01-14 Thread marmbrus
Github user marmbrus commented on the issue: https://github.com/apache/spark/pull/20085 This blocks better support for encoders on spark-avro, and seems safe, so I'd really like to include it in possible. --- - To

[GitHub] spark issue #20246: [SPARK-23054][SQL] Fix incorrect results of casting User...

2018-01-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20246 **[Test build #86126 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86126/testReport)** for PR 20246 at commit

[GitHub] spark issue #20246: [SPARK-23054][SQL] Fix incorrect results of casting User...

2018-01-14 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/20246 Retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20266: [SPARK-23072][SQL][TEST] Add a Unicode schema test for f...

2018-01-14 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/20266 cc @gatorsmile and @cloud-fan . --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20266: [SPARK-23072][SQL][TEST] Add a Unicode schema test for f...

2018-01-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20266 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86122/ Test PASSed. ---

[GitHub] spark issue #20266: [SPARK-23072][SQL][TEST] Add a Unicode schema test for f...

2018-01-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20266 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20266: [SPARK-23072][SQL][TEST] Add a Unicode schema test for f...

2018-01-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20266 **[Test build #86122 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86122/testReport)** for PR 20266 at commit

[GitHub] spark issue #20267: [SPARK-23068][BUILD][RELEASE] doc build error from jekyl...

2018-01-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20267 **[Test build #86125 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86125/testReport)** for PR 20267 at commit

[GitHub] spark pull request #20267: [SPARK-23068][BUILD][RELEASE] doc build error fro...

2018-01-14 Thread felixcheung
GitHub user felixcheung opened a pull request: https://github.com/apache/spark/pull/20267 [SPARK-23068][BUILD][RELEASE] doc build error from jekyll does not fail ## What changes were proposed in this pull request? check exit code. note that not errors are reported via exit

[GitHub] spark pull request #20264: [SPARK-23070] Bump previousSparkVersion in MimaBu...

2018-01-14 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/20264#discussion_r161406899 --- Diff: project/MimaBuild.scala --- @@ -88,7 +88,7 @@ object MimaBuild { def mimaSettings(sparkHome: File, projectRef: ProjectRef) = {

[GitHub] spark pull request #20265: [SPARK-21783][SQL] Turn on ORC filter push-down b...

2018-01-14 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20265#discussion_r161406817 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcReadBenchmark.scala --- @@ -483,6 +484,64 @@ object OrcReadBenchmark { }

[GitHub] spark pull request #20265: [SPARK-21783][SQL] Turn on ORC filter push-down b...

2018-01-14 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20265#discussion_r161406728 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcReadBenchmark.scala --- @@ -483,6 +484,64 @@ object OrcReadBenchmark { }

[GitHub] spark issue #20263: [SPARK-23069][DOCS][SPARKR] fix R doc for describe missi...

2018-01-14 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20263 thanks --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19224: [SPARK-20990][SQL] Read all JSON documents in files when...

2018-01-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19224 **[Test build #86124 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86124/testReport)** for PR 19224 at commit

[GitHub] spark issue #19224: [SPARK-20990][SQL] Read all JSON documents in files when...

2018-01-14 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19224 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20227: [SPARK-23035][SQL] Fix warning: TEMPORARY TABLE ... USIN...

2018-01-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20227 **[Test build #86123 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86123/testReport)** for PR 20227 at commit

[GitHub] spark issue #20227: [SPARK-23035][SQL] Fix warning: TEMPORARY TABLE ... USIN...

2018-01-14 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20227 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20265: [SPARK-21783][SQL] Turn on ORC filter push-down b...

2018-01-14 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20265#discussion_r161405679 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcReadBenchmark.scala --- @@ -483,6 +484,64 @@ object OrcReadBenchmark { }

[GitHub] spark pull request #20265: [SPARK-21783][SQL] Turn on ORC filter push-down b...

2018-01-14 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20265#discussion_r161405630 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcReadBenchmark.scala --- @@ -483,6 +484,64 @@ object OrcReadBenchmark { }

[GitHub] spark pull request #20194: [SPARK-22999][SQL]'show databases like command' c...

2018-01-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20194 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20194: [SPARK-22999][SQL]'show databases like command' can remo...

2018-01-14 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20194 LGTM Thanks! Merged to master/2.3 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20194: [SPARK-22999][SQL]'show databases like command' can remo...

2018-01-14 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/20194 cc @hvanhovell , too. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20265: [SPARK-21783][SQL] Turn on ORC filter push-down b...

2018-01-14 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20265#discussion_r161403798 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcReadBenchmark.scala --- @@ -483,6 +484,64 @@ object OrcReadBenchmark { }

[GitHub] spark issue #20194: [SPARK-22999][SQL]'show databases like command' can remo...

2018-01-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20194 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20194: [SPARK-22999][SQL]'show databases like command' can remo...

2018-01-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20194 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86120/ Test PASSed. ---

[GitHub] spark issue #20194: [SPARK-22999][SQL]'show databases like command' can remo...

2018-01-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20194 **[Test build #86120 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86120/testReport)** for PR 20194 at commit

[GitHub] spark issue #20266: [SPARK-23072][SQL][TEST] Add a Unicode schema test for f...

2018-01-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20266 **[Test build #86122 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86122/testReport)** for PR 20266 at commit

[GitHub] spark issue #20171: [SPARK-22978] [PySpark] Register Vectorized UDFs for SQL...

2018-01-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20171 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20171: [SPARK-22978] [PySpark] Register Vectorized UDFs for SQL...

2018-01-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20171 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86121/ Test PASSed. ---

[GitHub] spark issue #20171: [SPARK-22978] [PySpark] Register Vectorized UDFs for SQL...

2018-01-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20171 **[Test build #86121 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86121/testReport)** for PR 20171 at commit

[GitHub] spark pull request #20266: [SPARK-23072][SQL] Add a Unicode schema test for ...

2018-01-14 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/20266 [SPARK-23072][SQL] Add a Unicode schema test for file-based data sources ## What changes were proposed in this pull request? After

[GitHub] spark issue #20171: [SPARK-22978] [PySpark] Register Vectorized UDFs for SQL...

2018-01-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20171 **[Test build #86121 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86121/testReport)** for PR 20171 at commit

[GitHub] spark issue #20264: [SPARK-23070] Bump previousSparkVersion in MimaBuild.sca...

2018-01-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20264 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86119/ Test PASSed. ---

[GitHub] spark issue #20264: [SPARK-23070] Bump previousSparkVersion in MimaBuild.sca...

2018-01-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20264 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20264: [SPARK-23070] Bump previousSparkVersion in MimaBuild.sca...

2018-01-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20264 **[Test build #86119 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86119/testReport)** for PR 20264 at commit

[GitHub] spark pull request #20171: [SPARK-22978] [PySpark] Register Vectorized UDFs ...

2018-01-14 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20171#discussion_r161400802 --- Diff: python/pyspark/sql/context.py --- @@ -204,15 +206,31 @@ def registerFunction(self, name, f, returnType=StringType()): >>>

[GitHub] spark pull request #20171: [SPARK-22978] [PySpark] Register Vectorized UDFs ...

2018-01-14 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20171#discussion_r161400597 --- Diff: python/pyspark/sql/catalog.py --- @@ -256,27 +258,56 @@ def registerFunction(self, name, f, returnType=StringType()): >>>

[GitHub] spark pull request #20171: [SPARK-22978] [PySpark] Register Vectorized UDFs ...

2018-01-14 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20171#discussion_r161402514 --- Diff: python/pyspark/sql/catalog.py --- @@ -256,27 +258,56 @@ def registerFunction(self, name, f, returnType=StringType()): >>>

[GitHub] spark pull request #20251: [Spark-23051][core] Fix for broken job descriptio...

2018-01-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20251 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

  1   2   >