Github user zuotingbing commented on the issue:
https://github.com/apache/spark/pull/20025
ping @liufengdb
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user ferdonline commented on the issue:
https://github.com/apache/spark/pull/20269
Hi. Thanks for your review. Sounds good, I will go around and add a "unit
blurb" to them.
I wrote "Default unit: X" to keep it the shortest and very obvious, but I
agree to have nicer
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19872#discussion_r161701816
--- Diff: python/pyspark/sql/functions.py ---
@@ -2214,6 +2216,37 @@ def pandas_udf(f=None, returnType=None,
functionType=None):
..
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/20010
@bdrillard I think that we need to know Hive's behavior as per
https://github.com/apache/spark/pull/20010#issuecomment-355717067 to state
which is the preferred/right behavior here.
---
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19993#discussion_r161699705
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -249,6 +250,27 @@ object ParamValidators {
def
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20171
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86166/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20171
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20171
**[Test build #86166 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86166/testReport)**
for PR 20171 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20171
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20171
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86165/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20171
**[Test build #86165 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86165/testReport)**
for PR 20171 at commit
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20211#discussion_r161695928
--- Diff: python/pyspark/sql/group.py ---
@@ -233,6 +233,27 @@ def apply(self, udf):
| 2| 1.1094003924504583|
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20211
We should add a description to the PR, instead of just jira ticket link.
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20171
**[Test build #86166 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86166/testReport)**
for PR 20171 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20171
**[Test build #86165 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86165/testReport)**
for PR 20171 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19872#discussion_r161689381
--- Diff: python/pyspark/sql/functions.py ---
@@ -2214,6 +2216,37 @@ def pandas_udf(f=None, returnType=None,
functionType=None):
..
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20211#discussion_r161688635
--- Diff: python/pyspark/sql/group.py ---
@@ -233,6 +233,27 @@ def apply(self, udf):
| 2| 1.1094003924504583|
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20232
**[Test build #86164 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86164/testReport)**
for PR 20232 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20153
**[Test build #86163 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86163/testReport)**
for PR 20153 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20266
**[Test build #86162 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86162/testReport)**
for PR 20266 at commit
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/20267
I'm not 100% sure... I injected some error in jekyll but it stopped
immediately.
let me try to match the report condition more closely...
---
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20153
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/20232#discussion_r161683935
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifier.scala
---
@@ -102,36 +102,6 @@
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/20232#discussion_r161686126
--- Diff: docs/sparkr.md ---
@@ -663,3 +663,4 @@ You can inspect the search path in R with
[`search()`](https://stat.ethz.ch/R-ma
- The
Github user Ngone51 commented on the issue:
https://github.com/apache/spark/pull/20056
@squito yea, clean up will be fine. Maybe, I make things more complicated.
Thank for comment.
---
-
To unsubscribe, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20266
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19993#discussion_r161685200
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -249,6 +250,27 @@ object ParamValidators {
def
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/19892#discussion_r161683821
--- Diff: python/pyspark/ml/feature.py ---
@@ -317,13 +317,19 @@ class BucketedRandomProjectionLSHModel(LSHModel,
JavaMLReadable, JavaMLWritable)
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/19892#discussion_r161683714
--- Diff: python/pyspark/ml/feature.py ---
@@ -347,6 +353,28 @@ class Bucketizer(JavaTransformer, HasInputCol,
HasOutputCol, HasHandleInvalid,
>>>
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/19892#discussion_r161684641
--- Diff: python/pyspark/ml/param/__init__.py ---
@@ -134,6 +134,16 @@ def toListFloat(value):
return [float(v) for v in value]
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19993#discussion_r161684970
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -249,6 +250,27 @@ object ParamValidators {
def
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20146
**[Test build #86161 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86161/testReport)**
for PR 20146 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20146
@WeichenXu123 Ok. Thanks. Then let's revisit this after 2.3.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/19993#discussion_r161681586
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -249,6 +250,27 @@ object ParamValidators {
def
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/19993#discussion_r161682506
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/BucketizerSuite.scala ---
@@ -401,15 +390,9 @@ class BucketizerSuite extends SparkFunSuite with
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20232
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86155/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20232
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20266
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86159/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20266
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20153
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86160/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20232
**[Test build #86155 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86155/testReport)**
for PR 20232 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20153
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20153
**[Test build #86160 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86160/testReport)**
for PR 20153 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20266
**[Test build #86159 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86159/testReport)**
for PR 20266 at commit
601 - 644 of 644 matches
Mail list logo
