[GitHub] spark issue #20357: [SPARK-23186][SQL] Loading JDBC Drivers should be synchr...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20357 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/121/

[GitHub] spark issue #20357: [SPARK-23186][SQL] Loading JDBC Drivers should be synchr...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20357 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20357: [SPARK-23186][SQL] Loading JDBC Drivers should be...

2018-01-22 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/20357 [SPARK-23186][SQL] Loading JDBC Drivers should be synchronized ## What changes were proposed in this pull request? Since some JDBC Drivers have class initialization code to call

[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20025 **[Test build #86508 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86508/testReport)** for PR 20025 at commit

[GitHub] spark issue #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to handle...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20345 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86499/ Test FAILed. ---

[GitHub] spark issue #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to handle...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20345 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to handle...

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20345 **[Test build #86499 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86499/testReport)** for PR 20345 at commit

[GitHub] spark pull request #20355: SPARK-23148: [SQL] Allow pathnames with special c...

2018-01-22 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20355#discussion_r163137474 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/text/TextSuite.scala --- @@ -172,6 +172,14 @@ class TextSuite extends

[GitHub] spark pull request #20025: [SPARK-22837][SQL]Session timeout checker does no...

2018-01-22 Thread zuotingbing
Github user zuotingbing commented on a diff in the pull request: https://github.com/apache/spark/pull/20025#discussion_r163136632 --- Diff: sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/session/SessionManager.java --- @@ -80,7 +76,6 @@ public synchronized void

[GitHub] spark issue #20146: [SPARK-11215][ML] Add multiple columns support to String...

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20146 **[Test build #86507 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86507/testReport)** for PR 20146 at commit

[GitHub] spark issue #20146: [SPARK-11215][ML] Add multiple columns support to String...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20146 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/120/

[GitHub] spark issue #20146: [SPARK-11215][ML] Add multiple columns support to String...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20146 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20146: [SPARK-11215][ML] Add multiple columns support to String...

2018-01-22 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20146 retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20355: SPARK-23148: [SQL] Allow pathnames with special c...

2018-01-22 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20355#discussion_r163129347 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala --- @@ -2063,4 +2063,12 @@ class JsonSuite extends

[GitHub] spark issue #20356: [SPARK-23185][SQL] Make the configuration "spark.default...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20356 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20356: [SPARK-23185][SQL] Make the configuration "spark.default...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20356 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20356: [SPARK-23185][SQL] Make the configuration "spark....

2018-01-22 Thread lvdongr
GitHub user lvdongr opened a pull request: https://github.com/apache/spark/pull/20356 [SPARK-23185][SQL] Make the configuration "spark.default.parallelism" can be changed on each SQL session to decrease empty files ## What changes were proposed in this pull request? Make the

[GitHub] spark pull request #20350: [SPARK-23179][SQL] Support option to throw except...

2018-01-22 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20350#discussion_r163134873 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala --- @@ -237,14 +238,26 @@ final class Decimal extends Ordered[Decimal] with

[GitHub] spark issue #20177: [SPARK-22954][SQL] Fix the exception thrown by Analyze c...

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20177 **[Test build #86506 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86506/testReport)** for PR 20177 at commit

[GitHub] spark pull request #20350: [SPARK-23179][SQL] Support option to throw except...

2018-01-22 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20350#discussion_r163134537 --- Diff: sql/core/src/test/resources/sql-tests/inputs/decimalArithmeticOperations.sql --- @@ -49,7 +49,6 @@ select 1e35 / 0.1; -- arithmetic

[GitHub] spark issue #20177: [SPARK-22954][SQL] Fix the exception thrown by Analyze c...

2018-01-22 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20177 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20177: [SPARK-22954][SQL] Fix the exception thrown by Analyze c...

2018-01-22 Thread suchithjn225
Github user suchithjn225 commented on the issue: https://github.com/apache/spark/pull/20177 I did't understand why the build is getting killed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark pull request #20087: [SPARK-21786][SQL] The 'spark.sql.parquet.compres...

2018-01-22 Thread fjh100456
Github user fjh100456 commented on a diff in the pull request: https://github.com/apache/spark/pull/20087#discussion_r163132078 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/SaveAsHiveFile.scala --- @@ -55,18 +55,28 @@ private[hive] trait SaveAsHiveFile

[GitHub] spark pull request #19285: [SPARK-22068][CORE]Reduce the duplicate code betw...

2018-01-22 Thread ConeyLiu
Github user ConeyLiu commented on a diff in the pull request: https://github.com/apache/spark/pull/19285#discussion_r163131741 --- Diff: core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala --- @@ -162,26 +162,29 @@ private[spark] class MemoryStore( }

[GitHub] spark pull request #19285: [SPARK-22068][CORE]Reduce the duplicate code betw...

2018-01-22 Thread ConeyLiu
Github user ConeyLiu commented on a diff in the pull request: https://github.com/apache/spark/pull/19285#discussion_r163131519 --- Diff: core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala --- @@ -162,26 +162,29 @@ private[spark] class MemoryStore( }

[GitHub] spark pull request #19285: [SPARK-22068][CORE]Reduce the duplicate code betw...

2018-01-22 Thread ConeyLiu
Github user ConeyLiu commented on a diff in the pull request: https://github.com/apache/spark/pull/19285#discussion_r163131383 --- Diff: core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala --- @@ -233,17 +235,13 @@ private[spark] class MemoryStore( }

[GitHub] spark issue #20352: [SPARK-21727][R] Allow multi-element atomic vector as co...

2018-01-22 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/20352 Thanks @neilalex - Change LGTM. Lets also see if @felixcheung has any comments. --- - To unsubscribe, e-mail:

[GitHub] spark pull request #20025: [SPARK-22837][SQL]Session timeout checker does no...

2018-01-22 Thread zuotingbing
Github user zuotingbing commented on a diff in the pull request: https://github.com/apache/spark/pull/20025#discussion_r163127098 --- Diff: sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/session/SessionManager.java --- @@ -23,11 +23,7 @@ import

[GitHub] spark issue #20352: [SPARK-21727][R] Allow multi-element atomic vector as co...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20352 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86500/ Test PASSed. ---

[GitHub] spark issue #20352: [SPARK-21727][R] Allow multi-element atomic vector as co...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20352 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20352: [SPARK-21727][R] Allow multi-element atomic vector as co...

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20352 **[Test build #86500 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86500/testReport)** for PR 20352 at commit

[GitHub] spark issue #20355: SPARK-23148: [SQL] Allow pathnames with special characte...

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20355 **[Test build #86505 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86505/testReport)** for PR 20355 at commit

[GitHub] spark issue #20355: SPARK-23148: [SQL] Allow pathnames with special characte...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20355 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20355: SPARK-23148: [SQL] Allow pathnames with special characte...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20355 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/119/

[GitHub] spark issue #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to handle...

2018-01-22 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20345 Thanks! @jiangxb1987 I'll address your comments and check again? --- - To unsubscribe, e-mail:

[GitHub] spark issue #20355: SPARK-23148: [SQL] Allow pathnames with special characte...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20355 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20355: SPARK-23148: [SQL] Allow pathnames with special characte...

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20355 **[Test build #86503 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86503/testReport)** for PR 20355 at commit

[GitHub] spark issue #20355: SPARK-23148: [SQL] Allow pathnames with special characte...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20355 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86503/ Test FAILed. ---

[GitHub] spark issue #20355: SPARK-23148: [SQL] Allow pathnames with special characte...

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20355 **[Test build #86503 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86503/testReport)** for PR 20355 at commit

[GitHub] spark issue #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to handle...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20345 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/118/

[GitHub] spark issue #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to handle...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20345 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to handle...

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20345 **[Test build #86504 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86504/testReport)** for PR 20345 at commit

[GitHub] spark issue #20355: SPARK-23148: [SQL] Allow pathnames with special characte...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20355 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/117/

[GitHub] spark issue #20355: SPARK-23148: [SQL] Allow pathnames with special characte...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20355 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19861: [SPARK-22387][SQL] Propagate session configs to data sou...

2018-01-22 Thread rdblue
Github user rdblue commented on the issue: https://github.com/apache/spark/pull/19861 Thanks for the example, @cloud-fan. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20353: [SPARK-20664][core] Follow-up: remove workaround for SPA...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20353 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20353: [SPARK-20664][core] Follow-up: remove workaround for SPA...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20353 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86497/ Test PASSed. ---

[GitHub] spark issue #20355: SPARK-23148: [SQL] Allow pathnames with special characte...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20355 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/116/

[GitHub] spark issue #20355: SPARK-23148: [SQL] Allow pathnames with special characte...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20355 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20353: [SPARK-20664][core] Follow-up: remove workaround for SPA...

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20353 **[Test build #86497 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86497/testReport)** for PR 20353 at commit

[GitHub] spark issue #20355: SPARK-23148: [SQL] Allow pathnames with special characte...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20355 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20355: SPARK-23148: [SQL] Allow pathnames with special characte...

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20355 **[Test build #86502 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86502/testReport)** for PR 20355 at commit

[GitHub] spark issue #20355: SPARK-23148: [SQL] Allow pathnames with special characte...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20355 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86502/ Test FAILed. ---

[GitHub] spark issue #20355: SPARK-23148: [SQL] Allow pathnames with special characte...

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20355 **[Test build #86502 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86502/testReport)** for PR 20355 at commit

[GitHub] spark pull request #20355: SPARK-23148: [SQL] Allow pathnames with special c...

2018-01-22 Thread henryr
GitHub user henryr opened a pull request: https://github.com/apache/spark/pull/20355 SPARK-23148: [SQL] Allow pathnames with special characters for CSV / … …JSON / text ## What changes were proposed in this pull request? Fix for JSON and CSV data sources when

[GitHub] spark issue #20091: [SPARK-22465][FOLLOWUP] Update the number of partitions ...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20091 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86496/ Test PASSed. ---

[GitHub] spark issue #20091: [SPARK-22465][FOLLOWUP] Update the number of partitions ...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20091 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20091: [SPARK-22465][FOLLOWUP] Update the number of partitions ...

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20091 **[Test build #86496 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86496/testReport)** for PR 20091 at commit

[GitHub] spark issue #20343: [SPARK-23167][SQL] Add TPCDS queries v2.7 in TPCDSQueryS...

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20343 **[Test build #86501 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86501/testReport)** for PR 20343 at commit

[GitHub] spark issue #20343: [SPARK-23167][SQL] Add TPCDS queries v2.7 in TPCDSQueryS...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20343 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20343: [SPARK-23167][SQL] Add TPCDS queries v2.7 in TPCDSQueryS...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20343 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/115/

[GitHub] spark pull request #20297: [SPARK-23020][CORE] Fix races in launcher code, t...

2018-01-22 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20297#discussion_r163119635 --- Diff: launcher/src/main/java/org/apache/spark/launcher/ChildProcAppHandle.java --- @@ -48,14 +48,16 @@ public synchronized void disconnect() {

[GitHub] spark issue #19861: [SPARK-22387][SQL] Propagate session configs to data sou...

2018-01-22 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19861 Basically we want per-query options, which can be specified via `DataFrameReader/Writer.option`, and we also want per-session options, which can save users from typing same options again and

[GitHub] spark issue #20352: [SPARK-21727][R] Allow multi-element atomic vector as co...

2018-01-22 Thread neilalex
Github user neilalex commented on the issue: https://github.com/apache/spark/pull/20352 @shivaram alright, should be good with the tests now -- let me know how it seems --- - To unsubscribe, e-mail:

[GitHub] spark issue #19861: [SPARK-22387][SQL] Propagate session configs to data sou...

2018-01-22 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19861 @rdblue This is also what we already have for built-in data sources, e.g. `spark.sql.parquet.compression.codec`, `spark.sql.parquet.filterPushdown`, etc. ---

[GitHub] spark issue #19861: [SPARK-22387][SQL] Propagate session configs to data sou...

2018-01-22 Thread rdblue
Github user rdblue commented on the issue: https://github.com/apache/spark/pull/19861 @jiangxb1987, I understand what this does. I just wanted an example use case where it was necessary. What was the motivating *use case*? ---

[GitHub] spark pull request #20343: [SPARK-23167][SQL] Add TPCDS queries v2.7 in TPCD...

2018-01-22 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20343#discussion_r163119029 --- Diff: sql/core/src/test/resources/tpcds-v2.7.0/q11.sql --- @@ -0,0 +1,78 @@ +with year_total as ( + select c_customer_id customer_id +

[GitHub] spark issue #20201: [SPARK-22389][SQL] data source v2 partitioning reporting...

2018-01-22 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20201 ah sorry I missed this, but it's not too late to do post-hoc reviews, any comments are welcome! --- - To unsubscribe, e-mail:

[GitHub] spark issue #20352: [SPARK-21727][R] Allow multi-element atomic vector as co...

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20352 **[Test build #86500 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86500/testReport)** for PR 20352 at commit

[GitHub] spark issue #20347: [SPARK-20129][Core] JavaSparkContext should use SparkCon...

2018-01-22 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/20347 Using `getOrCreate` in constructor seems change the semantics. Maybe we can add a new static method for such usage in `JavaSparkContext`. ---

[GitHub] spark pull request #20345: [SPARK-23172][SQL] Respect Project nodes in Reord...

2018-01-22 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/20345#discussion_r163115407 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/JoinOptimizationSuite.scala --- @@ -116,7 +124,12 @@ class

[GitHub] spark pull request #20345: [SPARK-23172][SQL] Respect Project nodes in Reord...

2018-01-22 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/20345#discussion_r163115184 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/JoinOptimizationSuite.scala --- @@ -46,6 +46,19 @@ class

[GitHub] spark pull request #20345: [SPARK-23172][SQL] Respect Project nodes in Reord...

2018-01-22 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/20345#discussion_r163114625 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/JoinOptimizationSuite.scala --- @@ -46,6 +46,19 @@ class

[GitHub] spark pull request #20345: [SPARK-23172][SQL] Respect Project nodes in Reord...

2018-01-22 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/20345#discussion_r163113728 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala --- @@ -84,19 +84,46 @@ object ReorderJoin extends

[GitHub] spark issue #20345: [SPARK-23172][SQL] Respect Project nodes in ReorderJoin

2018-01-22 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/20345 This is not `respect project nodes`, this actually expand the `ReorderJoin` rule to allow handle the project-over-join nodes. ---

[GitHub] spark issue #19861: [SPARK-22387][SQL] Propagate session configs to data sou...

2018-01-22 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/19861 With `SessionConfigSupport`, you can use the datasource session configs more easily for that: 1. All configs with the name prefix `spark.datasource.$keyPrefix` will be imported in to the

[GitHub] spark pull request #20343: [SPARK-23167][SQL] Add TPCDS queries v2.7 in TPCD...

2018-01-22 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20343#discussion_r163112223 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/TPCDSQuerySuite.scala --- @@ -339,6 +340,24 @@ class TPCDSQuerySuite extends BenchmarkQueryTest {

[GitHub] spark issue #20343: [SPARK-23167][SQL] Add TPCDS queries v2.7 in TPCDSQueryS...

2018-01-22 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20343 ok, I'll try and check. Just s sec. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20342: [SPARK-23170][SQL] Dump the statistics of effective runs...

2018-01-22 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20342 ah, ok. I wait for the work! Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #19861: [SPARK-22387][SQL] Propagate session configs to data sou...

2018-01-22 Thread rdblue
Github user rdblue commented on the issue: https://github.com/apache/spark/pull/19861 @jiangxb1987, @cloud-fan, what was the use case you needed to add this for? --- - To unsubscribe, e-mail:

[GitHub] spark issue #19872: [SPARK-22274][PYTHON][SQL] User-defined aggregation func...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19872 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86492/ Test PASSed. ---

[GitHub] spark issue #19872: [SPARK-22274][PYTHON][SQL] User-defined aggregation func...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19872 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19872: [SPARK-22274][PYTHON][SQL] User-defined aggregation func...

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19872 **[Test build #86492 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86492/testReport)** for PR 19872 at commit

[GitHub] spark issue #20201: [SPARK-22389][SQL] data source v2 partitioning reporting...

2018-01-22 Thread rdblue
Github user rdblue commented on the issue: https://github.com/apache/spark/pull/20201 @cloud-fan, please ping me to review PRs for DataSourceV2. Our new table format uses it and we're preparing some changes, so I want to make sure we're heading in the same direction for this. ---

[GitHub] spark issue #20351: [SPARK-23014][SS] Fully remove V1 memory sink.

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20351 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20351: [SPARK-23014][SS] Fully remove V1 memory sink.

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20351 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86493/ Test FAILed. ---

[GitHub] spark issue #20351: [SPARK-23014][SS] Fully remove V1 memory sink.

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20351 **[Test build #86493 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86493/testReport)** for PR 20351 at commit

[GitHub] spark pull request #20201: [SPARK-22389][SQL] data source v2 partitioning re...

2018-01-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20201 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20201: [SPARK-22389][SQL] data source v2 partitioning reporting...

2018-01-22 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20201 Thanks! Merged to master/2.3 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20350: [SPARK-23179][SQL] Support option to throw exception if ...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20350 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20350: [SPARK-23179][SQL] Support option to throw exception if ...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20350 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86495/ Test FAILed. ---

[GitHub] spark issue #20350: [SPARK-23179][SQL] Support option to throw exception if ...

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20350 **[Test build #86495 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86495/testReport)** for PR 20350 at commit

[GitHub] spark issue #20345: [SPARK-23172][SQL] Respect Project nodes in ReorderJoin

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20345 **[Test build #86499 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86499/testReport)** for PR 20345 at commit

[GitHub] spark issue #20345: [SPARK-23172][SQL] Respect Project nodes in ReorderJoin

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20345 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/114/

[GitHub] spark issue #20345: [SPARK-23172][SQL] Respect Project nodes in ReorderJoin

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20345 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20344: [MINOR] Typo fixes

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20344 **[Test build #4071 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4071/testReport)** for PR 20344 at commit

[GitHub] spark issue #20345: [SPARK-23172][SQL] Respect Project nodes in ReorderJoin

2018-01-22 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/20345 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20354: [SPARK-23163][DOC][PYTHON] Sync ML Python API with Scala

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20354 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20354: [SPARK-23163][DOC][PYTHON] Sync ML Python API with Scala

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20354 **[Test build #86498 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86498/testReport)** for PR 20354 at commit

[GitHub] spark issue #20354: [SPARK-23163][DOC][PYTHON] Sync ML Python API with Scala

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20354 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86498/ Test PASSed. ---

<    1   2   3   4   5   6   >