Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/18931
LGTM except a few comments
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r163518761
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -156,13 +156,94 @@ trait CodegenSupport extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r163516654
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -156,13 +156,94 @@ trait CodegenSupport extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r163514909
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -156,13 +156,94 @@ trait CodegenSupport extends
Github user foxish commented on the issue:
https://github.com/apache/spark/pull/20272
@jiangxb1987 Is there any specific owner of the thrift server that we can
ping here? The testing looks good - so, all we're waiting for is confirmation
from them on the original intent behind
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r163513927
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -156,13 +156,94 @@ trait CodegenSupport extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r163512972
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -156,13 +156,94 @@ trait CodegenSupport extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r163512277
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -156,13 +156,94 @@ trait CodegenSupport extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r163511790
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -661,6 +661,14 @@ object SQLConf {
.intConf
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20292
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20292#discussion_r163510314
--- Diff:
core/src/main/scala/org/apache/spark/util/collection/ExternalAppendOnlyMap.scala
---
@@ -528,14 +528,22 @@ class ExternalAppendOnlyMap[K, V,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20376
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/189/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20376
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20376
**[Test build #86584 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86584/testReport)**
for PR 20376 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20376
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19575#discussion_r163499909
--- Diff: docs/sql-programming-guide.md ---
@@ -1640,6 +1640,147 @@ Configuration of Hive is done by placing your
`hive-site.xml`, `core-site.xml` a
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19575#discussion_r163483209
--- Diff: docs/sql-programming-guide.md ---
@@ -1640,6 +1640,147 @@ Configuration of Hive is done by placing your
`hive-site.xml`, `core-site.xml` a
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19575#discussion_r163486863
--- Diff: docs/sql-programming-guide.md ---
@@ -1640,6 +1640,147 @@ Configuration of Hive is done by placing your
`hive-site.xml`, `core-site.xml` a
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19575#discussion_r163490326
--- Diff: docs/sql-programming-guide.md ---
@@ -1640,6 +1640,147 @@ Configuration of Hive is done by placing your
`hive-site.xml`, `core-site.xml` a
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17702
**[Test build #86583 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86583/testReport)**
for PR 17702 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17702
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/188/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17702
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/17702
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20292
**[Test build #86582 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86582/testReport)**
for PR 20292 at commit
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/20292
ok to test.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/20327#discussion_r163491802
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -385,7 +386,13 @@ class SparkContext(config: SparkConf) extends Logging {
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20382
**[Test build #86581 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86581/testReport)**
for PR 20382 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20382
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/187/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20382
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/20382#discussion_r163487603
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/ConsoleWriter.scala
---
@@ -56,7 +58,7 @@ trait ConsoleWriter extends
GitHub user jerryshao opened a pull request:
https://github.com/apache/spark/pull/20382
[SPARK-23097][SQL][SS] Migrate text socket source to V2
## What changes were proposed in this pull request?
This PR moves structured streaming text socket source to V2.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19671
**[Test build #86579 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86579/testReport)**
for PR 19671 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18931
**[Test build #86580 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86580/testReport)**
for PR 18931 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18931
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19671
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18931
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/186/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19671
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/185/
Github user mpetruska commented on a diff in the pull request:
https://github.com/apache/spark/pull/19671#discussion_r163477899
--- Diff:
core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala ---
@@ -1322,33 +1322,55 @@ class BlockManagerSuite extends SparkFunSuite
Github user mpetruska commented on the issue:
https://github.com/apache/spark/pull/19671
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r163477806
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1313,6 +1331,9 @@ object CodeGenerator
Github user mpetruska commented on a diff in the pull request:
https://github.com/apache/spark/pull/19671#discussion_r163476983
--- Diff:
core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala ---
@@ -1322,33 +1322,55 @@ class BlockManagerSuite extends SparkFunSuite
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20338
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20338
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/184/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20355
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/183/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20355
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20376
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20376
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/182/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20379
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/181/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20379
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20379
**[Test build #86575 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86575/testReport)**
for PR 20379 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20338
**[Test build #86578 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86578/testReport)**
for PR 20338 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20376
**[Test build #86576 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86576/testReport)**
for PR 20376 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20355
**[Test build #86577 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86577/testReport)**
for PR 20355 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20338
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20376
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20379
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20376
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/180/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20381
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20355
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20376
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20379
**[Test build #86571 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86571/testReport)**
for PR 20379 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19285
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20376
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20355
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17702
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86573/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20379
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18931
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86568/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18931
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18931
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18931
**[Test build #86568 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86568/testReport)**
for PR 18931 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19285
**[Test build #86565 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86565/testReport)**
for PR 19285 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20355
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86564/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17702
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18931
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86566/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20338
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86569/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18931
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18931
**[Test build #86566 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86566/testReport)**
for PR 18931 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20355
**[Test build #86564 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86564/testReport)**
for PR 20355 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20376
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86574/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20376
**[Test build #86574 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86574/testReport)**
for PR 20376 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20338
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18931
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86570/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17702
**[Test build #86573 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86573/testReport)**
for PR 17702 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20338
**[Test build #86569 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86569/testReport)**
for PR 20338 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19285
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86565/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20379
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86571/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18931
**[Test build #86570 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86570/testReport)**
for PR 18931 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20381
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user heary-cao opened a pull request:
https://github.com/apache/spark/pull/20381
[MINOR][SQL]add new unit test to LimitPushdown
## What changes were proposed in this pull request?
This PR is repaired as follows
1ãupdate y -> x in "left outer join" test case
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20380
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86572/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20380
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20380
**[Test build #86572 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86572/testReport)**
for PR 20380 at commit
501 - 592 of 592 matches
Mail list logo
