[GitHub] spark issue #20454: [SPARK-23202][SQL] Add new API in DataSourceWriter: onDa...

2018-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20454 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20454: [SPARK-23202][SQL] Add new API in DataSourceWriter: onDa...

2018-02-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20454 **[Test build #86914 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86914/testReport)** for PR 20454 at commit

[GitHub] spark issue #20383: [SPARK-23200] Reset Kubernetes-specific config on Checkp...

2018-02-01 Thread ssaavedra
Github user ssaavedra commented on the issue: https://github.com/apache/spark/pull/20383 Yes, sorry for the misunderstanding I was also probably too eager with this. However, if the changes I'm stating up there don't work, I am not sure what I'm missing now. I'll take a further look

[GitHub] spark pull request #20471: [SPARK-23280][SQL][FOLLOWUP] Enable `MutableColum...

2018-02-01 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20471#discussion_r165288359 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/MutableColumnarRow.java --- @@ -162,8 +162,9 @@ public ColumnarArray

[GitHub] spark issue #20455: [SPARK-23284][SQL] Document the behavior of several Colu...

2018-02-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20455 **[Test build #86923 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86923/testReport)** for PR 20455 at commit

[GitHub] spark issue #20468: [SPARK-23280][SQL][FOLLOWUP] Fix Java style check issues...

2018-02-01 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20468 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20455: [SPARK-23284][SQL] Document the behavior of several Colu...

2018-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20455 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/472/

[GitHub] spark issue #20455: [SPARK-23284][SQL] Document the behavior of several Colu...

2018-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20455 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20455: [SPARK-23284][SQL] Document the behavior of several Colu...

2018-02-01 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20455 @ueshin Yes, missing it. Thanks. I'll add it. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20400: [SPARK-23084][PYTHON]Add unboundedPreceding(), unbounded...

2018-02-01 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20400 Yup, we could also string as a column but I was thinking of matching the signature with the Scala one for now, just for consistency .. On 1 Feb 2018 5:24 pm, "Liang-Chi Hsieh"

[GitHub] spark issue #20455: [SPARK-23284][SQL] Document the behavior of several Colu...

2018-02-01 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/20455 We also need to add `if (isNullAt(rowId)) return null;` to `WritableColumnVector.getMap()`? --- - To unsubscribe, e-mail:

[GitHub] spark issue #20471: [SPARK-23280][SQL][FOLLOWUP] Enable `MutableColumnarRow....

2018-02-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20471 **[Test build #86922 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86922/testReport)** for PR 20471 at commit

[GitHub] spark issue #20471: [SPARK-23280][SQL][FOLLOWUP] Enable `MutableColumnarRow....

2018-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20471 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/471/

[GitHub] spark issue #20471: [SPARK-23280][SQL][FOLLOWUP] Enable `MutableColumnarRow....

2018-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20471 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20471: [SPARK-23280][SQL][FOLLOWUP] Enable `MutableColumnarRow....

2018-02-01 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/20471 cc @cloud-fan @viirya --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20471: [SPARK-23280][SQL][FOLLOWUP] Enable `MutableColum...

2018-02-01 Thread ueshin
GitHub user ueshin opened a pull request: https://github.com/apache/spark/pull/20471 [SPARK-23280][SQL][FOLLOWUP] Enable `MutableColumnarRow.getMap()`. ## What changes were proposed in this pull request? This is a followup pr of #20450. We should've enabled

[GitHub] spark pull request #20400: [SPARK-23084][PYTHON]Add unboundedPreceding(), un...

2018-02-01 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20400#discussion_r165284328 --- Diff: python/pyspark/sql/window.py --- @@ -208,20 +236,27 @@ def rangeBetween(self, start, end): and "5" means the five off after the

[GitHub] spark pull request #20400: [SPARK-23084][PYTHON]Add unboundedPreceding(), un...

2018-02-01 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20400#discussion_r165284238 --- Diff: python/pyspark/sql/window.py --- @@ -120,20 +122,46 @@ def rangeBetween(start, end): and "5" means the five off after the current row.

[GitHub] spark issue #19219: [SPARK-21993][SQL] Close sessionState when finish

2018-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19219 Build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #19219: [SPARK-21993][SQL] Close sessionState when finish

2018-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19219 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86911/ Test FAILed. ---

[GitHub] spark issue #19219: [SPARK-21993][SQL] Close sessionState when finish

2018-02-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19219 **[Test build #86911 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86911/testReport)** for PR 19219 at commit

[GitHub] spark issue #20400: [SPARK-23084][PYTHON]Add unboundedPreceding(), unbounded...

2018-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20400 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86919/ Test PASSed. ---

[GitHub] spark issue #20470: [SPARK-23296][YARN] Include stacktrace in YARN-app diagn...

2018-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20470 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20400: [SPARK-23084][PYTHON]Add unboundedPreceding(), unbounded...

2018-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20400 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20400: [SPARK-23084][PYTHON]Add unboundedPreceding(), unbounded...

2018-02-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20400 **[Test build #86919 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86919/testReport)** for PR 20400 at commit

[GitHub] spark issue #20470: [SPARK-23296][YARN] Include stacktrace in YARN-app diagn...

2018-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20470 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20470: [SPARK-23296][YARN] Include stacktrace in YARN-ap...

2018-02-01 Thread gerashegalov
GitHub user gerashegalov opened a pull request: https://github.com/apache/spark/pull/20470 [SPARK-23296][YARN] Include stacktrace in YARN-app diagnostic ## What changes were proposed in this pull request? Include stacktrace in the diagnostics message upon abnormal

[GitHub] spark issue #20450: [SPARK-23280][SQL] add map type support to ColumnVector

2018-02-01 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20450 @ueshin Ok. No problem. :) --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20450: [SPARK-23280][SQL] add map type support to ColumnVector

2018-02-01 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/20450 @viirya Thanks! but I'm working on it. I'll do it soon. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #20450: [SPARK-23280][SQL] add map type support to ColumnVector

2018-02-01 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20450 I found that we don't enable `getMap` API in `MutableColumnarRow` in this change, should we do it? If so, I can make a small follow-up PR for it. ---

[GitHub] spark issue #18136: [SPARK-20910][SQL] Add build-in SQL function - UUID

2018-02-01 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/18136 I just came across this expression and I have a few concerns: 1. A row will not get the same UUID assigned when a task fails. This might cause some really weird problems when the UUID

<    2   3   4   5   6   7