Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20537
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20537
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/679/
Github user icexelloss commented on the issue:
https://github.com/apache/spark/pull/20537
This is pretty important bug fix that we should try to get in Spark
2.3...Thanks @felixcheung for reporting this!
---
-
To
Github user icexelloss commented on the issue:
https://github.com/apache/spark/pull/20537
cc @felixcheung @BryanCutler @ueshin @HyukjinKwon
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20525#discussion_r166780472
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileFormatWriterSuite.scala
---
@@ -32,6 +33,24 @@ class
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/20525#discussion_r166782197
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileFormatWriterSuite.scala
---
@@ -32,6 +33,24 @@ class
GitHub user icexelloss opened a pull request:
https://github.com/apache/spark/pull/20537
[SPARK-23314][PYTHON] Add ambiguous=False when localizing tz-naive
timestamps to deal with dst
## What changes were proposed in this pull request?
When tz_localize a tz-naive timetamp,
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20518#discussion_r166780413
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala ---
@@ -745,4 +763,27 @@ private[spark] class CosineDistanceMeasure extends
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/20525#discussion_r166779585
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileFormatWriterSuite.scala
---
@@ -32,6 +33,24 @@ class
Github user tdas commented on the issue:
https://github.com/apache/spark/pull/20445
seems like a unrelated flaky test ^
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20525#discussion_r166778741
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileFormatWriterSuite.scala
---
@@ -32,6 +33,24 @@ class
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/20525#discussion_r166778140
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala
---
@@ -190,9 +190,13 @@ object FileFormatWriter
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/20484
ok
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/20525#discussion_r166776296
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileFormatWriterSuite.scala
---
@@ -32,6 +33,24 @@ class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20519
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87173/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20519
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20519
**[Test build #87173 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87173/testReport)**
for PR 20519 at commit
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20525#discussion_r166774944
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileFormatWriterSuite.scala
---
@@ -32,6 +33,24 @@ class
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/20525#discussion_r166774153
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala
---
@@ -190,9 +190,13 @@ object FileFormatWriter
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20472#discussion_r166771387
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala ---
@@ -1001,11 +996,18 @@ private[spark] object RandomForest extends
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20472#discussion_r166770380
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala ---
@@ -931,7 +925,8 @@ private[spark] object RandomForest extends Logging {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20472#discussion_r166771033
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala ---
@@ -1001,11 +996,18 @@ private[spark] object RandomForest extends
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20472#discussion_r166773606
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala ---
@@ -1001,11 +996,18 @@ private[spark] object RandomForest extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20527#discussion_r166770787
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -132,6 +134,32 @@ class InMemoryCatalogedDDLSuite
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20529#discussion_r166768784
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2.scala
---
@@ -92,12 +92,14 @@ case class
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20516#discussion_r166767609
--- Diff:
core/src/test/scala/org/apache/spark/network/netty/NettyBlockTransferServiceSuite.scala
---
@@ -77,16 +79,53 @@ class
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20516#discussion_r166767674
--- Diff:
core/src/test/scala/org/apache/spark/network/netty/NettyBlockTransferServiceSuite.scala
---
@@ -77,16 +79,53 @@ class
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20516#discussion_r166767449
--- Diff:
core/src/test/scala/org/apache/spark/network/netty/NettyBlockTransferServiceSuite.scala
---
@@ -77,16 +79,53 @@ class
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20516#discussion_r166767860
--- Diff:
core/src/test/scala/org/apache/spark/network/netty/NettyBlockTransferServiceSuite.scala
---
@@ -77,16 +79,53 @@ class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20474
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20516#discussion_r166766796
--- Diff:
core/src/test/scala/org/apache/spark/network/netty/NettyBlockTransferServiceSuite.scala
---
@@ -77,16 +79,53 @@ class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20474
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87172/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20474
**[Test build #87172 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87172/testReport)**
for PR 20474 at commit
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20525#discussion_r166767068
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala
---
@@ -190,9 +190,13 @@ object FileFormatWriter
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20536
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87175/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20536
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20536
**[Test build #87175 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87175/testReport)**
for PR 20536 at commit
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20484#discussion_r166763629
--- Diff: docs/sql-programming-guide.md ---
@@ -1776,6 +1776,44 @@ working with timestamps in `pandas_udf`s to get the
best performance, see
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20484
Oh, I thought in this way, @tgravescs .
- For ORC files, the parameter names (ORC/Hive) are the same as we see
https://github.com/apache/spark/pull/20517 .
- For Hive tables, we don't
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20495
Thanks! Merged to master/2.3
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20524
LGTM Thanks! Merged to master/2.3
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20536
Thank you for pining me. +1 for the decision.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20445
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20445
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87174/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20445
**[Test build #87174 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87174/testReport)**
for PR 20445 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20484
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87177/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20484
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20484
**[Test build #87177 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87177/testReport)**
for PR 20484 at commit
Github user tdas commented on the issue:
https://github.com/apache/spark/pull/20382
#20445 will be merged in a few hours. please go ahead and update your PR
with the refactoring that was suggested (mainly, no v1 version).
---
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/20484
why did you remove the bit about the orc configs?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20484
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20484
**[Test build #87177 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87177/testReport)**
for PR 20484 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20484
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/678/
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20484
I see. I removed `spark.sql.hive.convertMetastoreOrc` and Hive ORC table
stuff from this PR accordingly. We can add that later if we fix the regresson
of `convertMetastoreOrc/Parquet`.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20387
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87170/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20387
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20387
**[Test build #87170 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87170/testReport)**
for PR 20387 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20484
Just FYI, https://github.com/apache/spark/pull/20536 is reverting the conf
`convertMetastoreOrc` back `false`. However, we still can turn it on by default
in 2.3 after we fix the regression.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20490
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87169/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20490
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20490
**[Test build #87169 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87169/testReport)**
for PR 20490 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20445
**[Test build #87176 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87176/testReport)**
for PR 20445 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20445
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20445
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/677/
Github user jose-torres commented on the issue:
https://github.com/apache/spark/pull/20445
LGTM pending passing run of that HiveDDLSuite test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20445#discussion_r166736890
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/memory.scala
---
@@ -149,18 +149,12 @@ case class MemoryStream[A : Encoder](id:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20536
**[Test build #87175 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87175/testReport)**
for PR 20536 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20536
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20536
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/676/
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20536
After a discussion with @marmbrus @rxin @yhuai , we decided to revert this
for avoiding any regression and blocking the release of Spark 2.3.
cc @sameeragarwal @dongjoon-hyun @cloud-fan
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/20536
Revert "[SPARK-22279][SQL] Turn on spark.sql.hive.convertMetastoreOrc by
default
## What changes were proposed in this pull request?
This is to revert the changes made in
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20530
@wujianping10043419 this change is too trivial to merge, I am sorry. The
main reason for not merging is because this will mess up the git blame for the
given code, which is sometimes very useful
Github user jose-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/20445#discussion_r166725859
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/memory.scala
---
@@ -149,18 +149,12 @@ case class MemoryStream[A :
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20445
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20445
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/675/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20445
**[Test build #87174 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87174/testReport)**
for PR 20445 at commit
Github user tdas commented on the issue:
https://github.com/apache/spark/pull/20445
Retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20445#discussion_r166720161
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/ForeachSinkSuite.scala
---
@@ -46,49 +46,34 @@ class ForeachSinkSuite extends
Github user tdas commented on the issue:
https://github.com/apache/spark/pull/20445
Jenkins retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20484#discussion_r166716818
--- Diff: docs/sql-programming-guide.md ---
@@ -1776,6 +1776,44 @@ working with timestamps in `pandas_udf`s to get the
best performance, see
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/20373
@HyukjinKwon would it be good to update this PR to match the upcoming 4.3
release you are working on? If the code is the same, then just updating the
title/description so it is clear
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20519
**[Test build #87173 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87173/testReport)**
for PR 20519 at commit
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/20499
I'd fix this in 2.3, and 2.2.1 as well.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/20535#discussion_r166709990
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ---
@@ -171,7 +171,8 @@ class DataFrameReader private[sql](sparkSession:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20534
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87165/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20534
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20474
**[Test build #87172 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87172/testReport)**
for PR 20474 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20534
**[Test build #87165 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87165/testReport)**
for PR 20534 at commit
Github user attilapiros commented on the issue:
https://github.com/apache/spark/pull/20474
jenkins retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20531
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20531
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87164/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20531
**[Test build #87164 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87164/testReport)**
for PR 20531 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20474
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87167/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20474
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20474
**[Test build #87167 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87167/testReport)**
for PR 20474 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19145
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20535#discussion_r166701501
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/DataSourceOptions.java
---
@@ -27,6 +27,39 @@
/**
* An immutable string-to-string
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20524
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/20535
This should move the standard options to `DataSourceV2Relation` to avoid
needing to instantiate `DataSourceOptions` wherever the relation is created.
---
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20524#discussion_r166699026
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/SharedSparkSession.scala ---
@@ -111,7 +111,7 @@ trait SharedSparkSession
201 - 300 of 520 matches
Mail list logo
