[GitHub] spark pull request #20406: [SPARK-23230][SQL]When hive.default.fileformat is...

2018-02-11 Thread cxzl25
Github user cxzl25 commented on a diff in the pull request: https://github.com/apache/spark/pull/20406#discussion_r167482913 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveSerDeSuite.scala --- @@ -100,6 +100,25 @@ class HiveSerDeSuite extends

[GitHub] spark pull request #20580: [SPARK-23388][SQL] Support for Parquet Binary Dec...

2018-02-11 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/20580#discussion_r167482592 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/WritableColumnVector.java --- @@ -691,11 +696,6 @@ public WritableColumnVector

[GitHub] spark pull request #20584: [SPARK-23390][SQL] Flaky Test Suite: FileBasedDat...

2018-02-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20584 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20531: [SPARK-23352][PYTHON] Explicitly specify supported types...

2018-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20531 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20580: [SPARK-23388][SQL] Support for Parquet Binary DecimalTyp...

2018-02-11 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/20580 @cloud-fan Is there any reason that the above PR removed to support some types such as `Array`? --- - To unsubscribe, e-mail:

[GitHub] spark issue #20531: [SPARK-23352][PYTHON] Explicitly specify supported types...

2018-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20531 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/804/

[GitHub] spark issue #20567: [SPARK-23380][PYTHON] Make toPandas fall back to non-Arr...

2018-02-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20567 **[Test build #87324 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87324/testReport)** for PR 20567 at commit

[GitHub] spark issue #20567: [SPARK-23380][PYTHON] Make toPandas fall back to non-Arr...

2018-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20567 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/803/

[GitHub] spark issue #20531: [SPARK-23352][PYTHON] Explicitly specify supported types...

2018-02-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20531 **[Test build #87325 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87325/testReport)** for PR 20531 at commit

[GitHub] spark issue #20567: [SPARK-23380][PYTHON] Make toPandas fall back to non-Arr...

2018-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20567 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20531: [SPARK-23352][PYTHON] Explicitly specify supported types...

2018-02-11 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20531 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20584: [SPARK-23390][SQL] Flaky Test Suite: FileBasedDataSource...

2018-02-11 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20584 merging this to master/2.3. Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20583: [SPARK-23392][TEST] Add some test cases for image...

2018-02-11 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/spark/pull/20583#discussion_r167481154 --- Diff: mllib/src/test/scala/org/apache/spark/ml/image/ImageSchemaSuite.scala --- @@ -65,11 +65,71 @@ class ImageSchemaSuite extends SparkFunSuite with

[GitHub] spark issue #20584: [SPARK-23390][SQL] Flaky Test Suite: FileBasedDataSource...

2018-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20584 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87321/ Test PASSed. ---

[GitHub] spark issue #20583: [SPARK-23392][TEST] Add some test cases for images featu...

2018-02-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20583 **[Test build #87323 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87323/testReport)** for PR 20583 at commit

[GitHub] spark issue #20584: [SPARK-23390][SQL] Flaky Test Suite: FileBasedDataSource...

2018-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20584 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20567: [SPARK-23380][PYTHON] Make toPandas fall back to non-Arr...

2018-02-11 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20567 @ueshin, yup, I initially thought so but realised that it might collect twice (`_collectAsArrow`, `collect`) and trigger two jobs due to one failure in execution time. Also, seems it could

[GitHub] spark issue #20584: [SPARK-23390][SQL] Flaky Test Suite: FileBasedDataSource...

2018-02-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20584 **[Test build #87321 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87321/testReport)** for PR 20584 at commit

[GitHub] spark pull request #20583: [SPARK-23392][TEST] Add some test cases for image...

2018-02-11 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/spark/pull/20583#discussion_r167479724 --- Diff: mllib/src/test/scala/org/apache/spark/ml/image/ImageSchemaSuite.scala --- @@ -65,11 +65,71 @@ class ImageSchemaSuite extends SparkFunSuite with

[GitHub] spark pull request #20583: [SPARK-23392][TEST] Add some test cases for image...

2018-02-11 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/spark/pull/20583#discussion_r167479658 --- Diff: mllib/src/test/scala/org/apache/spark/ml/image/ImageSchemaSuite.scala --- @@ -65,11 +65,71 @@ class ImageSchemaSuite extends SparkFunSuite with

[GitHub] spark pull request #20583: [SPARK-23392][TEST] Add some test cases for image...

2018-02-11 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/spark/pull/20583#discussion_r167479566 --- Diff: mllib/src/test/scala/org/apache/spark/ml/image/ImageSchemaSuite.scala --- @@ -65,11 +65,71 @@ class ImageSchemaSuite extends SparkFunSuite with

[GitHub] spark issue #20584: [SPARK-23390][SQL] Flaky Test Suite: FileBasedDataSource...

2018-02-11 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/20584 I am also thinking about this. I agree with this. > According to the log, the leaked file stream was created when building the ORC columnar reader. I am suspicious about relationship

[GitHub] spark issue #20581: [SPARK-23391][CORE]It may lead to overflow for some inte...

2018-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20581 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87316/ Test PASSed. ---

[GitHub] spark issue #20581: [SPARK-23391][CORE]It may lead to overflow for some inte...

2018-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20581 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20581: [SPARK-23391][CORE]It may lead to overflow for some inte...

2018-02-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20581 **[Test build #87316 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87316/testReport)** for PR 20581 at commit

[GitHub] spark issue #20584: [SPARK-23390][SQL] Flaky Test Suite: FileBasedDataSource...

2018-02-11 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20584 LGTM, seems plausible! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #18933: [WIP][SPARK-21722][SQL][PYTHON] Enable timezone-aware ti...

2018-02-11 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/18933 I'd close this for now. We can open another pr if needed. We need another implementation anyway. --- - To unsubscribe, e-mail:

[GitHub] spark pull request #18933: [WIP][SPARK-21722][SQL][PYTHON] Enable timezone-a...

2018-02-11 Thread ueshin
Github user ueshin closed the pull request at: https://github.com/apache/spark/pull/18933 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20584: [SPARK-23390][SQL] Flaky Test Suite: FileBasedDataSource...

2018-02-11 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20584 You are right. I have run out of ideas. LGTM too for a try if it happens more frequently in spark-branch-2.3-test-sbt-hadoop-2.7. ---

[GitHub] spark issue #20579: [SPARK-23372][SQL] Writing empty struct in parquet fails...

2018-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20579 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87317/ Test FAILed. ---

[GitHub] spark issue #20579: [SPARK-23372][SQL] Writing empty struct in parquet fails...

2018-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20579 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20579: [SPARK-23372][SQL] Writing empty struct in parquet fails...

2018-02-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20579 **[Test build #87317 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87317/testReport)** for PR 20579 at commit

[GitHub] spark issue #20584: [SPARK-23390][SQL] Flaky Test Suite: FileBasedDataSource...

2018-02-11 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20584 > BTW, my rough wild guess was that case 2. (reading it but not closing it) happens in schema inference path. According to the log, the leaked file stream was created when building the

[GitHub] spark issue #20584: [SPARK-23390][SQL] Flaky Test Suite: FileBasedDataSource...

2018-02-11 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20584 I won't get in the way but I am less sure on this. I thought this is also flaky in PR builder too anyway. --- - To

[GitHub] spark pull request #20583: [SPARK-23392][TEST] Add some test cases for image...

2018-02-11 Thread imatiach-msft
Github user imatiach-msft commented on a diff in the pull request: https://github.com/apache/spark/pull/20583#discussion_r167471442 --- Diff: mllib/src/test/scala/org/apache/spark/ml/image/ImageSchemaSuite.scala --- @@ -65,11 +65,71 @@ class ImageSchemaSuite extends SparkFunSuite

[GitHub] spark pull request #20567: [SPARK-23380][PYTHON] Make toPandas fall back to ...

2018-02-11 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/20567#discussion_r167469258 --- Diff: python/pyspark/sql/tests.py --- @@ -48,12 +49,12 @@ else: import unittest +from pyspark.util import _exception_message

[GitHub] spark pull request #20583: [SPARK-23392][TEST] Add some test cases for image...

2018-02-11 Thread imatiach-msft
Github user imatiach-msft commented on a diff in the pull request: https://github.com/apache/spark/pull/20583#discussion_r167470547 --- Diff: mllib/src/test/scala/org/apache/spark/ml/image/ImageSchemaSuite.scala --- @@ -65,11 +65,71 @@ class ImageSchemaSuite extends SparkFunSuite

[GitHub] spark pull request #20583: [SPARK-23392][TEST] Add some test cases for image...

2018-02-11 Thread imatiach-msft
Github user imatiach-msft commented on a diff in the pull request: https://github.com/apache/spark/pull/20583#discussion_r167470380 --- Diff: mllib/src/test/scala/org/apache/spark/ml/image/ImageSchemaSuite.scala --- @@ -65,11 +65,71 @@ class ImageSchemaSuite extends SparkFunSuite

[GitHub] spark issue #20584: [SPARK-23390][SQL] Flaky Test Suite: FileBasedDataSource...

2018-02-11 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20584 LGTM, I would merge this first and see whether this can help fix the flaky tests. --- - To unsubscribe, e-mail:

[GitHub] spark pull request #20583: [SPARK-23392][TEST] Add some test cases for image...

2018-02-11 Thread imatiach-msft
Github user imatiach-msft commented on a diff in the pull request: https://github.com/apache/spark/pull/20583#discussion_r167470275 --- Diff: mllib/src/test/scala/org/apache/spark/ml/image/ImageSchemaSuite.scala --- @@ -65,11 +65,71 @@ class ImageSchemaSuite extends SparkFunSuite

[GitHub] spark issue #20584: [SPARK-23390][SQL] Flaky Test Suite: FileBasedDataSource...

2018-02-11 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20584 BTW, my rough wild guess was that case 2. (reading it but not closing it) happens in schema inference path. --- - To

[GitHub] spark issue #20584: [SPARK-23390][SQL] Flaky Test Suite: FileBasedDataSource...

2018-02-11 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20584 BTW, I would bet for case 2. in the PR description (just a rough wild guess). --- - To unsubscribe, e-mail:

[GitHub] spark pull request #20584: [SPARK-23390][SQL] Flaky Test Suite: FileBasedDat...

2018-02-11 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20584#discussion_r167469495 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala --- @@ -102,17 +104,27 @@ class FileBasedDataSourceSuite extends

[GitHub] spark issue #20581: [SPARK-23391][CORE]It may lead to overflow for some inte...

2018-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20581 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20581: [SPARK-23391][CORE]It may lead to overflow for some inte...

2018-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20581 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87315/ Test FAILed. ---

[GitHub] spark issue #20581: [SPARK-23391][CORE]It may lead to overflow for some inte...

2018-02-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20581 **[Test build #87315 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87315/testReport)** for PR 20581 at commit

[GitHub] spark issue #20531: [SPARK-23352][PYTHON] Explicitly specify supported types...

2018-02-11 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/20531 @HyukjinKwon Yes, LGTM. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20582: [MINOR][TEST]`spark.testing` No effect on the SparkFunSu...

2018-02-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20582 **[Test build #87322 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87322/testReport)** for PR 20582 at commit

[GitHub] spark issue #20582: [MINOR][TEST]`spark.testing` No effect on the SparkFunSu...

2018-02-11 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20582 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20582: [MINOR][TEST]`spark.testing` No effect on the Spa...

2018-02-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20582#discussion_r167468000 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSparkSubmitSuite.scala --- @@ -50,7 +50,6 @@ class HiveSparkSubmitSuite

[GitHub] spark issue #20584: [SPARK-23390][SQL] Flaky Test Suite: FileBasedDataSource...

2018-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20584 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20584: [SPARK-23390][SQL] Flaky Test Suite: FileBasedDataSource...

2018-02-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20584 **[Test build #87321 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87321/testReport)** for PR 20584 at commit

[GitHub] spark issue #20583: [SPARK-23392][TEST] Add some test cases for images featu...

2018-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20583 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20584: [SPARK-23390][SQL] Flaky Test Suite: FileBasedDataSource...

2018-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20584 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/802/

[GitHub] spark issue #20583: [SPARK-23392][TEST] Add some test cases for images featu...

2018-02-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20583 **[Test build #87320 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87320/testReport)** for PR 20583 at commit

[GitHub] spark issue #20583: [SPARK-23392][TEST] Add some test cases for images featu...

2018-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20583 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87320/ Test FAILed. ---

[GitHub] spark issue #20584: [SPARK-23390][SQL] Flaky Test Suite: FileBasedDataSource...

2018-02-11 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20584 cc @sameeragarwal @dongjoon-hyun @gatorsmile --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark pull request #20584: [SPARK-23390][SQL] Flaky Test Suite: FileBasedDat...

2018-02-11 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/20584 [SPARK-23390][SQL] Flaky Test Suite: FileBasedDataSourceSuite in Spark 2.3/hadoop 2.7 ## What changes were proposed in this pull request? This test only fails with sbt on Hadoop 2.7, I

[GitHub] spark issue #20583: [SPARK-23392][TEST] Add some test cases for images featu...

2018-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20583 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87319/ Test FAILed. ---

[GitHub] spark issue #20583: [SPARK-23392][TEST] Add some test cases for images featu...

2018-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20583 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20583: [SPARK-23392][TEST] Add some test cases for images featu...

2018-02-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20583 **[Test build #87319 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87319/testReport)** for PR 20583 at commit

[GitHub] spark issue #20504: [SPARK-23332][SQL] Update SQLQueryTestSuite to support a...

2018-02-11 Thread wangyum
Github user wangyum commented on the issue: https://github.com/apache/spark/pull/20504 @gatorsmile --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20583: [SPARK-23392][TEST] Add some test cases for images featu...

2018-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20583 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20583: [SPARK-23392][TEST] Add some test cases for images featu...

2018-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20583 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87318/ Test FAILed. ---

[GitHub] spark issue #20583: [SPARK-23392][TEST] Add some test cases for images featu...

2018-02-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20583 **[Test build #87318 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87318/testReport)** for PR 20583 at commit

[GitHub] spark issue #20531: [SPARK-23352][PYTHON] Explicitly specify supported types...

2018-02-11 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20531 @ueshin, does this looks fine to you too? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20583: [SPARK-23392][TEST] Add some test cases for images featu...

2018-02-11 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20583 Thanks, @xubo245. Seems fine. cc @MrBago, @imatiach-msft, @jkbradley, @WeichenXu123 who I can directly think of for now. ---

[GitHub] spark issue #20583: [SPARK-23392][TEST] Add some test cases for images featu...

2018-02-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20583 **[Test build #87320 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87320/testReport)** for PR 20583 at commit

[GitHub] spark issue #20583: [SPARK-23392][TEST] Add some test cases for images featu...

2018-02-11 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/spark/pull/20583 Sorry, done. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20583: [SPARK-23392][TEST] Add some test cases for images featu...

2018-02-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20583 **[Test build #87319 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87319/testReport)** for PR 20583 at commit

[GitHub] spark issue #20583: [CARBONDATA-23392][TEST] Add some test cases for images ...

2018-02-11 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20583 Shall we fix the title to `[SPARK-23392] ...`? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #20583: [CARBONDATA-23392][TEST] Add some test cases for images ...

2018-02-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20583 **[Test build #87318 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87318/testReport)** for PR 20583 at commit

[GitHub] spark issue #20579: [SPARK-23372][SQL] Writing empty struct in parquet fails...

2018-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20579 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/801/

[GitHub] spark issue #20579: [SPARK-23372][SQL] Writing empty struct in parquet fails...

2018-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20579 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20583: [CARBONDATA-23392][TEST] Add some test cases for images ...

2018-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20583 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20579: [SPARK-23372][SQL] Writing empty struct in parque...

2018-02-11 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/20579#discussion_r167465371 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala --- @@ -72,6 +72,29 @@ class FileBasedDataSourceSuite extends

[GitHub] spark pull request #20583: [CARBONDATA-23392][TEST] Add some test cases for ...

2018-02-11 Thread xubo245
GitHub user xubo245 opened a pull request: https://github.com/apache/spark/pull/20583 [CARBONDATA-23392][TEST] Add some test cases for images feature ## What changes were proposed in this pull request? Add some test cases for images feature ## How was this patch

[GitHub] spark issue #20579: [SPARK-23372][SQL] Writing empty struct in parquet fails...

2018-02-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20579 **[Test build #87317 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87317/testReport)** for PR 20579 at commit

[GitHub] spark issue #20581: [SPARK-23358][CORE][FOLLOW-UP]When reduceId is greater t...

2018-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20581 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/800/

[GitHub] spark issue #20581: [SPARK-23358][CORE][FOLLOW-UP]When reduceId is greater t...

2018-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20581 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20581: [SPARK-23358][CORE][FOLLOW-UP]When reduceId is greater t...

2018-02-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20581 **[Test build #87316 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87316/testReport)** for PR 20581 at commit

[GitHub] spark pull request #20579: [SPARK-23372][SQL] Writing empty struct in parque...

2018-02-11 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/20579#discussion_r167463979 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala --- @@ -68,6 +68,16 @@ class

[GitHub] spark pull request #20579: [SPARK-23372][SQL] Writing empty struct in parque...

2018-02-11 Thread mannharleen
Github user mannharleen commented on a diff in the pull request: https://github.com/apache/spark/pull/20579#discussion_r167463659 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala --- @@ -68,6 +68,16 @@ class

[GitHub] spark issue #19788: [SPARK-9853][Core] Optimize shuffle fetch of contiguous ...

2018-02-11 Thread yucai
Github user yucai commented on the issue: https://github.com/apache/spark/pull/19788 I did local UT, org.apache.spark.sql.FileBasedDataSourceSuite looks good, @jerryshao could you help re-trigger testing? --- - To

[GitHub] spark issue #20582: [MINOR][TEST]`spark.testing` No effect on the SparkFunSu...

2018-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20582 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20582: [MINOR][TEST]`spark.testing` No effect on the SparkFunSu...

2018-02-11 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/20582 @cloud-fan @srowen Can you help me to review it , thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #20582: [MINOR][TEST]`spark.testing` No effect on the SparkFunSu...

2018-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20582 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20582: [MINOR][TEST]`spark.testing` No effect on the Spa...

2018-02-11 Thread heary-cao
GitHub user heary-cao opened a pull request: https://github.com/apache/spark/pull/20582 [MINOR][TEST]`spark.testing` No effect on the SparkFunSuite unit test ## What changes were proposed in this pull request? Currently, we use SBT and MAVN to spark unit test, are

[GitHub] spark issue #19788: [SPARK-9853][Core] Optimize shuffle fetch of contiguous ...

2018-02-11 Thread yucai
Github user yucai commented on the issue: https://github.com/apache/spark/pull/19788 retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19788: [SPARK-9853][Core] Optimize shuffle fetch of contiguous ...

2018-02-11 Thread yucai
Github user yucai commented on the issue: https://github.com/apache/spark/pull/19788 @JoshRosen this feature only happens in SparkSQL, and SparkSQL uses UnsafeRowSerializer, which supports relocation of serialized objects, so I think we only consider compression, right? I have added

[GitHub] spark issue #20581: [SPARK-23358][CORE][FOLLOW-UP]When reduceId is greater t...

2018-02-11 Thread 10110346
Github user 10110346 commented on the issue: https://github.com/apache/spark/pull/20581 @srowen I will check all of our code. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20557: [SPARK-23364][SQL]'desc table' command in spark-sql add ...

2018-02-11 Thread guoxiaolongzte
Github user guoxiaolongzte commented on the issue: https://github.com/apache/spark/pull/20557 @srowen @gatorsmile ![4](https://user-images.githubusercontent.com/26266482/36081707-86d3a7cc-0fdd-11e8-9ee8-1c17efd5d690.png) Can I overload hive's

[GitHub] spark pull request #20518: [SPARK-22119][FOLLOWUP][ML] Use spherical KMeans ...

2018-02-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20518 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20581: [SPARK-23358][CORE][FOLLOW-UP]When reduceId is greater t...

2018-02-11 Thread 10110346
Github user 10110346 commented on the issue: https://github.com/apache/spark/pull/20581 @srowen I am sorry, i didn't notice this place, i found it yesterday. --- - To unsubscribe, e-mail:

[GitHub] spark issue #20518: [SPARK-22119][FOLLOWUP][ML] Use spherical KMeans with co...

2018-02-11 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/20518 Merged to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20581: [SPARK-23358][CORE][FOLLOW-UP]When reduceId is greater t...

2018-02-11 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/20581 Hm, why was this not part of the previous PR? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19788: [SPARK-9853][Core] Optimize shuffle fetch of contiguous ...

2018-02-11 Thread yucai
Github user yucai commented on the issue: https://github.com/apache/spark/pull/19788 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20581: [SPARK-23358][CORE][FOLLOW-UP]When reduceId is greater t...

2018-02-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20581 **[Test build #87315 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87315/testReport)** for PR 20581 at commit

[GitHub] spark issue #20581: [SPARK-23358][CORE][FOLLOW-UP]When reduceId is greater t...

2018-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20581 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20581: [SPARK-23358][CORE][FOLLOW-UP]When reduceId is greater t...

2018-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20581 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/799/

  1   2   3   >