Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20511
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20511
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/920/
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20057
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20511
Sure, I rebased this.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20619
**[Test build #87482 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87482/testReport)**
for PR 20619 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20620
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20619
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20619
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/919/
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20619
Hi, @cloud-fan and @gatorsmile .
This is the same kind of PR about opened file leakage for
ParquetFileFormat. Could you review this?
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20620
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user gaborgsomogyi opened a pull request:
https://github.com/apache/spark/pull/20620
[SPARK-23438][DSTREAMS] Fix DStreams data loss with WAL when driver crashes
## What changes were proposed in this pull request?
There is a race condition introduced in SPARK-11141
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20610
Thank you, @gatorsmile , @cloud-fan , and @viirya .
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20610
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/20619
[SPARK-23390][SQL] Register task completion listerners first in
ParquetFileFormat
## What changes were proposed in this pull request?
ParquetFileFormat leaks opened files in some
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20511
@dongjoon-hyun Could you rebase this PR? We want to merge it to master.
Thanks!
---
-
To unsubscribe, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20610
LGTM
Thanks! Merged to master/2.3
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20617
Thank you for review and approval, @HyukjinKwon !
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20616
Hi, @cloud-fan and @gatorsmile .
Could you review this PR?
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20601
**[Test build #87481 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87481/testReport)**
for PR 20601 at commit
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20610#discussion_r168531711
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/FileStreamSinkSuite.scala
---
@@ -33,6 +33,19 @@ import org.apache.spark.util.Utils
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20295
**[Test build #87480 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87480/testReport)**
for PR 20295 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20295
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user misutoth commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r168531352
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -770,7 +837,14 @@ case class Unhex(child:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20295
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/918/
Github user attilapiros commented on the issue:
https://github.com/apache/spark/pull/20601
jenkins retest please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user misutoth commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r168526385
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -1313,131 +1313,178 @@ object functions {
Github user misutoth commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r168525504
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -1313,131 +1313,178 @@ object functions {
Github user Fokko commented on the issue:
https://github.com/apache/spark/pull/20057
We're in the process of integrating Spark in Airflow, and support for the
`cascadeTruncate` is required to make this succeed. First steps are here:
Github user misutoth commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r168521316
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -262,6 +285,11 @@ case class Cos(child:
Github user rkrzr commented on the issue:
https://github.com/apache/spark/pull/20607
I'll close this for now. (I am running into a problem related to this, but
I'll better open a new issue about that when I know more)
---
Github user rkrzr closed the pull request at:
https://github.com/apache/spark/pull/20607
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user danielvdende commented on the issue:
https://github.com/apache/spark/pull/20057
@dongjoon-hyun @gatorsmile sorry to keep asking, but could you let me know
when we can get this merged?
---
-
To
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20601
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87477/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20601
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20601
**[Test build #87477 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87477/testReport)**
for PR 20601 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20587
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20586
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20575
If doing this, it would be cleaner to do it as part of parsing the logs.
e.g., if you make `AppListingListener` write the app info to the store when
interesting events happen, that would be much
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/17619#discussion_r168509141
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -484,7 +481,6 @@
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20607
@rkrzr please close the PR, unless you plan to actually test that this is
not an issue anymore.
---
-
To unsubscribe, e-mail:
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r168511361
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -1313,131 +1313,178 @@ object functions {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r168511774
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -770,7 +837,14 @@ case class Unhex(child:
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r168504378
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -262,6 +285,11 @@ case class Cos(child:
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r168511869
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2873,7 +2945,7 @@ object functions {
* or equal
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r168511172
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -1313,131 +1313,178 @@ object functions {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r168510272
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -770,7 +837,14 @@ case class Unhex(child:
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r168510579
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -972,6 +1045,7 @@ case class Logarithm(left:
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20601
LGTM pending tests.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20424
**[Test build #87479 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87479/testReport)**
for PR 20424 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20424
Sure, you can. retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user bersprockets commented on the issue:
https://github.com/apache/spark/pull/20424
The test that finished last succeeded, but the one that started last had a
spurious error. Can I get a retest?
---
-
To
Github user robert3005 closed the pull request at:
https://github.com/apache/spark/pull/18176
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20601
**[Test build #87478 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87478/testReport)**
for PR 20601 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20464
ping @felixcheung
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gaborgsomogyi commented on the issue:
https://github.com/apache/spark/pull/20362
gentle ping @jkbradley @WeichenXu123
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user michalsenkyr commented on the issue:
https://github.com/apache/spark/pull/20505
Yes, that is the idea. Frankly, I am not that familiar with how the
compiler resolves all the implicit parameters to say confidently what is going
on. But here's my take:
I did a
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20568
Retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user attilapiros commented on the issue:
https://github.com/apache/spark/pull/20601
Yes, of course. The test of @zsxwing is perfect to avoid similar problems
in the future.
---
-
To unsubscribe, e-mail:
Github user peshopetrov commented on the issue:
https://github.com/apache/spark/pull/20512
Any update?
We have rolled out our Spark clusters with this change and it seems to be
working great. We see no lingering connections on the masters.
---
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20601
@attilapiros could you take a look at the test case Ryan added in #20615
and add something like that to your patch? It'd be nice to catch these things
in unit tests.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20601
**[Test build #87477 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87477/testReport)**
for PR 20601 at commit
Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/20601#discussion_r168458891
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala ---
@@ -963,33 +965,60 @@ private[ui] class TaskPagedTable(
private
Github user tdas commented on the issue:
https://github.com/apache/spark/pull/20554
@zsxwing can you look at it once again. some more changes.
@jose-torres PTAL.
---
-
To unsubscribe, e-mail:
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20608
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20608
Merging to master / 2.3.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20616
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20616
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87476/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20616
**[Test build #87476 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87476/testReport)**
for PR 20616 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20610
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87475/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20610
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20610
**[Test build #87475 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87475/testReport)**
for PR 20610 at commit
Github user hantuzun commented on the issue:
https://github.com/apache/spark/pull/17619
Even though we only run normal Spark jobs this PR is going to fix a case
for us as well.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20617
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20617
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87474/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20617
**[Test build #87474 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87474/testReport)**
for PR 20617 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14431
Build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14431
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/917/
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20610#discussion_r168416253
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/FileStreamSinkSuite.scala
---
@@ -33,6 +33,19 @@ import org.apache.spark.util.Utils
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20545
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20568#discussion_r168415065
--- Diff:
common/sketch/src/main/java/org/apache/spark/util/sketch/Murmur3_x86_32.java ---
@@ -71,6 +73,20 @@ public static int hashUnsafeBytes(Object
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20555
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20545
thanks, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20567
Sure.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20555
thanks, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20618
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20618
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20567
^ this change LGTM. Can we make a PR for this change only and leave the
fallback part for Spark 2.4?
---
-
To unsubscribe,
GitHub user misutoth opened a pull request:
https://github.com/apache/spark/pull/20618
[SPARK-23329][SQL] Fix documentation of trigonometric functions
## What changes were proposed in this pull request?
Provide more details in trigonometric function documentations.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20567
> The binary type bug sounds like a blocker, can we just fix it surgically
by checking the supported data types before going to the arrow optimization
path? For now we can stick with that the
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20605
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20605
thanks, merging to master/2.3! Since it's a bug fix so I included it in
branch 2.3, please let me know if you have other concerns, cc @sameeragarwal
@marmbrus
---
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20567
The binary type bug sounds like a blocker, can we just fix it surgically by
checking the supported data types before going to the arrow optimization path?
For now we can stick with that the
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20615
This looks the same as SPARK-23413 / #20601
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20601#discussion_r168408617
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala ---
@@ -963,33 +965,60 @@ private[ui] class TaskPagedTable(
private object
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20616
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20616
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/916/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20616
**[Test build #87476 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87476/testReport)**
for PR 20616 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20567
The root cause is Arrow conversion in Python side interprets binaries as
`str`, and I here avoided this by checking if the type is what we supported or
not.
This is the most trivial
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20616
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20610
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
201 - 300 of 323 matches
Mail list logo
