[GitHub] spark issue #20713: [SPARK-23434][SQL][BRANCH-2.3] Spark should not warn `me...

2018-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20713 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87875/ Test PASSed. ---

[GitHub] spark issue #20713: [SPARK-23434][SQL][BRANCH-2.3] Spark should not warn `me...

2018-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20713 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20713: [SPARK-23434][SQL][BRANCH-2.3] Spark should not warn `me...

2018-03-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20713 **[Test build #87875 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87875/testReport)** for PR 20713 at commit

[GitHub] spark issue #20715: [SPARK-23434][SQL][BRANCH-2.2] Spark should not warn `me...

2018-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20715 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20700: [SPARK-23546][SQL] Refactor stateless methods/val...

2018-03-01 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20700#discussion_r171773544 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -537,13 +537,38 @@ class CodegenContext

[GitHub] spark pull request #20700: [SPARK-23546][SQL] Refactor stateless methods/val...

2018-03-01 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20700#discussion_r171774581 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala --- @@ -734,23 +734,26 @@ case class Cast(child: Expression,

[GitHub] spark issue #20715: [SPARK-23434][SQL][BRANCH-2.2] Spark should not warn `me...

2018-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20715 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87874/ Test PASSed. ---

[GitHub] spark pull request #20700: [SPARK-23546][SQL] Refactor stateless methods/val...

2018-03-01 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20700#discussion_r171774915 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -833,8 +669,8 @@ class CodegenContext {

[GitHub] spark pull request #20700: [SPARK-23546][SQL] Refactor stateless methods/val...

2018-03-01 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20700#discussion_r171774634 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala --- @@ -734,23 +734,26 @@ case class Cast(child: Expression,

[GitHub] spark issue #20714: [SPARK-23457][SQL][BRANCH-2.3] Register task completion ...

2018-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20714 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87873/ Test FAILed. ---

[GitHub] spark issue #20715: [SPARK-23434][SQL][BRANCH-2.2] Spark should not warn `me...

2018-03-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20715 **[Test build #87874 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87874/testReport)** for PR 20715 at commit

[GitHub] spark issue #20714: [SPARK-23457][SQL][BRANCH-2.3] Register task completion ...

2018-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20714 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20714: [SPARK-23457][SQL][BRANCH-2.3] Register task completion ...

2018-03-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20714 **[Test build #87873 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87873/testReport)** for PR 20714 at commit

[GitHub] spark issue #20709: [SPARK-18844][MLLIB] Adding more binary classification e...

2018-03-01 Thread sandecho
Github user sandecho commented on the issue: https://github.com/apache/spark/pull/20709 @sethah Would you recommended closing this one and opening the previous one? --- - To unsubscribe, e-mail:

[GitHub] spark issue #20700: [SPARK-23546][SQL] Refactor stateless methods/values in ...

2018-03-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20700 **[Test build #87881 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87881/testReport)** for PR 20700 at commit

[GitHub] spark issue #20700: [SPARK-23546][SQL] Refactor stateless methods/values in ...

2018-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20700 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20708: [SPARK-21209][MLLLIB] Implement Incremental PCA algorith...

2018-03-01 Thread sandecho
Github user sandecho commented on the issue: https://github.com/apache/spark/pull/20708 Thanks @wbstclair . That's a good suggestion. Although I would have to take it to ML from MLLIB, rest will be the same. --- -

[GitHub] spark issue #20700: [SPARK-23546][SQL] Refactor stateless methods/values in ...

2018-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20700 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1224/

[GitHub] spark issue #20708: [SPARK-21209][MLLLIB] Implement Incremental PCA algorith...

2018-03-01 Thread wbstclair
Github user wbstclair commented on the issue: https://github.com/apache/spark/pull/20708 Sorry for being out of touch! I have been busy with work. I will look at your code soon. I also have an implementation which adheres to the style which is a decent first draft, but needs to

[GitHub] spark pull request #20681: [SPARK-23518][SQL] Avoid metastore access when th...

2018-03-01 Thread liufengdb
Github user liufengdb commented on a diff in the pull request: https://github.com/apache/spark/pull/20681#discussion_r171770982 --- Diff: R/pkg/tests/fulltests/test_sparkSQL.R --- @@ -67,6 +67,8 @@ sparkSession <- if (windows_with_hadoop()) { sparkR.session(master =

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2018-03-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19222 **[Test build #87880 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87880/testReport)** for PR 19222 at commit

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2018-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19222 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2018-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19222 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1223/

[GitHub] spark issue #20682: [SPARK-23522][Python] always use sys.exit over builtin e...

2018-03-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20682 **[Test build #87879 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87879/testReport)** for PR 20682 at commit

[GitHub] spark issue #20682: [SPARK-23522][Python] always use sys.exit over builtin e...

2018-03-01 Thread benjaminp
Github user benjaminp commented on the issue: https://github.com/apache/spark/pull/20682 I've now fixed the style as you suggest and got `python/run-tests` passing. --- - To unsubscribe, e-mail:

[GitHub] spark issue #20708: [SPARK-21209][MLLLIB] Implement Incremental PCA algorith...

2018-03-01 Thread sandecho
Github user sandecho commented on the issue: https://github.com/apache/spark/pull/20708 @sethah Thank you. I accept your recommendation. I will take it to ML. Secondly I have written unit tests and I have also adhere to style guidelines. But my concern is that no one is having a

[GitHub] spark issue #20681: [SPARK-23518][SQL] Avoid metastore access when the users...

2018-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20681 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20681: [SPARK-23518][SQL] Avoid metastore access when the users...

2018-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20681 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87867/ Test PASSed. ---

[GitHub] spark issue #20327: [SPARK-12963][CORE] NM host for driver end points

2018-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20327 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87866/ Test PASSed. ---

[GitHub] spark issue #20327: [SPARK-12963][CORE] NM host for driver end points

2018-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20327 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20327: [SPARK-12963][CORE] NM host for driver end points

2018-03-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20327 **[Test build #87866 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87866/testReport)** for PR 20327 at commit

[GitHub] spark issue #20681: [SPARK-23518][SQL] Avoid metastore access when the users...

2018-03-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20681 **[Test build #87867 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87867/testReport)** for PR 20681 at commit

[GitHub] spark issue #20709: [SPARK-18844][MLLIB] Adding more binary classification e...

2018-03-01 Thread sandecho
Github user sandecho commented on the issue: https://github.com/apache/spark/pull/20709 Actually the previous pull request was not able to merge. So, I opened a new pull request. Can you please run the test? --- -

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2018-03-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19222 **[Test build #87878 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87878/testReport)** for PR 19222 at commit

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2018-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19222 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87878/ Test FAILed. ---

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2018-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19222 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2018-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19222 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1222/

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2018-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19222 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20647: [SPARK-23303][SQL] improve the explain result for data s...

2018-03-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20647 **[Test build #87877 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87877/testReport)** for PR 20647 at commit

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2018-03-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19222 **[Test build #87878 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87878/testReport)** for PR 19222 at commit

[GitHub] spark issue #20706: [SPARK-23550][core] Cleanup `Utils`.

2018-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20706 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87863/ Test PASSed. ---

[GitHub] spark issue #20706: [SPARK-23550][core] Cleanup `Utils`.

2018-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20706 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20647: [SPARK-23303][SQL] improve the explain result for data s...

2018-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20647 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20647: [SPARK-23303][SQL] improve the explain result for...

2018-03-01 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20647#discussion_r171767913 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2StringFormat.scala --- @@ -0,0 +1,98 @@ +/* + *

[GitHub] spark issue #20647: [SPARK-23303][SQL] improve the explain result for data s...

2018-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20647 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1221/

[GitHub] spark issue #20706: [SPARK-23550][core] Cleanup `Utils`.

2018-03-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20706 **[Test build #87863 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87863/testReport)** for PR 20706 at commit

[GitHub] spark issue #18784: [SPARK-21559][Mesos] remove mesos fine-grained mode

2018-03-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18784 **[Test build #87876 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87876/testReport)** for PR 18784 at commit

[GitHub] spark pull request #20111: [SPARK-22883][ML][TEST] Streaming tests for spark...

2018-03-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20111 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20686: [SPARK-22915][MLlib] Streaming tests for spark.ml...

2018-03-01 Thread attilapiros
Github user attilapiros commented on a diff in the pull request: https://github.com/apache/spark/pull/20686#discussion_r171765261 --- Diff: mllib/src/test/scala/org/apache/spark/ml/feature/OneHotEncoderEstimatorSuite.scala --- @@ -103,11 +96,12 @@ class

[GitHub] spark pull request #20686: [SPARK-22915][MLlib] Streaming tests for spark.ml...

2018-03-01 Thread attilapiros
Github user attilapiros commented on a diff in the pull request: https://github.com/apache/spark/pull/20686#discussion_r171765221 --- Diff: mllib/src/test/scala/org/apache/spark/ml/feature/NormalizerSuite.scala --- @@ -17,94 +17,72 @@ package org.apache.spark.ml.feature

[GitHub] spark issue #20713: [SPARK-23434][SQL][BRANCH-2.3] Spark should not warn `me...

2018-03-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20713 **[Test build #87875 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87875/testReport)** for PR 20713 at commit

[GitHub] spark issue #20713: [SPARK-23434][SQL][BRANCH-2.3] Spark should not warn `me...

2018-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20713 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20713: [SPARK-23434][SQL][BRANCH-2.3] Spark should not warn `me...

2018-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20713 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1220/

[GitHub] spark issue #20633: [SPARK-23455][ML] Default Params in ML should be saved s...

2018-03-01 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20633 also ping @MLnick @WeichenXu123 for review. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20464: [SPARK-23291][SQL][R] R's substr should not reduce start...

2018-03-01 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20464 Because 2.3 is released, ping @felixcheung again --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #20713: [SPARK-23434][SQL][BRANCH-2.3] Spark should not warn `me...

2018-03-01 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/20713 Retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20713: [SPARK-23434][SQL][BRANCH-2.3] Spark should not warn `me...

2018-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20713 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20713: [SPARK-23434][SQL][BRANCH-2.3] Spark should not warn `me...

2018-03-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20713 **[Test build #87872 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87872/testReport)** for PR 20713 at commit

[GitHub] spark issue #20713: [SPARK-23434][SQL][BRANCH-2.3] Spark should not warn `me...

2018-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20713 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87872/ Test FAILed. ---

[GitHub] spark pull request #20686: [SPARK-22915][MLlib] Streaming tests for spark.ml...

2018-03-01 Thread attilapiros
Github user attilapiros commented on a diff in the pull request: https://github.com/apache/spark/pull/20686#discussion_r171764043 --- Diff: mllib/src/test/scala/org/apache/spark/ml/feature/RFormulaSuite.scala --- @@ -313,13 +306,14 @@ class RFormulaSuite extends MLTest with

[GitHub] spark issue #20715: [SPARK-23434][SQL][BRANCH-2.2] Spark should not warn `me...

2018-03-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20715 **[Test build #87874 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87874/testReport)** for PR 20715 at commit

[GitHub] spark issue #20714: [SPARK-23457][SQL][BRANCH-2.3] Register task completion ...

2018-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20714 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1219/

[GitHub] spark issue #20715: [SPARK-23434][SQL][BRANCH-2.2] Spark should not warn `me...

2018-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20715 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20714: [SPARK-23457][SQL][BRANCH-2.3] Register task completion ...

2018-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20714 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20715: [SPARK-23434][SQL][BRANCH-2.2] Spark should not warn `me...

2018-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20715 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1218/

[GitHub] spark pull request #20715: [SPARK-23434][SQL][BRANCH-2.2] Spark should not w...

2018-03-01 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/20715 [SPARK-23434][SQL][BRANCH-2.2] Spark should not warn `metadata directory` for a HDFS file path ## What changes were proposed in this pull request? In a kerberized cluster, when

[GitHub] spark issue #20714: [SPARK-23457][SQL][BRANCH-2.3] Register task completion ...

2018-03-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20714 **[Test build #87873 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87873/testReport)** for PR 20714 at commit

[GitHub] spark pull request #20714: [SPARK-23457][SQL][BRANCH-2.3] Register task comp...

2018-03-01 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/20714 [SPARK-23457][SQL][BRANCH-2.3] Register task completion listeners first in ParquetFileFormat ## What changes were proposed in this pull request? ParquetFileFormat leaks opened files

[GitHub] spark issue #20632: [SPARK-3159][ML] Add decision tree pruning

2018-03-01 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/20632 Jenkins test this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20713: [SPARK-23434][SQL][BRANCH-2.3] Spark should not warn `me...

2018-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20713 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1217/

[GitHub] spark issue #20713: [SPARK-23434][SQL][BRANCH-2.3] Spark should not warn `me...

2018-03-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20713 **[Test build #87872 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87872/testReport)** for PR 20713 at commit

[GitHub] spark issue #20709: [SPARK-18844][MLLIB] Adding more binary classification e...

2018-03-01 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/20709 Why did you close the old one and re-open this? The discussion is lost now. --- - To unsubscribe, e-mail:

[GitHub] spark issue #20713: [SPARK-23434][SQL][BRANCH-2.3] Spark should not warn `me...

2018-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20713 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20686: [SPARK-22915][MLlib] Streaming tests for spark.ml...

2018-03-01 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/20686#discussion_r171762299 --- Diff: mllib/src/test/scala/org/apache/spark/ml/feature/SQLTransformerSuite.scala --- @@ -63,13 +68,17 @@ class SQLTransformerSuite }

[GitHub] spark pull request #20686: [SPARK-22915][MLlib] Streaming tests for spark.ml...

2018-03-01 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/20686#discussion_r171760358 --- Diff: mllib/src/test/scala/org/apache/spark/ml/feature/RFormulaSuite.scala --- @@ -32,10 +31,20 @@ class RFormulaSuite extends MLTest with

[GitHub] spark pull request #20686: [SPARK-22915][MLlib] Streaming tests for spark.ml...

2018-03-01 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/20686#discussion_r171757214 --- Diff: mllib/src/test/scala/org/apache/spark/ml/feature/NormalizerSuite.scala --- @@ -17,94 +17,72 @@ package

[GitHub] spark issue #20619: [SPARK-23457][SQL] Register task completion listeners fi...

2018-03-01 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/20619 Thank you, @cloud-fan ! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #20686: [SPARK-22915][MLlib] Streaming tests for spark.ml...

2018-03-01 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/20686#discussion_r171757269 --- Diff: mllib/src/test/scala/org/apache/spark/ml/feature/OneHotEncoderEstimatorSuite.scala --- @@ -103,11 +96,12 @@ class

[GitHub] spark pull request #20686: [SPARK-22915][MLlib] Streaming tests for spark.ml...

2018-03-01 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/20686#discussion_r171762031 --- Diff: mllib/src/test/scala/org/apache/spark/ml/feature/RFormulaSuite.scala --- @@ -538,21 +540,28 @@ class RFormulaSuite extends MLTest with

[GitHub] spark pull request #20686: [SPARK-22915][MLlib] Streaming tests for spark.ml...

2018-03-01 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/20686#discussion_r171761570 --- Diff: mllib/src/test/scala/org/apache/spark/ml/feature/RFormulaSuite.scala --- @@ -32,10 +31,20 @@ class RFormulaSuite extends MLTest with

[GitHub] spark pull request #20686: [SPARK-22915][MLlib] Streaming tests for spark.ml...

2018-03-01 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/20686#discussion_r171762037 --- Diff: mllib/src/test/scala/org/apache/spark/ml/feature/RFormulaSuite.scala --- @@ -538,21 +540,28 @@ class RFormulaSuite extends MLTest with

[GitHub] spark pull request #20686: [SPARK-22915][MLlib] Streaming tests for spark.ml...

2018-03-01 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/20686#discussion_r171761966 --- Diff: mllib/src/test/scala/org/apache/spark/ml/feature/RFormulaSuite.scala --- @@ -381,31 +386,31 @@ class RFormulaSuite extends MLTest with

[GitHub] spark pull request #20686: [SPARK-22915][MLlib] Streaming tests for spark.ml...

2018-03-01 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/20686#discussion_r171759634 --- Diff: mllib/src/test/scala/org/apache/spark/ml/feature/OneHotEncoderEstimatorSuite.scala --- @@ -151,29 +146,30 @@ class

[GitHub] spark pull request #20686: [SPARK-22915][MLlib] Streaming tests for spark.ml...

2018-03-01 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/20686#discussion_r171761941 --- Diff: mllib/src/test/scala/org/apache/spark/ml/feature/RFormulaSuite.scala --- @@ -313,13 +306,14 @@ class RFormulaSuite extends MLTest with

[GitHub] spark pull request #20713: [SPARK-23434][SQL][BRANCH-2.3] Spark should not w...

2018-03-01 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/20713 [SPARK-23434][SQL][BRANCH-2.3] Spark should not warn `metadata directory` for a HDFS file path ## What changes were proposed in this pull request? In a kerberized cluster, when

[GitHub] spark issue #20708: [SPARK-21209][MLLLIB] Implement Incremental PCA algorith...

2018-03-01 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/20708 * Only committers can trigger the tests. * MLlib is in maintenance only mode, so we wouldn't accept this patch as is. * If this were to go into ML, I think you'd need to discuss it more

[GitHub] spark issue #20616: [SPARK-23434][SQL] Spark should not warn `metadata direc...

2018-03-01 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/20616 Thank you, @cloud-fan . Then, I'll make a backport PR to pass Jenkins once more for each branch. --- - To unsubscribe,

[GitHub] spark issue #20712: [SPARK-23563] config codegen compile cache size

2018-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20712 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20712: [SPARK-23563] config codegen compile cache size

2018-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20712 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20712: [SPARK-23563] config codegen compile cache size

2018-03-01 Thread passionke
GitHub user passionke opened a pull request: https://github.com/apache/spark/pull/20712 [SPARK-23563] config codegen compile cache size ## What changes were proposed in this pull request? config codegen compile class cache size ## How was this patch tested?

[GitHub] spark issue #20616: [SPARK-23434][SQL] Spark should not warn `metadata direc...

2018-03-01 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20616 no objection from my side. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20619: [SPARK-23457][SQL] Register task completion listeners fi...

2018-03-01 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20619 Yea, please go ahead. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20705: [SPARK-23553][TESTS] Tests should not assume the default...

2018-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20705 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87861/ Test PASSed. ---

[GitHub] spark issue #20705: [SPARK-23553][TESTS] Tests should not assume the default...

2018-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20705 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19108: [SPARK-21898][ML] Feature parity for KolmogorovSmirnovTe...

2018-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19108 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19108: [SPARK-21898][ML] Feature parity for KolmogorovSmirnovTe...

2018-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19108 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87868/ Test PASSed. ---

[GitHub] spark issue #20705: [SPARK-23553][TESTS] Tests should not assume the default...

2018-03-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20705 **[Test build #87861 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87861/testReport)** for PR 20705 at commit

[GitHub] spark issue #19108: [SPARK-21898][ML] Feature parity for KolmogorovSmirnovTe...

2018-03-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19108 **[Test build #87868 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87868/testReport)** for PR 19108 at commit

[GitHub] spark issue #20692: [SPARK-23531][SQL] Show attribute type in explain

2018-03-01 Thread rdblue
Github user rdblue commented on the issue: https://github.com/apache/spark/pull/20692 Good point on nested types. I don't think heavy nesting is the usual case, but we can definitely improve the explain result in the long term by separating it out. Maybe just using a high-level type

[GitHub] spark issue #20711: [SPARKR][DOC] fix link in vignettes

2018-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20711 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

  1   2   3   4   5   6   7   >